Re: linux-next: build warning after merge of the ftrace tree
On Mon, 16 Nov 2020 13:29:29 -0700 Jonathan Corbet wrote: > > Would something like the below work? I think I fixed the other places with > > issues and for consistency, replaced the ".. code-block:: c" with just "::" > > usage throughout the file. > > That will work. It will also have the effect of removing C syntax > highlighting from the formatted output; that is fine with me, but others > are more attached to it. Is there a way to set a default highlighting to be C syntax? Otherwise I'll just put it back and add the code-block statements back in, even though there are those that will complain about the added mark up ;-) -- Steve
Re: linux-next: build warning after merge of the ftrace tree
On Mon, 16 Nov 2020 15:25:52 -0500 Steven Rostedt wrote: > On Mon, 16 Nov 2020 12:24:32 -0700 > Jonathan Corbet wrote: > > > The problem is those literal blocks. The easiest fix will be to just use > > the double-colon notation to indicate a literal block, so the paragraph > > above would end with "...start your code with::". Note that there's a few > > of them to fix. > > Would something like the below work? I think I fixed the other places with > issues and for consistency, replaced the ".. code-block:: c" with just "::" > usage throughout the file. That will work. It will also have the effect of removing C syntax highlighting from the formatted output; that is fine with me, but others are more attached to it. jon
Re: linux-next: build warning after merge of the ftrace tree
On Mon, 16 Nov 2020 12:24:32 -0700
Jonathan Corbet wrote:
> The problem is those literal blocks. The easiest fix will be to just use
> the double-colon notation to indicate a literal block, so the paragraph
> above would end with "...start your code with::". Note that there's a few
> of them to fix.
Would something like the below work? I think I fixed the other places with
issues and for consistency, replaced the ".. code-block:: c" with just "::"
usage throughout the file.
-- Steve
diff --git a/Documentation/trace/ftrace-uses.rst
b/Documentation/trace/ftrace-uses.rst
index 5981d5691745..f21464538fa0 100644
--- a/Documentation/trace/ftrace-uses.rst
+++ b/Documentation/trace/ftrace-uses.rst
@@ -43,9 +43,7 @@ as well as what protections the callback will perform and not
require
ftrace to handle.
There is only one field that is needed to be set when registering
-an ftrace_ops with ftrace:
-
-.. code-block:: c
+an ftrace_ops with ftrace::
struct ftrace_ops ops = {
.func = my_callback_func,
@@ -82,9 +80,7 @@ may take some time to finish.
The callback function
=
-The prototype of the callback function is as follows (as of v4.14):
-
-.. code-block:: c
+The prototype of the callback function is as follows (as of v4.14)::
void callback_func(unsigned long ip, unsigned long parent_ip,
struct ftrace_ops *op, struct pt_regs *regs);
@@ -114,7 +110,7 @@ Protect your callback
As functions can be called from anywhere, and it is possible that a function
called by a callback may also be traced, and call that same callback,
recursion protection must be used. There are two helper functions that
-can help in this regard. If you start your code with:
+can help in this regard. If you start your code with::
int bit;
@@ -122,7 +118,7 @@ can help in this regard. If you start your code with:
if (bit < 0)
return;
-and end it with:
+and end it with::
ftrace_test_recursion_unlock(bit);
@@ -143,7 +139,7 @@ function call.
If your callback accesses any data or critical section that requires RCU
protection, it is best to make sure that RCU is "watching", otherwise
that data or critical section will not be protected as expected. In this
-case add:
+case add::
if (!rcu_is_watching())
return;
@@ -249,9 +245,7 @@ match a specific pattern.
See Filter Commands in :file:`Documentation/trace/ftrace.rst`.
-To just trace the schedule function:
-
-.. code-block:: c
+To just trace the schedule function::
ret = ftrace_set_filter(&ops, "schedule", strlen("schedule"), 0);
@@ -259,17 +253,13 @@ To add more functions, call the ftrace_set_filter() more
than once with the
@reset parameter set to zero. To remove the current filter set and replace it
with new functions defined by @buf, have @reset be non-zero.
-To remove all the filtered functions and trace all functions:
-
-.. code-block:: c
+To remove all the filtered functions and trace all functions::
ret = ftrace_set_filter(&ops, NULL, 0, 1);
Sometimes more than one function has the same name. To trace just a specific
-function in this case, ftrace_set_filter_ip() can be used.
-
-.. code-block:: c
+function in this case, ftrace_set_filter_ip() can be used::
ret = ftrace_set_filter_ip(&ops, ip, 0, 0);
@@ -284,9 +274,7 @@ two lists are non-empty and contain the same functions, the
callback will not
be called by any function.
An empty "notrace" list means to allow all functions defined by the filter
-to be traced.
-
-.. code-block:: c
+to be traced::
int ftrace_set_notrace(struct ftrace_ops *ops, unsigned char *buf,
int len, int reset);
@@ -298,9 +286,7 @@ filter list, and this function does not modify the filter
list.
A non-zero @reset will clear the "notrace" list before adding functions
that match @buf to it.
-Clearing the "notrace" list is the same as clearing the filter list
-
-.. code-block:: c
+Clearing the "notrace" list is the same as clearing the filter list::
ret = ftrace_set_notrace(&ops, NULL, 0, 1);
@@ -311,9 +297,7 @@ has been registered.
If a filter is in place, and the @reset is non-zero, and @buf contains a
matching glob to functions, the switch will happen during the time of
-the ftrace_set_filter() call. At no time will all functions call the callback.
-
-.. code-block:: c
+the ftrace_set_filter() call. At no time will all functions call the callback::
ftrace_set_filter(&ops, "schedule", strlen("schedule"), 1);
@@ -323,9 +307,7 @@ the ftrace_set_filter() call. At no time will all functions
call the callback.
ftrace_set_filter(&ops, "try_to_wake_up", strlen("try_to_wake_up"), 1);
-is not the same as:
-
-.. code-block:: c
+is not the same as::
ftrace_set_filter(&ops, "schedule", strlen("schedule"), 1);
Re: linux-next: build warning after merge of the ftrace tree
On Mon, 16 Nov 2020 12:43:38 -0500
Steven Rostedt wrote:
> > After merging the ftrace tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > Documentation/trace/ftrace-uses.rst:123: WARNING: Unexpected indentation.
> >
> > Introduced by commit
> >
> > a25d036d939a ("ftrace: Reverse what the RECURSION flag means in the
> > ftrace_ops")
> >
>
> I'm not good at rst markup. Not sure how to fix this.
Looking at the commit in question:
> +Protect your callback
> +=
> +
> +As functions can be called from anywhere, and it is possible that a function
> +called by a callback may also be traced, and call that same callback,
> +recursion protection must be used. There are two helper functions that
> +can help in this regard. If you start your code with:
> +
> + int bit;
> +
> + bit = ftrace_test_recursion_trylock();
> + if (bit < 0)
> + return;
The problem is those literal blocks. The easiest fix will be to just use
the double-colon notation to indicate a literal block, so the paragraph
above would end with "...start your code with::". Note that there's a few
of them to fix.
Thanks,
jon
Re: linux-next: build warning after merge of the ftrace tree
On Mon, 16 Nov 2020 17:35:02 +1100
Stephen Rothwell wrote:
> Hi all,
>
> After merging the ftrace tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/trace/ftrace-uses.rst:123: WARNING: Unexpected indentation.
>
> Introduced by commit
>
> a25d036d939a ("ftrace: Reverse what the RECURSION flag means in the
> ftrace_ops")
>
I'm not good at rst markup. Not sure how to fix this.
Thanks,
-- Steve
linux-next: build warning after merge of the ftrace tree
Hi all,
After merging the ftrace tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/trace/ftrace-uses.rst:123: WARNING: Unexpected indentation.
Introduced by commit
a25d036d939a ("ftrace: Reverse what the RECURSION flag means in the
ftrace_ops")
--
Cheers,
Stephen Rothwell
pgpLwhAXd6kuP.pgp
Description: OpenPGP digital signature
Re: [External] linux-next: build warning after merge of the ftrace tree
On Wed, 5 Aug 2020 12:53:39 +0800
Muchun Song wrote:
> On Wed, Aug 5, 2020 at 12:21 PM Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> > After merging the ftrace tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > kernel/kprobes.c: In function 'kill_kprobe':
> > kernel/kprobes.c:1116:33: warning: statement with no effect [-Wunused-value]
> > 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
> > | ^
> > kernel/kprobes.c:2154:3: note: in expansion of macro 'disarm_kprobe_ftrace'
> > 2154 | disarm_kprobe_ftrace(p);
> > | ^~~~
> >
>
> Sorry, maybe we should rework the macro of disarm_kprobe_ftrace to an
> inline function like below.
>
> -#define disarm_kprobe_ftrace(p)(-ENODEV)
> +static inline int disarm_kprobe_ftrace(struct kprobe *p)
> +{
> + return -ENODEV
> +}
> #endif
Looks like that would work. Care to send a formal patch. Could you also
change arm_kprobe_ftrace() as well?
Thanks!
-- Steve
Re: [External] linux-next: build warning after merge of the ftrace tree
On Wed, Aug 5, 2020 at 11:11 PM Steven Rostedt wrote:
>
> On Wed, 5 Aug 2020 12:53:39 +0800
> Muchun Song wrote:
>
> > On Wed, Aug 5, 2020 at 12:21 PM Stephen Rothwell
> > wrote:
> > >
> > > Hi all,
> > >
> > > After merging the ftrace tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > kernel/kprobes.c: In function 'kill_kprobe':
> > > kernel/kprobes.c:1116:33: warning: statement with no effect
> > > [-Wunused-value]
> > > 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
> > > | ^
> > > kernel/kprobes.c:2154:3: note: in expansion of macro
> > > 'disarm_kprobe_ftrace'
> > > 2154 | disarm_kprobe_ftrace(p);
> > > | ^~~~
> > >
> >
> > Sorry, maybe we should rework the macro of disarm_kprobe_ftrace to an
> > inline function like below.
> >
> > -#define disarm_kprobe_ftrace(p)(-ENODEV)
> > +static inline int disarm_kprobe_ftrace(struct kprobe *p)
> > +{
> > + return -ENODEV
> > +}
> > #endif
>
> Looks like that would work. Care to send a formal patch. Could you also
> change arm_kprobe_ftrace() as well?
OK, I will do that. Thanks.
>
> Thanks!
>
> -- Steve
--
Yours,
Muchun
Re: [External] linux-next: build warning after merge of the ftrace tree
On Thu, 6 Aug 2020 02:04:45 +0900 Masami Hiramatsu wrote: > > Looks like that would work. Care to send a formal patch. Could you also > > change arm_kprobe_ftrace() as well? > > Looks good to me too as far as updating it to static inline function. Can you add an Acked-by to the final patch from Muchun? (when he sends it out) Thanks! -- Steve
Re: [External] linux-next: build warning after merge of the ftrace tree
On Wed, 5 Aug 2020 11:11:05 -0400
Steven Rostedt wrote:
> On Wed, 5 Aug 2020 12:53:39 +0800
> Muchun Song wrote:
>
> > On Wed, Aug 5, 2020 at 12:21 PM Stephen Rothwell
> > wrote:
> > >
> > > Hi all,
> > >
> > > After merging the ftrace tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > kernel/kprobes.c: In function 'kill_kprobe':
> > > kernel/kprobes.c:1116:33: warning: statement with no effect
> > > [-Wunused-value]
> > > 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
> > > | ^
> > > kernel/kprobes.c:2154:3: note: in expansion of macro
> > > 'disarm_kprobe_ftrace'
> > > 2154 | disarm_kprobe_ftrace(p);
> > > | ^~~~
> > >
> >
> > Sorry, maybe we should rework the macro of disarm_kprobe_ftrace to an
> > inline function like below.
> >
> > -#define disarm_kprobe_ftrace(p)(-ENODEV)
> > +static inline int disarm_kprobe_ftrace(struct kprobe *p)
> > +{
> > + return -ENODEV
> > +}
> > #endif
>
> Looks like that would work. Care to send a formal patch. Could you also
> change arm_kprobe_ftrace() as well?
Looks good to me too as far as updating it to static inline function.
Thank you,
--
Masami Hiramatsu
Re: [External] linux-next: build warning after merge of the ftrace tree
On Wed, Aug 5, 2020 at 12:21 PM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the ftrace tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> kernel/kprobes.c: In function 'kill_kprobe':
> kernel/kprobes.c:1116:33: warning: statement with no effect [-Wunused-value]
> 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
> | ^
> kernel/kprobes.c:2154:3: note: in expansion of macro 'disarm_kprobe_ftrace'
> 2154 | disarm_kprobe_ftrace(p);
> | ^~~~
>
Sorry, maybe we should rework the macro of disarm_kprobe_ftrace to an
inline function like below.
-#define disarm_kprobe_ftrace(p)(-ENODEV)
+static inline int disarm_kprobe_ftrace(struct kprobe *p)
+{
+ return -ENODEV
+}
#endif
> Introduced by commit
>
> 0cb2f1372baa ("kprobes: Fix NULL pointer dereference at
> kprobe_ftrace_handler")
>
> --
> Cheers,
> Stephen Rothwell
--
Yours,
Muchun
linux-next: build warning after merge of the ftrace tree
Hi all,
After merging the ftrace tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
kernel/kprobes.c: In function 'kill_kprobe':
kernel/kprobes.c:1116:33: warning: statement with no effect [-Wunused-value]
1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
| ^
kernel/kprobes.c:2154:3: note: in expansion of macro 'disarm_kprobe_ftrace'
2154 | disarm_kprobe_ftrace(p);
| ^~~~
Introduced by commit
0cb2f1372baa ("kprobes: Fix NULL pointer dereference at
kprobe_ftrace_handler")
--
Cheers,
Stephen Rothwell
pgp9wR7NZkTPH.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the ftrace tree
On Wed, Jun 04, 2014 at 11:13:51PM -0400, Steven Rostedt wrote: > On Thu, 5 Jun 2014 11:03:34 +0800 > Fengguang Wu wrote: > > > On Wed, Jun 04, 2014 at 10:36:24PM -0400, Steven Rostedt wrote: > > > On Thu, 5 Jun 2014 10:14:57 +0800 > > > Fengguang Wu wrote: > > > > > > > > I wonder if the "(Red Hat)" part is causing an issue. Can you send > > > > > directly to my email "rost...@goodmis.org" and strip the name part? > > > > > > > > OK. I've committed the change. Let's see how well it will work. > > > > > > OK, I never received an error message for my buggy commit I posted > > > before you did this change. I fixed the buggy commit and added another > > > bug. I'll now wait again to see if I get notified. > > > > FYI, we got two error reports > > > > [trace:test-wu-bot 28/29] kernel/trace/trace.c:6683:1: error: expected '; ' > > before '}' token > > [trace:test-wu-bot 29/29] kernel/trace/trace.c:6701:9: error: 'x' undeclared > > > > in > > > > https://lists.01.org/pipermail/kbuild-all/2014-June/004839.html > > https://lists.01.org/pipermail/kbuild-all/2014-June/004840.html > > > > And I received no emails :-( Those 2 emails has To: Steven Rostedt in the header. > I wonder why it's failing. What changed since March? I can't think of > anything on my end. It could be changes in one of the SMTP servers. Who knows. The simplest workaround may be to have another email address to receive all reports to you. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Thu, 5 Jun 2014 11:03:34 +0800 Fengguang Wu wrote: > On Wed, Jun 04, 2014 at 10:36:24PM -0400, Steven Rostedt wrote: > > On Thu, 5 Jun 2014 10:14:57 +0800 > > Fengguang Wu wrote: > > > > > > I wonder if the "(Red Hat)" part is causing an issue. Can you send > > > > directly to my email "rost...@goodmis.org" and strip the name part? > > > > > > OK. I've committed the change. Let's see how well it will work. > > > > OK, I never received an error message for my buggy commit I posted > > before you did this change. I fixed the buggy commit and added another > > bug. I'll now wait again to see if I get notified. > > FYI, we got two error reports > > [trace:test-wu-bot 28/29] kernel/trace/trace.c:6683:1: error: expected '; ' > before '}' token > [trace:test-wu-bot 29/29] kernel/trace/trace.c:6701:9: error: 'x' undeclared > > in > > https://lists.01.org/pipermail/kbuild-all/2014-June/004839.html > https://lists.01.org/pipermail/kbuild-all/2014-June/004840.html > And I received no emails :-( I wonder why it's failing. What changed since March? I can't think of anything on my end. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Wed, Jun 04, 2014 at 10:36:24PM -0400, Steven Rostedt wrote: > On Thu, 5 Jun 2014 10:14:57 +0800 > Fengguang Wu wrote: > > > > I wonder if the "(Red Hat)" part is causing an issue. Can you send > > > directly to my email "rost...@goodmis.org" and strip the name part? > > > > OK. I've committed the change. Let's see how well it will work. > > OK, I never received an error message for my buggy commit I posted > before you did this change. I fixed the buggy commit and added another > bug. I'll now wait again to see if I get notified. FYI, we got two error reports [trace:test-wu-bot 28/29] kernel/trace/trace.c:6683:1: error: expected '; ' before '}' token [trace:test-wu-bot 29/29] kernel/trace/trace.c:6701:9: error: 'x' undeclared in https://lists.01.org/pipermail/kbuild-all/2014-June/004839.html https://lists.01.org/pipermail/kbuild-all/2014-June/004840.html Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Wed, Jun 04, 2014 at 10:36:24PM -0400, Steven Rostedt wrote: > On Thu, 5 Jun 2014 10:14:57 +0800 > Fengguang Wu wrote: > > > > I wonder if the "(Red Hat)" part is causing an issue. Can you send > > > directly to my email "rost...@goodmis.org" and strip the name part? > > > > OK. I've committed the change. Let's see how well it will work. > > OK, I never received an error message for my buggy commit I posted > before you did this change. I fixed the buggy commit and added another > bug. I'll now wait again to see if I get notified. Sorry we got something wrong and your first bad commit is not tested. The new one is being tested now. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Thu, 5 Jun 2014 10:14:57 +0800 Fengguang Wu wrote: > On Wed, Jun 04, 2014 at 09:39:32PM -0400, Steven Rostedt wrote: > > On Thu, 5 Jun 2014 09:33:00 +0800 > > Fengguang Wu wrote: > > > > > > > Here are the recent emails sent to you: > > > > > > 439 F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] > > > kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used > > > 446 F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] > > > kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member > > > named 'trampoline' > > > 1207 F May 31 To Steven Rostedt ( 43:0) [trace:ftrace/core 29/32] > > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' > > > 1210 F May 31 To Steven Rostedt ( 29:0) [trace:ftrace/core 29/32] > > > kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct > > > pointer types lacks a cast > > > > I don't have any of those :-( BTW, this is the last report I received from your build bot. Anything after that has gone into limbo. From: kbuild test robot To: Steven Rostedt Cc: Daniel Vetter , kbuild-...@01.org Subject: [drm-intel:for-linux-next 342/342] drivers/gpu/drm/i915/./i915_trace.h:246:22: error: 'dev' undeclared Date: Wed, 19 Mar 2014 10:12:41 +0800 User-Agent: Heirloom mailx 12.5 6/20/10 Message-ID: <5328fd19.a1axhoyyvl3i2gl3%fengguang...@intel.com> I noticed that there was no "Red Hat" in that one. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Wed, Jun 04, 2014 at 10:38:17PM -0400, Steven Rostedt wrote: > On Thu, 5 Jun 2014 10:14:57 +0800 > Fengguang Wu wrote: > > > On Wed, Jun 04, 2014 at 09:39:32PM -0400, Steven Rostedt wrote: > > > On Thu, 5 Jun 2014 09:33:00 +0800 > > > Fengguang Wu wrote: > > > > > > > > > > Here are the recent emails sent to you: > > > > > > > > 439 F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 > > > > 29/29] kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but > > > > not used > > > > 446 F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 > > > > 29/29] kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no > > > > member named 'trampoline' > > > > 1207 F May 31 To Steven Rostedt ( 43:0) [trace:ftrace/core 29/32] > > > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' > > > > 1210 F May 31 To Steven Rostedt ( 29:0) [trace:ftrace/core 29/32] > > > > kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct > > > > pointer types lacks a cast > > > > > > I don't have any of those :-( > > > BTW, can you give me the links to those errors. I'd like to fix them. Sure. Search "ftrace" in this page, and you'll get all the 4 reports: https://lists.01.org/pipermail/kbuild-all/2014-May/date.html Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Thu, 5 Jun 2014 10:14:57 +0800 Fengguang Wu wrote: > On Wed, Jun 04, 2014 at 09:39:32PM -0400, Steven Rostedt wrote: > > On Thu, 5 Jun 2014 09:33:00 +0800 > > Fengguang Wu wrote: > > > > > > > Here are the recent emails sent to you: > > > > > > 439 F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] > > > kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used > > > 446 F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] > > > kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member > > > named 'trampoline' > > > 1207 F May 31 To Steven Rostedt ( 43:0) [trace:ftrace/core 29/32] > > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' > > > 1210 F May 31 To Steven Rostedt ( 29:0) [trace:ftrace/core 29/32] > > > kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct > > > pointer types lacks a cast > > > > I don't have any of those :-( > BTW, can you give me the links to those errors. I'd like to fix them. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Thu, 5 Jun 2014 10:14:57 +0800 Fengguang Wu wrote: > > I wonder if the "(Red Hat)" part is causing an issue. Can you send > > directly to my email "rost...@goodmis.org" and strip the name part? > > OK. I've committed the change. Let's see how well it will work. OK, I never received an error message for my buggy commit I posted before you did this change. I fixed the buggy commit and added another bug. I'll now wait again to see if I get notified. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Wed, Jun 04, 2014 at 09:39:32PM -0400, Steven Rostedt wrote: > On Thu, 5 Jun 2014 09:33:00 +0800 > Fengguang Wu wrote: > > > > Here are the recent emails sent to you: > > > > 439 F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] > > kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used > > 446 F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] > > kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member > > named 'trampoline' > > 1207 F May 31 To Steven Rostedt ( 43:0) [trace:ftrace/core 29/32] > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' > > 1210 F May 31 To Steven Rostedt ( 29:0) [trace:ftrace/core 29/32] > > kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct > > pointer types lacks a cast > > I don't have any of those :-( Ah.. > > > I may add a bad commit to one of my branches and see if I get a > > > response from you just to test it out. I really hope we can fix this > > > because I've gotten someone dependent on your reports. :-/ > > > > Yes we need to fix it. The same lost email issue has happened for > > someone else, which was fixed by changing the email address. I can > > conveniently redirect reports to any other email addresses you have. > > I wonder if the "(Red Hat)" part is causing an issue. Can you send > directly to my email "rost...@goodmis.org" and strip the name part? OK. I've committed the change. Let's see how well it will work. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Thu, 5 Jun 2014 09:33:00 +0800 Fengguang Wu wrote: > Here are the recent emails sent to you: > > 439 F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] > kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used > 446 F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] > kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member named > 'trampoline' > 1207 F May 31 To Steven Rostedt ( 43:0) [trace:ftrace/core 29/32] > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' > 1210 F May 31 To Steven Rostedt ( 29:0) [trace:ftrace/core 29/32] > kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer > types lacks a cast I don't have any of those :-( > > > I may add a bad commit to one of my branches and see if I get a > > response from you just to test it out. I really hope we can fix this > > because I've gotten someone dependent on your reports. :-/ > > Yes we need to fix it. The same lost email issue has happened for > someone else, which was fixed by changing the email address. I can > conveniently redirect reports to any other email addresses you have. I wonder if the "(Red Hat)" part is causing an issue. Can you send directly to my email "rost...@goodmis.org" and strip the name part? Thanks. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Wed, Jun 04, 2014 at 09:12:02PM -0400, Steven Rostedt wrote: > On Thu, 5 Jun 2014 09:03:53 +0800 > Fengguang Wu wrote: > > > > Was I Cc'd? I don't have that in my inbox, nor do I see it in any of my > > > spam filters. > > > > Yes, here is the email message: > > > > Date: Sat, 31 May 2014 02:16:43 +0800 > > From: kbuild test robot > > ==> To: "Steven Rostedt (Red Hat)" > > Hmm, I wonder where it ended up? I do have a pretty complex procmailrc > file, but I even checked the procmail log file, and it doesn't show it. > > I don't think my email provider dropped it, as I have all the spam > filtering turned off and do my own filtering. Although, they may have > added something behind my back. Wouldn't be the first time. > > Are you sure that got sent? I have no supporting log to check whether the emails are actually sent to you. All I have is the list of emails that were sent, and these emails do have the TO: field to you. > Can you check if your bots have triggered anything else for me. Because > your bots have been surprisingly quiet lately. I just took that as me > getting better at not pushing crap. Here are the recent emails sent to you: 439 F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used 446 F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member named 'trampoline' 1207 F May 31 To Steven Rostedt ( 43:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' 1210 F May 31 To Steven Rostedt ( 29:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer types lacks a cast > I may add a bad commit to one of my branches and see if I get a > response from you just to test it out. I really hope we can fix this > because I've gotten someone dependent on your reports. :-/ Yes we need to fix it. The same lost email issue has happened for someone else, which was fixed by changing the email address. I can conveniently redirect reports to any other email addresses you have. Thanks, Fengguang > > -- Steve > > > > CC: kbuild-...@01.org > > Subject: [trace:ftrace/core 29/32] > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' > > User-Agent: Heirloom mailx 12.5 6/20/10 > > > > tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > > ftrace/core > > head: 4c27e756bc019ec1c11232893af036fdae720a97 > > commit: 81dc9f0ef21e40114cc895894c7acf3055f6d1fb [29/32] tracing: > > Add tracepoint benchmark tracepoint > > config: make ARCH=x86_64 allmodconfig > > > > All warnings: > > > >kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark': > > >> kernel/trace/trace_benchmark.c:38:6: warning: unused variable > > 'seedsq' [-Wunused-variable] > > u64 seedsq; > > ^ > > Thanks, > > Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Wed, 4 Jun 2014 21:12:02 -0400 Steven Rostedt wrote: > I may add a bad commit to one of my branches and see if I get a > response from you just to test it out. I really hope we can fix this > because I've gotten someone dependent on your reports. :-/ I did just this. I created a branch called test-wu-bot and added a commit that removed a semicolon. I pushed it up to kernel.org. Now I'll just sit back to see if it reports a build failure. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Thu, 5 Jun 2014 09:03:53 +0800 Fengguang Wu wrote: > > Was I Cc'd? I don't have that in my inbox, nor do I see it in any of my > > spam filters. > > Yes, here is the email message: > > Date: Sat, 31 May 2014 02:16:43 +0800 > From: kbuild test robot > ==> To: "Steven Rostedt (Red Hat)" Hmm, I wonder where it ended up? I do have a pretty complex procmailrc file, but I even checked the procmail log file, and it doesn't show it. I don't think my email provider dropped it, as I have all the spam filtering turned off and do my own filtering. Although, they may have added something behind my back. Wouldn't be the first time. Are you sure that got sent? Can you check if your bots have triggered anything else for me. Because your bots have been surprisingly quiet lately. I just took that as me getting better at not pushing crap. I may add a bad commit to one of my branches and see if I get a response from you just to test it out. I really hope we can fix this because I've gotten someone dependent on your reports. :-/ -- Steve > CC: kbuild-...@01.org > Subject: [trace:ftrace/core 29/32] > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' > User-Agent: Heirloom mailx 12.5 6/20/10 > > tree: > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > ftrace/core > head: 4c27e756bc019ec1c11232893af036fdae720a97 > commit: 81dc9f0ef21e40114cc895894c7acf3055f6d1fb [29/32] tracing: Add > tracepoint benchmark tracepoint > config: make ARCH=x86_64 allmodconfig > > All warnings: > >kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark': > >> kernel/trace/trace_benchmark.c:38:6: warning: unused variable > 'seedsq' [-Wunused-variable] > u64 seedsq; > > ^ > Thanks, > Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Wed, Jun 04, 2014 at 09:00:16PM -0400, Steven Rostedt wrote:
> On Thu, 5 Jun 2014 08:20:12 +0800
> Fengguang Wu wrote:
>
> > On Wed, Jun 04, 2014 at 12:26:12PM -0400, Steven Rostedt wrote:
> > > On Wed, 4 Jun 2014 16:09:21 +1000
> > > Stephen Rothwell wrote:
> > >
> > > > Hi Steven,
> > > >
> > > > After merging the ftrace tree, today's linux-next build (x86_64
> > > > allmodconfig)
> > > > produced this warning:
> > > >
> > > > kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> > > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> > > > [-Wunused-variable]
> > > > u64 seedsq;
> > > > ^
> > > >
> > > > Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark
> > > > tracepoint").
> > >
> > > Hmm, I don't know why my tests missed this. I do a allmodconfig looking
> > > for new warning messages too. Oh, but I do need to add this config to my
> > > regular testing config :-/
> > >
> > > I'm surprised Wu's bot didn't report it either.
> >
> > Steven, it was reported, here is the email archive:
> >
> > https://lists.01.org/pipermail/kbuild-all/2014-May/004749.html
>
> Was I Cc'd? I don't have that in my inbox, nor do I see it in any of my
> spam filters.
Yes, here is the email message:
Date: Sat, 31 May 2014 02:16:43 +0800
From: kbuild test robot
==> To: "Steven Rostedt (Red Hat)"
CC: kbuild-...@01.org
Subject: [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6:
warning: unused variable 'seedsq'
User-Agent: Heirloom mailx 12.5 6/20/10
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
ftrace/core
head: 4c27e756bc019ec1c11232893af036fdae720a97
commit: 81dc9f0ef21e40114cc895894c7acf3055f6d1fb [29/32] tracing: Add
tracepoint benchmark tracepoint
config: make ARCH=x86_64 allmodconfig
All warnings:
kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
>> kernel/trace/trace_benchmark.c:38:6: warning: unused variable
'seedsq' [-Wunused-variable]
u64 seedsq;
^
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Thu, 5 Jun 2014 08:20:12 +0800
Fengguang Wu wrote:
> On Wed, Jun 04, 2014 at 12:26:12PM -0400, Steven Rostedt wrote:
> > On Wed, 4 Jun 2014 16:09:21 +1000
> > Stephen Rothwell wrote:
> >
> > > Hi Steven,
> > >
> > > After merging the ftrace tree, today's linux-next build (x86_64
> > > allmodconfig)
> > > produced this warning:
> > >
> > > kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> > > [-Wunused-variable]
> > > u64 seedsq;
> > > ^
> > >
> > > Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark
> > > tracepoint").
> >
> > Hmm, I don't know why my tests missed this. I do a allmodconfig looking
> > for new warning messages too. Oh, but I do need to add this config to my
> > regular testing config :-/
> >
> > I'm surprised Wu's bot didn't report it either.
>
> Steven, it was reported, here is the email archive:
>
> https://lists.01.org/pipermail/kbuild-all/2014-May/004749.html
Was I Cc'd? I don't have that in my inbox, nor do I see it in any of my
spam filters.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
On Wed, Jun 04, 2014 at 12:26:12PM -0400, Steven Rostedt wrote:
> On Wed, 4 Jun 2014 16:09:21 +1000
> Stephen Rothwell wrote:
>
> > Hi Steven,
> >
> > After merging the ftrace tree, today's linux-next build (x86_64
> > allmodconfig)
> > produced this warning:
> >
> > kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> > [-Wunused-variable]
> > u64 seedsq;
> > ^
> >
> > Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark
> > tracepoint").
>
> Hmm, I don't know why my tests missed this. I do a allmodconfig looking
> for new warning messages too. Oh, but I do need to add this config to my
> regular testing config :-/
>
> I'm surprised Wu's bot didn't report it either.
Steven, it was reported, here is the email archive:
https://lists.01.org/pipermail/kbuild-all/2014-May/004749.html
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the ftrace tree
Hi Steve,
On Wed, 4 Jun 2014 12:26:12 -0400 Steven Rostedt wrote:
>
> On Wed, 4 Jun 2014 16:09:21 +1000
> Stephen Rothwell wrote:
>
> > After merging the ftrace tree, today's linux-next build (x86_64
> > allmodconfig)
> > produced this warning:
> >
> > kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> > [-Wunused-variable]
> > u64 seedsq;
> > ^
> >
> > Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark
> > tracepoint").
>
> Hmm, I don't know why my tests missed this. I do a allmodconfig looking
> for new warning messages too. Oh, but I do need to add this config to my
> regular testing config :-/
>
> I'm surprised Wu's bot didn't report it either.
>
> I'm not going to rebase, but I'll add a patch to nuke it.
Correct behaviour! :-)
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
signature.asc
Description: PGP signature
Re: linux-next: build warning after merge of the ftrace tree
On Wed, 4 Jun 2014 16:09:21 +1000
Stephen Rothwell wrote:
> Hi Steven,
>
> After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> [-Wunused-variable]
> u64 seedsq;
> ^
>
> Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark
> tracepoint").
Hmm, I don't know why my tests missed this. I do a allmodconfig looking
for new warning messages too. Oh, but I do need to add this config to my
regular testing config :-/
I'm surprised Wu's bot didn't report it either.
I'm not going to rebase, but I'll add a patch to nuke it.
Thanks!
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build warning after merge of the ftrace tree
Hi Steven,
After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
[-Wunused-variable]
u64 seedsq;
^
Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark
tracepoint").
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
signature.asc
Description: PGP signature
