linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (powerpc allyesconfig) produced this warning: ld: warning: orphan section `.bpfilter_umh' from `net/bpfilter/bpfilter_umh_blob.o' being placed in section `.bpfilter_umh' Introduced by commit 61fbf5933d42 ("net: bpfilter: restart bpfilter_umh when error occurred") -- Cheers, Stephen Rothwell pgpoTtWv9YudO.pgp Description: OpenPGP digital signature
linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: net/ipv6/route.c: In function 'rt6_check': net/ipv6/route.c:1294:43: warning: 'rt_cookie' may be used uninitialized in this function [-Wmaybe-uninitialized] if (!rt6_get_cookie_safe(rt, _cookie) || rt_cookie != cookie) ^ Introduced by commit c5cff8561d2d ("ipv6: add rcu grace period before freeing fib6_node") -- Cheers, Stephen Rothwell
linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: net/ipv6/route.c: In function 'rt6_check': net/ipv6/route.c:1294:43: warning: 'rt_cookie' may be used uninitialized in this function [-Wmaybe-uninitialized] if (!rt6_get_cookie_safe(rt, _cookie) || rt_cookie != cookie) ^ Introduced by commit c5cff8561d2d ("ipv6: add rcu grace period before freeing fib6_node") -- Cheers, Stephen Rothwell
Re: linux-next: build warning after merge of the net tree
Hi Stephen, On 2017-06-13 16:38, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (powerpc ppc44x_defconfig) produced this warning: net/core/dev.c: In function 'dev_cpu_dead': net/core/dev.c:8330:2: warning: 'remsd' is used uninitialized in this function [-Wuninitialized] net_rps_send_ipi(remsd); ^ Introduced by commit 773fc8f6e8d6 ("net: rps: send out pending IPI's on CPU hotplug") These builds have CONFIG_RPS not set. I have sent the fix patch to netdev mailing list.
Re: linux-next: build warning after merge of the net tree
Hi Stephen, On 2017-06-13 16:38, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (powerpc ppc44x_defconfig) produced this warning: net/core/dev.c: In function 'dev_cpu_dead': net/core/dev.c:8330:2: warning: 'remsd' is used uninitialized in this function [-Wuninitialized] net_rps_send_ipi(remsd); ^ Introduced by commit 773fc8f6e8d6 ("net: rps: send out pending IPI's on CPU hotplug") These builds have CONFIG_RPS not set. I have sent the fix patch to netdev mailing list.
linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (powerpc ppc44x_defconfig) produced this warning: net/core/dev.c: In function 'dev_cpu_dead': net/core/dev.c:8330:2: warning: 'remsd' is used uninitialized in this function [-Wuninitialized] net_rps_send_ipi(remsd); ^ Introduced by commit 773fc8f6e8d6 ("net: rps: send out pending IPI's on CPU hotplug") These builds have CONFIG_RPS not set. -- Cheers, Stephen Rothwell
linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (powerpc ppc44x_defconfig) produced this warning: net/core/dev.c: In function 'dev_cpu_dead': net/core/dev.c:8330:2: warning: 'remsd' is used uninitialized in this function [-Wuninitialized] net_rps_send_ipi(remsd); ^ Introduced by commit 773fc8f6e8d6 ("net: rps: send out pending IPI's on CPU hotplug") These builds have CONFIG_RPS not set. -- Cheers, Stephen Rothwell
Re: linux-next: build warning after merge of the net tree
Hi Stephen, On 19/01/2017 12:56 AM, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels': drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:546:6: warning: unused variable 'ncv' [-Wunused-variable] int ncv = mlx5e_get_max_num_channels(priv->mdev); ^ Introduced by commit 639e9e94160e ("net/mlx5e: Remove unnecessary checks when setting num channels") which removed the last reference to 'ncv'. We will send a fix shortly. Thanks for your report! Regards, Tariq
Re: linux-next: build warning after merge of the net tree
Hi Stephen, On 19/01/2017 12:56 AM, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels': drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:546:6: warning: unused variable 'ncv' [-Wunused-variable] int ncv = mlx5e_get_max_num_channels(priv->mdev); ^ Introduced by commit 639e9e94160e ("net/mlx5e: Remove unnecessary checks when setting num channels") which removed the last reference to 'ncv'. We will send a fix shortly. Thanks for your report! Regards, Tariq
linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels': drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:546:6: warning: unused variable 'ncv' [-Wunused-variable] int ncv = mlx5e_get_max_num_channels(priv->mdev); ^ Introduced by commit 639e9e94160e ("net/mlx5e: Remove unnecessary checks when setting num channels") which removed the last reference to 'ncv'. -- Cheers, Stephen Rothwell
linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels': drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:546:6: warning: unused variable 'ncv' [-Wunused-variable] int ncv = mlx5e_get_max_num_channels(priv->mdev); ^ Introduced by commit 639e9e94160e ("net/mlx5e: Remove unnecessary checks when setting num channels") which removed the last reference to 'ncv'. -- Cheers, Stephen Rothwell
Re: linux-next: build warning after merge of the net tree
From: Stephen Rothwell Date: Wed, 24 Sep 2014 07:23:06 +1000 > Dave, this is a bit slack of you since I reported that problem a week > ago in the net tree and yet it has not been completely fixed before you > asked Linus to pull your tree :-( There were build failures I saw due to some misbalanced select/depends issues which I fixed in: commit df568d8e5250bf24e38c69ad4374baf0f8d279ba Author: David S. Miller Date: Mon Sep 22 13:14:33 2014 -0400 scsi: Use 'depends' with LIBFC instead of 'select'. which went in yesterday. I thought that would resolve all of your problems. Believe me, it is a tragic surprise that several defconfigs absolutely depended upon this broken usage of select in the scsi layer, to of all things make CONFIG_NET=y implicit. I'll do my best to sort this out, but I hope that this short term pain is worth it in the end. Thanks for your understanding. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the net tree
Hi all, On Wed, 24 Sep 2014 07:23:06 +1000 Stephen Rothwell wrote: > > On Tue, 23 Sep 2014 16:59:59 +0200 Michal Marek wrote: > > > > On 2014-09-18 02:35, Randy Dunlap wrote: > > > On 09/17/14 17:32, Stephen Rothwell wrote: > > >> Hi all, > > >> > > >> After merging the net tree, today's linux-next build (powerpc > > >> ppc64_defconfig) produced these warnings: > > >> > > >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && > > >> EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects > > >> IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && > > >> ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX > > >> && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII > > >> which has unmet direct dependencies (NETDEVICES && ETHERNET && > > >> NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) > > >> selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && > > >> ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && > > >> 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 > > >> which has unmet direct dependencies (NETDEVICES && ETHERNET && > > >> NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX > > >> && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII > > >> which has unmet direct dependencies (NETDEVICES && ETHERNET && > > >> NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && > > >> EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects > > >> IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && > > >> ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) > > >> selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && > > >> ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && > > >> 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 > > >> which has unmet direct dependencies (NETDEVICES && ETHERNET && > > >> NET_VENDOR_IBM) > > >> > > > > > > I have looked into these and don't see why there is a problem. > > > Any help would be appreciated. > > > > This is a side effect of 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK > > dependent on NET instead of selecting NET"). Previously, SCSI_FC_ATTRS > > would select SCSI_NETLINK which would select CONFIG_NET. The above > > warnings are just a tip of the iceberg, the more serious issue is that > > ppc64_defconfig is lacking networking support. This is the downside of > > savedefconfig, because the 'select' implications can disappear over > > time. Looks like more defconfigs are affected by this: > > And since 5d6be6a5 is now in Linus' tree, we need Michal's 5 patches > (at least) to be sent to Linus ASAP ... I have put those 5 patches in my fixes tree for today ... -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build warning after merge of the net tree
Hi all, On Tue, 23 Sep 2014 16:59:59 +0200 Michal Marek wrote: > > On 2014-09-18 02:35, Randy Dunlap wrote: > > On 09/17/14 17:32, Stephen Rothwell wrote: > >> Hi all, > >> > >> After merging the net tree, today's linux-next build (powerpc > >> ppc64_defconfig) produced these warnings: > >> > >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER > >> && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII > >> which has unmet direct dependencies (NETDEVICES && ETHERNET && > >> NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && > >> 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which > >> has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects > >> IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET > >> && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && > >> 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 > >> which has unmet direct dependencies (NETDEVICES && ETHERNET && > >> NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && > >> 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which > >> has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER > >> && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII > >> which has unmet direct dependencies (NETDEVICES && ETHERNET && > >> NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects > >> IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET > >> && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && > >> 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 > >> which has unmet direct dependencies (NETDEVICES && ETHERNET && > >> NET_VENDOR_IBM) > >> > > > > I have looked into these and don't see why there is a problem. > > Any help would be appreciated. > > This is a side effect of 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK > dependent on NET instead of selecting NET"). Previously, SCSI_FC_ATTRS > would select SCSI_NETLINK which would select CONFIG_NET. The above > warnings are just a tip of the iceberg, the more serious issue is that > ppc64_defconfig is lacking networking support. This is the downside of > savedefconfig, because the 'select' implications can disappear over > time. Looks like more defconfigs are affected by this: And since 5d6be6a5 is now in Linus' tree, we need Michal's 5 patches (at least) to be sent to Linus ASAP ... So it appears that using select can get us into the same sort of trouble that not including all needed header files can. Unfortunately, savedconfig makes that much worse :-(. So anyone changing a "select X" to "depends on X" needs to regenerate a lot of defconfigs to make sure that there are no unforeseen consequences. Dave, this is a bit slack of you since I reported that problem a week ago in the net tree and yet it has not been completely fixed before you asked Linus to pull your tree :-( -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build warning after merge of the net tree
On 2014-09-18 02:35, Randy Dunlap wrote: > On 09/17/14 17:32, Stephen Rothwell wrote: >> Hi all, >> >> After merging the net tree, today's linux-next build (powerpc >> ppc64_defconfig) produced these warnings: >> >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && >> 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which >> has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && >> 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has >> unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects >> IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && >> NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe >> && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has >> unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && >> 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has >> unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && >> 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which >> has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects >> IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && >> NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe >> && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has >> unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> > > I have looked into these and don't see why there is a problem. > Any help would be appreciated. This is a side effect of 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET"). Previously, SCSI_FC_ATTRS would select SCSI_NETLINK which would select CONFIG_NET. The above warnings are just a tip of the iceberg, the more serious issue is that ppc64_defconfig is lacking networking support. This is the downside of savedefconfig, because the 'select' implications can disappear over time. Looks like more defconfigs are affected by this: $ grep -rL CONFIG_NET= arch/*/configs/ | xargs grep -l CONFIG_SCSI_FC_ATTRS= arch/ia64/configs/generic_defconfig arch/ia64/configs/gensparse_defconfig arch/mips/configs/ip27_defconfig arch/mips/configs/malta_defconfig arch/mips/configs/rm200_defconfig arch/mips/configs/malta_kvm_guest_defconfig arch/mips/configs/gpr_defconfig arch/mips/configs/jazz_defconfig arch/mips/configs/mtx1_defconfig arch/mips/configs/malta_kvm_defconfig arch/mips/configs/loongson3_defconfig arch/parisc/configs/c8000_defconfig arch/powerpc/configs/pseries_defconfig arch/powerpc/configs/pseries_le_defconfig arch/powerpc/configs/ppc64e_defconfig arch/powerpc/configs/ppc64_defconfig arch/powerpc/configs/pmac32_defconfig arch/sh/configs/sh2007_defconfig arch/sh/configs/sdk7780_defconfig arch/sparc/configs/sparc64_defconfig Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the net tree
On 2014-09-18 02:35, Randy Dunlap wrote: On 09/17/14 17:32, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) I have looked into these and don't see why there is a problem. Any help would be appreciated. This is a side effect of 5d6be6a5 (scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET). Previously, SCSI_FC_ATTRS would select SCSI_NETLINK which would select CONFIG_NET. The above warnings are just a tip of the iceberg, the more serious issue is that ppc64_defconfig is lacking networking support. This is the downside of savedefconfig, because the 'select' implications can disappear over time. Looks like more defconfigs are affected by this: $ grep -rL CONFIG_NET= arch/*/configs/ | xargs grep -l CONFIG_SCSI_FC_ATTRS= arch/ia64/configs/generic_defconfig arch/ia64/configs/gensparse_defconfig arch/mips/configs/ip27_defconfig arch/mips/configs/malta_defconfig arch/mips/configs/rm200_defconfig arch/mips/configs/malta_kvm_guest_defconfig arch/mips/configs/gpr_defconfig arch/mips/configs/jazz_defconfig arch/mips/configs/mtx1_defconfig arch/mips/configs/malta_kvm_defconfig arch/mips/configs/loongson3_defconfig arch/parisc/configs/c8000_defconfig arch/powerpc/configs/pseries_defconfig arch/powerpc/configs/pseries_le_defconfig arch/powerpc/configs/ppc64e_defconfig arch/powerpc/configs/ppc64_defconfig arch/powerpc/configs/pmac32_defconfig arch/sh/configs/sh2007_defconfig arch/sh/configs/sdk7780_defconfig arch/sparc/configs/sparc64_defconfig Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the net tree
Hi all, On Tue, 23 Sep 2014 16:59:59 +0200 Michal Marek mma...@suse.cz wrote: On 2014-09-18 02:35, Randy Dunlap wrote: On 09/17/14 17:32, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) I have looked into these and don't see why there is a problem. Any help would be appreciated. This is a side effect of 5d6be6a5 (scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET). Previously, SCSI_FC_ATTRS would select SCSI_NETLINK which would select CONFIG_NET. The above warnings are just a tip of the iceberg, the more serious issue is that ppc64_defconfig is lacking networking support. This is the downside of savedefconfig, because the 'select' implications can disappear over time. Looks like more defconfigs are affected by this: And since 5d6be6a5 is now in Linus' tree, we need Michal's 5 patches (at least) to be sent to Linus ASAP ... So it appears that using select can get us into the same sort of trouble that not including all needed header files can. Unfortunately, savedconfig makes that much worse :-(. So anyone changing a select X to depends on X needs to regenerate a lot of defconfigs to make sure that there are no unforeseen consequences. Dave, this is a bit slack of you since I reported that problem a week ago in the net tree and yet it has not been completely fixed before you asked Linus to pull your tree :-( -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build warning after merge of the net tree
Hi all, On Wed, 24 Sep 2014 07:23:06 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: On Tue, 23 Sep 2014 16:59:59 +0200 Michal Marek mma...@suse.cz wrote: On 2014-09-18 02:35, Randy Dunlap wrote: On 09/17/14 17:32, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) I have looked into these and don't see why there is a problem. Any help would be appreciated. This is a side effect of 5d6be6a5 (scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET). Previously, SCSI_FC_ATTRS would select SCSI_NETLINK which would select CONFIG_NET. The above warnings are just a tip of the iceberg, the more serious issue is that ppc64_defconfig is lacking networking support. This is the downside of savedefconfig, because the 'select' implications can disappear over time. Looks like more defconfigs are affected by this: And since 5d6be6a5 is now in Linus' tree, we need Michal's 5 patches (at least) to be sent to Linus ASAP ... I have put those 5 patches in my fixes tree for today ... -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build warning after merge of the net tree
From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 24 Sep 2014 07:23:06 +1000 Dave, this is a bit slack of you since I reported that problem a week ago in the net tree and yet it has not been completely fixed before you asked Linus to pull your tree :-( There were build failures I saw due to some misbalanced select/depends issues which I fixed in: commit df568d8e5250bf24e38c69ad4374baf0f8d279ba Author: David S. Miller da...@davemloft.net Date: Mon Sep 22 13:14:33 2014 -0400 scsi: Use 'depends' with LIBFC instead of 'select'. which went in yesterday. I thought that would resolve all of your problems. Believe me, it is a tragic surprise that several defconfigs absolutely depended upon this broken usage of select in the scsi layer, to of all things make CONFIG_NET=y implicit. I'll do my best to sort this out, but I hope that this short term pain is worth it in the end. Thanks for your understanding. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the net tree
On 09/17/14 17:32, Stephen Rothwell wrote: > Hi all, > > After merging the net tree, today's linux-next build (powerpc > ppc64_defconfig) produced these warnings: > > warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && > 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has > unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && > 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has > unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects > IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && > NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe > && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has > unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && > 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has > unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && > 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has > unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects > IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && > NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe > && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has > unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > I have looked into these and don't see why there is a problem. Any help would be appreciated. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
linux-next: build warning after merge of the net tree
Hi all, After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build warning after merge of the net tree
On 09/17/14 17:32, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) I have looked into these and don't see why there is a problem. Any help would be appreciated. -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/