Re: linux-next: build warning after merge of the slave-dma tree
Hi Arnd, On Mon, 12 Aug 2019 11:14:08 +0200 Arnd Bergmann wrote: > > The warning is valid, I will send a fix. Thanks. > I have never seen this message though, I guess the build system just > introduced > a check for this? I don't see where this would come from in next-20190809 > (only checking with grep, not actually trying to build right now). Yeah, we had a version of this a week or so ago and it has come back today (I haven't done today's release yet). -- Cheers, Stephen Rothwell pgpIANwhXl2r1.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the slave-dma tree
On Mon, Aug 12, 2019 at 9:14 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the slave-dma tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> WARNING: "omap_dma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL_GPL
> WARNING: "edma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL
>
> Introduced by commits
>
> 9c71b9eb3cb2 ("dmaengine: omap-dma: make omap_dma_filter_fn private")
> d2bfe7b5d182 ("dmaengine: edma: make edma_filter_fn private")
The warning is valid, I will send a fix.
I have never seen this message though, I guess the build system just introduced
a check for this? I don't see where this would come from in next-20190809
(only checking with grep, not actually trying to build right now).
Arnd
linux-next: build warning after merge of the slave-dma tree
Hi all,
After merging the slave-dma tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
WARNING: "omap_dma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL_GPL
WARNING: "edma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL
Introduced by commits
9c71b9eb3cb2 ("dmaengine: omap-dma: make omap_dma_filter_fn private")
d2bfe7b5d182 ("dmaengine: edma: make edma_filter_fn private")
--
Cheers,
Stephen Rothwell
pgp9nA5k3ZLTK.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the slave-dma tree
Hi Stephen,
On 26-11-18, 16:59, Stephen Rothwell wrote:
> Hi Vinod,
>
> After merging the slave-dma tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/dma/coh901318.c: In function 'coh901318_config':
> drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags'
> [-Wunused-variable]
> unsigned long flags;
> ^
>
> Introduced by commit
>
> 627469e4445b ("dmaengine: coh901318: Fix a double-lock bug")
Thanks for the report, I have fixed it up with below:
-- >8 --
>From fbbdec195155b4497cb83be37788865f98f31dca Mon Sep 17 00:00:00 2001
From: Vinod Koul
Date: Mon, 26 Nov 2018 13:34:15 +0530
Subject: [PATCH] dmaengine: coh901318: Remove unused variable
Commit 627469e4445b ("dmaengine: coh901318: Fix a double-lock bug") left
flags variable unused, so remove it to fix the warning.
drivers/dma/coh901318.c: In function 'coh901318_config':
drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags'
[-Wunused-variable]
unsigned long flags;
^
Reported-By: Stephen Rothwell
Signed-off-by: Vinod Koul
---
drivers/dma/coh901318.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c
index fd862a478738..b69d66e44052 100644
--- a/drivers/dma/coh901318.c
+++ b/drivers/dma/coh901318.c
@@ -1802,7 +1802,6 @@ static struct dma_chan *coh901318_xlate(struct
of_phandle_args *dma_spec,
static int coh901318_config(struct coh901318_chan *cohc,
struct coh901318_params *param)
{
- unsigned long flags;
const struct coh901318_params *p;
int channel = cohc->id;
void __iomem *virtbase = cohc->base->virtbase;
--
2.14.5
--
~Vinod
Re: linux-next: build warning after merge of the slave-dma tree
Hi Stephen,
On 26-11-18, 16:59, Stephen Rothwell wrote:
> Hi Vinod,
>
> After merging the slave-dma tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/dma/coh901318.c: In function 'coh901318_config':
> drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags'
> [-Wunused-variable]
> unsigned long flags;
> ^
>
> Introduced by commit
>
> 627469e4445b ("dmaengine: coh901318: Fix a double-lock bug")
Thanks for the report, I have fixed it up with below:
-- >8 --
>From fbbdec195155b4497cb83be37788865f98f31dca Mon Sep 17 00:00:00 2001
From: Vinod Koul
Date: Mon, 26 Nov 2018 13:34:15 +0530
Subject: [PATCH] dmaengine: coh901318: Remove unused variable
Commit 627469e4445b ("dmaengine: coh901318: Fix a double-lock bug") left
flags variable unused, so remove it to fix the warning.
drivers/dma/coh901318.c: In function 'coh901318_config':
drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags'
[-Wunused-variable]
unsigned long flags;
^
Reported-By: Stephen Rothwell
Signed-off-by: Vinod Koul
---
drivers/dma/coh901318.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c
index fd862a478738..b69d66e44052 100644
--- a/drivers/dma/coh901318.c
+++ b/drivers/dma/coh901318.c
@@ -1802,7 +1802,6 @@ static struct dma_chan *coh901318_xlate(struct
of_phandle_args *dma_spec,
static int coh901318_config(struct coh901318_chan *cohc,
struct coh901318_params *param)
{
- unsigned long flags;
const struct coh901318_params *p;
int channel = cohc->id;
void __iomem *virtbase = cohc->base->virtbase;
--
2.14.5
--
~Vinod
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/dma/coh901318.c: In function 'coh901318_config':
drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags'
[-Wunused-variable]
unsigned long flags;
^
Introduced by commit
627469e4445b ("dmaengine: coh901318: Fix a double-lock bug")
--
Cheers,
Stephen Rothwell
pgp_XvZgdKYFJ.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/dma/coh901318.c: In function 'coh901318_config':
drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags'
[-Wunused-variable]
unsigned long flags;
^
Introduced by commit
627469e4445b ("dmaengine: coh901318: Fix a double-lock bug")
--
Cheers,
Stephen Rothwell
pgp_XvZgdKYFJ.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the slave-dma tree
Hi,
sorry, there was no build-test robot warning anymore about it.
Will fix it in a patch in short.
On Thu, Sep 13, 2018 at 12:22:18PM +1000, Stephen Rothwell wrote:
> Hi Vinod,
>
> After merging the slave-dma tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/dma/mcf-edma.c: In function 'mcf_edma_filter_fn':
> drivers/dma/mcf-edma.c:296:33: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
>return (mcf_chan->slave_id == (u32)param);
> ^
>
> Introduced by commit
>
> e7a3ff92eaf1 ("dmaengine: fsl-edma: add ColdFire mcf5441x edma support")
>
Regards,
Angelo
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build warning after merge of the slave-dma tree
Hi,
sorry, there was no build-test robot warning anymore about it.
Will fix it in a patch in short.
On Thu, Sep 13, 2018 at 12:22:18PM +1000, Stephen Rothwell wrote:
> Hi Vinod,
>
> After merging the slave-dma tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/dma/mcf-edma.c: In function 'mcf_edma_filter_fn':
> drivers/dma/mcf-edma.c:296:33: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
>return (mcf_chan->slave_id == (u32)param);
> ^
>
> Introduced by commit
>
> e7a3ff92eaf1 ("dmaengine: fsl-edma: add ColdFire mcf5441x edma support")
>
Regards,
Angelo
> --
> Cheers,
> Stephen Rothwell
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/dma/mcf-edma.c: In function 'mcf_edma_filter_fn':
drivers/dma/mcf-edma.c:296:33: warning: cast from pointer to integer of
different size [-Wpointer-to-int-cast]
return (mcf_chan->slave_id == (u32)param);
^
Introduced by commit
e7a3ff92eaf1 ("dmaengine: fsl-edma: add ColdFire mcf5441x edma support")
--
Cheers,
Stephen Rothwell
pgpxoP9d36xHg.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/dma/mcf-edma.c: In function 'mcf_edma_filter_fn':
drivers/dma/mcf-edma.c:296:33: warning: cast from pointer to integer of
different size [-Wpointer-to-int-cast]
return (mcf_chan->slave_id == (u32)param);
^
Introduced by commit
e7a3ff92eaf1 ("dmaengine: fsl-edma: add ColdFire mcf5441x edma support")
--
Cheers,
Stephen Rothwell
pgpxoP9d36xHg.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the slave-dma tree
Hi Stephen,
On 05-07-18, 12:47, Stephen Rothwell wrote:
> On Wed, 4 Jul 2018 09:50:17 +0530 Vinod wrote:
> > On 04-07-18, 13:30, Stephen Rothwell wrote:
> > >
> > > After merging the slave-dma tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > WARNING: modpost: missing MODULE_LICENSE() in
> > > drivers/dma/fsl-edma-common.o
> >
> > Thanks for the report, I have fixed it by adding this and pushed out.
>
> Unfortunately, my arm multi_v7_defconfig build now gets this failure:
>
> drivers/dma/fsl-edma-common.c:672:16: error: expected declaration specifiers
> or '...' before string constant
> MODULE_LICENSE("GPL v2");
> ^~~~
>
> presumable a missing include of module.h ...
Thanks for reporting will check and fix this.
--
~Vinod
Re: linux-next: build warning after merge of the slave-dma tree
Hi Stephen,
On 05-07-18, 12:47, Stephen Rothwell wrote:
> On Wed, 4 Jul 2018 09:50:17 +0530 Vinod wrote:
> > On 04-07-18, 13:30, Stephen Rothwell wrote:
> > >
> > > After merging the slave-dma tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > WARNING: modpost: missing MODULE_LICENSE() in
> > > drivers/dma/fsl-edma-common.o
> >
> > Thanks for the report, I have fixed it by adding this and pushed out.
>
> Unfortunately, my arm multi_v7_defconfig build now gets this failure:
>
> drivers/dma/fsl-edma-common.c:672:16: error: expected declaration specifiers
> or '...' before string constant
> MODULE_LICENSE("GPL v2");
> ^~~~
>
> presumable a missing include of module.h ...
Thanks for reporting will check and fix this.
--
~Vinod
Re: linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
On Wed, 4 Jul 2018 09:50:17 +0530 Vinod wrote:
>
> On 04-07-18, 13:30, Stephen Rothwell wrote:
> >
> > After merging the slave-dma tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-edma-common.o
> >
>
> Thanks for the report, I have fixed it by adding this and pushed out.
Unfortunately, my arm multi_v7_defconfig build now gets this failure:
drivers/dma/fsl-edma-common.c:672:16: error: expected declaration specifiers or
'...' before string constant
MODULE_LICENSE("GPL v2");
^~~~
presumable a missing include of module.h ...
I have gone back to the slave-dma tree from next-20180704 for today.
--
Cheers,
Stephen Rothwell
pgpfIhizur9j_.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
On Wed, 4 Jul 2018 09:50:17 +0530 Vinod wrote:
>
> On 04-07-18, 13:30, Stephen Rothwell wrote:
> >
> > After merging the slave-dma tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-edma-common.o
> >
>
> Thanks for the report, I have fixed it by adding this and pushed out.
Unfortunately, my arm multi_v7_defconfig build now gets this failure:
drivers/dma/fsl-edma-common.c:672:16: error: expected declaration specifiers or
'...' before string constant
MODULE_LICENSE("GPL v2");
^~~~
presumable a missing include of module.h ...
I have gone back to the slave-dma tree from next-20180704 for today.
--
Cheers,
Stephen Rothwell
pgpfIhizur9j_.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the slave-dma tree
Hi Stephen, On 04-07-18, 13:30, Stephen Rothwell wrote: > > After merging the slave-dma tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-edma-common.o Thanks for the report, I have fixed it by adding this and pushed out. -- ~Vinod
Re: linux-next: build warning after merge of the slave-dma tree
Hi Stephen, On 04-07-18, 13:30, Stephen Rothwell wrote: > > After merging the slave-dma tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-edma-common.o Thanks for the report, I have fixed it by adding this and pushed out. -- ~Vinod
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-edma-common.o
Introduced by commit
6ad069123f03 ("dmaengine: fsl-edma: extract common fsl-edma code (no changes
in behavior intended)")
--
Cheers,
Stephen Rothwell
pgplP29CfMj2l.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-edma-common.o
Introduced by commit
6ad069123f03 ("dmaengine: fsl-edma: extract common fsl-edma code (no changes
in behavior intended)")
--
Cheers,
Stephen Rothwell
pgplP29CfMj2l.pgp
Description: OpenPGP digital signature
RE: linux-next: build warning after merge of the slave-dma tree
Hi Stephen Rothwell,
> Hi Vinod,
>
> After merging the slave-dma tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
> drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>segment->hw.control |= XILINX_DMA_BD_SOP;
Thanks for reporting the issue.
I have fixed it and sent the patch...
>
> Introduced by commit
>
> 92d794dfb699 ("dmaengine: vdma: Add support for cyclic dma mode")
>
> I am not sure if this is tecnically a problem, but gcc certainly cannot tell.
Thanks,
Kedar.
RE: linux-next: build warning after merge of the slave-dma tree
Hi Stephen Rothwell,
> Hi Vinod,
>
> After merging the slave-dma tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
> drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>segment->hw.control |= XILINX_DMA_BD_SOP;
Thanks for reporting the issue.
I have fixed it and sent the patch...
>
> Introduced by commit
>
> 92d794dfb699 ("dmaengine: vdma: Add support for cyclic dma mode")
>
> I am not sure if this is tecnically a problem, but gcc certainly cannot tell.
Thanks,
Kedar.
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
uninitialized in this function [-Wmaybe-uninitialized]
segment->hw.control |= XILINX_DMA_BD_SOP;
Introduced by commit
92d794dfb699 ("dmaengine: vdma: Add support for cyclic dma mode")
I am not sure if this is tecnically a problem, but gcc certainly cannot
tell.
--
Cheers,
Stephen Rothwell
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
uninitialized in this function [-Wmaybe-uninitialized]
segment->hw.control |= XILINX_DMA_BD_SOP;
Introduced by commit
92d794dfb699 ("dmaengine: vdma: Add support for cyclic dma mode")
I am not sure if this is tecnically a problem, but gcc certainly cannot
tell.
--
Cheers,
Stephen Rothwell
Re: linux-next: build warning after merge of the slave-dma tree
Hi Stephen Rothwell,
I will fix this and will send a patch.
Regards,
Kedar.
On 3/30/2015 11:50 AM, Stephen Rothwell wrote:
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0:
include/linux/dmapool.h:18:4: warning: 'struct device' declared inside
parameter list
size_t size, size_t align, size_t allocation);
^
include/linux/dmapool.h:18:4: warning: its scope is only this definition or
declaration, which is probably not what you want
include/linux/dmapool.h:31:7: warning: 'struct device' declared inside
parameter list
size_t size, size_t align, size_t allocation);
^
drivers/dma/xilinx/xilinx_vdma.c: In function
'xilinx_vdma_alloc_chan_resources':
drivers/dma/xilinx/xilinx_vdma.c:501:20: warning: passing argument 2 of
'dma_pool_create' from incompatible pointer type
chan->desc_pool = dma_pool_create("xilinx_vdma_desc_pool",
^
In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0:
include/linux/dmapool.h:17:18: note: expected 'struct device *' but argument is
of type 'struct device *'
struct dma_pool *dma_pool_create(const char *name, struct device *dev,
^
Presumable caused by the include order change in commit 937abe88aea3
("dmaengine: xilinx-dma: move header file to common location").
I guess that dmapool.h needs a "struct device;" line near the top.
This email and any attachments are intended for the sole use of the named
recipient(s) and contain(s) confidential information that may be proprietary,
privileged or copyrighted under applicable law. If you are not the intended
recipient, do not read, copy, or forward this email message or any attachments.
Delete this email message and any attachments immediately.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build warning after merge of the slave-dma tree
Hi Vinod,
After merging the slave-dma tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0:
include/linux/dmapool.h:18:4: warning: 'struct device' declared inside
parameter list
size_t size, size_t align, size_t allocation);
^
include/linux/dmapool.h:18:4: warning: its scope is only this definition or
declaration, which is probably not what you want
include/linux/dmapool.h:31:7: warning: 'struct device' declared inside
parameter list
size_t size, size_t align, size_t allocation);
^
drivers/dma/xilinx/xilinx_vdma.c: In function
'xilinx_vdma_alloc_chan_resources':
drivers/dma/xilinx/xilinx_vdma.c:501:20: warning: passing argument 2 of
'dma_pool_create' from incompatible pointer type
chan->desc_pool = dma_pool_create("xilinx_vdma_desc_pool",
^
In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0:
include/linux/dmapool.h:17:18: note: expected 'struct device *' but argument is
of type 'struct device *'
struct dma_pool *dma_pool_create(const char *name, struct device *dev,
^
Presumable caused by the include order change in commit 937abe88aea3
("dmaengine: xilinx-dma: move header file to common location").
I guess that dmapool.h needs a "struct device;" line near the top.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgptitvjp64RM.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the slave-dma tree
Hi Vinod, After merging the slave-dma tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0: include/linux/dmapool.h:18:4: warning: 'struct device' declared inside parameter list size_t size, size_t align, size_t allocation); ^ include/linux/dmapool.h:18:4: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/dmapool.h:31:7: warning: 'struct device' declared inside parameter list size_t size, size_t align, size_t allocation); ^ drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_vdma_alloc_chan_resources': drivers/dma/xilinx/xilinx_vdma.c:501:20: warning: passing argument 2 of 'dma_pool_create' from incompatible pointer type chan-desc_pool = dma_pool_create(xilinx_vdma_desc_pool, ^ In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0: include/linux/dmapool.h:17:18: note: expected 'struct device *' but argument is of type 'struct device *' struct dma_pool *dma_pool_create(const char *name, struct device *dev, ^ Presumable caused by the include order change in commit 937abe88aea3 (dmaengine: xilinx-dma: move header file to common location). I guess that dmapool.h needs a struct device; line near the top. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgptitvjp64RM.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the slave-dma tree
Hi Stephen Rothwell, I will fix this and will send a patch. Regards, Kedar. On 3/30/2015 11:50 AM, Stephen Rothwell wrote: Hi Vinod, After merging the slave-dma tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0: include/linux/dmapool.h:18:4: warning: 'struct device' declared inside parameter list size_t size, size_t align, size_t allocation); ^ include/linux/dmapool.h:18:4: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/dmapool.h:31:7: warning: 'struct device' declared inside parameter list size_t size, size_t align, size_t allocation); ^ drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_vdma_alloc_chan_resources': drivers/dma/xilinx/xilinx_vdma.c:501:20: warning: passing argument 2 of 'dma_pool_create' from incompatible pointer type chan-desc_pool = dma_pool_create(xilinx_vdma_desc_pool, ^ In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0: include/linux/dmapool.h:17:18: note: expected 'struct device *' but argument is of type 'struct device *' struct dma_pool *dma_pool_create(const char *name, struct device *dev, ^ Presumable caused by the include order change in commit 937abe88aea3 (dmaengine: xilinx-dma: move header file to common location). I guess that dmapool.h needs a struct device; line near the top. This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
