Re: linux-next: build warning after merge of the sound tree

[Takashi Iwai]

On Fri, 01 May 2020 06:03:23 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/pci/hda/patch_realtek.c: In function 'alc_fixup_hp_gpio_led':
> sound/pci/hda/patch_realtek.c:4134:6: warning: unused variable 'err' 
> [-Wunused-variable]
>  4134 |  int err;
>   |  ^~~
> 
> Introduced by commit
> 
>   87dc36482cab ("ALSA: hda/realtek - Add LED class support for micmute LED")

I submitted the fix patch now and it will be included later:
  https://lore.kernel.org/r/20200501072857.13720-1-ti...@suse.de


thanks,

Takashi

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

Hi all,

After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/pci/hda/patch_realtek.c: In function 'alc_fixup_hp_gpio_led':
sound/pci/hda/patch_realtek.c:4134:6: warning: unused variable 'err' 
[-Wunused-variable]
 4134 |  int err;
  |  ^~~

Introduced by commit

  87dc36482cab ("ALSA: hda/realtek - Add LED class support for micmute LED")

-- 
Cheers,
Stephen Rothwell


pgpvchfDJI3EV.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the sound tree

[Takashi Iwai]

On Mon, 21 Jan 2019 01:21:48 +0100,
Stephen Rothwell wrote:
On Mon, 21 Jan 2019 01:21:48 +0100,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
> sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm' 
> [-Wunused-variable]
>   struct hda_pcm *pcm;
>   ^~~
> 
> Introduced by commit
> 
>   17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")

Thanks, fixed now with the patch below.


Takashi

-- 8< --
From: Takashi Iwai 
Subject: [PATCH] ALSA: hda - Fix unused variable warning

The unused variable was forgotten to be removed and now we get a
compiler warning:
  sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
  sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm'

Fixes: 17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")
Reported-by: Stephen Rothwell 
Signed-off-by: Takashi Iwai 
---
 sound/pci/hda/hda_codec.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index ff6dbed4d3cd..e4704f5729d3 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -2923,7 +2923,6 @@ static void hda_call_codec_resume(struct hda_codec *codec)
 static int hda_codec_runtime_suspend(struct device *dev)
 {
struct hda_codec *codec = dev_to_hda_codec(dev);
-   struct hda_pcm *pcm;
unsigned int state;
 
cancel_delayed_work_sync(>jackpoll_work);
-- 
2.16.4

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

Hi Takashi,

After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm' 
[-Wunused-variable]
  struct hda_pcm *pcm;
  ^~~

Introduced by commit

  17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")

-- 
Cheers,
Stephen Rothwell


pgpaDTZov4lfg.pgp
Description: OpenPGP digital signature