Re: linux-next: build warning after merge of the tty tree

[miaoqinglang]

在 2020/9/29 15:32, Greg KH 写道:

On Tue, Sep 29, 2020 at 02:41:27PM +0800, miaoqinglang wrote:



在 2020/9/29 14:01, Stephen Rothwell 写道:

Hi all,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' 
[-Wunused-variable]
806 |  int ret, id, irq;
|  ^~~

Introduced by commit

b63537020db3 ("serial: mvebu-uart: simplify the return expression of 
mvebu_uart_probe()")


Hi Greg,

Sorry about the noise for remaining the unused variable 'ret' in commit
b63537020db3.

Should I send another patch to clean up this warning or send another v2
patch instead?


A fix-up patch would be best, as this is already in my tree.

thanks,

greg k-h
.A fix-up patch has been sent.

Thanks

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Tue, Sep 29, 2020 at 02:41:27PM +0800, miaoqinglang wrote:
> 
> 
> 在 2020/9/29 14:01, Stephen Rothwell 写道:
> > Hi all,
> > 
> > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
> > drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' 
> > [-Wunused-variable]
> >806 |  int ret, id, irq;
> >|  ^~~
> > 
> > Introduced by commit
> > 
> >b63537020db3 ("serial: mvebu-uart: simplify the return expression of 
> > mvebu_uart_probe()")
> > 
> Hi Greg,
> 
> Sorry about the noise for remaining the unused variable 'ret' in commit
> b63537020db3.
> 
> Should I send another patch to clean up this warning or send another v2
> patch instead?

A fix-up patch would be best, as this is already in my tree.

thanks,

greg k-h

Re: linux-next: build warning after merge of the tty tree

[miaoqinglang]

在 2020/9/29 14:01, Stephen Rothwell 写道:

Hi all,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' 
[-Wunused-variable]
   806 |  int ret, id, irq;
   |  ^~~

Introduced by commit

   b63537020db3 ("serial: mvebu-uart: simplify the return expression of 
mvebu_uart_probe()")


Hi Greg,

Sorry about the noise for remaining the unused variable 'ret' in commit 
b63537020db3.


Should I send another patch to clean up this warning or send another v2 
patch instead?


Thanks.

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi all,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' 
[-Wunused-variable]
  806 |  int ret, id, irq;
  |  ^~~

Introduced by commit

  b63537020db3 ("serial: mvebu-uart: simplify the return expression of 
mvebu_uart_probe()")

-- 
Cheers,
Stephen Rothwell


pgpuG0DL6aVh9.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Wed, Sep 09, 2020 at 03:56:54PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/8250/8250_bcm2835aux.c: In function 
> 'bcm2835aux_serial_probe':
> drivers/tty/serial/8250/8250_bcm2835aux.c:154:3: warning: ignoring return 
> value of 'dev_err_probe' declared with attribute 'warn_unused_result' 
> [-Wunused-result]
>   154 |   dev_err_probe(>dev, ret, "unable to register 8250 port\n");
>   |   ^~~~
> 
> Introduced by commit
> 
>   ea43a60b1548 ("serial: 8250: Simplify with dev_err_probe()")

Offending patch now dropped from the driver-core tree, thanks.

greg k-h

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi all,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/tty/serial/8250/8250_bcm2835aux.c: In function 
'bcm2835aux_serial_probe':
drivers/tty/serial/8250/8250_bcm2835aux.c:154:3: warning: ignoring return value 
of 'dev_err_probe' declared with attribute 'warn_unused_result' 
[-Wunused-result]
  154 |   dev_err_probe(>dev, ret, "unable to register 8250 port\n");
  |   ^~~~

Introduced by commit

  ea43a60b1548 ("serial: 8250: Simplify with dev_err_probe()")

-- 
Cheers,
Stephen Rothwell


pgp5MOzggYyyG.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/tty/serial/kgdboc.c:134:12: warning: 'kgdboc_option_setup' defined but 
not used [-Wunused-function]
 static int kgdboc_option_setup(char *opt)
^~~

Introduced by commit

  2dd453168643 ("kgdboc: Fix restrict error")

-- 
Cheers,
Stephen Rothwell


pgpqCp4ZgBnER.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/tty/serial/kgdboc.c:134:12: warning: 'kgdboc_option_setup' defined but 
not used [-Wunused-function]
 static int kgdboc_option_setup(char *opt)
^~~

Introduced by commit

  2dd453168643 ("kgdboc: Fix restrict error")

-- 
Cheers,
Stephen Rothwell


pgpqCp4ZgBnER.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the tty tree

[Andy Shevchenko]

On Mon, 2018-07-23 at 15:39 +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/8250/8250_exar.c: In function 'pci_xr17v35x_setup':
> drivers/tty/serial/8250/8250_exar.c:380:31: warning: unused variable
> 'board' [-Wunused-variable]
>   const struct exar8250_board *board = priv->board;
>^
> 
> Introduced by commit
> 
>   328c11f24b57 ("serial: 8250_exar: Remove useless has_slave member")

Oops, my fault. Usually I compile with W=1, but I somehow missed this
warning (Okay, found, I used to have it in another patch). Sorry, the
just sent patch should fix it.

-- 
Andy Shevchenko 
Intel Finland Oy

Re: linux-next: build warning after merge of the tty tree

[Andy Shevchenko]

On Mon, 2018-07-23 at 15:39 +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/8250/8250_exar.c: In function 'pci_xr17v35x_setup':
> drivers/tty/serial/8250/8250_exar.c:380:31: warning: unused variable
> 'board' [-Wunused-variable]
>   const struct exar8250_board *board = priv->board;
>^
> 
> Introduced by commit
> 
>   328c11f24b57 ("serial: 8250_exar: Remove useless has_slave member")

Oops, my fault. Usually I compile with W=1, but I somehow missed this
warning (Okay, found, I used to have it in another patch). Sorry, the
just sent patch should fix it.

-- 
Andy Shevchenko 
Intel Finland Oy

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/tty/serial/8250/8250_exar.c: In function 'pci_xr17v35x_setup':
drivers/tty/serial/8250/8250_exar.c:380:31: warning: unused variable 'board' 
[-Wunused-variable]
  const struct exar8250_board *board = priv->board;
   ^

Introduced by commit

  328c11f24b57 ("serial: 8250_exar: Remove useless has_slave member")

-- 
Cheers,
Stephen Rothwell


pgp1Ggd6wPA0H.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/tty/serial/8250/8250_exar.c: In function 'pci_xr17v35x_setup':
drivers/tty/serial/8250/8250_exar.c:380:31: warning: unused variable 'board' 
[-Wunused-variable]
  const struct exar8250_board *board = priv->board;
   ^

Introduced by commit

  328c11f24b57 ("serial: 8250_exar: Remove useless has_slave member")

-- 
Cheers,
Stephen Rothwell


pgp1Ggd6wPA0H.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Tue, 7 Feb 2017 09:37:31 +0100 Greg KH  wrote:
>
> On Tue, Feb 07, 2017 at 09:37:09AM +1100, Stephen Rothwell wrote:
> > 
> > I don't see that commit in any tree I have fetched.  
> 
> That is correct, it's in my "testing" branch that I use to stage things
> in before it gets sent to the branch that you pull from.

What an amusing idea ;-)

> That branch is now merged with my -next branch, so you will see this
> change the next time you sync.

Thanks.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Tue, 7 Feb 2017 09:37:31 +0100 Greg KH  wrote:
>
> On Tue, Feb 07, 2017 at 09:37:09AM +1100, Stephen Rothwell wrote:
> > 
> > I don't see that commit in any tree I have fetched.  
> 
> That is correct, it's in my "testing" branch that I use to stage things
> in before it gets sent to the branch that you pull from.

What an amusing idea ;-)

> That branch is now merged with my -next branch, so you will see this
> change the next time you sync.

Thanks.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Tue, Feb 07, 2017 at 09:37:09AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 6 Feb 2017 18:01:20 +0100 Ulrich Hecht 
>  wrote:
> >
> > On Mon, Feb 6, 2017 at 9:50 AM, Greg KH  wrote:
> > >
> > > I think this is fixed by a patch I just took into my tree, which isn't
> > > in linux-next yet.  Right Ulrich?  
> > 
> > That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
> > SCIFA/B RX FIFO software timeout".
> 
> I don't see that commit in any tree I have fetched.

That is correct, it's in my "testing" branch that I use to stage things
in before it gets sent to the branch that you pull from.

That branch is now merged with my -next branch, so you will see this
change the next time you sync.

thanks,

greg k-h

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Tue, Feb 07, 2017 at 09:37:09AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 6 Feb 2017 18:01:20 +0100 Ulrich Hecht 
>  wrote:
> >
> > On Mon, Feb 6, 2017 at 9:50 AM, Greg KH  wrote:
> > >
> > > I think this is fixed by a patch I just took into my tree, which isn't
> > > in linux-next yet.  Right Ulrich?  
> > 
> > That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
> > SCIFA/B RX FIFO software timeout".
> 
> I don't see that commit in any tree I have fetched.

That is correct, it's in my "testing" branch that I use to stage things
in before it gets sent to the branch that you pull from.

That branch is now merged with my -next branch, so you will see this
change the next time you sync.

thanks,

greg k-h

Re: linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi all,

On Mon, 6 Feb 2017 18:01:20 +0100 Ulrich Hecht  
wrote:
>
> On Mon, Feb 6, 2017 at 9:50 AM, Greg KH  wrote:
> >
> > I think this is fixed by a patch I just took into my tree, which isn't
> > in linux-next yet.  Right Ulrich?  
> 
> That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
> SCIFA/B RX FIFO software timeout".

I don't see that commit in any tree I have fetched.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi all,

On Mon, 6 Feb 2017 18:01:20 +0100 Ulrich Hecht  
wrote:
>
> On Mon, Feb 6, 2017 at 9:50 AM, Greg KH  wrote:
> >
> > I think this is fixed by a patch I just took into my tree, which isn't
> > in linux-next yet.  Right Ulrich?  
> 
> That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
> SCIFA/B RX FIFO software timeout".

I don't see that commit in any tree I have fetched.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tty tree

[Ulrich Hecht]

On Mon, Feb 6, 2017 at 9:50 AM, Greg KH  wrote:
> On Mon, Feb 06, 2017 at 03:16:38PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build
>> (arm_multi_v7_defconfig) produced this warning:
>>
>> drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not 
>> used [-Wunused-function]
>>  static int scif_set_rtrg(struct uart_port *port, int rx_trig)
>> ^
>>
>> Introduced by commit
>>
>>   a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")
>>
>> Forgot to add a call to this new function?
>
> I think this is fixed by a patch I just took into my tree, which isn't
> in linux-next yet.  Right Ulrich?

That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
SCIFA/B RX FIFO software timeout".

CU
Uli

Re: linux-next: build warning after merge of the tty tree

[Ulrich Hecht]

On Mon, Feb 6, 2017 at 9:50 AM, Greg KH  wrote:
> On Mon, Feb 06, 2017 at 03:16:38PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build
>> (arm_multi_v7_defconfig) produced this warning:
>>
>> drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not 
>> used [-Wunused-function]
>>  static int scif_set_rtrg(struct uart_port *port, int rx_trig)
>> ^
>>
>> Introduced by commit
>>
>>   a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")
>>
>> Forgot to add a call to this new function?
>
> I think this is fixed by a patch I just took into my tree, which isn't
> in linux-next yet.  Right Ulrich?

That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
SCIFA/B RX FIFO software timeout".

CU
Uli

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 03:16:38PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build
> (arm_multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not 
> used [-Wunused-function]
>  static int scif_set_rtrg(struct uart_port *port, int rx_trig)
> ^
> 
> Introduced by commit
> 
>   a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")
> 
> Forgot to add a call to this new function?

I think this is fixed by a patch I just took into my tree, which isn't
in linux-next yet.  Right Ulrich?  Or is this still a warning with your
latest patch series?

thanks,

greg k-h

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 03:16:38PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build
> (arm_multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not 
> used [-Wunused-function]
>  static int scif_set_rtrg(struct uart_port *port, int rx_trig)
> ^
> 
> Introduced by commit
> 
>   a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")
> 
> Forgot to add a call to this new function?

I think this is fixed by a patch I just took into my tree, which isn't
in linux-next yet.  Right Ulrich?  Or is this still a warning with your
latest patch series?

thanks,

greg k-h

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:

drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not 
used [-Wunused-function]
 static int scif_set_rtrg(struct uart_port *port, int rx_trig)
^

Introduced by commit

  a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")

Forgot to add a call to this new function?

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:

drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not 
used [-Wunused-function]
 static int scif_set_rtrg(struct uart_port *port, int rx_trig)
^

Introduced by commit

  a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")

Forgot to add a call to this new function?

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Thu, Jan 21, 2016 at 12:56:18PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree (now in Linus' tree, sorry for not pointing
> it out earlier), today's linux-next build (multi_v7_defconfig) produced
> this warning:
> 
> drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not 
> used [-Wunused-variable]
>  static struct vendor_data vendor_zte = {
>^
> 
> Introduced by commit
> 
>   7ec758718920 ("tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL)")

Thanks, Arnd sent me a patch for this earlier today, I'll merge it after
4.5-rc1 is out.

thanks,

greg k-h

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree (now in Linus' tree, sorry for not pointing
it out earlier), today's linux-next build (multi_v7_defconfig) produced
this warning:

drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not 
used [-Wunused-variable]
 static struct vendor_data vendor_zte = {
   ^

Introduced by commit

  7ec758718920 ("tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL)")

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree (now in Linus' tree, sorry for not pointing
it out earlier), today's linux-next build (multi_v7_defconfig) produced
this warning:

drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not 
used [-Wunused-variable]
 static struct vendor_data vendor_zte = {
   ^

Introduced by commit

  7ec758718920 ("tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL)")

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Thu, Jan 21, 2016 at 12:56:18PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree (now in Linus' tree, sorry for not pointing
> it out earlier), today's linux-next build (multi_v7_defconfig) produced
> this warning:
> 
> drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not 
> used [-Wunused-variable]
>  static struct vendor_data vendor_zte = {
>^
> 
> Introduced by commit
> 
>   7ec758718920 ("tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL)")

Thanks, Arnd sent me a patch for this earlier today, I'll merge it after
4.5-rc1 is out.

thanks,

greg k-h

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Tue, Mar 10, 2015 at 09:23:18AM +0100, Uwe Kleine-König wrote:
> Hello Greg,
> 
> On Tue, Mar 10, 2015 at 04:28:16PM +1100, Stephen Rothwell wrote:
> > After merging the tty tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > drivers/tty/serial/imx.c: In function 'imx_set_termios':
> > drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid 
> > ambiguous 'else' [-Wparentheses]
> > if (port->rs485.flags & SER_RS485_ENABLED)
> >^
> > 
> > Introduced by commit 17b8f2a3fdca ("serial: imx: add support for half
> > duplex rs485").
> should I send a fixed commit or do you prefer an incremental change?

It's already in my tree, so I need an add-on patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the tty tree

[Uwe Kleine-König]

Hello Greg,

On Tue, Mar 10, 2015 at 04:28:16PM +1100, Stephen Rothwell wrote:
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/imx.c: In function 'imx_set_termios':
> drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid 
> ambiguous 'else' [-Wparentheses]
> if (port->rs485.flags & SER_RS485_ENABLED)
>^
> 
> Introduced by commit 17b8f2a3fdca ("serial: imx: add support for half
> duplex rs485").
should I send a fixed commit or do you prefer an incremental change?

Best regards
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the tty tree

[Uwe Kleine-König]

Hello Greg,

On Tue, Mar 10, 2015 at 04:28:16PM +1100, Stephen Rothwell wrote:
 After merging the tty tree, today's linux-next build (arm
 multi_v7_defconfig) produced this warning:
 
 drivers/tty/serial/imx.c: In function 'imx_set_termios':
 drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid 
 ambiguous 'else' [-Wparentheses]
 if (port-rs485.flags  SER_RS485_ENABLED)
^
 
 Introduced by commit 17b8f2a3fdca (serial: imx: add support for half
 duplex rs485).
should I send a fixed commit or do you prefer an incremental change?

Best regards
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Tue, Mar 10, 2015 at 09:23:18AM +0100, Uwe Kleine-König wrote:
 Hello Greg,
 
 On Tue, Mar 10, 2015 at 04:28:16PM +1100, Stephen Rothwell wrote:
  After merging the tty tree, today's linux-next build (arm
  multi_v7_defconfig) produced this warning:
  
  drivers/tty/serial/imx.c: In function 'imx_set_termios':
  drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid 
  ambiguous 'else' [-Wparentheses]
  if (port-rs485.flags  SER_RS485_ENABLED)
 ^
  
  Introduced by commit 17b8f2a3fdca (serial: imx: add support for half
  duplex rs485).
 should I send a fixed commit or do you prefer an incremental change?

It's already in my tree, so I need an add-on patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/tty/serial/imx.c: In function 'imx_set_termios':
drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid 
ambiguous 'else' [-Wparentheses]
if (port->rs485.flags & SER_RS485_ENABLED)
   ^

Introduced by commit 17b8f2a3fdca ("serial: imx: add support for half
duplex rs485").

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpCF4dRvYISK.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/tty/serial/imx.c: In function 'imx_set_termios':
drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid 
ambiguous 'else' [-Wparentheses]
if (port-rs485.flags  SER_RS485_ENABLED)
   ^

Introduced by commit 17b8f2a3fdca (serial: imx: add support for half
duplex rs485).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpCF4dRvYISK.pgp
Description: OpenPGP digital signature