linux-next: build warning after merge of the usb tree
Hi all,
After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:
include/linux/usb/ch9.h:1: warning: no structured comments found
Introduced by commit
855b35ea96c4 ("usb: common: move function's kerneldoc next to its definition")
--
Cheers,
Stephen Rothwell
pgppQRssdYv1C.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the usb tree
Hi all,
After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:
drivers/usb/dwc3/core.h:1273: warning: Function parameter or member 'usb_psy'
not described in 'dwc3'
Introduced by commit
59fa3def35de ("usb: dwc3: add a power supply for current control")
--
Cheers,
Stephen Rothwell
pgpVlpDEeQUHC.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the usb tree
Hi,
On Wed, Feb 03, 2021 at 04:13:00PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the usb tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/usb/typec/class.c: In function 'typec_partner_set_pd_revision':
> drivers/usb/typec/class.c:763:6: warning: unused variable 'ret'
> [-Wunused-variable]
> 763 | int ret;
> | ^~~
>
> Introduced by commit
>
> 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")
>
Will be fixed by
https://lore.kernel.org/r/20210202095512.761214-1-kyle...@google.com,
already in Greg's usb-testing.
Thanks Kyle for the quick fix yesterday.
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
linux-next: build warning after merge of the usb tree
Hi all,
After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/usb/typec/class.c: In function 'typec_partner_set_pd_revision':
drivers/usb/typec/class.c:763:6: warning: unused variable 'ret'
[-Wunused-variable]
763 | int ret;
| ^~~
Introduced by commit
29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")
--
Cheers,
Stephen Rothwell
pgpgxp5mbIgrN.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the usb tree
On Thu, Jan 14, 2021 at 09:48:56AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 6 Jan 2021 13:12:25 +1100 Stephen Rothwell
> wrote:
> >
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> >
> > drivers/usb/dwc3/core.h:1259: warning: Function parameter or member
> > 'gadget_max_speed' not described in 'dwc3'
> >
> > Introduced by commit
> >
> > 7c9a2598463a ("usb: dwc3: gadget: Preserve UDC max speed setting")
>
> I am still getting this warning.
Looks like Mauro just sent me a patch for this, will queue it up now,
thanks.
greg k-h
Re: linux-next: build warning after merge of the usb tree
Hi all,
On Wed, 6 Jan 2021 13:12:25 +1100 Stephen Rothwell
wrote:
>
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
>
> drivers/usb/dwc3/core.h:1259: warning: Function parameter or member
> 'gadget_max_speed' not described in 'dwc3'
>
> Introduced by commit
>
> 7c9a2598463a ("usb: dwc3: gadget: Preserve UDC max speed setting")
I am still getting this warning.
--
Cheers,
Stephen Rothwell
pgpvACACL_xYQ.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the usb tree
Hi all,
After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:
drivers/usb/dwc3/core.h:1259: warning: Function parameter or member
'gadget_max_speed' not described in 'dwc3'
Introduced by commit
7c9a2598463a ("usb: dwc3: gadget: Preserve UDC max speed setting")
--
Cheers,
Stephen Rothwell
pgpyRxFh6XXCO.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the usb tree
Hi Stephen,
On Fri, Nov 20, 2020 at 04:15:06PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
>
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter
> 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
>
> Introduced by commit
>
> a0ccdc4a77a1 ("usb: typec: Add number of altmodes partner attr")
Thank you for the email, and my apologies about the warning. I've sent a
patch the mailing lists which should hopefully fix this [1].
Please let me know if there is further action required from my side.
Best regards,
[1]:
https://lore.kernel.org/linux-usb/20201120063523.4159877-1-pmal...@chromium.org/
>
> --
> Cheers,
> Stephen Rothwell
linux-next: build warning after merge of the usb tree
Hi all,
After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter
'num_alt_modes' description in 'typec_partner_set_num_altmodes'
Introduced by commit
a0ccdc4a77a1 ("usb: typec: Add number of altmodes partner attr")
--
Cheers,
Stephen Rothwell
pgpLM6Q7r8OjE.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the usb tree
On Tue, Sep 11, 2018 at 12:47:43PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the usb tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb':
> drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags'
> [-Wunused-variable]
> unsigned long flags;
> ^
>
> Introduced by commit
>
> ed194d136769 ("usb: core: remove local_irq_save() around ->complete()
> handler")
Ugh, sorry I missed this :(
Re: linux-next: build warning after merge of the usb tree
On Tue, Sep 11, 2018 at 12:47:43PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the usb tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb':
> drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags'
> [-Wunused-variable]
> unsigned long flags;
> ^
>
> Introduced by commit
>
> ed194d136769 ("usb: core: remove local_irq_save() around ->complete()
> handler")
Ugh, sorry I missed this :(
linux-next: build warning after merge of the usb tree
Hi Greg,
After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb':
drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags'
[-Wunused-variable]
unsigned long flags;
^
Introduced by commit
ed194d136769 ("usb: core: remove local_irq_save() around ->complete()
handler")
--
Cheers,
Stephen Rothwell
pgpWOq5GNm2gm.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the usb tree
Hi Greg,
After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb':
drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags'
[-Wunused-variable]
unsigned long flags;
^
Introduced by commit
ed194d136769 ("usb: core: remove local_irq_save() around ->complete()
handler")
--
Cheers,
Stephen Rothwell
pgpWOq5GNm2gm.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the usb tree
Hi Greg, After merging the usb tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: arch/arm/boot/dts/stih410-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000 arch/arm/boot/dts/stih407-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000 arch/arm/boot/dts/stih410-b2260.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000 arch/arm/boot/dts/mt2701-evb.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b00 or bad phandle (referred from /ethernet@1b10:resets[0]) arch/arm/boot/dts/mt7623n-rfb-nand.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b00 or bad phandle (referred from /ethernet@1b10:resets[0]) arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b00 or bad phandle (referred from /ethernet@1b10:resets[0]) -- Cheers, Stephen Rothwell
linux-next: build warning after merge of the usb tree
Hi Greg, After merging the usb tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: arch/arm/boot/dts/stih410-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000 arch/arm/boot/dts/stih407-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000 arch/arm/boot/dts/stih410-b2260.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000 arch/arm/boot/dts/mt2701-evb.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b00 or bad phandle (referred from /ethernet@1b10:resets[0]) arch/arm/boot/dts/mt7623n-rfb-nand.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b00 or bad phandle (referred from /ethernet@1b10:resets[0]) arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b00 or bad phandle (referred from /ethernet@1b10:resets[0]) -- Cheers, Stephen Rothwell
linux-next: build warning after merge of the usb tree
Hi Greg,
After merging the usb tree, today's linux-next build (sparc64 defconfig)
produced this warning:
drivers/usb/storage/protocol.c: In function 'usb_stor_access_xfer_buf':
drivers/usb/storage/protocol.c:155:22: warning: comparison of distinct pointer
types lacks a cast [enabled by default]
Introduced by commit e5fc70d5ccc3 ("USB: storage: use sg_miter_* APIs to
access scsi buffer").
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpAyE02YKX5y.pgp
Description: PGP signature
linux-next: build warning after merge of the usb tree
Hi Greg, After merging the usb tree, today's linux-next build (sparc64 defconfig) produced this warning: drivers/usb/storage/protocol.c: In function 'usb_stor_access_xfer_buf': drivers/usb/storage/protocol.c:155:22: warning: comparison of distinct pointer types lacks a cast [enabled by default] Introduced by commit e5fc70d5ccc3 (USB: storage: use sg_miter_* APIs to access scsi buffer). -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpAyE02YKX5y.pgp Description: PGP signature
Re: linux-next: build warning after merge of the usb tree
On Fri, 2 Nov 2012, Felipe Balbi wrote:
> Hi,
>
> On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice.
> > Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous
> > export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous
> > export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous
> > export was in drivers/usb/chipidea/ci_hdrc.ko
> >
> > Introduced by commit 3e0232039967 ("USB: EHCI: prepare to make ehci-hcd a
> > library module").
>
> Alex, why on earth is chipidea exporting symbols it doesn't own ?
That's at least partly my fault. ehci-hcd.c now exports four symbols
that it didn't before. Since the ChipIdea driver does
#include "../host/ehci-hcd.c"
it now exports them too, unintentionally. A quick band-aid fix would
be to protect those functions with
#ifndef CHIPIDEA_EHCI
but the real fix is the patch I posted yesterday -- assuming it works
right. If we don't hear back from Alex soon, I will post the band-aid
fix as a temporary stop-gap.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the usb tree
Hi,
On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice.
> Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous
> export was in drivers/usb/chipidea/ci_hdrc.ko
> WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous
> export was in drivers/usb/chipidea/ci_hdrc.ko
> WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous
> export was in drivers/usb/chipidea/ci_hdrc.ko
>
> Introduced by commit 3e0232039967 ("USB: EHCI: prepare to make ehci-hcd a
> library module").
Alex, why on earth is chipidea exporting symbols it doesn't own ?
--
balbi
signature.asc
Description: Digital signature
Re: linux-next: build warning after merge of the usb tree
Hi, On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote: Hi Greg, After merging the usb tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko Introduced by commit 3e0232039967 (USB: EHCI: prepare to make ehci-hcd a library module). Alex, why on earth is chipidea exporting symbols it doesn't own ? -- balbi signature.asc Description: Digital signature
Re: linux-next: build warning after merge of the usb tree
On Fri, 2 Nov 2012, Felipe Balbi wrote: Hi, On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote: Hi Greg, After merging the usb tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko Introduced by commit 3e0232039967 (USB: EHCI: prepare to make ehci-hcd a library module). Alex, why on earth is chipidea exporting symbols it doesn't own ? That's at least partly my fault. ehci-hcd.c now exports four symbols that it didn't before. Since the ChipIdea driver does #include ../host/ehci-hcd.c it now exports them too, unintentionally. A quick band-aid fix would be to protect those functions with #ifndef CHIPIDEA_EHCI but the real fix is the patch I posted yesterday -- assuming it works right. If we don't hear back from Alex soon, I will post the band-aid fix as a temporary stop-gap. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build warning after merge of the usb tree
Hi Greg,
After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous
export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous
export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous
export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous
export was in drivers/usb/chipidea/ci_hdrc.ko
Introduced by commit 3e0232039967 ("USB: EHCI: prepare to make ehci-hcd a
library module").
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp9cuZdVOnbT.pgp
Description: PGP signature
linux-next: build warning after merge of the usb tree
Hi Greg, After merging the usb tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko Introduced by commit 3e0232039967 (USB: EHCI: prepare to make ehci-hcd a library module). -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp9cuZdVOnbT.pgp Description: PGP signature
