Re: linux-next: build warnings after merge of the devicetree tree
On Mon, 29 Mar 2021, Stephen Rothwell wrote:
> Hi all,
>
> After merging the devicetree tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> drivers/of/base.c:1781: warning: Excess function parameter 'prob' description
> in '__of_add_property'
> drivers/of/base.c:1804: warning: Excess function parameter 'prob' description
> in 'of_add_property'
> drivers/of/base.c:1855: warning: Function parameter or member 'prop' not
> described in 'of_remove_property'
> drivers/of/base.c:1855: warning: Excess function parameter 'prob' description
> in 'of_remove_property'
>
> Introduced by commit
>
> 3637d49e1121 ("of: base: Fix some formatting issues and provide missing
> descriptions")
Ah, I see. Will fix. Please bear with me.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
linux-next: build warnings after merge of the devicetree tree
Hi all,
After merging the devicetree tree, today's linux-next build (htmldocs)
produced these warnings:
drivers/of/base.c:1781: warning: Excess function parameter 'prob' description
in '__of_add_property'
drivers/of/base.c:1804: warning: Excess function parameter 'prob' description
in 'of_add_property'
drivers/of/base.c:1855: warning: Function parameter or member 'prop' not
described in 'of_remove_property'
drivers/of/base.c:1855: warning: Excess function parameter 'prob' description
in 'of_remove_property'
Introduced by commit
3637d49e1121 ("of: base: Fix some formatting issues and provide missing
descriptions")
--
Cheers,
Stephen Rothwell
pgpdF1x2NOhxz.pgp
Description: OpenPGP digital signature
Re: linux-next: build warnings after merge of the devicetree tree
On Wed, Sep 19, 2018 at 6:47 PM Stephen Rothwell wrote: > > Hi Rob, > > After merging the devicetree tree, today's linux-next build (arm > multi_v7_defconfig) produced these warnings: Yes, that's expected. I posted fixes for all of these last week. Some sub-arch maintainers haven't picked up the patches yet. Rob
linux-next: build warnings after merge of the devicetree tree
Hi Rob, After merging the devicetree tree, today's linux-next build (arm multi_v7_defconfig) produced these warnings: arch/arm/boot/dts/bcm53340-ubnt-unifi-switch8.dtb: Warning (spi_bus_bridge): /axi@1800/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm53340-ubnt-unifi-switch8.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/bcm958522er.dtb: Warning (spi_bus_bridge): /axi/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm958522er.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/bcm958525er.dtb: Warning (spi_bus_bridge): /axi/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm958525er.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/bcm958525xmc.dtb: Warning (spi_bus_bridge): /axi/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm958525xmc.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/bcm958622hr.dtb: Warning (spi_bus_bridge): /axi/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm958622hr.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/bcm958623hr.dtb: Warning (spi_bus_bridge): /axi/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm958623hr.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/bcm958625hr.dtb: Warning (spi_bus_bridge): /axi/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm958625hr.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/bcm988312hr.dtb: Warning (spi_bus_bridge): /axi/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm988312hr.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/bcm958625k.dtb: Warning (spi_bus_bridge): /axi/qspi@27200: node name for SPI buses should be 'spi' arch/arm/boot/dts/bcm958625k.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/keystone-k2g-evm.dtb: Warning (spi_bus_bridge): /soc@0/qspi@294: node name for SPI buses should be 'spi' arch/arm/boot/dts/keystone-k2g-evm.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/keystone-k2g-ice.dtb: Warning (spi_bus_bridge): /soc@0/qspi@294: node name for SPI buses should be 'spi' arch/arm/boot/dts/keystone-k2g-ice.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx50-evk.dtb: Warning (spi_bus_bridge): /soc/aips@6000/cspi@63fc: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx50-evk.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx51-babbage.dtb: Warning (spi_bus_bridge): /soc/aips@7000/spba@7000/ecspi@7001: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx51-babbage.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx51-digi-connectcore-jsk.dtb: Warning (spi_bus_bridge): /soc/aips@7000/spba@7000/ecspi@7001: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx51-digi-connectcore-jsk.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dtb: Warning (spi_bus_bridge): /soc/aips@7000/spba@7000/ecspi@7001: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx51-zii-rdu1.dtb: Warning (spi_bus_bridge): /soc/aips@7000/spba@7000/ecspi@7001: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx51-zii-rdu1.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx51-zii-scu2-mezz.dtb: Warning (spi_bus_bridge): /soc/aips@7000/spba@7000/ecspi@7001: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx51-zii-scu2-mezz.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx51-zii-scu3-esb.dtb: Warning (spi_bus_bridge): /soc/aips@7000/spba@7000/ecspi@7001: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx51-zii-scu3-esb.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx53-ppd.dtb: Warning (spi_bus_bridge): /soc/aips@5000/spba@5000/ecspi@5001: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx53-ppd.dtb: Warning (spi_bus_bridge): /soc/aips@6000/ecspi@63fac000: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx53-ppd.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/imx53-smd.dtb: Warning (spi_bus_bridge): /soc/aips@5000/spba@5000/ecspi@5001: node name for SPI buses should be 'spi' arch/arm/boot/dts/imx53-smd.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_br
Re: linux-next: build warnings after merge of the devicetree tree
On Tue, Sep 4, 2018 at 8:54 PM Stephen Rothwell wrote:
>
> Hi all,
>
> On Wed, 5 Sep 2018 10:39:06 +1000 Stephen Rothwell
> wrote:
> >
> > After merging the devicetree tree, today's linux-next build (x86_64
> > allmodconfig) produced these warnings:
> >
> > WARNING: vmlinux.o(.text+0xf40a16): Section mismatch in reference from the
> > function of_fdt_limit_memory() to the variable .init.data:dt_root_addr_cells
> > The function of_fdt_limit_memory() references
> > the variable __initdata dt_root_addr_cells.
> > This is often because of_fdt_limit_memory lacks a __initdata
> > annotation or the annotation of dt_root_addr_cells is wrong.
> >
> > WARNING: vmlinux.o(.text+0xf40a1d): Section mismatch in reference from the
> > function of_fdt_limit_memory() to the variable .init.data:dt_root_size_cells
> > The function of_fdt_limit_memory() references
> > the variable __initdata dt_root_size_cells.
> > This is often because of_fdt_limit_memory lacks a __initdata
> > annotation or the annotation of dt_root_size_cells is wrong.
> >
> > Introduced by commit
> >
> > bb35ea5c7c30 ("of/fdt: avoid re-parsing '#{address,size}-cells' in
> > of_fdt_limit_memory")
>
> It turns out that section mismatches are fatal errors in some configs (like
> powerpc allnoconfig), so I have added the following patch for today:
Sorry about that. I've fixed it now.
Rob
Re: linux-next: build warnings after merge of the devicetree tree
Hi all,
On Wed, 5 Sep 2018 10:39:06 +1000 Stephen Rothwell
wrote:
>
> After merging the devicetree tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> WARNING: vmlinux.o(.text+0xf40a16): Section mismatch in reference from the
> function of_fdt_limit_memory() to the variable .init.data:dt_root_addr_cells
> The function of_fdt_limit_memory() references
> the variable __initdata dt_root_addr_cells.
> This is often because of_fdt_limit_memory lacks a __initdata
> annotation or the annotation of dt_root_addr_cells is wrong.
>
> WARNING: vmlinux.o(.text+0xf40a1d): Section mismatch in reference from the
> function of_fdt_limit_memory() to the variable .init.data:dt_root_size_cells
> The function of_fdt_limit_memory() references
> the variable __initdata dt_root_size_cells.
> This is often because of_fdt_limit_memory lacks a __initdata
> annotation or the annotation of dt_root_size_cells is wrong.
>
> Introduced by commit
>
> bb35ea5c7c30 ("of/fdt: avoid re-parsing '#{address,size}-cells' in
> of_fdt_limit_memory")
It turns out that section mismatches are fatal errors in some configs (like
powerpc allnoconfig), so I have added the following patch for today:
From: Stephen Rothwell
Date: Wed, 5 Sep 2018 11:50:29 +1000
Subject: [PATCH] mark of_fdt_limit_memory() as __init
Signed-off-by: Stephen Rothwell
---
drivers/of/fdt.c | 2 +-
include/linux/of_fdt.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index fef4b2c8a171..fe78bed8925f 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -39,7 +39,7 @@
* memory entries in the /memory node. This function may be called
* any time after initial_boot_param is set.
*/
-void of_fdt_limit_memory(int limit)
+void __init of_fdt_limit_memory(int limit)
{
int memory;
int len;
diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
index b9cd9ebdf9b9..19ebf22a7862 100644
--- a/include/linux/of_fdt.h
+++ b/include/linux/of_fdt.h
@@ -46,7 +46,7 @@ extern char __dtb_end[];
/* Other Prototypes */
extern u64 of_flat_dt_translate_address(unsigned long node);
-extern void of_fdt_limit_memory(int limit);
+extern void __init of_fdt_limit_memory(int limit);
#endif /* CONFIG_OF_FLATTREE */
#ifdef CONFIG_OF_EARLY_FLATTREE
--
2.18.0
--
Cheers,
Stephen Rothwell
pgpNjpkMIxaNL.pgp
Description: OpenPGP digital signature
linux-next: build warnings after merge of the devicetree tree
Hi Rob,
After merging the devicetree tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
WARNING: vmlinux.o(.text+0xf40a16): Section mismatch in reference from the
function of_fdt_limit_memory() to the variable .init.data:dt_root_addr_cells
The function of_fdt_limit_memory() references
the variable __initdata dt_root_addr_cells.
This is often because of_fdt_limit_memory lacks a __initdata
annotation or the annotation of dt_root_addr_cells is wrong.
WARNING: vmlinux.o(.text+0xf40a1d): Section mismatch in reference from the
function of_fdt_limit_memory() to the variable .init.data:dt_root_size_cells
The function of_fdt_limit_memory() references
the variable __initdata dt_root_size_cells.
This is often because of_fdt_limit_memory lacks a __initdata
annotation or the annotation of dt_root_size_cells is wrong.
Introduced by commit
bb35ea5c7c30 ("of/fdt: avoid re-parsing '#{address,size}-cells' in
of_fdt_limit_memory")
--
Cheers,
Stephen Rothwell
pgphx2tNF83ur.pgp
Description: OpenPGP digital signature
