Re: linux-next: build warnings after merge of the tip tree

2020-11-30 Thread Borislav Petkov
On Mon, Nov 30, 2020 at 09:56:27PM +, Ernst, Justin wrote:
> After scratching my head for a while, I found that the issue was
> missing empty lines before three different code-block sections.

Oh great.

> The line number is definitely bogus, but I wasn't able to discover
> why.

Very helpful that tool. :-\

> You can find my patch at: https://lkml.org/lkml/2020/11/30/1196 The
> patch depends on the v2 patch set Mike Travis 
> submitted, which hasn't made it to tip yet.

Yeah, thanks for figuring this out.

I'll simply rebase your previous patch on the tip:x86/platform branch
since it is documentation stuff only and there's only one patch ontop
which updates MAINTAINERS but I don't think it'll be the end of the
world if those two got rebased.

Thx.

-- 
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG 
Nürnberg


RE: linux-next: build warnings after merge of the tip tree

2020-11-30 Thread Ernst, Justin
> On Mon, Nov 30, 2020 at 06:05:03PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the tip tree, today's linux-next build (htmldocs) produced
> > these warnings:
> >
> > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
> > indentation.
> > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
> > indentation.
> > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
> > indentation.
> >
> > Introduced by commit
> >
> >   7ac2f1017115 ("x86/platform/uv: Update ABI documentation of 
> > /sys/firmware/sgi_uv/")
> 
> Yah, I can reproduce but I have no clue what sphinx wants from me. Line
> 2 looks ok which could mean that the warning line it points to is bogus.
> 
> Justin, this is all yours. :)

After scratching my head for a while, I found that the issue was missing empty 
lines before three different code-block sections.
The line number is definitely bogus, but I wasn't able to discover why.

You can find my patch at: https://lkml.org/lkml/2020/11/30/1196
The patch depends on the v2 patch set Mike Travis  
submitted, which hasn't made it to tip yet.

Thanks,
-Justin

> 
> Thx.
> 
> --
> Regards/Gruss,
> Boris.
> 
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG 
> Nürnberg


Re: linux-next: build warnings after merge of the tip tree

2020-11-30 Thread Borislav Petkov
On Mon, Nov 30, 2020 at 06:05:03PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tip tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
> indentation.
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
> indentation.
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
> indentation.
> 
> Introduced by commit
> 
>   7ac2f1017115 ("x86/platform/uv: Update ABI documentation of 
> /sys/firmware/sgi_uv/")

Yah, I can reproduce but I have no clue what sphinx wants from me. Line
2 looks ok which could mean that the warning line it points to is bogus.

Justin, this is all yours. :)

Thx.

-- 
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG 
Nürnberg


linux-next: build warnings after merge of the tip tree

2020-11-29 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
indentation.
Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
indentation.
Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected 
indentation.

Introduced by commit

  7ac2f1017115 ("x86/platform/uv: Update ABI documentation of 
/sys/firmware/sgi_uv/")

-- 
Cheers,
Stephen Rothwell


pgpJtQmSDKAaD.pgp
Description: OpenPGP digital signature


Re: linux-next: build warnings after merge of the tip tree

2020-11-23 Thread Jarkko Sakkinen
On Mon, Nov 23, 2020 at 06:19:22PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tip tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Function parameter or member 
> 'encl' not described in 'sgx_ioc_enclave_provision'
> arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Excess function parameter 
> 'enclave' description in 'sgx_ioc_enclave_provision'
> 
> Introduced by commit
> 
>   c82c61865024 ("x86/sgx: Add SGX_IOC_ENCLAVE_PROVISION")
> 
> -- 
> Cheers,
> Stephen Rothwell

Thanks, was about sending a fix but saw that Boris put already one out,
when adding "Link: 
https://lore.kernel.org/linux-next/20201123101334.gc29...@zn.tnic/;

/Jarkko


linux-next: build warnings after merge of the tip tree

2020-11-22 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (htmldocs) produced
these warnings:

arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Function parameter or member 
'encl' not described in 'sgx_ioc_enclave_provision'
arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Excess function parameter 
'enclave' description in 'sgx_ioc_enclave_provision'

Introduced by commit

  c82c61865024 ("x86/sgx: Add SGX_IOC_ENCLAVE_PROVISION")

-- 
Cheers,
Stephen Rothwell


pgpbmtLeaIMFh.pgp
Description: OpenPGP digital signature


Re: linux-next: build warnings after merge of the tip tree

2017-11-13 Thread Stephen Rothwell
Hi all,

On Thu, 2 Nov 2017 13:53:51 +1100 Stephen Rothwell  
wrote:
>
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
> 
> net/dccp/probe.c: In function 'dccpprobe_init':
> net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   ret = register_jprobe(_send_probe);
>   ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
> ret = register_jprobe(_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c: In function 'dccpprobe_exit':
> net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_send_probe);
>   ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
> net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   ret = register_jprobe(_jprobe);
>   ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
> net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_jprobe);
>   ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> net/sctp/probe.c: In function 'sctp_setup_jprobe':
> net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   int ret = register_jprobe(_recv_probe);
>   ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>ret = register_jprobe(_recv_probe);
>^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctpprobe_exit':
> net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_recv_probe);
>   ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> 
> Introduced by commit
> 
>   590c84593045 ("kprobes: Disable the jprobes APIs")
> 
> These days we normally don't deprecate things, just remove them.  But we
> do that *after* fixing up all the usages in the tree, please.

Just a reminder that I am still getting these warnings.

-- 
Cheers,
Stephen Rothwell


Re: linux-next: build warnings after merge of the tip tree

2017-11-13 Thread Stephen Rothwell
Hi all,

On Thu, 2 Nov 2017 13:53:51 +1100 Stephen Rothwell  
wrote:
>
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
> 
> net/dccp/probe.c: In function 'dccpprobe_init':
> net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   ret = register_jprobe(_send_probe);
>   ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
> ret = register_jprobe(_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c: In function 'dccpprobe_exit':
> net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_send_probe);
>   ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
> net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   ret = register_jprobe(_jprobe);
>   ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
> net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_jprobe);
>   ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> net/sctp/probe.c: In function 'sctp_setup_jprobe':
> net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   int ret = register_jprobe(_recv_probe);
>   ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>ret = register_jprobe(_recv_probe);
>^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctpprobe_exit':
> net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_recv_probe);
>   ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> 
> Introduced by commit
> 
>   590c84593045 ("kprobes: Disable the jprobes APIs")
> 
> These days we normally don't deprecate things, just remove them.  But we
> do that *after* fixing up all the usages in the tree, please.

Just a reminder that I am still getting these warnings.

-- 
Cheers,
Stephen Rothwell


Re: linux-next: build warnings after merge of the tip tree

2017-11-04 Thread Masami Hiramatsu
On Sat, 4 Nov 2017 09:01:34 +0100
Ingo Molnar  wrote:

> 
> * Masami Hiramatsu  wrote:
> 
> > > net/sctp/probe.c: In function 'sctpprobe_exit':
> > > net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
> > > [-Wdeprecated-declarations]
> > >   unregister_jprobe(_recv_probe);
> > >   ^
> > > In file included from net/sctp/probe.c:28:0:
> > > include/linux/kprobes.h:479:33: note: declared here
> > >  static inline void __deprecated unregister_jprobe(struct jprobe *p)
> > >  ^
> > > 
> > > Introduced by commit
> > > 
> > >   590c84593045 ("kprobes: Disable the jprobes APIs")
> > > 
> > > These days we normally don't deprecate things, just remove them.  But we
> > > do that *after* fixing up all the usages in the tree, please.
> > 
> > OK, should I remove __deprecated or revert above patch?
> > I pinged such users but no response. I can just rewrite it but not sure 
> > they can reply.
> 
> Ideal would be to just fix all these places: convert code where the facility 
> appears to be actively used, remove code where it looks unused. If 
> maintainers 
> don't reply, I can apply them to a separate branch in -tip.

Thanks, that will help me.

> 
> For example I'm pretty sure we can just remove the jprobes usage in SCTP.

Actually TCP and DCCP jprobes usages are similar to that SCTP usage 
(maybe derived from TCP one). For those usages, we can not replace
it with kprobe/ftrace because it depends on the arguments of target funcs.
For such use-cases, we have 3 options;
 - Remove entirely feature if possible (like no more used).
 - Replace it with trace-events, and handle the event from kernel as sched 
tracer does.
 - Just introduce trace-events, remove usage, and trace it via ftrace or perf.

At a glance, all network probes are just used for printing out the event,
so we can just introduce trace-events and remove usage. I will try it.

Thank you,

-- 
Masami Hiramatsu 


Re: linux-next: build warnings after merge of the tip tree

2017-11-04 Thread Masami Hiramatsu
On Sat, 4 Nov 2017 09:01:34 +0100
Ingo Molnar  wrote:

> 
> * Masami Hiramatsu  wrote:
> 
> > > net/sctp/probe.c: In function 'sctpprobe_exit':
> > > net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
> > > [-Wdeprecated-declarations]
> > >   unregister_jprobe(_recv_probe);
> > >   ^
> > > In file included from net/sctp/probe.c:28:0:
> > > include/linux/kprobes.h:479:33: note: declared here
> > >  static inline void __deprecated unregister_jprobe(struct jprobe *p)
> > >  ^
> > > 
> > > Introduced by commit
> > > 
> > >   590c84593045 ("kprobes: Disable the jprobes APIs")
> > > 
> > > These days we normally don't deprecate things, just remove them.  But we
> > > do that *after* fixing up all the usages in the tree, please.
> > 
> > OK, should I remove __deprecated or revert above patch?
> > I pinged such users but no response. I can just rewrite it but not sure 
> > they can reply.
> 
> Ideal would be to just fix all these places: convert code where the facility 
> appears to be actively used, remove code where it looks unused. If 
> maintainers 
> don't reply, I can apply them to a separate branch in -tip.

Thanks, that will help me.

> 
> For example I'm pretty sure we can just remove the jprobes usage in SCTP.

Actually TCP and DCCP jprobes usages are similar to that SCTP usage 
(maybe derived from TCP one). For those usages, we can not replace
it with kprobe/ftrace because it depends on the arguments of target funcs.
For such use-cases, we have 3 options;
 - Remove entirely feature if possible (like no more used).
 - Replace it with trace-events, and handle the event from kernel as sched 
tracer does.
 - Just introduce trace-events, remove usage, and trace it via ftrace or perf.

At a glance, all network probes are just used for printing out the event,
so we can just introduce trace-events and remove usage. I will try it.

Thank you,

-- 
Masami Hiramatsu 


Re: linux-next: build warnings after merge of the tip tree

2017-11-04 Thread Ingo Molnar

* Masami Hiramatsu  wrote:

> > net/sctp/probe.c: In function 'sctpprobe_exit':
> > net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
> > [-Wdeprecated-declarations]
> >   unregister_jprobe(_recv_probe);
> >   ^
> > In file included from net/sctp/probe.c:28:0:
> > include/linux/kprobes.h:479:33: note: declared here
> >  static inline void __deprecated unregister_jprobe(struct jprobe *p)
> >  ^
> > 
> > Introduced by commit
> > 
> >   590c84593045 ("kprobes: Disable the jprobes APIs")
> > 
> > These days we normally don't deprecate things, just remove them.  But we
> > do that *after* fixing up all the usages in the tree, please.
> 
> OK, should I remove __deprecated or revert above patch?
> I pinged such users but no response. I can just rewrite it but not sure they 
> can reply.

Ideal would be to just fix all these places: convert code where the facility 
appears to be actively used, remove code where it looks unused. If maintainers 
don't reply, I can apply them to a separate branch in -tip.

For example I'm pretty sure we can just remove the jprobes usage in SCTP.

Thanks,

Ingo


Re: linux-next: build warnings after merge of the tip tree

2017-11-04 Thread Ingo Molnar

* Masami Hiramatsu  wrote:

> > net/sctp/probe.c: In function 'sctpprobe_exit':
> > net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
> > [-Wdeprecated-declarations]
> >   unregister_jprobe(_recv_probe);
> >   ^
> > In file included from net/sctp/probe.c:28:0:
> > include/linux/kprobes.h:479:33: note: declared here
> >  static inline void __deprecated unregister_jprobe(struct jprobe *p)
> >  ^
> > 
> > Introduced by commit
> > 
> >   590c84593045 ("kprobes: Disable the jprobes APIs")
> > 
> > These days we normally don't deprecate things, just remove them.  But we
> > do that *after* fixing up all the usages in the tree, please.
> 
> OK, should I remove __deprecated or revert above patch?
> I pinged such users but no response. I can just rewrite it but not sure they 
> can reply.

Ideal would be to just fix all these places: convert code where the facility 
appears to be actively used, remove code where it looks unused. If maintainers 
don't reply, I can apply them to a separate branch in -tip.

For example I'm pretty sure we can just remove the jprobes usage in SCTP.

Thanks,

Ingo


Re: linux-next: build warnings after merge of the tip tree

2017-11-03 Thread Masami Hiramatsu
On Thu, 2 Nov 2017 13:53:51 +1100
Stephen Rothwell  wrote:

> Hi all,
> 
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
> 
> net/dccp/probe.c: In function 'dccpprobe_init':
> net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   ret = register_jprobe(_send_probe);
>   ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
> ret = register_jprobe(_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c: In function 'dccpprobe_exit':
> net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_send_probe);
>   ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
> net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   ret = register_jprobe(_jprobe);
>   ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
> net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_jprobe);
>   ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> net/sctp/probe.c: In function 'sctp_setup_jprobe':
> net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   int ret = register_jprobe(_recv_probe);
>   ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>ret = register_jprobe(_recv_probe);
>^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctpprobe_exit':
> net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_recv_probe);
>   ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> 
> Introduced by commit
> 
>   590c84593045 ("kprobes: Disable the jprobes APIs")
> 
> These days we normally don't deprecate things, just remove them.  But we
> do that *after* fixing up all the usages in the tree, please.

OK, should I remove __deprecated or revert above patch?
I pinged such users but no response. I can just rewrite it but not sure they 
can reply.

Thank you,

> 
> -- 
> Cheers,
> Stephen Rothwell


-- 
Masami Hiramatsu 


Re: linux-next: build warnings after merge of the tip tree

2017-11-03 Thread Masami Hiramatsu
On Thu, 2 Nov 2017 13:53:51 +1100
Stephen Rothwell  wrote:

> Hi all,
> 
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
> 
> net/dccp/probe.c: In function 'dccpprobe_init':
> net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   ret = register_jprobe(_send_probe);
>   ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
> ret = register_jprobe(_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c: In function 'dccpprobe_exit':
> net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_send_probe);
>   ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
> net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   ret = register_jprobe(_jprobe);
>   ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
> net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_jprobe);
>   ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> net/sctp/probe.c: In function 'sctp_setup_jprobe':
> net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   int ret = register_jprobe(_recv_probe);
>   ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>ret = register_jprobe(_recv_probe);
>^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
>  static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctpprobe_exit':
> net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
> [-Wdeprecated-declarations]
>   unregister_jprobe(_recv_probe);
>   ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:479:33: note: declared here
>  static inline void __deprecated unregister_jprobe(struct jprobe *p)
>  ^
> 
> Introduced by commit
> 
>   590c84593045 ("kprobes: Disable the jprobes APIs")
> 
> These days we normally don't deprecate things, just remove them.  But we
> do that *after* fixing up all the usages in the tree, please.

OK, should I remove __deprecated or revert above patch?
I pinged such users but no response. I can just rewrite it but not sure they 
can reply.

Thank you,

> 
> -- 
> Cheers,
> Stephen Rothwell


-- 
Masami Hiramatsu 


linux-next: build warnings after merge of the tip tree

2017-11-01 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

net/dccp/probe.c: In function 'dccpprobe_init':
net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
  ret = register_jprobe(_send_probe);
  ^
In file included from net/dccp/probe.c:26:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
ret = register_jprobe(_send_probe);
^
In file included from net/dccp/probe.c:26:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/dccp/probe.c: In function 'dccpprobe_exit':
net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated 
[-Wdeprecated-declarations]
  unregister_jprobe(_send_probe);
  ^
In file included from net/dccp/probe.c:26:0:
include/linux/kprobes.h:479:33: note: declared here
 static inline void __deprecated unregister_jprobe(struct jprobe *p)
 ^
net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
  ret = register_jprobe(_jprobe);
  ^
In file included from net/ipv4/tcp_probe.c:24:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated 
[-Wdeprecated-declarations]
  unregister_jprobe(_jprobe);
  ^
In file included from net/ipv4/tcp_probe.c:24:0:
include/linux/kprobes.h:479:33: note: declared here
 static inline void __deprecated unregister_jprobe(struct jprobe *p)
 ^
net/sctp/probe.c: In function 'sctp_setup_jprobe':
net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
  int ret = register_jprobe(_recv_probe);
  ^
In file included from net/sctp/probe.c:28:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
   ret = register_jprobe(_recv_probe);
   ^
In file included from net/sctp/probe.c:28:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/sctp/probe.c: In function 'sctpprobe_exit':
net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
[-Wdeprecated-declarations]
  unregister_jprobe(_recv_probe);
  ^
In file included from net/sctp/probe.c:28:0:
include/linux/kprobes.h:479:33: note: declared here
 static inline void __deprecated unregister_jprobe(struct jprobe *p)
 ^

Introduced by commit

  590c84593045 ("kprobes: Disable the jprobes APIs")

These days we normally don't deprecate things, just remove them.  But we
do that *after* fixing up all the usages in the tree, please.

-- 
Cheers,
Stephen Rothwell


linux-next: build warnings after merge of the tip tree

2017-11-01 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

net/dccp/probe.c: In function 'dccpprobe_init':
net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
  ret = register_jprobe(_send_probe);
  ^
In file included from net/dccp/probe.c:26:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
ret = register_jprobe(_send_probe);
^
In file included from net/dccp/probe.c:26:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/dccp/probe.c: In function 'dccpprobe_exit':
net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated 
[-Wdeprecated-declarations]
  unregister_jprobe(_send_probe);
  ^
In file included from net/dccp/probe.c:26:0:
include/linux/kprobes.h:479:33: note: declared here
 static inline void __deprecated unregister_jprobe(struct jprobe *p)
 ^
net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
  ret = register_jprobe(_jprobe);
  ^
In file included from net/ipv4/tcp_probe.c:24:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated 
[-Wdeprecated-declarations]
  unregister_jprobe(_jprobe);
  ^
In file included from net/ipv4/tcp_probe.c:24:0:
include/linux/kprobes.h:479:33: note: declared here
 static inline void __deprecated unregister_jprobe(struct jprobe *p)
 ^
net/sctp/probe.c: In function 'sctp_setup_jprobe':
net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
  int ret = register_jprobe(_recv_probe);
  ^
In file included from net/sctp/probe.c:28:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated 
[-Wdeprecated-declarations]
   ret = register_jprobe(_recv_probe);
   ^
In file included from net/sctp/probe.c:28:0:
include/linux/kprobes.h:471:32: note: declared here
 static inline int __deprecated register_jprobe(struct jprobe *p)
^
net/sctp/probe.c: In function 'sctpprobe_exit':
net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated 
[-Wdeprecated-declarations]
  unregister_jprobe(_recv_probe);
  ^
In file included from net/sctp/probe.c:28:0:
include/linux/kprobes.h:479:33: note: declared here
 static inline void __deprecated unregister_jprobe(struct jprobe *p)
 ^

Introduced by commit

  590c84593045 ("kprobes: Disable the jprobes APIs")

These days we normally don't deprecate things, just remove them.  But we
do that *after* fixing up all the usages in the tree, please.

-- 
Cheers,
Stephen Rothwell


linux-next: build warnings after merge of the tip tree

2017-06-22 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

In file included from arch/x86/include/asm/paravirt_types.h:44:0,
 from arch/x86/include/asm/ptrace.h:71,
 from arch/x86/include/asm/math_emu.h:4,
 from arch/x86/include/asm/processor.h:11,
 from arch/x86/include/asm/cpufeature.h:4,
 from arch/x86/include/asm/thread_info.h:52,
 from include/linux/thread_info.h:37,
 from arch/x86/include/asm/preempt.h:6,
 from include/linux/preempt.h:80,
 from include/linux/spinlock.h:50,
 from include/linux/seqlock.h:35,
 from include/linux/time.h:5,
 from include/uapi/linux/timex.h:56,
 from include/linux/timex.h:56,
 from include/linux/clocksource.h:12,
 from arch/x86/include/asm/vgtod.h:5,
 from arch/x86/entry/vdso/vdso32/../vclock_gettime.c:15,
 from arch/x86/entry/vdso/vdso32/vclock_gettime.c:32:
arch/x86/include/asm/pgtable.h: In function 'pte_flags_pkey':
arch/x86/include/asm/pgtable_types.h:56:43: warning: left shift count >= width 
of type [-Wshift-count-overflow]
 #define _PAGE_PKEY_BIT0 (_AT(pteval_t, 1) << _PAGE_BIT_PKEY_BIT0)
   ^
arch/x86/include/asm/pgtable_types.h:68:26: note: in expansion of macro 
'_PAGE_PKEY_BIT0'
 #define _PAGE_PKEY_MASK (_PAGE_PKEY_BIT0 | \
  ^
arch/x86/include/asm/pgtable.h:1187:22: note: in expansion of macro 
'_PAGE_PKEY_MASK'
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
  ^
arch/x86/include/asm/pgtable_types.h:57:43: warning: left shift count >= width 
of type [-Wshift-count-overflow]
 #define _PAGE_PKEY_BIT1 (_AT(pteval_t, 1) << _PAGE_BIT_PKEY_BIT1)
   ^
arch/x86/include/asm/pgtable_types.h:69:5: note: in expansion of macro 
'_PAGE_PKEY_BIT1'
 _PAGE_PKEY_BIT1 | \
 ^
arch/x86/include/asm/pgtable.h:1187:22: note: in expansion of macro 
'_PAGE_PKEY_MASK'
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
  ^
arch/x86/include/asm/pgtable_types.h:58:43: warning: left shift count >= width 
of type [-Wshift-count-overflow]
 #define _PAGE_PKEY_BIT2 (_AT(pteval_t, 1) << _PAGE_BIT_PKEY_BIT2)
   ^
arch/x86/include/asm/pgtable_types.h:70:5: note: in expansion of macro 
'_PAGE_PKEY_BIT2'
 _PAGE_PKEY_BIT2 | \
 ^
arch/x86/include/asm/pgtable.h:1187:22: note: in expansion of macro 
'_PAGE_PKEY_MASK'
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
  ^
arch/x86/include/asm/pgtable_types.h:59:43: warning: left shift count >= width 
of type [-Wshift-count-overflow]
 #define _PAGE_PKEY_BIT3 (_AT(pteval_t, 1) << _PAGE_BIT_PKEY_BIT3)
   ^
arch/x86/include/asm/pgtable_types.h:71:5: note: in expansion of macro 
'_PAGE_PKEY_BIT3'
 _PAGE_PKEY_BIT3)
 ^
arch/x86/include/asm/pgtable.h:1187:22: note: in expansion of macro 
'_PAGE_PKEY_MASK'
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
  ^
In file included from include/linux/kasan.h:16:0,
 from include/linux/slab.h:120,
 from include/linux/irq.h:25,
 from arch/x86/include/asm/hardirq.h:5,
 from include/linux/hardirq.h:8,
 from include/linux/interrupt.h:12,
 from arch/x86/include/asm/mshyperv.h:5,
 from arch/x86/entry/vdso/vdso32/../vclock_gettime.c:20,
 from arch/x86/entry/vdso/vdso32/vclock_gettime.c:32:
arch/x86/include/asm/pgtable.h:1187:39: warning: right shift count >= width of 
type [-Wshift-count-overflow]
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
   ^

I have no idea what caused this.

-- 
Cheers,
Stephen Rothwell


linux-next: build warnings after merge of the tip tree

2017-06-22 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

In file included from arch/x86/include/asm/paravirt_types.h:44:0,
 from arch/x86/include/asm/ptrace.h:71,
 from arch/x86/include/asm/math_emu.h:4,
 from arch/x86/include/asm/processor.h:11,
 from arch/x86/include/asm/cpufeature.h:4,
 from arch/x86/include/asm/thread_info.h:52,
 from include/linux/thread_info.h:37,
 from arch/x86/include/asm/preempt.h:6,
 from include/linux/preempt.h:80,
 from include/linux/spinlock.h:50,
 from include/linux/seqlock.h:35,
 from include/linux/time.h:5,
 from include/uapi/linux/timex.h:56,
 from include/linux/timex.h:56,
 from include/linux/clocksource.h:12,
 from arch/x86/include/asm/vgtod.h:5,
 from arch/x86/entry/vdso/vdso32/../vclock_gettime.c:15,
 from arch/x86/entry/vdso/vdso32/vclock_gettime.c:32:
arch/x86/include/asm/pgtable.h: In function 'pte_flags_pkey':
arch/x86/include/asm/pgtable_types.h:56:43: warning: left shift count >= width 
of type [-Wshift-count-overflow]
 #define _PAGE_PKEY_BIT0 (_AT(pteval_t, 1) << _PAGE_BIT_PKEY_BIT0)
   ^
arch/x86/include/asm/pgtable_types.h:68:26: note: in expansion of macro 
'_PAGE_PKEY_BIT0'
 #define _PAGE_PKEY_MASK (_PAGE_PKEY_BIT0 | \
  ^
arch/x86/include/asm/pgtable.h:1187:22: note: in expansion of macro 
'_PAGE_PKEY_MASK'
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
  ^
arch/x86/include/asm/pgtable_types.h:57:43: warning: left shift count >= width 
of type [-Wshift-count-overflow]
 #define _PAGE_PKEY_BIT1 (_AT(pteval_t, 1) << _PAGE_BIT_PKEY_BIT1)
   ^
arch/x86/include/asm/pgtable_types.h:69:5: note: in expansion of macro 
'_PAGE_PKEY_BIT1'
 _PAGE_PKEY_BIT1 | \
 ^
arch/x86/include/asm/pgtable.h:1187:22: note: in expansion of macro 
'_PAGE_PKEY_MASK'
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
  ^
arch/x86/include/asm/pgtable_types.h:58:43: warning: left shift count >= width 
of type [-Wshift-count-overflow]
 #define _PAGE_PKEY_BIT2 (_AT(pteval_t, 1) << _PAGE_BIT_PKEY_BIT2)
   ^
arch/x86/include/asm/pgtable_types.h:70:5: note: in expansion of macro 
'_PAGE_PKEY_BIT2'
 _PAGE_PKEY_BIT2 | \
 ^
arch/x86/include/asm/pgtable.h:1187:22: note: in expansion of macro 
'_PAGE_PKEY_MASK'
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
  ^
arch/x86/include/asm/pgtable_types.h:59:43: warning: left shift count >= width 
of type [-Wshift-count-overflow]
 #define _PAGE_PKEY_BIT3 (_AT(pteval_t, 1) << _PAGE_BIT_PKEY_BIT3)
   ^
arch/x86/include/asm/pgtable_types.h:71:5: note: in expansion of macro 
'_PAGE_PKEY_BIT3'
 _PAGE_PKEY_BIT3)
 ^
arch/x86/include/asm/pgtable.h:1187:22: note: in expansion of macro 
'_PAGE_PKEY_MASK'
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
  ^
In file included from include/linux/kasan.h:16:0,
 from include/linux/slab.h:120,
 from include/linux/irq.h:25,
 from arch/x86/include/asm/hardirq.h:5,
 from include/linux/hardirq.h:8,
 from include/linux/interrupt.h:12,
 from arch/x86/include/asm/mshyperv.h:5,
 from arch/x86/entry/vdso/vdso32/../vclock_gettime.c:20,
 from arch/x86/entry/vdso/vdso32/vclock_gettime.c:32:
arch/x86/include/asm/pgtable.h:1187:39: warning: right shift count >= width of 
type [-Wshift-count-overflow]
  return (pte_flags & _PAGE_PKEY_MASK) >> _PAGE_BIT_PKEY_BIT0;
   ^

I have no idea what caused this.

-- 
Cheers,
Stephen Rothwell


Re: linux-next: build warnings after merge of the tip tree

2016-07-13 Thread Stephen Rothwell
Hi all,

On Thu, 14 Jul 2016 13:37:29 +1000 Stephen Rothwell  
wrote:
>
> After merging the tip tree, today's linux-next build (powerpc64le perf)
> produced these warnings:
> 
> Warning: tools/include/uapi/linux/bpf.h differs from kernel
> Warning: tools/arch/x86/include/asm/disabled-features.h differs from kernel
> Warning: tools/arch/x86/include/asm/required-features.h differs from kernel
> Warning: tools/arch/x86/include/asm/cpufeatures.h differs from kernel
> 
> Introduced by commits
> 
>   7d7d1bf1d1da ("perf bench: Copy kernel files needed to build mem{cpy,set} 
> x86_64 benchmarks")
>   971e827bffef ("tools lib bpf: Copy bpf.h and bpf_common.h from the kernel")

The kvm tree has introduced a few more:

Warning: tools/arch/s390/include/uapi/asm/kvm.h
Warning: tools/arch/s390/include/uapi/asm/sie.h

-- 
Cheers,
Stephen Rothwell


Re: linux-next: build warnings after merge of the tip tree

2016-07-13 Thread Stephen Rothwell
Hi all,

On Thu, 14 Jul 2016 13:37:29 +1000 Stephen Rothwell  
wrote:
>
> After merging the tip tree, today's linux-next build (powerpc64le perf)
> produced these warnings:
> 
> Warning: tools/include/uapi/linux/bpf.h differs from kernel
> Warning: tools/arch/x86/include/asm/disabled-features.h differs from kernel
> Warning: tools/arch/x86/include/asm/required-features.h differs from kernel
> Warning: tools/arch/x86/include/asm/cpufeatures.h differs from kernel
> 
> Introduced by commits
> 
>   7d7d1bf1d1da ("perf bench: Copy kernel files needed to build mem{cpy,set} 
> x86_64 benchmarks")
>   971e827bffef ("tools lib bpf: Copy bpf.h and bpf_common.h from the kernel")

The kvm tree has introduced a few more:

Warning: tools/arch/s390/include/uapi/asm/kvm.h
Warning: tools/arch/s390/include/uapi/asm/sie.h

-- 
Cheers,
Stephen Rothwell


linux-next: build warnings after merge of the tip tree

2016-07-13 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

In file included from tools/include/linux/hashtable.h:12:0,
 from elf.h:24,
 from builtin-check.c:33:
tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" redefined [-Werror]
 #define BITS_PER_LONG __WORDSIZE
 ^
In file included from /usr/include/powerpc64le-linux-gnu/asm/bitsperlong.h:10:0,
 from /usr/include/asm-generic/int-ll64.h:11,
 from /usr/include/powerpc64le-linux-gnu/asm/types.h:27,
 from tools/include/linux/types.h:9,
 from tools/include/linux/list.h:4,
 from elf.h:23,
 from builtin-check.c:33:
tools/include/asm-generic/bitsperlong.h:10:0: note: this is the location of the 
previous definition
 #define BITS_PER_LONG 32
 ^
In file included from tools/include/linux/hashtable.h:12:0,
 from elf.h:24,
 from special.h:22,
 from special.c:26:
tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" redefined [-Werror]
 #define BITS_PER_LONG __WORDSIZE
 ^
In file included from /usr/include/powerpc64le-linux-gnu/asm/bitsperlong.h:10:0,
 from /usr/include/asm-generic/int-ll64.h:11,
 from /usr/include/powerpc64le-linux-gnu/asm/types.h:27,
 from tools/include/linux/types.h:9,
 from tools/include/linux/list.h:4,
 from elf.h:23,
 from special.h:22,
 from special.c:26:
tools/include/asm-generic/bitsperlong.h:10:0: note: this is the location of the 
previous definition
 #define BITS_PER_LONG 32
 ^
In file included from tools/include/linux/hashtable.h:12:0,
 from elf.h:24,
 from elf.c:30:
tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" redefined [-Werror]
 #define BITS_PER_LONG __WORDSIZE
 ^
In file included from /usr/include/powerpc64le-linux-gnu/asm/bitsperlong.h:10:0,
 from /usr/include/asm-generic/int-ll64.h:11,
 from /usr/include/powerpc64le-linux-gnu/asm/types.h:27,
 from tools/include/linux/types.h:9,
 from tools/include/linux/list.h:4,
 from elf.h:23,
 from elf.c:30:
tools/include/asm-generic/bitsperlong.h:10:0: note: this is the location of the 
previous definition
 #define BITS_PER_LONG 32
 ^
cc1: all warnings being treated as errors
In file included from tools/include/linux/hashtable.h:12:0,
 from arch/x86/../../elf.h:24,
 from arch/x86/decode.c:26:
tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" redefined [-Werror]
 #define BITS_PER_LONG __WORDSIZE
 ^
In file included from /usr/include/powerpc64le-linux-gnu/asm/bitsperlong.h:10:0,
 from /usr/include/asm-generic/int-ll64.h:11,
 from /usr/include/powerpc64le-linux-gnu/asm/types.h:27,
 from tools/include/linux/types.h:9,
 from tools/include/linux/list.h:4,
 from arch/x86/../../elf.h:23,
 from arch/x86/decode.c:26:
tools/include/asm-generic/bitsperlong.h:10:0: note: this is the location of the 
previous definition
 #define BITS_PER_LONG 32
 ^

Introduced (I think) by commit

  bb9707077b4e ("tools: Copy the bitsperlong.h files from the kernel")

I saw some discussion of this, so I assume ti will be fixed soon.

-- 
Cheers,
Stephen Rothwell


linux-next: build warnings after merge of the tip tree

2016-07-13 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

In file included from tools/include/linux/hashtable.h:12:0,
 from elf.h:24,
 from builtin-check.c:33:
tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" redefined [-Werror]
 #define BITS_PER_LONG __WORDSIZE
 ^
In file included from /usr/include/powerpc64le-linux-gnu/asm/bitsperlong.h:10:0,
 from /usr/include/asm-generic/int-ll64.h:11,
 from /usr/include/powerpc64le-linux-gnu/asm/types.h:27,
 from tools/include/linux/types.h:9,
 from tools/include/linux/list.h:4,
 from elf.h:23,
 from builtin-check.c:33:
tools/include/asm-generic/bitsperlong.h:10:0: note: this is the location of the 
previous definition
 #define BITS_PER_LONG 32
 ^
In file included from tools/include/linux/hashtable.h:12:0,
 from elf.h:24,
 from special.h:22,
 from special.c:26:
tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" redefined [-Werror]
 #define BITS_PER_LONG __WORDSIZE
 ^
In file included from /usr/include/powerpc64le-linux-gnu/asm/bitsperlong.h:10:0,
 from /usr/include/asm-generic/int-ll64.h:11,
 from /usr/include/powerpc64le-linux-gnu/asm/types.h:27,
 from tools/include/linux/types.h:9,
 from tools/include/linux/list.h:4,
 from elf.h:23,
 from special.h:22,
 from special.c:26:
tools/include/asm-generic/bitsperlong.h:10:0: note: this is the location of the 
previous definition
 #define BITS_PER_LONG 32
 ^
In file included from tools/include/linux/hashtable.h:12:0,
 from elf.h:24,
 from elf.c:30:
tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" redefined [-Werror]
 #define BITS_PER_LONG __WORDSIZE
 ^
In file included from /usr/include/powerpc64le-linux-gnu/asm/bitsperlong.h:10:0,
 from /usr/include/asm-generic/int-ll64.h:11,
 from /usr/include/powerpc64le-linux-gnu/asm/types.h:27,
 from tools/include/linux/types.h:9,
 from tools/include/linux/list.h:4,
 from elf.h:23,
 from elf.c:30:
tools/include/asm-generic/bitsperlong.h:10:0: note: this is the location of the 
previous definition
 #define BITS_PER_LONG 32
 ^
cc1: all warnings being treated as errors
In file included from tools/include/linux/hashtable.h:12:0,
 from arch/x86/../../elf.h:24,
 from arch/x86/decode.c:26:
tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" redefined [-Werror]
 #define BITS_PER_LONG __WORDSIZE
 ^
In file included from /usr/include/powerpc64le-linux-gnu/asm/bitsperlong.h:10:0,
 from /usr/include/asm-generic/int-ll64.h:11,
 from /usr/include/powerpc64le-linux-gnu/asm/types.h:27,
 from tools/include/linux/types.h:9,
 from tools/include/linux/list.h:4,
 from arch/x86/../../elf.h:23,
 from arch/x86/decode.c:26:
tools/include/asm-generic/bitsperlong.h:10:0: note: this is the location of the 
previous definition
 #define BITS_PER_LONG 32
 ^

Introduced (I think) by commit

  bb9707077b4e ("tools: Copy the bitsperlong.h files from the kernel")

I saw some discussion of this, so I assume ti will be fixed soon.

-- 
Cheers,
Stephen Rothwell


linux-next: build warnings after merge of the tip tree

2016-07-13 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (powerpc64le perf)
produced these warnings:

Warning: tools/include/uapi/linux/bpf.h differs from kernel
Warning: tools/arch/x86/include/asm/disabled-features.h differs from kernel
Warning: tools/arch/x86/include/asm/required-features.h differs from kernel
Warning: tools/arch/x86/include/asm/cpufeatures.h differs from kernel

Introduced by commits

  7d7d1bf1d1da ("perf bench: Copy kernel files needed to build mem{cpy,set} 
x86_64 benchmarks")
  971e827bffef ("tools lib bpf: Copy bpf.h and bpf_common.h from the kernel")

-- 
Cheers,
Stephen Rothwell


linux-next: build warnings after merge of the tip tree

2016-07-13 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (powerpc64le perf)
produced these warnings:

Warning: tools/include/uapi/linux/bpf.h differs from kernel
Warning: tools/arch/x86/include/asm/disabled-features.h differs from kernel
Warning: tools/arch/x86/include/asm/required-features.h differs from kernel
Warning: tools/arch/x86/include/asm/cpufeatures.h differs from kernel

Introduced by commits

  7d7d1bf1d1da ("perf bench: Copy kernel files needed to build mem{cpy,set} 
x86_64 benchmarks")
  971e827bffef ("tools lib bpf: Copy bpf.h and bpf_common.h from the kernel")

-- 
Cheers,
Stephen Rothwell


linux-next: build warnings after merge of the tip tree

2012-10-11 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (powerpc allnoconfig)
produced these warnings:

kernel/sched/fair.c:801:22: warning: 'task_h_load' declared 'static' but never 
defined [-Wunused-function]
kernel/sched/fair.c:1013:13: warning: 'account_offnode_enqueue' defined but not 
used [-Wunused-function]

Introduced by commit 4ae834f767c5 ("sched/numa: Implement NUMA home-node
selection code").

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdSL7ckyJCR.pgp
Description: PGP signature


linux-next: build warnings after merge of the tip tree

2012-10-11 Thread Stephen Rothwell
Hi all,

After merging the tip tree, today's linux-next build (powerpc allnoconfig)
produced these warnings:

kernel/sched/fair.c:801:22: warning: 'task_h_load' declared 'static' but never 
defined [-Wunused-function]
kernel/sched/fair.c:1013:13: warning: 'account_offnode_enqueue' defined but not 
used [-Wunused-function]

Introduced by commit 4ae834f767c5 (sched/numa: Implement NUMA home-node
selection code).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdSL7ckyJCR.pgp
Description: PGP signature