Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
On Wed, 20 Jun 2007 21:14:22 -0400 "Bob Picco" <[EMAIL PROTECTED]> wrote: > Randy Dunlap wrote: [Wed Jun 20 2007, 09:07:11PM EDT] > > On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote: > > > > > [EMAIL PROTECTED] wrote: [Wed Jun 20 2007, 01:14:34PM EDT] > > > [snip] > > > > > > Build breakage. pci_mmcfg_late_init is for i386. > > > > then you want CONFIG_X86_32 instead of CONFIG_X86. > > CONFIG_X86 is set/true for both X86_32 and X86_64. > Then what I stated within the patch description is incorrect. pci.h which is > the > required include for the declaration is conditionally for CONFIG_X86. So it is > both I guess? (reads code and config files, works out that the breakage must have been ia64) Really the header file should take care of this, and conditional inclusion is evil. So let's give this a whizz? From: Andrew Morton <[EMAIL PROTECTED]> drivers/acpi/bus.c: In function `acpi_init': drivers/acpi/bus.c:760: warning: implicit declaration of function `pci_mmcfg_late_init' Fix this by always including pci.h in drivers/acpi/bus.c. Also remove unneeded inclusion of asm/pci.h (linux/pci.h did that) Cc: Andi Kleen <[EMAIL PROTECTED]> Cc: Greg KH <[EMAIL PROTECTED]> Cc: Jesse Barnes <[EMAIL PROTECTED]> Cc: Linus Torvalds <[EMAIL PROTECTED]> Cc: Rajesh Shah <[EMAIL PROTECTED]> Cc: Robert Hancock <[EMAIL PROTECTED]> Cc: Len Brown <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/acpi/bus.c |3 +-- linux/pci.h|0 2 files changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/acpi/bus.c~mmconfig-validate-against-acpi-motherboard-resources-fix-2-3 drivers/acpi/bus.c --- a/drivers/acpi/bus.c~mmconfig-validate-against-acpi-motherboard-resources-fix-2-3 +++ a/drivers/acpi/bus.c @@ -34,9 +34,8 @@ #include #ifdef CONFIG_X86 #include -#include -#include #endif +#include #include #include _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
On Wed, 20 Jun 2007 21:14:22 -0400 Bob Picco [EMAIL PROTECTED] wrote: Randy Dunlap wrote: [Wed Jun 20 2007, 09:07:11PM EDT] On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote: [EMAIL PROTECTED] wrote: [Wed Jun 20 2007, 01:14:34PM EDT] [snip] Build breakage. pci_mmcfg_late_init is for i386. then you want CONFIG_X86_32 instead of CONFIG_X86. CONFIG_X86 is set/true for both X86_32 and X86_64. Then what I stated within the patch description is incorrect. pci.h which is the required include for the declaration is conditionally for CONFIG_X86. So it is both I guess? (reads code and config files, works out that the breakage must have been ia64) Really the header file should take care of this, and conditional inclusion is evil. So let's give this a whizz? From: Andrew Morton [EMAIL PROTECTED] drivers/acpi/bus.c: In function `acpi_init': drivers/acpi/bus.c:760: warning: implicit declaration of function `pci_mmcfg_late_init' Fix this by always including pci.h in drivers/acpi/bus.c. Also remove unneeded inclusion of asm/pci.h (linux/pci.h did that) Cc: Andi Kleen [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Linus Torvalds [EMAIL PROTECTED] Cc: Rajesh Shah [EMAIL PROTECTED] Cc: Robert Hancock [EMAIL PROTECTED] Cc: Len Brown [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/acpi/bus.c |3 +-- linux/pci.h|0 2 files changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/acpi/bus.c~mmconfig-validate-against-acpi-motherboard-resources-fix-2-3 drivers/acpi/bus.c --- a/drivers/acpi/bus.c~mmconfig-validate-against-acpi-motherboard-resources-fix-2-3 +++ a/drivers/acpi/bus.c @@ -34,9 +34,8 @@ #include linux/proc_fs.h #ifdef CONFIG_X86 #include asm/mpspec.h -#include linux/pci.h -#include asm/pci.h #endif +#include linux/pci.h #include acpi/acpi_bus.h #include acpi/acpi_drivers.h _ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
> On Wed, 20 Jun 2007 20:33:18 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> > wrote: > [EMAIL PROTECTED] wrote: > > git-r8169-fixup.patch > > > This causes a compile failure: > > /home/jeremy/hg/xen/paravirt/linux/drivers/net/r8169.c: In function > 'rtl8169_rx_interrupt': > /home/jeremy/hg/xen/paravirt/linux/drivers/net/r8169.c:2569: error: too many > arguments to function 'rtl8169_try_rx_copy' > > with an allyesconfig on x86-64. Should git-r8169-fixup.patch also be > changing the callers? > git-r8169-fixup is a fix for git-r8169, which I'd in fact dropped, so it should't be there at all. Sorry, that was just a heading-for-the-airport-quick-dump-my-queue thing. I have some serious catching up to do. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fs/quota.c build fix (Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded)
On Wed, 2007-06-20 at 20:45 +0200, Michal Piotrowski wrote: > [EMAIL PROTECTED] pisze: > > The mm snapshot broken-out-2007-06-20-10-12.tar.gz has been uploaded to > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-06-20-10-12.tar.gz > > it was my fault, sorry. Thank you for the fix. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fs/quota.c build fix (Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded)
On Wed, 2007-06-20 at 20:45 +0200, Michal Piotrowski wrote: [EMAIL PROTECTED] pisze: The mm snapshot broken-out-2007-06-20-10-12.tar.gz has been uploaded to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-06-20-10-12.tar.gz it was my fault, sorry. Thank you for the fix. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
On Wed, 20 Jun 2007 20:33:18 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: git-r8169-fixup.patch This causes a compile failure: /home/jeremy/hg/xen/paravirt/linux/drivers/net/r8169.c: In function 'rtl8169_rx_interrupt': /home/jeremy/hg/xen/paravirt/linux/drivers/net/r8169.c:2569: error: too many arguments to function 'rtl8169_try_rx_copy' with an allyesconfig on x86-64. Should git-r8169-fixup.patch also be changing the callers? git-r8169-fixup is a fix for git-r8169, which I'd in fact dropped, so it should't be there at all. Sorry, that was just a heading-for-the-airport-quick-dump-my-queue thing. I have some serious catching up to do. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
Bob Picco wrote:
Randy Dunlap wrote: [Wed Jun 20 2007, 09:07:11PM EDT]
On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote:
[EMAIL PROTECTED] wrote:[Wed Jun 20 2007, 01:14:34PM EDT]
[snip]
Build breakage. pci_mmcfg_late_init is for i386.
then you want CONFIG_X86_32 instead of CONFIG_X86.
CONFIG_X86 is set/true for both X86_32 and X86_64.
Then what I stated within the patch description is incorrect. pci.h which is the
required include for the declaration is conditionally for CONFIG_X86. So it is
both I guess?
Yes.
bob
Signed-off-by: Bob Picco <[EMAIL PROTECTED]>
drivers/acpi/bus.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
===
--- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c2007-06-20
14:09:07.0 -0400
+++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.0
-0400
@@ -757,7 +757,9 @@ static int __init acpi_init(void)
result = acpi_bus_init();
if (!result) {
+#ifdef CONFIG_X86
pci_mmcfg_late_init();
+#endif
#ifdef CONFIG_PM_LEGACY
if (!PM_IS_ACTIVE())
pm_active = 1;
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
[EMAIL PROTECTED] wrote: git-r8169-fixup.patch This causes a compile failure: /home/jeremy/hg/xen/paravirt/linux/drivers/net/r8169.c: In function 'rtl8169_rx_interrupt': /home/jeremy/hg/xen/paravirt/linux/drivers/net/r8169.c:2569: error: too many arguments to function 'rtl8169_try_rx_copy' with an allyesconfig on x86-64. Should git-r8169-fixup.patch also be changing the callers? J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
[EMAIL PROTECTED] wrote: i386-minor-nx-handling-adjustment.patch This is needed: Include asm/pgtable.h to get declaration of __supported_pte_mask This fixes problem exposed by i386-minor-nx-handling-adjustment.patch Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> --- include/xen/page.h |1 + 1 file changed, 1 insertion(+) === --- a/include/xen/page.h +++ b/include/xen/page.h @@ -4,6 +4,7 @@ #include #include +#include #include - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
Randy Dunlap wrote: [Wed Jun 20 2007, 09:07:11PM EDT]
> On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote:
>
> > [EMAIL PROTECTED] wrote:[Wed Jun 20 2007, 01:14:34PM EDT]
> > [snip]
> >
> > Build breakage. pci_mmcfg_late_init is for i386.
>
> then you want CONFIG_X86_32 instead of CONFIG_X86.
> CONFIG_X86 is set/true for both X86_32 and X86_64.
Then what I stated within the patch description is incorrect. pci.h which is the
required include for the declaration is conditionally for CONFIG_X86. So it is
both I guess?
bob
>
>
> > Signed-off-by: Bob Picco <[EMAIL PROTECTED]>
> >
> > drivers/acpi/bus.c |2 ++
> > 1 file changed, 2 insertions(+)
> >
> > Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
> > ===
> > --- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c2007-06-20
> > 14:09:07.0 -0400
> > +++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.0
> > -0400
> > @@ -757,7 +757,9 @@ static int __init acpi_init(void)
> > result = acpi_bus_init();
> >
> > if (!result) {
> > +#ifdef CONFIG_X86
> > pci_mmcfg_late_init();
> > +#endif
> > #ifdef CONFIG_PM_LEGACY
> > if (!PM_IS_ACTIVE())
> > pm_active = 1;
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote:
> [EMAIL PROTECTED] wrote: [Wed Jun 20 2007, 01:14:34PM EDT]
> [snip]
>
> Build breakage. pci_mmcfg_late_init is for i386.
then you want CONFIG_X86_32 instead of CONFIG_X86.
CONFIG_X86 is set/true for both X86_32 and X86_64.
> Signed-off-by: Bob Picco <[EMAIL PROTECTED]>
>
> drivers/acpi/bus.c |2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
> ===
> --- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c 2007-06-20
> 14:09:07.0 -0400
> +++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.0
> -0400
> @@ -757,7 +757,9 @@ static int __init acpi_init(void)
> result = acpi_bus_init();
>
> if (!result) {
> +#ifdef CONFIG_X86
> pci_mmcfg_late_init();
> +#endif
> #ifdef CONFIG_PM_LEGACY
> if (!PM_IS_ACTIVE())
> pm_active = 1;
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
[EMAIL PROTECTED] wrote:[Wed Jun 20 2007, 01:14:34PM EDT] [snip] More build breakage. efi_range_is_wc is referenced but not declared. Signed-off-by: Bob Picco <[EMAIL PROTECTED]> include/asm-ia64/fb.h |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.22-rc5-mm1/include/asm-ia64/fb.h === --- linux-2.6.22-rc5-mm1.orig/include/asm-ia64/fb.h 2007-06-20 14:09:18.0 -0400 +++ linux-2.6.22-rc5-mm1/include/asm-ia64/fb.h 2007-06-20 20:40:48.0 -0400 @@ -3,6 +3,7 @@ #include #include +#include #include static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
[EMAIL PROTECTED] wrote:[Wed Jun 20 2007, 01:14:34PM EDT]
[snip]
Build breakage. pci_mmcfg_late_init is for i386.
Signed-off-by: Bob Picco <[EMAIL PROTECTED]>
drivers/acpi/bus.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
===
--- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c2007-06-20
14:09:07.0 -0400
+++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.0
-0400
@@ -757,7 +757,9 @@ static int __init acpi_init(void)
result = acpi_bus_init();
if (!result) {
+#ifdef CONFIG_X86
pci_mmcfg_late_init();
+#endif
#ifdef CONFIG_PM_LEGACY
if (!PM_IS_ACTIVE())
pm_active = 1;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fs/quota.c build fix (Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded)
[EMAIL PROTECTED] pisze: The mm snapshot broken-out-2007-06-20-10-12.tar.gz has been uploaded to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-06-20-10-12.tar.gz It contains the following patches against 2.6.22-rc5: CC fs/quota.o fs/quota.c:13:24: error: asm/compat.h: No such file or directory make[1]: *** [fs/quota.o] Error 1 make: *** [fs] Error 2 diskquota-32bit-quota-tools-on-64bit-architectures.patch Regards, Michal -- LOG http://www.stardust.webpages.pl/log/ Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> --- linux-work-clean/fs/quota.c 2007-06-20 20:38:52.0 +0200 +++ linux-work/fs/quota.c 2007-06-20 20:35:02.0 +0200 @@ -10,7 +10,7 @@ #include #include #include -#include +#include #include #include #include - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fs/quota.c build fix (Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded)
[EMAIL PROTECTED] pisze: The mm snapshot broken-out-2007-06-20-10-12.tar.gz has been uploaded to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-06-20-10-12.tar.gz It contains the following patches against 2.6.22-rc5: CC fs/quota.o fs/quota.c:13:24: error: asm/compat.h: No such file or directory make[1]: *** [fs/quota.o] Error 1 make: *** [fs] Error 2 diskquota-32bit-quota-tools-on-64bit-architectures.patch Regards, Michal -- LOG http://www.stardust.webpages.pl/log/ Signed-off-by: Michal Piotrowski [EMAIL PROTECTED] --- linux-work-clean/fs/quota.c 2007-06-20 20:38:52.0 +0200 +++ linux-work/fs/quota.c 2007-06-20 20:35:02.0 +0200 @@ -10,7 +10,7 @@ #include linux/slab.h #include asm/current.h #include asm/uaccess.h -#include asm/compat.h +#include linux/compat.h #include linux/kernel.h #include linux/security.h #include linux/syscalls.h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
[EMAIL PROTECTED] wrote:[Wed Jun 20 2007, 01:14:34PM EDT]
[snip]
Build breakage. pci_mmcfg_late_init is for i386.
Signed-off-by: Bob Picco [EMAIL PROTECTED]
drivers/acpi/bus.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
===
--- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c2007-06-20
14:09:07.0 -0400
+++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.0
-0400
@@ -757,7 +757,9 @@ static int __init acpi_init(void)
result = acpi_bus_init();
if (!result) {
+#ifdef CONFIG_X86
pci_mmcfg_late_init();
+#endif
#ifdef CONFIG_PM_LEGACY
if (!PM_IS_ACTIVE())
pm_active = 1;
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
[EMAIL PROTECTED] wrote:[Wed Jun 20 2007, 01:14:34PM EDT] [snip] More build breakage. efi_range_is_wc is referenced but not declared. Signed-off-by: Bob Picco [EMAIL PROTECTED] include/asm-ia64/fb.h |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.22-rc5-mm1/include/asm-ia64/fb.h === --- linux-2.6.22-rc5-mm1.orig/include/asm-ia64/fb.h 2007-06-20 14:09:18.0 -0400 +++ linux-2.6.22-rc5-mm1/include/asm-ia64/fb.h 2007-06-20 20:40:48.0 -0400 @@ -3,6 +3,7 @@ #include linux/fb.h #include linux/fs.h +#include linux/efi.h #include asm/page.h static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote:
[EMAIL PROTECTED] wrote: [Wed Jun 20 2007, 01:14:34PM EDT]
[snip]
Build breakage. pci_mmcfg_late_init is for i386.
then you want CONFIG_X86_32 instead of CONFIG_X86.
CONFIG_X86 is set/true for both X86_32 and X86_64.
Signed-off-by: Bob Picco [EMAIL PROTECTED]
drivers/acpi/bus.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
===
--- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c 2007-06-20
14:09:07.0 -0400
+++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.0
-0400
@@ -757,7 +757,9 @@ static int __init acpi_init(void)
result = acpi_bus_init();
if (!result) {
+#ifdef CONFIG_X86
pci_mmcfg_late_init();
+#endif
#ifdef CONFIG_PM_LEGACY
if (!PM_IS_ACTIVE())
pm_active = 1;
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
Randy Dunlap wrote: [Wed Jun 20 2007, 09:07:11PM EDT]
On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote:
[EMAIL PROTECTED] wrote:[Wed Jun 20 2007, 01:14:34PM EDT]
[snip]
Build breakage. pci_mmcfg_late_init is for i386.
then you want CONFIG_X86_32 instead of CONFIG_X86.
CONFIG_X86 is set/true for both X86_32 and X86_64.
Then what I stated within the patch description is incorrect. pci.h which is the
required include for the declaration is conditionally for CONFIG_X86. So it is
both I guess?
bob
Signed-off-by: Bob Picco [EMAIL PROTECTED]
drivers/acpi/bus.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
===
--- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c2007-06-20
14:09:07.0 -0400
+++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.0
-0400
@@ -757,7 +757,9 @@ static int __init acpi_init(void)
result = acpi_bus_init();
if (!result) {
+#ifdef CONFIG_X86
pci_mmcfg_late_init();
+#endif
#ifdef CONFIG_PM_LEGACY
if (!PM_IS_ACTIVE())
pm_active = 1;
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
[EMAIL PROTECTED] wrote: i386-minor-nx-handling-adjustment.patch This is needed: Include asm/pgtable.h to get declaration of __supported_pte_mask This fixes problem exposed by i386-minor-nx-handling-adjustment.patch Signed-off-by: Jeremy Fitzhardinge [EMAIL PROTECTED] --- include/xen/page.h |1 + 1 file changed, 1 insertion(+) === --- a/include/xen/page.h +++ b/include/xen/page.h @@ -4,6 +4,7 @@ #include linux/pfn.h #include asm/uaccess.h +#include asm/pgtable.h #include xen/features.h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
[EMAIL PROTECTED] wrote: git-r8169-fixup.patch This causes a compile failure: /home/jeremy/hg/xen/paravirt/linux/drivers/net/r8169.c: In function 'rtl8169_rx_interrupt': /home/jeremy/hg/xen/paravirt/linux/drivers/net/r8169.c:2569: error: too many arguments to function 'rtl8169_try_rx_copy' with an allyesconfig on x86-64. Should git-r8169-fixup.patch also be changing the callers? J - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
Bob Picco wrote:
Randy Dunlap wrote: [Wed Jun 20 2007, 09:07:11PM EDT]
On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote:
[EMAIL PROTECTED] wrote:[Wed Jun 20 2007, 01:14:34PM EDT]
[snip]
Build breakage. pci_mmcfg_late_init is for i386.
then you want CONFIG_X86_32 instead of CONFIG_X86.
CONFIG_X86 is set/true for both X86_32 and X86_64.
Then what I stated within the patch description is incorrect. pci.h which is the
required include for the declaration is conditionally for CONFIG_X86. So it is
both I guess?
Yes.
bob
Signed-off-by: Bob Picco [EMAIL PROTECTED]
drivers/acpi/bus.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
===
--- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c2007-06-20
14:09:07.0 -0400
+++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.0
-0400
@@ -757,7 +757,9 @@ static int __init acpi_init(void)
result = acpi_bus_init();
if (!result) {
+#ifdef CONFIG_X86
pci_mmcfg_late_init();
+#endif
#ifdef CONFIG_PM_LEGACY
if (!PM_IS_ACTIVE())
pm_active = 1;
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
