Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Jan Engelhardt 

On Jul 29 2007 14:12, Mike Houston wrote:
>I know it's off topic here, but this will help people.
>
>When that happens, check their forum. Chances are someone has
>posted, and the nvidia developers have answered with a patch, code
>snippet, quick instructions to get it to compile or advice to try a
>beta driver if applicable.

At least for solidarity for those stuck with it, patch below.

>To build nvidia kernel module failed in
>kernel-2.6.23-0.41.rc0.git14.fc8
>http://www.nvnews.net/vbulletin/showthread.php?t=95296

Jan
===

---
 nv-linux.h |2 +-
 nv.c   |6 ++
 2 files changed, 3 insertions(+), 5 deletions(-)

Index: nv_kernel-100.14.11/nv-linux.h
===
--- nv_kernel-100.14.11.orig/nv-linux.h
+++ nv_kernel-100.14.11/nv-linux.h
@@ -533,7 +533,7 @@ static inline unsigned long nv_virt_to_p
 #define NV_KMEM_CACHE_CREATE(kmem_cache, name, type)\
 {   \
 kmem_cache = kmem_cache_create(name, sizeof(type),  \
-0, 0, NULL, NULL);  \
+0, 0, NULL);  \
 } 
 
 #define NV_KMEM_CACHE_DESTROY(kmem_cache)   \
Index: nv_kernel-100.14.11/nv.c
===
--- nv_kernel-100.14.11.orig/nv.c
+++ nv_kernel-100.14.11/nv.c
@@ -1566,8 +1566,7 @@ failed:
 if (apm_nv_dev[i] != NULL) pm_unregister(apm_nv_dev[i]);
 #endif
 
-if (unregister_chrdev(nv_major, "nvidia") < 0)
-nv_printf(NV_DBG_ERRORS, "NVRM: unregister nv chrdev failed\n");
+unregister_chrdev(nv_major, "nvidia");
 
 for (i = 0; i < num_nv_devices; i++)
 {
@@ -1598,8 +1597,7 @@ static void __exit nvidia_exit_module(vo
 
 nv_printf(NV_DBG_INFO, "NVRM: nvidia_exit_module\n");
 
-if (unregister_chrdev(nv_major, "nvidia") < 0)
-nv_printf(NV_DBG_ERRORS, "NVRM: unregister nv chrdev failed\n");
+unregister_chrdev(nv_major, "nvidia");
 
 for (i = 0; i < num_nv_devices; i++)
 {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Mike Houston 
On Sun, 29 Jul 2007 10:57:33 -0400
Gene Heskett <[EMAIL PROTECTED]> wrote:

> Greetings;
> 
> I got around to building the 2.6.23-rc1 tree, updated to yesterday
> with git from the linus tree.  The build was fairly clean, but when
> I rebooted to it, the latest nvidia installer fails, with these
> messages:

I know it's off topic here, but this will help people.

When that happens, check their forum. Chances are someone has
posted, and the nvidia developers have answered with a patch, code
snippet, quick instructions to get it to compile or advice to try a
beta driver if applicable.

To build nvidia kernel module failed in
kernel-2.6.23-0.41.rc0.git14.fc8
http://www.nvnews.net/vbulletin/showthread.php?t=95296

Mike Houston
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Stefan Richter 
Jan Engelhardt wrote:
> On Jul 29 2007 10:57, Gene Heskett wrote:
>>   /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c: In 
>> function
>>   ‘nvidia_init_module’:
>>   /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c:1326: 
>> error:
>>   too many arguments to function ‘kmem_cache_create’
...
> Fix the source until they have a fix. It seems to be
> just an extra argument to kmem_cache_create that got removed.

Gene,
the last argument to kmem_cache_create has been removed.  It should be
a simple matter to delete it from the caller, since it already was
unsupported by the callees in previous kernels.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=20c2df83d25c6a95affe6157a4c9cac4cf5ffaac
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=mm/slab.c;h=bde271c001ba33ef1f61dd0f563f74d319cd1f0e;hp=c3feeaab387537ef00aa2085b4f54f6d7e4abca0
-- 
Stefan Richter
-=-=-=== -=== ===-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Alistair John Strachan 
On Sunday 29 July 2007 15:57:33 Gene Heskett wrote:
> Is this a known problem?  Do I need to report it to nvidia somehow?  It
> looks to me like it may be their problem, and I have submitted it, but if
> anyone has a better idea, please advise.  System is FC6, uptodate as of
> yesterday.

Gene, this happens almost every kernel version. You should know that binary 
drivers are OT for LKML, and if you want to report the problem you go through 
the [EMAIL PROTECTED] address clearly printed in the driver 
documentation, and on their website.

(As it turns out, the fix is very easy and you could easily fix it yourself. 
Just run --extract-only on the installer and poke around the affected files, 
removing the extra "NULL" argument to kmem_cache_create().)

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Jan Engelhardt 

On Jul 29 2007 10:57, Gene Heskett wrote:
>   /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c: In 
>function
>   ‘nvidia_init_module’:
>   /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c:1326: 
>error:
>   too many arguments to function ‘kmem_cache_create’


>Is this a known problem?  Do I need to report it to nvidia somehow? 

Well, you do not *need* to report it, just as you do not need to report
kernel oopses or Windows crashes. They'll eventually stumble upon
that themselves

>It looks to me like it may be their problem, and I have submitted
>it, but if anyone has a better idea, please advise.  System is FC6,
>uptodate as of yesterday.

Better idea? Fix the source until they have a fix. It seems to be
just an extra argument to kmem_cache_create that got removed.


Jan
--

nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Gene Heskett 
Greetings;

I got around to building the 2.6.23-rc1 tree, updated to yesterday with git 
from the linus tree.  The build was fairly clean, but when I rebooted to it, 
the latest nvidia installer fails, with these messages:

nvidia-installer log file '/var/log/nvidia-installer.log'
creation time: Sun Jul 29 10:14:04 2007

option status:
  license pre-accepted: false
  update  : false
  force update: false
  expert  : false
  uninstall   : false
  driver info : false
  precompiled interfaces  : true
  no ncurses color: false
  query latest version: false
  OpenGL header files : true
  no questions: false
  silent  : false
  no recursion: false
  no backup   : false
  kernel module only  : false
  sanity  : false
  add this kernel : false
  no runlevel check   : false
  no network  : false
  no ABI note : false
  no RPMs : false
  no kernel module: false
  force SELinux   : default
  no X server check   : false
  force tls   : (not specified)
  X install prefix: (not specified)
  X library install path  : (not specified)
  X module install path   : (not specified)
  OpenGL install prefix   : (not specified)
  OpenGL install libdir   : (not specified)
  utility install prefix  : (not specified)
  utility install libdir  : (not specified)
  doc install prefix  : (not specified)
  kernel name : (not specified)
  kernel include path : (not specified)
  kernel source path  : (not specified)
  kernel output path  : (not specified)
  kernel install path : (not specified)
  proc mount point: /proc
  ui  : (not specified)
  tmpdir  : /tmp
  ftp mirror  : ftp://download.nvidia.com
  RPM file list   : (not specified)
[...]  
   NVIDIA: calling KBUILD...
   make CC=cc KBUILD_OUTPUT=/lib/modules/2.6.23-rc1/build 
KBUILD_VERBOSE=1 -C /
   lib/modules/2.6.23-rc1/source 
SUBDIRS=/tmp/selfgz9678/NVIDIA-Linux-x86-100.1
   4.11-pkg1/usr/src/nv modules
   make -C /lib/modules/2.6.23-rc1/build \
KBUILD_SRC=/usr/src/linux.git \   <---has softlink to 
linux-2.6.23-rc1

KBUILD_EXTMOD="/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv" 
   -f /usr/src/linux.git/Makefile modules
   test -e include/linux/autoconf.h -a -e include/config/auto.conf || ( 
\
echo;   \
echo "  ERROR: Kernel configuration is invalid.";   \
echo " include/linux/autoconf.h or include/config/auto.conf are 
missing.";  \
echo " Run 'make oldconfig && make prepare' on kernel src to 
fix 
it

I've done the above, no effect

[...] 
cc -Wp,-MD,/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/.nv.
   
o.d  -nostdinc -isystem /usr/lib/gcc/i386-redhat-linux/4.1.2/include -D__KER
   NEL__ -Iinclude -Iinclude2 -I/usr/src/linux.git/include -include 
include/lin
   ux/autoconf.h  -I/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv 
   -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-c
   
ommon -Werror-implicit-function-declaration -Os -pipe -msoft-float -mregparm
   
=3 -freg-struct-return -mpreferred-stack-boundary=2 -march=athlon -mtune=gen
   
eric -ffreestanding -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS
   _CFI_SIGNAL_FRAME=1 -
   
I/usr/src/linux.git/include/asm-i386/mach-default -Iinclude/asm-i386/mach-de
   
fault -fomit-frame-pointer -fno-stack-protector -Wdeclaration-after-statemen
   
t -Wno-pointer-sign  -I/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/s
   
rc/nv -Wall -Wimplicit -Wreturn-type -Wswitch -Wformat -Wchar-subscripts -Wp
   
arentheses -Wpointer-arith -Wno-multichar -Werror -O -fno-common -msoft-floa
   
t -MD -Wsign-compare -Wno-cast-qual -Wno-error -D_LOOSE_KERNEL_NAMES -D__KER
   
NEL__ -DMODULE -DNVRM -DNV_VERSION_STRING=\"100.14.11\" -UDEBUG -U_DEBUG -DN
   
DEBUG -DNV_SIGNAL_STRUCT_RLIM -DNV_MULTIPLE_BRIDGE_AGPGART_PRESENT -DNV_PCI_
   
GET_CLASS_PRESENT -DNV_SYSCTL_MAX_MAP_COUNT_PRESENT -DNV_PM_MESSAGE_T_PRESEN
   
T -DNV_PCI_CHOOSE_STATE_PRESENT -DNV_VM_INSERT_PAGE_PRESENT -DNV_OLD_MM_KGDB
   
_BREAKPOINT_PRESENT -DNV_REMAP_PFN_RANGE_PRESENT -DNV_CHANGE_PAGE_ATTR_PRESE
   
NT -DNV_ACQUIRE_CONSOLE_SEM_PRESENT -DNV_VMAP_4_PRESENT -DMODULE -D"KBUILD_S
   
TR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(nv)"  -D"KBUILD_MODNAME=KBUILD_STR(n
   vidia)" -c -o /tmp/selfgz9678/NVIDIA
   -Linux-x86-100.14.11-pkg1/usr/src/nv/nv.o /tmp/selfgz9678/NVIDIA-Linux-x86-1
   00.14.11-pkg1/usr/src/nv/nv.c
   In file included from include/linux/list.h:9,
from include/linux/preempt.h:12,
from include/linux/spinlock.h:50,

nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Gene Heskett 
Greetings;

I got around to building the 2.6.23-rc1 tree, updated to yesterday with git 
from the linus tree.  The build was fairly clean, but when I rebooted to it, 
the latest nvidia installer fails, with these messages:

nvidia-installer log file '/var/log/nvidia-installer.log'
creation time: Sun Jul 29 10:14:04 2007

option status:
  license pre-accepted: false
  update  : false
  force update: false
  expert  : false
  uninstall   : false
  driver info : false
  precompiled interfaces  : true
  no ncurses color: false
  query latest version: false
  OpenGL header files : true
  no questions: false
  silent  : false
  no recursion: false
  no backup   : false
  kernel module only  : false
  sanity  : false
  add this kernel : false
  no runlevel check   : false
  no network  : false
  no ABI note : false
  no RPMs : false
  no kernel module: false
  force SELinux   : default
  no X server check   : false
  force tls   : (not specified)
  X install prefix: (not specified)
  X library install path  : (not specified)
  X module install path   : (not specified)
  OpenGL install prefix   : (not specified)
  OpenGL install libdir   : (not specified)
  utility install prefix  : (not specified)
  utility install libdir  : (not specified)
  doc install prefix  : (not specified)
  kernel name : (not specified)
  kernel include path : (not specified)
  kernel source path  : (not specified)
  kernel output path  : (not specified)
  kernel install path : (not specified)
  proc mount point: /proc
  ui  : (not specified)
  tmpdir  : /tmp
  ftp mirror  : ftp://download.nvidia.com
  RPM file list   : (not specified)
[...]  
   NVIDIA: calling KBUILD...
   make CC=cc KBUILD_OUTPUT=/lib/modules/2.6.23-rc1/build 
KBUILD_VERBOSE=1 -C /
   lib/modules/2.6.23-rc1/source 
SUBDIRS=/tmp/selfgz9678/NVIDIA-Linux-x86-100.1
   4.11-pkg1/usr/src/nv modules
   make -C /lib/modules/2.6.23-rc1/build \
KBUILD_SRC=/usr/src/linux.git \   ---has softlink to 
linux-2.6.23-rc1

KBUILD_EXTMOD=/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv 
   -f /usr/src/linux.git/Makefile modules
   test -e include/linux/autoconf.h -a -e include/config/auto.conf || ( 
\
echo;   \
echo   ERROR: Kernel configuration is invalid.;   \
echo  include/linux/autoconf.h or include/config/auto.conf are 
missing.;  \
echo  Run 'make oldconfig  make prepare' on kernel src to 
fix 
it

I've done the above, no effect

[...] 
cc -Wp,-MD,/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/.nv.
   
o.d  -nostdinc -isystem /usr/lib/gcc/i386-redhat-linux/4.1.2/include -D__KER
   NEL__ -Iinclude -Iinclude2 -I/usr/src/linux.git/include -include 
include/lin
   ux/autoconf.h  -I/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv 
   -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-c
   
ommon -Werror-implicit-function-declaration -Os -pipe -msoft-float -mregparm
   
=3 -freg-struct-return -mpreferred-stack-boundary=2 -march=athlon -mtune=gen
   
eric -ffreestanding -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS
   _CFI_SIGNAL_FRAME=1 -
   
I/usr/src/linux.git/include/asm-i386/mach-default -Iinclude/asm-i386/mach-de
   
fault -fomit-frame-pointer -fno-stack-protector -Wdeclaration-after-statemen
   
t -Wno-pointer-sign  -I/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/s
   
rc/nv -Wall -Wimplicit -Wreturn-type -Wswitch -Wformat -Wchar-subscripts -Wp
   
arentheses -Wpointer-arith -Wno-multichar -Werror -O -fno-common -msoft-floa
   
t -MD -Wsign-compare -Wno-cast-qual -Wno-error -D_LOOSE_KERNEL_NAMES -D__KER
   
NEL__ -DMODULE -DNVRM -DNV_VERSION_STRING=\100.14.11\ -UDEBUG -U_DEBUG -DN
   
DEBUG -DNV_SIGNAL_STRUCT_RLIM -DNV_MULTIPLE_BRIDGE_AGPGART_PRESENT -DNV_PCI_
   
GET_CLASS_PRESENT -DNV_SYSCTL_MAX_MAP_COUNT_PRESENT -DNV_PM_MESSAGE_T_PRESEN
   
T -DNV_PCI_CHOOSE_STATE_PRESENT -DNV_VM_INSERT_PAGE_PRESENT -DNV_OLD_MM_KGDB
   
_BREAKPOINT_PRESENT -DNV_REMAP_PFN_RANGE_PRESENT -DNV_CHANGE_PAGE_ATTR_PRESE
   
NT -DNV_ACQUIRE_CONSOLE_SEM_PRESENT -DNV_VMAP_4_PRESENT -DMODULE -DKBUILD_S
   
TR(s)=#s -DKBUILD_BASENAME=KBUILD_STR(nv)  -DKBUILD_MODNAME=KBUILD_STR(n
   vidia) -c -o /tmp/selfgz9678/NVIDIA
   -Linux-x86-100.14.11-pkg1/usr/src/nv/nv.o /tmp/selfgz9678/NVIDIA-Linux-x86-1
   00.14.11-pkg1/usr/src/nv/nv.c
   In file included from include/linux/list.h:9,
from include/linux/preempt.h:12,
from include/linux/spinlock.h:50,
from

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Alistair John Strachan 
On Sunday 29 July 2007 15:57:33 Gene Heskett wrote:
 Is this a known problem?  Do I need to report it to nvidia somehow?  It
 looks to me like it may be their problem, and I have submitted it, but if
 anyone has a better idea, please advise.  System is FC6, uptodate as of
 yesterday.

Gene, this happens almost every kernel version. You should know that binary 
drivers are OT for LKML, and if you want to report the problem you go through 
the [EMAIL PROTECTED] address clearly printed in the driver 
documentation, and on their website.

(As it turns out, the fix is very easy and you could easily fix it yourself. 
Just run --extract-only on the installer and poke around the affected files, 
removing the extra NULL argument to kmem_cache_create().)

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Jan Engelhardt 

On Jul 29 2007 10:57, Gene Heskett wrote:
   /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c: In 
function
   ‘nvidia_init_module’:
   /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c:1326: 
error:
   too many arguments to function ‘kmem_cache_create’


Is this a known problem?  Do I need to report it to nvidia somehow? 

Well, you do not *need* to report it, just as you do not need to report
kernel oopses or Windows crashes. They'll eventually stumble upon
that themselves

It looks to me like it may be their problem, and I have submitted
it, but if anyone has a better idea, please advise.  System is FC6,
uptodate as of yesterday.

Better idea? Fix the source until they have a fix. It seems to be
just an extra argument to kmem_cache_create that got removed.


Jan
--

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Stefan Richter 
Jan Engelhardt wrote:
 On Jul 29 2007 10:57, Gene Heskett wrote:
   /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c: In 
 function
   ‘nvidia_init_module’:
   /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c:1326: 
 error:
   too many arguments to function ‘kmem_cache_create’
...
 Fix the source until they have a fix. It seems to be
 just an extra argument to kmem_cache_create that got removed.

Gene,
the last argument to kmem_cache_create has been removed.  It should be
a simple matter to delete it from the caller, since it already was
unsupported by the callees in previous kernels.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=20c2df83d25c6a95affe6157a4c9cac4cf5ffaac
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=mm/slab.c;h=bde271c001ba33ef1f61dd0f563f74d319cd1f0e;hp=c3feeaab387537ef00aa2085b4f54f6d7e4abca0
-- 
Stefan Richter
-=-=-=== -=== ===-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Mike Houston 
On Sun, 29 Jul 2007 10:57:33 -0400
Gene Heskett [EMAIL PROTECTED] wrote:

 Greetings;
 
 I got around to building the 2.6.23-rc1 tree, updated to yesterday
 with git from the linus tree.  The build was fairly clean, but when
 I rebooted to it, the latest nvidia installer fails, with these
 messages:

I know it's off topic here, but this will help people.

When that happens, check their forum. Chances are someone has
posted, and the nvidia developers have answered with a patch, code
snippet, quick instructions to get it to compile or advice to try a
beta driver if applicable.

To build nvidia kernel module failed in
kernel-2.6.23-0.41.rc0.git14.fc8
http://www.nvnews.net/vbulletin/showthread.php?t=95296

Mike Houston
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: nvidia installer DIW with 2.6.23-rc1

2007-07-29 Thread Jan Engelhardt 

On Jul 29 2007 14:12, Mike Houston wrote:
I know it's off topic here, but this will help people.

When that happens, check their forum. Chances are someone has
posted, and the nvidia developers have answered with a patch, code
snippet, quick instructions to get it to compile or advice to try a
beta driver if applicable.

At least for solidarity for those stuck with it, patch below.

To build nvidia kernel module failed in
kernel-2.6.23-0.41.rc0.git14.fc8
http://www.nvnews.net/vbulletin/showthread.php?t=95296

Jan
===

---
 nv-linux.h |2 +-
 nv.c   |6 ++
 2 files changed, 3 insertions(+), 5 deletions(-)

Index: nv_kernel-100.14.11/nv-linux.h
===
--- nv_kernel-100.14.11.orig/nv-linux.h
+++ nv_kernel-100.14.11/nv-linux.h
@@ -533,7 +533,7 @@ static inline unsigned long nv_virt_to_p
 #define NV_KMEM_CACHE_CREATE(kmem_cache, name, type)\
 {   \
 kmem_cache = kmem_cache_create(name, sizeof(type),  \
-0, 0, NULL, NULL);  \
+0, 0, NULL);  \
 } 
 
 #define NV_KMEM_CACHE_DESTROY(kmem_cache)   \
Index: nv_kernel-100.14.11/nv.c
===
--- nv_kernel-100.14.11.orig/nv.c
+++ nv_kernel-100.14.11/nv.c
@@ -1566,8 +1566,7 @@ failed:
 if (apm_nv_dev[i] != NULL) pm_unregister(apm_nv_dev[i]);
 #endif
 
-if (unregister_chrdev(nv_major, nvidia)  0)
-nv_printf(NV_DBG_ERRORS, NVRM: unregister nv chrdev failed\n);
+unregister_chrdev(nv_major, nvidia);
 
 for (i = 0; i  num_nv_devices; i++)
 {
@@ -1598,8 +1597,7 @@ static void __exit nvidia_exit_module(vo
 
 nv_printf(NV_DBG_INFO, NVRM: nvidia_exit_module\n);
 
-if (unregister_chrdev(nv_major, nvidia)  0)
-nv_printf(NV_DBG_ERRORS, NVRM: unregister nv chrdev failed\n);
+unregister_chrdev(nv_major, nvidia);
 
 for (i = 0; i  num_nv_devices; i++)
 {
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/