Re: problem with cscope and 2.4-test8 source file
Rusty writes:
> In message <[EMAIL PROTECTED]> you write:
>> * Mark Salisbury <[EMAIL PROTECTED]> [000918 07:32]:
>>> the source file linux/fs/hpfs/super.c
>>>
>>> from kernel version 2.4-test8 causes cscope to core dump during
>>> the database generation phase.
>>>
>>> the problem is the extremely long printk() string starting on
>>> line 280 in the function static inline void hpfs_help(void){}
>
> printk has a 1024 character limit. This printk must be broken up anyway.
No other filesystem driver has a built-in man page. HPFS is already
documented in mount.8, so there is no need to use kernel memory to
store additional documentation.
Of course, cscope still looks like a security hazard. One just needs
to sneak a buffer-overflow exploit patch past Linus. I'll guess that
this can be fixed by building cscope with flex in place of lex, not
that I've actually looked at the source though.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: problem with cscope and 2.4-test8 source file
In message <[EMAIL PROTECTED]> you write:
> * Mark Salisbury <[EMAIL PROTECTED]> [000918 07:32]:
> > the source file linux/fs/hpfs/super.c
> >
> > from kernel version 2.4-test8 causes cscope to core dump during the database
> > generation phase.
> >
> > the problem is the extremely long printk() string starting on line 280 in t
he
> > function static inline void hpfs_help(void){}
printk has a 1024 character limit. This printk must be broken up anyway.
Rusty.
--
Hacking time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: problem with cscope and 2.4-test8 source file
Mark Salisbury writes:
> the source file linux/fs/hpfs/super.c
>
> the problem is the extremely long printk() string starting on line 280 in the
> function static inline void hpfs_help(void){}
>
> simply breaking up this printk up into several smaller printk's solves the
> problem.
Looking at this printk makes me think that this is better off in the man
page than in the kernel... Maybe you should just submit a patch which
removes the whole hpfs_help() function, and updates the mount(8) man page...
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: problem with cscope and 2.4-test8 source file
* Mark Salisbury <[EMAIL PROTECTED]> [000918 07:32]:
> I use cscope version 13.7 (on solaris 2.6)
There is an open sourced version of cscope released under a BSD license at
http://cscope.sourceforge.net/ ...
> the source file linux/fs/hpfs/super.c
>
> from kernel version 2.4-test8 causes cscope to core dump during the database
> generation phase.
>
> the problem is the extremely long printk() string starting on line 280 in the
> function static inline void hpfs_help(void){}
I just tried it with the open sourced cscope, and it works on that line
just fine. It (the cscope) still needs a little work in some areas, but
it seems fairly decent to me.
> simply breaking up this printk up into several smaller printk's solves the
> problem.
You can submit a kernel patch if you think it'll get accepted... it's
a trivial enough hack... but no guarantees.
> I guess this is only a problem if you use cscope, but I thought you all would
> like to know..
Try using the open source cscope... this isn't a bug there, and if you
do run into any, you can always email me (or submit to cscope's
sourceforge site) patches to it.
Good luck. :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
problem with cscope and 2.4-test8 source file
I use cscope version 13.7 (on solaris 2.6)
the source file linux/fs/hpfs/super.c
from kernel version 2.4-test8 causes cscope to core dump during the database
generation phase.
the problem is the extremely long printk() string starting on line 280 in the
function static inline void hpfs_help(void){}
simply breaking up this printk up into several smaller printk's solves the
problem.
I guess this is only a problem if you use cscope, but I thought you all would
like to know..
Mark
/***
** Mark Salisbury | Mercury Computer Systems**
** [EMAIL PROTECTED] | System OS - Kernel Team **
****
** "WYGIWYD - What You Get Is What You Deserve" **
***/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
