Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
On 3/4/19 5:27 PM, Eric Anholt wrote: > Helen Koike writes: > >> Hello, >> >> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4 >> driver, the HDMI wans't being detected. >> >> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it >> works correctly. I can see that modeprint from libdrm detects correctly >> when the display is plugged and when it is unpluggled. >> >> So I was wondering if this is just in my board or if there is an error >> in the dts (which I think it's unlikely). >> >> In any case I am dropping this email here in case anyone else see this >> problem, if you do, try appliying the patch below. > > We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts > agrees. You are right, I didn't notice it. > > Reviewed-by: Eric Anholt > Thanks! If Stefan doesn't pick this up shortly, I can. > Thanks for reviewing! Helen
Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
On 3/4/19 5:15 PM, Stefan Wahren wrote:
> Hi Helen,
>
>> Helen Koike hat am 4. März 2019 um 19:54
>> geschrieben:
>>
>>
>> Hello,
>>
>> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
>> driver, the HDMI wans't being detected.
>>
>> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
>> works correctly. I can see that modeprint from libdrm detects correctly
>> when the display is plugged and when it is unpluggled.
>>
>> So I was wondering if this is just in my board or if there is an error
>> in the dts (which I think it's unlikely).
>>
>> In any case I am dropping this email here in case anyone else see this
>> problem, if you do, try appliying the patch below.
>
> thanks for your report and the patch. I verified your change against
> dt-blob.dts / downstream file and it's correct.
>
> I'm sorry but i cannot apply your patch because it doesn't have the proper
> format.
>
> Should i take care of this?
> Can i add your Signed-off-by including your mail address?
I just resent it in a proper format, please check.
Thanks!
Helen
>
> Stefan
>
>>
>> Regards,
>> Helen
>>
>> ---
>> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
>> b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
>> index 5641d162dfdb..28e7513ce617 100644
>> --- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
>> +++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
>> @@ -93,7 +93,7 @@
>> };
>>
>> {
>> -hpd-gpios = < 46 GPIO_ACTIVE_LOW>;
>> +hpd-gpios = < 46 GPIO_ACTIVE_HIGH>;
>> };
>>
>> {
>> --
>> 2.20.1
>>
Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
Helen Koike writes: > Hello, > > I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4 > driver, the HDMI wans't being detected. > > So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it > works correctly. I can see that modeprint from libdrm detects correctly > when the display is plugged and when it is unpluggled. > > So I was wondering if this is just in my board or if there is an error > in the dts (which I think it's unlikely). > > In any case I am dropping this email here in case anyone else see this > problem, if you do, try appliying the patch below. We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts agrees. Reviewed-by: Eric Anholt Thanks! If Stefan doesn't pick this up shortly, I can. signature.asc Description: PGP signature
Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
Hi Helen,
> Helen Koike hat am 4. März 2019 um 19:54
> geschrieben:
>
>
> Hello,
>
> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
> driver, the HDMI wans't being detected.
>
> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
> works correctly. I can see that modeprint from libdrm detects correctly
> when the display is plugged and when it is unpluggled.
>
> So I was wondering if this is just in my board or if there is an error
> in the dts (which I think it's unlikely).
>
> In any case I am dropping this email here in case anyone else see this
> problem, if you do, try appliying the patch below.
thanks for your report and the patch. I verified your change against
dt-blob.dts / downstream file and it's correct.
I'm sorry but i cannot apply your patch because it doesn't have the proper
format.
Should i take care of this?
Can i add your Signed-off-by including your mail address?
Stefan
>
> Regards,
> Helen
>
> ---
> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> index 5641d162dfdb..28e7513ce617 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> +++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> @@ -93,7 +93,7 @@
> };
>
> {
> - hpd-gpios = < 46 GPIO_ACTIVE_LOW>;
> + hpd-gpios = < 46 GPIO_ACTIVE_HIGH>;
> };
>
> {
> --
> 2.20.1
>
rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
Hello,
I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
driver, the HDMI wans't being detected.
So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
works correctly. I can see that modeprint from libdrm detects correctly
when the display is plugged and when it is unpluggled.
So I was wondering if this is just in my board or if there is an error
in the dts (which I think it's unlikely).
In any case I am dropping this email here in case anyone else see this
problem, if you do, try appliying the patch below.
Regards,
Helen
---
arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
index 5641d162dfdb..28e7513ce617 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
@@ -93,7 +93,7 @@
};
{
- hpd-gpios = < 46 GPIO_ACTIVE_LOW>;
+ hpd-gpios = < 46 GPIO_ACTIVE_HIGH>;
};
{
--
2.20.1
