Re: scsi: delete decade+ obsolete aic7xxx_old driver
On 09/17/2013 08:27 PM, Paul Bolle wrote: > On Mon, 2013-09-16 at 21:51 -0400, Paul Gortmaker wrote: >> Currently we have people wasting time building it during routine testing, >> and then wasting more time re-researching the known reported warnings, >> only to find that nobody really is willing to integrate the fixes[3] for >> it. >> >> [...] >> >> [3] https://lkml.org/lkml/2012/10/29/215 > > Well, this didn't end up as an entire waste of my time. After that > message I sent a patch to Fedora's kernel list, and a reminder a few > months later[1]. That prompted Josh Boyer to remove this old driver from > the Fedora build[2]. > > And now that driver is disabled in all kernels that Fedora currently > ships. I'm not familiar with any complaints about this decision. > Ok, good to know. So this patch appears to be good, then. Acked-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
[Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver] On 17/09/2013 (Tue 16:27) Doug Ledford wrote: > On 09/17/13 16:10, James Bottomley wrote: > > > OK, so do we have any real evidence that no-one uses this driver? Does > > any distro actually compile it, for instance? > > Red Hat doesn't use it in any of their products (and it hasn't been the > preferred driver since about the old Red Hat Linux 7.0 days). The oldest ubuntu machine I could find was running a 2.6.32 kernel and even back then, they weren't building/enabling this driver either. Paul. -- > > > -- > Doug Ledford > GPG KeyID: 0E572FDD > http://people.redhat.com/dledford > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On 09/17/13 16:10, James Bottomley wrote: > OK, so do we have any real evidence that no-one uses this driver? Does > any distro actually compile it, for instance? Red Hat doesn't use it in any of their products (and it hasn't been the preferred driver since about the old Red Hat Linux 7.0 days). -- Doug Ledford GPG KeyID: 0E572FDD http://people.redhat.com/dledford -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On Tue, 2013-09-17 at 16:29 +0200, Hannes Reinecke wrote: > On 09/17/2013 04:13 AM, Doug Ledford wrote: > > Yes, this driver is well past ready to be removed. > > > > Acked-by: Doug Ledford > > > > Sent from my ASUS Pad > > > > Paul Gortmaker wrote: > > > >> After getting warnings in an allyesconfig build[1] from this > >> driver, I decided to remind myself just how old it was, and > >> whether it warranted fixing. In the Kconfig help text, I found: > >> > >> "This driver will eventually be phased out entirely" > >> > >> Going back to the history archive, I see the line was added[2] > >> in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2 > >> > >> So, with over a decade of notification, and multiple major releases > >> since then, I think we can justify removing this. Currently we have > >> people wasting time building it during routine testing, and then > >> wasting more time re-researching the known reported warnings, only to > >> find that nobody really is willing to integrate the fixes[3] for it. > >> > >> A quick search didn't seem to indicate any active user base for it. > >> If someone happens to have a quirky _old_ card that the eleven year > >> old "new" driver doesn't work with, then it is entirely reasonable > >> that they stick with a kernel version that predates this removal. > >> > >> [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: > >>drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in > >> enumerated type ‘ahc_chip’ [-Wswitch] > >>drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in > >> enumerated type ‘ahc_chip’ [-Wswitch] > >>drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: > >>drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in > >> enumerated type ‘ahc_chip’ [-Wswitch] > >>drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in > >> enumerated type ‘ahc_chip’ [-Wswitch] > >> > >> [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit > >> 44e8778c > >> > >> [3] https://lkml.org/lkml/2012/10/29/215 > >> > >> Cc: Hannes Reinecke > >> Cc: Doug Ledford > >> Cc: "James E.J. Bottomley" > >> Signed-off-by: Paul Gortmaker > > However, if we do this we're removing support for any non-PCI based > adapters. I personally doubt that there are any installations left > running on (E)ISA or VLB. But we should be clear on this. Actually, that's not true: the aic7xxx driver has support for EISA (I know because I've got one) but not the VLB and some of the really old cards. > In general I'm in favour removing obsolete drivers, so OK, so do we have any real evidence that no-one uses this driver? Does any distro actually compile it, for instance? James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On Tue, 2013-09-17 at 16:29 +0200, Hannes Reinecke wrote: > On 09/17/2013 04:13 AM, Doug Ledford wrote: > > Yes, this driver is well past ready to be removed. > > > > Acked-by: Doug Ledford > > > > Sent from my ASUS Pad > > > > Paul Gortmaker wrote: > > > >> After getting warnings in an allyesconfig build[1] from this > >> driver, I decided to remind myself just how old it was, and > >> whether it warranted fixing. In the Kconfig help text, I found: > >> > >> "This driver will eventually be phased out entirely" > >> > >> Going back to the history archive, I see the line was added[2] > >> in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2 > >> > >> So, with over a decade of notification, and multiple major releases > >> since then, I think we can justify removing this. Currently we have > >> people wasting time building it during routine testing, and then > >> wasting more time re-researching the known reported warnings, only to > >> find that nobody really is willing to integrate the fixes[3] for it. > >> > >> A quick search didn't seem to indicate any active user base for it. > >> If someone happens to have a quirky _old_ card that the eleven year > >> old "new" driver doesn't work with, then it is entirely reasonable > >> that they stick with a kernel version that predates this removal. > >> > >> [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: > >>drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in > >> enumerated type ‘ahc_chip’ [-Wswitch] > >>drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in > >> enumerated type ‘ahc_chip’ [-Wswitch] > >>drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: > >>drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in > >> enumerated type ‘ahc_chip’ [-Wswitch] > >>drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in > >> enumerated type ‘ahc_chip’ [-Wswitch] > >> > >> [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit > >> 44e8778c > >> > >> [3] https://lkml.org/lkml/2012/10/29/215 > >> > >> Cc: Hannes Reinecke > >> Cc: Doug Ledford > >> Cc: "James E.J. Bottomley" > >> Signed-off-by: Paul Gortmaker > > However, if we do this we're removing support for any non-PCI based > adapters. I personally doubt that there are any installations left > running on (E)ISA or VLB. But we should be clear on this. Actually, that's not true: the aic7xxx driver has support for EISA (I know because I've got one) but not the VLB and some of the really old cards. > In general I'm in favour removing obsolete drivers, so OK, so do we have any real evidence that no-one uses this driver? Does any distro actually compile it, for instance? James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: scsi: delete decade+ obsolete aic7xxx_old driver
On Mon, 2013-09-16 at 21:51 -0400, Paul Gortmaker wrote: > Currently we have people wasting time building it during routine testing, > and then wasting more time re-researching the known reported warnings, > only to find that nobody really is willing to integrate the fixes[3] for > it. > >[...] > > [3] https://lkml.org/lkml/2012/10/29/215 Well, this didn't end up as an entire waste of my time. After that message I sent a patch to Fedora's kernel list, and a reminder a few months later[1]. That prompted Josh Boyer to remove this old driver from the Fedora build[2]. And now that driver is disabled in all kernels that Fedora currently ships. I'm not familiar with any complaints about this decision. Paul Bolle [1] https://lists.fedoraproject.org/pipermail/kernel/2013-February/004102.html [2] http://pkgs.fedoraproject.org/cgit/kernel.git/commit/?id=2192022f4bf13b30e389e77170da7ae08fd28ecf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On 13-09-17 10:29 AM, Hannes Reinecke wrote: > On 09/17/2013 04:13 AM, Doug Ledford wrote: >> Yes, this driver is well past ready to be removed. >> >> Acked-by: Doug Ledford >> >> Sent from my ASUS Pad >> >> Paul Gortmaker wrote: >> >>> After getting warnings in an allyesconfig build[1] from this >>> driver, I decided to remind myself just how old it was, and >>> whether it warranted fixing. In the Kconfig help text, I found: >>> >>> "This driver will eventually be phased out entirely" >>> >>> Going back to the history archive, I see the line was added[2] >>> in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2 >>> >>> So, with over a decade of notification, and multiple major releases >>> since then, I think we can justify removing this. Currently we have >>> people wasting time building it during routine testing, and then >>> wasting more time re-researching the known reported warnings, only to >>> find that nobody really is willing to integrate the fixes[3] for it. >>> >>> A quick search didn't seem to indicate any active user base for it. >>> If someone happens to have a quirky _old_ card that the eleven year >>> old "new" driver doesn't work with, then it is entirely reasonable >>> that they stick with a kernel version that predates this removal. >>> >>> [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: >>>drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in >>> enumerated type ‘ahc_chip’ [-Wswitch] >>>drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in >>> enumerated type ‘ahc_chip’ [-Wswitch] >>>drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: >>>drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in >>> enumerated type ‘ahc_chip’ [-Wswitch] >>>drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in >>> enumerated type ‘ahc_chip’ [-Wswitch] >>> >>> [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit >>> 44e8778c >>> >>> [3] https://lkml.org/lkml/2012/10/29/215 >>> >>> Cc: Hannes Reinecke >>> Cc: Doug Ledford >>> Cc: "James E.J. Bottomley" >>> Signed-off-by: Paul Gortmaker > > However, if we do this we're removing support for any non-PCI based > adapters. I personally doubt that there are any installations left > running on (E)ISA or VLB. But we should be clear on this. Is the Kconfig text for the "new" driver wrong then? It says: - config SCSI_AIC7XXX tristate "Adaptec AIC7xxx Fast -> U160 support (New Driver)" depends on (PCI || EISA) && SCSI select SCSI_SPI_ATTRS ---help--- This driver supports all of Adaptec's Fast through Ultra 160 PCI based SCSI controllers as well as the aic7770 based EISA and VLB SCSI controllers (the 274x and 284x series). - So, as long as you'd enabled either of PCI or EISA, a VLB card should work too. (Of course you are correct in doubting that anyone is genuinely using a 486 VLB system with ~16MB RAM, so it is largely a moot point.) [I probably could delete that "(New Driver)" text as part of this commit too]. Thanks, Paul. -- > > In general I'm in favour removing obsolete drivers, so > > Acked-by: Hannes Reinecke > > Cheers, > > Hannes > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On 09/17/2013 04:13 AM, Doug Ledford wrote: > Yes, this driver is well past ready to be removed. > > Acked-by: Doug Ledford > > Sent from my ASUS Pad > > Paul Gortmaker wrote: > >> After getting warnings in an allyesconfig build[1] from this >> driver, I decided to remind myself just how old it was, and >> whether it warranted fixing. In the Kconfig help text, I found: >> >> "This driver will eventually be phased out entirely" >> >> Going back to the history archive, I see the line was added[2] >> in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2 >> >> So, with over a decade of notification, and multiple major releases >> since then, I think we can justify removing this. Currently we have >> people wasting time building it during routine testing, and then >> wasting more time re-researching the known reported warnings, only to >> find that nobody really is willing to integrate the fixes[3] for it. >> >> A quick search didn't seem to indicate any active user base for it. >> If someone happens to have a quirky _old_ card that the eleven year >> old "new" driver doesn't work with, then it is entirely reasonable >> that they stick with a kernel version that predates this removal. >> >> [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: >>drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in >> enumerated type ‘ahc_chip’ [-Wswitch] >>drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in >> enumerated type ‘ahc_chip’ [-Wswitch] >>drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: >>drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in >> enumerated type ‘ahc_chip’ [-Wswitch] >>drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in >> enumerated type ‘ahc_chip’ [-Wswitch] >> >> [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit >> 44e8778c >> >> [3] https://lkml.org/lkml/2012/10/29/215 >> >> Cc: Hannes Reinecke >> Cc: Doug Ledford >> Cc: "James E.J. Bottomley" >> Signed-off-by: Paul Gortmaker However, if we do this we're removing support for any non-PCI based adapters. I personally doubt that there are any installations left running on (E)ISA or VLB. But we should be clear on this. In general I'm in favour removing obsolete drivers, so Acked-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On 09/17/2013 04:13 AM, Doug Ledford wrote: Yes, this driver is well past ready to be removed. Acked-by: Doug Ledford dledf...@redhat.com Sent from my ASUS Pad Paul Gortmaker paul.gortma...@windriver.com wrote: After getting warnings in an allyesconfig build[1] from this driver, I decided to remind myself just how old it was, and whether it warranted fixing. In the Kconfig help text, I found: This driver will eventually be phased out entirely Going back to the history archive, I see the line was added[2] in Feb 2002, when we moved from v2.4.2.1 --- v2.4.2.2 So, with over a decade of notification, and multiple major releases since then, I think we can justify removing this. Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. A quick search didn't seem to indicate any active user base for it. If someone happens to have a quirky _old_ card that the eleven year old new driver doesn't work with, then it is entirely reasonable that they stick with a kernel version that predates this removal. [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c [3] https://lkml.org/lkml/2012/10/29/215 Cc: Hannes Reinecke h...@suse.de Cc: Doug Ledford dledf...@redhat.com Cc: James E.J. Bottomley jbottom...@parallels.com Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com However, if we do this we're removing support for any non-PCI based adapters. I personally doubt that there are any installations left running on (E)ISA or VLB. But we should be clear on this. In general I'm in favour removing obsolete drivers, so Acked-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On 13-09-17 10:29 AM, Hannes Reinecke wrote: On 09/17/2013 04:13 AM, Doug Ledford wrote: Yes, this driver is well past ready to be removed. Acked-by: Doug Ledford dledf...@redhat.com Sent from my ASUS Pad Paul Gortmaker paul.gortma...@windriver.com wrote: After getting warnings in an allyesconfig build[1] from this driver, I decided to remind myself just how old it was, and whether it warranted fixing. In the Kconfig help text, I found: This driver will eventually be phased out entirely Going back to the history archive, I see the line was added[2] in Feb 2002, when we moved from v2.4.2.1 --- v2.4.2.2 So, with over a decade of notification, and multiple major releases since then, I think we can justify removing this. Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. A quick search didn't seem to indicate any active user base for it. If someone happens to have a quirky _old_ card that the eleven year old new driver doesn't work with, then it is entirely reasonable that they stick with a kernel version that predates this removal. [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c [3] https://lkml.org/lkml/2012/10/29/215 Cc: Hannes Reinecke h...@suse.de Cc: Doug Ledford dledf...@redhat.com Cc: James E.J. Bottomley jbottom...@parallels.com Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com However, if we do this we're removing support for any non-PCI based adapters. I personally doubt that there are any installations left running on (E)ISA or VLB. But we should be clear on this. Is the Kconfig text for the new driver wrong then? It says: - config SCSI_AIC7XXX tristate Adaptec AIC7xxx Fast - U160 support (New Driver) depends on (PCI || EISA) SCSI select SCSI_SPI_ATTRS ---help--- This driver supports all of Adaptec's Fast through Ultra 160 PCI based SCSI controllers as well as the aic7770 based EISA and VLB SCSI controllers (the 274x and 284x series). - So, as long as you'd enabled either of PCI or EISA, a VLB card should work too. (Of course you are correct in doubting that anyone is genuinely using a 486 VLB system with ~16MB RAM, so it is largely a moot point.) [I probably could delete that (New Driver) text as part of this commit too]. Thanks, Paul. -- In general I'm in favour removing obsolete drivers, so Acked-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: scsi: delete decade+ obsolete aic7xxx_old driver
On Mon, 2013-09-16 at 21:51 -0400, Paul Gortmaker wrote: Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. [...] [3] https://lkml.org/lkml/2012/10/29/215 Well, this didn't end up as an entire waste of my time. After that message I sent a patch to Fedora's kernel list, and a reminder a few months later[1]. That prompted Josh Boyer to remove this old driver from the Fedora build[2]. And now that driver is disabled in all kernels that Fedora currently ships. I'm not familiar with any complaints about this decision. Paul Bolle [1] https://lists.fedoraproject.org/pipermail/kernel/2013-February/004102.html [2] http://pkgs.fedoraproject.org/cgit/kernel.git/commit/?id=2192022f4bf13b30e389e77170da7ae08fd28ecf -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On Tue, 2013-09-17 at 16:29 +0200, Hannes Reinecke wrote: On 09/17/2013 04:13 AM, Doug Ledford wrote: Yes, this driver is well past ready to be removed. Acked-by: Doug Ledford dledf...@redhat.com Sent from my ASUS Pad Paul Gortmaker paul.gortma...@windriver.com wrote: After getting warnings in an allyesconfig build[1] from this driver, I decided to remind myself just how old it was, and whether it warranted fixing. In the Kconfig help text, I found: This driver will eventually be phased out entirely Going back to the history archive, I see the line was added[2] in Feb 2002, when we moved from v2.4.2.1 --- v2.4.2.2 So, with over a decade of notification, and multiple major releases since then, I think we can justify removing this. Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. A quick search didn't seem to indicate any active user base for it. If someone happens to have a quirky _old_ card that the eleven year old new driver doesn't work with, then it is entirely reasonable that they stick with a kernel version that predates this removal. [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c [3] https://lkml.org/lkml/2012/10/29/215 Cc: Hannes Reinecke h...@suse.de Cc: Doug Ledford dledf...@redhat.com Cc: James E.J. Bottomley jbottom...@parallels.com Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com However, if we do this we're removing support for any non-PCI based adapters. I personally doubt that there are any installations left running on (E)ISA or VLB. But we should be clear on this. Actually, that's not true: the aic7xxx driver has support for EISA (I know because I've got one) but not the VLB and some of the really old cards. In general I'm in favour removing obsolete drivers, so OK, so do we have any real evidence that no-one uses this driver? Does any distro actually compile it, for instance? James -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On Tue, 2013-09-17 at 16:29 +0200, Hannes Reinecke wrote: On 09/17/2013 04:13 AM, Doug Ledford wrote: Yes, this driver is well past ready to be removed. Acked-by: Doug Ledford dledf...@redhat.com Sent from my ASUS Pad Paul Gortmaker paul.gortma...@windriver.com wrote: After getting warnings in an allyesconfig build[1] from this driver, I decided to remind myself just how old it was, and whether it warranted fixing. In the Kconfig help text, I found: This driver will eventually be phased out entirely Going back to the history archive, I see the line was added[2] in Feb 2002, when we moved from v2.4.2.1 --- v2.4.2.2 So, with over a decade of notification, and multiple major releases since then, I think we can justify removing this. Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. A quick search didn't seem to indicate any active user base for it. If someone happens to have a quirky _old_ card that the eleven year old new driver doesn't work with, then it is entirely reasonable that they stick with a kernel version that predates this removal. [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c [3] https://lkml.org/lkml/2012/10/29/215 Cc: Hannes Reinecke h...@suse.de Cc: Doug Ledford dledf...@redhat.com Cc: James E.J. Bottomley jbottom...@parallels.com Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com However, if we do this we're removing support for any non-PCI based adapters. I personally doubt that there are any installations left running on (E)ISA or VLB. But we should be clear on this. Actually, that's not true: the aic7xxx driver has support for EISA (I know because I've got one) but not the VLB and some of the really old cards. In general I'm in favour removing obsolete drivers, so OK, so do we have any real evidence that no-one uses this driver? Does any distro actually compile it, for instance? James -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
On 09/17/13 16:10, James Bottomley wrote: OK, so do we have any real evidence that no-one uses this driver? Does any distro actually compile it, for instance? Red Hat doesn't use it in any of their products (and it hasn't been the preferred driver since about the old Red Hat Linux 7.0 days). -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
[Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver] On 17/09/2013 (Tue 16:27) Doug Ledford wrote: On 09/17/13 16:10, James Bottomley wrote: OK, so do we have any real evidence that no-one uses this driver? Does any distro actually compile it, for instance? Red Hat doesn't use it in any of their products (and it hasn't been the preferred driver since about the old Red Hat Linux 7.0 days). The oldest ubuntu machine I could find was running a 2.6.32 kernel and even back then, they weren't building/enabling this driver either. Paul. -- -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: scsi: delete decade+ obsolete aic7xxx_old driver
On 09/17/2013 08:27 PM, Paul Bolle wrote: On Mon, 2013-09-16 at 21:51 -0400, Paul Gortmaker wrote: Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. [...] [3] https://lkml.org/lkml/2012/10/29/215 Well, this didn't end up as an entire waste of my time. After that message I sent a patch to Fedora's kernel list, and a reminder a few months later[1]. That prompted Josh Boyer to remove this old driver from the Fedora build[2]. And now that driver is disabled in all kernels that Fedora currently ships. I'm not familiar with any complaints about this decision. Ok, good to know. So this patch appears to be good, then. Acked-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
Yes, this driver is well past ready to be removed. Acked-by: Doug Ledford Sent from my ASUS Pad Paul Gortmaker wrote: >After getting warnings in an allyesconfig build[1] from this >driver, I decided to remind myself just how old it was, and >whether it warranted fixing. In the Kconfig help text, I found: > > "This driver will eventually be phased out entirely" > >Going back to the history archive, I see the line was added[2] >in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2 > >So, with over a decade of notification, and multiple major releases >since then, I think we can justify removing this. Currently we have >people wasting time building it during routine testing, and then >wasting more time re-researching the known reported warnings, only to >find that nobody really is willing to integrate the fixes[3] for it. > >A quick search didn't seem to indicate any active user base for it. >If someone happens to have a quirky _old_ card that the eleven year >old "new" driver doesn't work with, then it is entirely reasonable >that they stick with a kernel version that predates this removal. > >[1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: >drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in > enumerated type ‘ahc_chip’ [-Wswitch] >drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in > enumerated type ‘ahc_chip’ [-Wswitch] >drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: >drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in > enumerated type ‘ahc_chip’ [-Wswitch] >drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in > enumerated type ‘ahc_chip’ [-Wswitch] > >[2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit >44e8778c > >[3] https://lkml.org/lkml/2012/10/29/215 > >Cc: Hannes Reinecke >Cc: Doug Ledford >Cc: "James E.J. Bottomley" >Signed-off-by: Paul Gortmaker >--- > >[This is an "--irreversible-delete" pseudo-patch which doesn't show all >the file content that was deleted wholesale. The full commit is at: >git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git aic7xxx-delete ] > > Documentation/scsi/00-INDEX | 2 - > Documentation/scsi/aic7xxx_old.txt | 511 -- > MAINTAINERS | 1 - > drivers/scsi/Kconfig|41 - > drivers/scsi/Makefile | 1 - > drivers/scsi/aic7xxx_old.c | 11149 -- > drivers/scsi/aic7xxx_old/aic7xxx.h |28 - > drivers/scsi/aic7xxx_old/aic7xxx.reg| 1401 > drivers/scsi/aic7xxx_old/aic7xxx.seq| 1539 - > drivers/scsi/aic7xxx_old/aic7xxx_proc.c | 270 - > drivers/scsi/aic7xxx_old/aic7xxx_reg.h | 629 -- > drivers/scsi/aic7xxx_old/aic7xxx_seq.c | 817 --- > drivers/scsi/aic7xxx_old/scsi_message.h |49 - > drivers/scsi/aic7xxx_old/sequencer.h| 135 - > 14 files changed, 16573 deletions(-) > delete mode 100644 Documentation/scsi/aic7xxx_old.txt > delete mode 100644 drivers/scsi/aic7xxx_old.c > delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.h > delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.reg > delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.seq > delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_proc.c > delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_reg.h > delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_seq.c > delete mode 100644 drivers/scsi/aic7xxx_old/scsi_message.h > delete mode 100644 drivers/scsi/aic7xxx_old/sequencer.h > >diff --git a/Documentation/scsi/00-INDEX b/Documentation/scsi/00-INDEX >index 9b0787f..2044be5 100644 >--- a/Documentation/scsi/00-INDEX >+++ b/Documentation/scsi/00-INDEX >@@ -42,8 +42,6 @@ aic79xx.txt > - Adaptec Ultra320 SCSI host adapters > aic7xxx.txt > - info on driver for Adaptec controllers >-aic7xxx_old.txt >- - info on driver for Adaptec controllers, old generation > arcmsr_spec.txt > - ARECA FIRMWARE SPEC (for IOP331 adapter) > dc395x.txt >diff --git a/Documentation/scsi/aic7xxx_old.txt >b/Documentation/scsi/aic7xxx_old.txt >deleted file mode 100644 >index ecfc474..000 >diff --git a/MAINTAINERS b/MAINTAINERS >index e61c2e8..c79be42 100644 >--- a/MAINTAINERS >+++ b/MAINTAINERS >@@ -470,7 +470,6 @@ M: Hannes Reinecke > L:linux-s...@vger.kernel.org > S:Maintained > F:drivers/scsi/aic7xxx/ >-F:drivers/scsi/aic7xxx_old/ > > AIMSLAB FM RADIO RECEIVER DRIVER > M:Hans Verkuil >diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig >index fe25677..1f02003 100644 >--- a/drivers/scsi/Kconfig >+++ b/drivers/scsi/Kconfig >@@ -499,47 +499,6 @@ config SCSI_AACRAID > > > source "drivers/scsi/aic7xxx/Kconfig.aic7xxx" >- >-config SCSI_AIC7XXX_OLD >- tristate "Adaptec AIC7xxx support (old driver)" >- depends on (ISA || EISA || PCI ) && SCSI >- help >-WARNING This driver is an older aic7xxx driver and is no longer >-under active
[PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
After getting warnings in an allyesconfig build[1] from this driver, I decided to remind myself just how old it was, and whether it warranted fixing. In the Kconfig help text, I found: "This driver will eventually be phased out entirely" Going back to the history archive, I see the line was added[2] in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2 So, with over a decade of notification, and multiple major releases since then, I think we can justify removing this. Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. A quick search didn't seem to indicate any active user base for it. If someone happens to have a quirky _old_ card that the eleven year old "new" driver doesn't work with, then it is entirely reasonable that they stick with a kernel version that predates this removal. [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c [3] https://lkml.org/lkml/2012/10/29/215 Cc: Hannes Reinecke Cc: Doug Ledford Cc: "James E.J. Bottomley" Signed-off-by: Paul Gortmaker --- [This is an "--irreversible-delete" pseudo-patch which doesn't show all the file content that was deleted wholesale. The full commit is at: git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git aic7xxx-delete ] Documentation/scsi/00-INDEX | 2 - Documentation/scsi/aic7xxx_old.txt | 511 -- MAINTAINERS | 1 - drivers/scsi/Kconfig|41 - drivers/scsi/Makefile | 1 - drivers/scsi/aic7xxx_old.c | 11149 -- drivers/scsi/aic7xxx_old/aic7xxx.h |28 - drivers/scsi/aic7xxx_old/aic7xxx.reg| 1401 drivers/scsi/aic7xxx_old/aic7xxx.seq| 1539 - drivers/scsi/aic7xxx_old/aic7xxx_proc.c | 270 - drivers/scsi/aic7xxx_old/aic7xxx_reg.h | 629 -- drivers/scsi/aic7xxx_old/aic7xxx_seq.c | 817 --- drivers/scsi/aic7xxx_old/scsi_message.h |49 - drivers/scsi/aic7xxx_old/sequencer.h| 135 - 14 files changed, 16573 deletions(-) delete mode 100644 Documentation/scsi/aic7xxx_old.txt delete mode 100644 drivers/scsi/aic7xxx_old.c delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.h delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.reg delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.seq delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_proc.c delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_reg.h delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_seq.c delete mode 100644 drivers/scsi/aic7xxx_old/scsi_message.h delete mode 100644 drivers/scsi/aic7xxx_old/sequencer.h diff --git a/Documentation/scsi/00-INDEX b/Documentation/scsi/00-INDEX index 9b0787f..2044be5 100644 --- a/Documentation/scsi/00-INDEX +++ b/Documentation/scsi/00-INDEX @@ -42,8 +42,6 @@ aic79xx.txt - Adaptec Ultra320 SCSI host adapters aic7xxx.txt - info on driver for Adaptec controllers -aic7xxx_old.txt - - info on driver for Adaptec controllers, old generation arcmsr_spec.txt - ARECA FIRMWARE SPEC (for IOP331 adapter) dc395x.txt diff --git a/Documentation/scsi/aic7xxx_old.txt b/Documentation/scsi/aic7xxx_old.txt deleted file mode 100644 index ecfc474..000 diff --git a/MAINTAINERS b/MAINTAINERS index e61c2e8..c79be42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -470,7 +470,6 @@ M: Hannes Reinecke L: linux-s...@vger.kernel.org S: Maintained F: drivers/scsi/aic7xxx/ -F: drivers/scsi/aic7xxx_old/ AIMSLAB FM RADIO RECEIVER DRIVER M: Hans Verkuil diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index fe25677..1f02003 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -499,47 +499,6 @@ config SCSI_AACRAID source "drivers/scsi/aic7xxx/Kconfig.aic7xxx" - -config SCSI_AIC7XXX_OLD - tristate "Adaptec AIC7xxx support (old driver)" - depends on (ISA || EISA || PCI ) && SCSI - help - WARNING This driver is an older aic7xxx driver and is no longer - under active development. Adaptec, Inc. is writing a new driver to - take the place of this one, and it is recommended that whenever - possible, people should use the new Adaptec written driver instead - of this one. This
[PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
After getting warnings in an allyesconfig build[1] from this driver, I decided to remind myself just how old it was, and whether it warranted fixing. In the Kconfig help text, I found: This driver will eventually be phased out entirely Going back to the history archive, I see the line was added[2] in Feb 2002, when we moved from v2.4.2.1 --- v2.4.2.2 So, with over a decade of notification, and multiple major releases since then, I think we can justify removing this. Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. A quick search didn't seem to indicate any active user base for it. If someone happens to have a quirky _old_ card that the eleven year old new driver doesn't work with, then it is entirely reasonable that they stick with a kernel version that predates this removal. [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c [3] https://lkml.org/lkml/2012/10/29/215 Cc: Hannes Reinecke h...@suse.de Cc: Doug Ledford dledf...@redhat.com Cc: James E.J. Bottomley jbottom...@parallels.com Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com --- [This is an --irreversible-delete pseudo-patch which doesn't show all the file content that was deleted wholesale. The full commit is at: git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git aic7xxx-delete ] Documentation/scsi/00-INDEX | 2 - Documentation/scsi/aic7xxx_old.txt | 511 -- MAINTAINERS | 1 - drivers/scsi/Kconfig|41 - drivers/scsi/Makefile | 1 - drivers/scsi/aic7xxx_old.c | 11149 -- drivers/scsi/aic7xxx_old/aic7xxx.h |28 - drivers/scsi/aic7xxx_old/aic7xxx.reg| 1401 drivers/scsi/aic7xxx_old/aic7xxx.seq| 1539 - drivers/scsi/aic7xxx_old/aic7xxx_proc.c | 270 - drivers/scsi/aic7xxx_old/aic7xxx_reg.h | 629 -- drivers/scsi/aic7xxx_old/aic7xxx_seq.c | 817 --- drivers/scsi/aic7xxx_old/scsi_message.h |49 - drivers/scsi/aic7xxx_old/sequencer.h| 135 - 14 files changed, 16573 deletions(-) delete mode 100644 Documentation/scsi/aic7xxx_old.txt delete mode 100644 drivers/scsi/aic7xxx_old.c delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.h delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.reg delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.seq delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_proc.c delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_reg.h delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_seq.c delete mode 100644 drivers/scsi/aic7xxx_old/scsi_message.h delete mode 100644 drivers/scsi/aic7xxx_old/sequencer.h diff --git a/Documentation/scsi/00-INDEX b/Documentation/scsi/00-INDEX index 9b0787f..2044be5 100644 --- a/Documentation/scsi/00-INDEX +++ b/Documentation/scsi/00-INDEX @@ -42,8 +42,6 @@ aic79xx.txt - Adaptec Ultra320 SCSI host adapters aic7xxx.txt - info on driver for Adaptec controllers -aic7xxx_old.txt - - info on driver for Adaptec controllers, old generation arcmsr_spec.txt - ARECA FIRMWARE SPEC (for IOP331 adapter) dc395x.txt diff --git a/Documentation/scsi/aic7xxx_old.txt b/Documentation/scsi/aic7xxx_old.txt deleted file mode 100644 index ecfc474..000 diff --git a/MAINTAINERS b/MAINTAINERS index e61c2e8..c79be42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -470,7 +470,6 @@ M: Hannes Reinecke h...@suse.de L: linux-s...@vger.kernel.org S: Maintained F: drivers/scsi/aic7xxx/ -F: drivers/scsi/aic7xxx_old/ AIMSLAB FM RADIO RECEIVER DRIVER M: Hans Verkuil hverk...@xs4all.nl diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index fe25677..1f02003 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -499,47 +499,6 @@ config SCSI_AACRAID source drivers/scsi/aic7xxx/Kconfig.aic7xxx - -config SCSI_AIC7XXX_OLD - tristate Adaptec AIC7xxx support (old driver) - depends on (ISA || EISA || PCI ) SCSI - help - WARNING This driver is an older aic7xxx driver and is no longer - under active development. Adaptec, Inc. is writing a new driver to - take the place of this one, and it is recommended that whenever -
Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver
Yes, this driver is well past ready to be removed. Acked-by: Doug Ledford dledf...@redhat.com Sent from my ASUS Pad Paul Gortmaker paul.gortma...@windriver.com wrote: After getting warnings in an allyesconfig build[1] from this driver, I decided to remind myself just how old it was, and whether it warranted fixing. In the Kconfig help text, I found: This driver will eventually be phased out entirely Going back to the history archive, I see the line was added[2] in Feb 2002, when we moved from v2.4.2.1 --- v2.4.2.2 So, with over a decade of notification, and multiple major releases since then, I think we can justify removing this. Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it. A quick search didn't seem to indicate any active user base for it. If someone happens to have a quirky _old_ card that the eleven year old new driver doesn't work with, then it is entirely reasonable that they stick with a kernel version that predates this removal. [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c [3] https://lkml.org/lkml/2012/10/29/215 Cc: Hannes Reinecke h...@suse.de Cc: Doug Ledford dledf...@redhat.com Cc: James E.J. Bottomley jbottom...@parallels.com Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com --- [This is an --irreversible-delete pseudo-patch which doesn't show all the file content that was deleted wholesale. The full commit is at: git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git aic7xxx-delete ] Documentation/scsi/00-INDEX | 2 - Documentation/scsi/aic7xxx_old.txt | 511 -- MAINTAINERS | 1 - drivers/scsi/Kconfig|41 - drivers/scsi/Makefile | 1 - drivers/scsi/aic7xxx_old.c | 11149 -- drivers/scsi/aic7xxx_old/aic7xxx.h |28 - drivers/scsi/aic7xxx_old/aic7xxx.reg| 1401 drivers/scsi/aic7xxx_old/aic7xxx.seq| 1539 - drivers/scsi/aic7xxx_old/aic7xxx_proc.c | 270 - drivers/scsi/aic7xxx_old/aic7xxx_reg.h | 629 -- drivers/scsi/aic7xxx_old/aic7xxx_seq.c | 817 --- drivers/scsi/aic7xxx_old/scsi_message.h |49 - drivers/scsi/aic7xxx_old/sequencer.h| 135 - 14 files changed, 16573 deletions(-) delete mode 100644 Documentation/scsi/aic7xxx_old.txt delete mode 100644 drivers/scsi/aic7xxx_old.c delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.h delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.reg delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.seq delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_proc.c delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_reg.h delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_seq.c delete mode 100644 drivers/scsi/aic7xxx_old/scsi_message.h delete mode 100644 drivers/scsi/aic7xxx_old/sequencer.h diff --git a/Documentation/scsi/00-INDEX b/Documentation/scsi/00-INDEX index 9b0787f..2044be5 100644 --- a/Documentation/scsi/00-INDEX +++ b/Documentation/scsi/00-INDEX @@ -42,8 +42,6 @@ aic79xx.txt - Adaptec Ultra320 SCSI host adapters aic7xxx.txt - info on driver for Adaptec controllers -aic7xxx_old.txt - - info on driver for Adaptec controllers, old generation arcmsr_spec.txt - ARECA FIRMWARE SPEC (for IOP331 adapter) dc395x.txt diff --git a/Documentation/scsi/aic7xxx_old.txt b/Documentation/scsi/aic7xxx_old.txt deleted file mode 100644 index ecfc474..000 diff --git a/MAINTAINERS b/MAINTAINERS index e61c2e8..c79be42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -470,7 +470,6 @@ M: Hannes Reinecke h...@suse.de L:linux-s...@vger.kernel.org S:Maintained F:drivers/scsi/aic7xxx/ -F:drivers/scsi/aic7xxx_old/ AIMSLAB FM RADIO RECEIVER DRIVER M:Hans Verkuil hverk...@xs4all.nl diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index fe25677..1f02003 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -499,47 +499,6 @@ config SCSI_AACRAID source drivers/scsi/aic7xxx/Kconfig.aic7xxx - -config SCSI_AIC7XXX_OLD - tristate Adaptec AIC7xxx support (old driver) - depends on (ISA || EISA || PCI ) SCSI - help -WARNING This driver is an older aic7xxx driver and is no longer -
