Re: v2.6.23-rc4-rt1 / new project URL

2007-09-26 Thread Steven Rostedt

--

On Wed, 26 Sep 2007, Peter Zijlstra wrote:

> On Mon, 2007-09-10 at 14:35 +0200, Peter Zijlstra wrote:
> > > A bunch of patches are postponed for -rt2 (they are neither ignored
> > > nor forgotten):
> > >
> > > - simple_irq change (Kevin Hilman): needs more thought
> > > - RCU updates (Paul McKenney): needs proper integration
> > > - latency tracer changes (Daniel Walker): needs review
> > > - PICK_OP changes (Daniel Walker): needs review
> >
> > This one seems to have slipped through the cracks:
> >   http://lkml.org/lkml/2007/8/16/135
>
> Seems to be missed again :-/
>

Will work on that tonight.

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-09-26 Thread Peter Zijlstra
Steve, 

On Mon, 2007-09-10 at 14:35 +0200, Peter Zijlstra wrote:
> On Fri, 2007-08-31 at 22:59 +0200, Thomas Gleixner wrote:
> > We're pleased to announce the release of the v2.6.23-rc4-rt1 kernel,
> > which can be downloaded from a new place:
> >  
> >http://www.kernel.org/pub/linux/kernel/projects/rt/
> >  
> > The move to kernel.org is experimental for now, we'll keep it if it
> > works out fine.
> > 
> > Changes since 2.6.23-rc2-rt2:
> > 
> > - update to -rc4
> > - update to 2.6.23-rc4-hrt1
> > 
> > - UP compile fixes back merged (Kevin Hilman / Steven Rostedt)
> > - various latency tracer fixes (Steven Rostedt)
> > - softirq migration fixes (Steven Rostedt)
> > - ARM futex cmpxchg in atomic support (Khem Raj)
> > - ARM raw lock fix (Kevin Hilman)
> > - loadavgrt fix (Luis Claudio R. Goncalves)
> > - mellanox driver fix (Michael S. Tsirkin)
> > 
> > A bunch of patches are postponed for -rt2 (they are neither ignored
> > nor forgotten):
> > 
> > - simple_irq change (Kevin Hilman): needs more thought
> > - RCU updates (Paul McKenney): needs proper integration
> > - latency tracer changes (Daniel Walker): needs review
> > - PICK_OP changes (Daniel Walker): needs review
> 
> This one seems to have slipped through the cracks:
>   http://lkml.org/lkml/2007/8/16/135

Seems to be missed again :-/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-09-10 Thread Peter Zijlstra
On Mon, 2007-09-10 at 08:18 -0700, Daniel Walker wrote:
> On Mon, 2007-09-10 at 14:35 +0200, Peter Zijlstra wrote:
> 
> > > - simple_irq change (Kevin Hilman): needs more thought
> > > - RCU updates (Paul McKenney): needs proper integration
> > > - latency tracer changes (Daniel Walker): needs review
> > > - PICK_OP changes (Daniel Walker): needs review
> > 
> > This one seems to have slipped through the cracks:
> >   http://lkml.org/lkml/2007/8/16/135
> 
> There was a comment in this patch that reads,
> 
> + /*
> +  * all modifications are done under spinlocks
> +  * but this read is not, the unlock acks as a wmb
> +  * for modifications.
> +  */
> 
> I you mean "acts" (like an actor) instead of "acks" here right?

ah, indeed :-) sometimes my fingers have a life of their own.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-09-10 Thread Daniel Walker
On Mon, 2007-09-10 at 14:35 +0200, Peter Zijlstra wrote:

> > - simple_irq change (Kevin Hilman): needs more thought
> > - RCU updates (Paul McKenney): needs proper integration
> > - latency tracer changes (Daniel Walker): needs review
> > - PICK_OP changes (Daniel Walker): needs review
> 
> This one seems to have slipped through the cracks:
>   http://lkml.org/lkml/2007/8/16/135

There was a comment in this patch that reads,

+   /*
+* all modifications are done under spinlocks
+* but this read is not, the unlock acks as a wmb
+* for modifications.
+*/

I you mean "acts" (like an actor) instead of "acks" here right?

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-09-10 Thread Peter Zijlstra
On Fri, 2007-08-31 at 22:59 +0200, Thomas Gleixner wrote:
> We're pleased to announce the release of the v2.6.23-rc4-rt1 kernel,
> which can be downloaded from a new place:
>  
>http://www.kernel.org/pub/linux/kernel/projects/rt/
>  
> The move to kernel.org is experimental for now, we'll keep it if it
> works out fine.
> 
> Changes since 2.6.23-rc2-rt2:
> 
> - update to -rc4
> - update to 2.6.23-rc4-hrt1
> 
> - UP compile fixes back merged (Kevin Hilman / Steven Rostedt)
> - various latency tracer fixes (Steven Rostedt)
> - softirq migration fixes (Steven Rostedt)
> - ARM futex cmpxchg in atomic support (Khem Raj)
> - ARM raw lock fix (Kevin Hilman)
> - loadavgrt fix (Luis Claudio R. Goncalves)
> - mellanox driver fix (Michael S. Tsirkin)
> 
> A bunch of patches are postponed for -rt2 (they are neither ignored
> nor forgotten):
> 
> - simple_irq change (Kevin Hilman): needs more thought
> - RCU updates (Paul McKenney): needs proper integration
> - latency tracer changes (Daniel Walker): needs review
> - PICK_OP changes (Daniel Walker): needs review

This one seems to have slipped through the cracks:
  http://lkml.org/lkml/2007/8/16/135


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-09-02 Thread Steven Rostedt

On Sat, 1 Sep 2007, Thomas Gleixner wrote:

> On Fri, 2007-08-31 at 17:01 -0700, Daniel Walker wrote:
> >
> > I'm not sure which latency tracing fixes these are, but Steven's
> > get_monotonic_cycles() changes are racy .. It might be a little
> > premature to include them .. It at least fouls latency tracing on my
> > test machine.
>
> Worked fine here, but I take it out again when it causes problems on
> your box. Steven ???

Yeah, I talked with Daniel too about it. I need to look more into it.
I haven't had time since I'm spending the weekend (Monday too, since it's
a holiday in the US), moving to my new house.

There is a race, but honestly, it will be a merical to happen, and if it
does, it only gives the results that we had "before" the patches ;-)

But take them out, until I get to the bottom of them. But that won't be
until "earliest" Tuesday.

Thanks,

-- Steve
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-09-01 Thread Daniel Walker
On Fri, 2007-08-31 at 22:59 +0200, Thomas Gleixner wrote:

> - loadavgrt fix (Luis Claudio R. Goncalves)

Sven caught that this patch was broken, I think there is an updated
one.. It's also breaking !PREEMPT_RT compiles..

 dwalker2/140 failed
kernel/timer.c: In function 'calc_load':
kernel/timer.c:962: error: implicit declaration of function 
'count_active_rt_tasks'
make[1]: *** [kernel/timer.o] Error 1


Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-09-01 Thread Daniel Walker
On Sat, 2007-09-01 at 09:27 +0200, Thomas Gleixner wrote:

> 
> Yeah, I know. Still I wanted to go through it myself.
> 

Ok,

Here are some other trivial fixes,

http://lkml.org/lkml/2007/8/28/331
http://lkml.org/lkml/2007/8/28/334

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-09-01 Thread Thomas Gleixner
On Fri, 2007-08-31 at 17:01 -0700, Daniel Walker wrote:
> > - UP compile fixes back merged (Kevin Hilman / Steven Rostedt)
> > - various latency tracer fixes (Steven Rostedt)
> 
> I'm not sure which latency tracing fixes these are, but Steven's
> get_monotonic_cycles() changes are racy .. It might be a little
> premature to include them .. It at least fouls latency tracing on my
> test machine.

Worked fine here, but I take it out again when it causes problems on
your box. Steven ???

> > - simple_irq change (Kevin Hilman): needs more thought
> > - RCU updates (Paul McKenney): needs proper integration
> > - latency tracer changes (Daniel Walker): needs review
> > - PICK_OP changes (Daniel Walker): needs review
> 
> The PICK_OP changes got reviewed by Ingo , as of,
> 
> http://marc.info/?l=linux-rt-users&m=118638506125380&w=2

Yeah, I know. Still I wanted to go through it myself.

> They do need one small fix tho .. Below ..

Sigh.

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: v2.6.23-rc4-rt1 / new project URL

2007-08-31 Thread Daniel Walker
On Fri, 2007-08-31 at 22:59 +0200, Thomas Gleixner wrote:
> We're pleased to announce the release of the v2.6.23-rc4-rt1 kernel,
> which can be downloaded from a new place:
>  
>http://www.kernel.org/pub/linux/kernel/projects/rt/
>  
> The move to kernel.org is experimental for now, we'll keep it if it
> works out fine.
> 
> Changes since 2.6.23-rc2-rt2:
> 
> - update to -rc4
> - update to 2.6.23-rc4-hrt1
> 
> - UP compile fixes back merged (Kevin Hilman / Steven Rostedt)
> - various latency tracer fixes (Steven Rostedt)

I'm not sure which latency tracing fixes these are, but Steven's
get_monotonic_cycles() changes are racy .. It might be a little
premature to include them .. It at least fouls latency tracing on my
test machine.

> - simple_irq change (Kevin Hilman): needs more thought
> - RCU updates (Paul McKenney): needs proper integration
> - latency tracer changes (Daniel Walker): needs review
> - PICK_OP changes (Daniel Walker): needs review

The PICK_OP changes got reviewed by Ingo , as of,

http://marc.info/?l=linux-rt-users&m=118638506125380&w=2

They do need one small fix tho .. Below ..

Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>

Index: linux-2.6.22/include/linux/spinlock.h
===
--- linux-2.6.22.orig/include/linux/spinlock.h  2007-09-01 00:08:04.0 
+
+++ linux-2.6.22/include/linux/spinlock.h   2007-09-01 00:07:48.0 
+
@@ -501,7 +501,7 @@ do {
\
 
 #define spin_trylock_irq(lock) \
__cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irq,  \
-   __spin_trylock_irq, lock))
+   _spin_trylock_irq, lock))
 
 #define spin_trylock_irqsave(lock, flags) \
__cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irqsave,  \


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


v2.6.23-rc4-rt1 / new project URL

2007-08-31 Thread Thomas Gleixner
We're pleased to announce the release of the v2.6.23-rc4-rt1 kernel,
which can be downloaded from a new place:
 
   http://www.kernel.org/pub/linux/kernel/projects/rt/
 
The move to kernel.org is experimental for now, we'll keep it if it
works out fine.

Changes since 2.6.23-rc2-rt2:

- update to -rc4
- update to 2.6.23-rc4-hrt1

- UP compile fixes back merged (Kevin Hilman / Steven Rostedt)
- various latency tracer fixes (Steven Rostedt)
- softirq migration fixes (Steven Rostedt)
- ARM futex cmpxchg in atomic support (Khem Raj)
- ARM raw lock fix (Kevin Hilman)
- loadavgrt fix (Luis Claudio R. Goncalves)
- mellanox driver fix (Michael S. Tsirkin)

A bunch of patches are postponed for -rt2 (they are neither ignored
nor forgotten):

- simple_irq change (Kevin Hilman): needs more thought
- RCU updates (Paul McKenney): needs proper integration
- latency tracer changes (Daniel Walker): needs review
- PICK_OP changes (Daniel Walker): needs review


More info about the -rt patch set can be found in the RT wiki:
 
  http://rt.wiki.kernel.org
  
To build a 2.6.23-rc4-rt1 tree, the following patches should be applied:
 
  http://kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.22.tar.bz2
  http://kernel.org/pub/linux/kernel/v2.6/testing/patch-2.6.23-rc4.bz2
  http://kernel.org/pub/linux/kernel/projects/rt/patch-2.6.23-rc4-rt1.bz2

Thomas, Ingo


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/