Re: selftest: net: fcnal-test.sh TIMEOUT
On 06. 01. 2024. 22:02, Mirsad Todorovac wrote: > On 06. 01. 2024. 17:16, David Ahern wrote: >> On 1/5/24 2:41 AM, Mirsad Todorovac wrote: >>> diff --git a/tools/testing/selftests/net/settings >>> b/tools/testing/selftests/net/settings index dfc27cdc6c05..ed8418e8217a >>> 100644 --- a/tools/testing/selftests/net/settings +++ >>> b/tools/testing/selftests/net/settings @@ -1 +1 @@ -timeout=1500 >>> +timeout=3600 >> >> bumping the timeout is fine to me. that script is running a lot of >> permutations. > > Well, aren't bugs best discovered if all cases or permutations are tested? > > I recall some cases with Giullaume and Ido fixing them the last Summer or so. Hi, David, I apologise for my poor understanding of American English phrases. If increasing the timeout value is OK with you, will you guys do it or should I submit the formal patch? Thank you, Mirsad -- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu System engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb, Republic of Croatia The European Union "I see something approaching fast ... Will it be friends with me?"
Re: selftest: net: fcnal-test.sh TIMEOUT
On 06. 01. 2024. 17:16, David Ahern wrote: > On 1/5/24 2:41 AM, Mirsad Todorovac wrote: >> diff --git a/tools/testing/selftests/net/settings >> b/tools/testing/selftests/net/settings index dfc27cdc6c05..ed8418e8217a >> 100644 --- a/tools/testing/selftests/net/settings +++ >> b/tools/testing/selftests/net/settings @@ -1 +1 @@ -timeout=1500 >> +timeout=3600 > > bumping the timeout is fine to me. that script is running a lot of > permutations. Well, aren't bugs best discovered if all cases or permutations are tested? I recall some cases with Giullaume and Ido fixing them the last Summer or so. Thanks. Regards, Mirsad -- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu System engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb, Republic of Croatia The European Union "I see something approaching fast ... Will it be friends with me?"
Re: selftest: net: fcnal-test.sh TIMEOUT
On 1/5/24 2:41 AM, Mirsad Todorovac wrote: > diff --git a/tools/testing/selftests/net/settings > b/tools/testing/selftests/net/settings index dfc27cdc6c05..ed8418e8217a > 100644 --- a/tools/testing/selftests/net/settings +++ > b/tools/testing/selftests/net/settings @@ -1 +1 @@ -timeout=1500 > +timeout=3600 bumping the timeout is fine to me. that script is running a lot of permutations.
selftest: net: fcnal-test.sh TIMEOUT
Hi, all, The default timeout for tools/testing/selftest/net groups of tests is 1500s (25m). This is less than half of what is required to run the full fcnal-test.sh on my hardware (53m48s). With the timeout adjusted, tests passed 914 of 914 OK. Best regards, Mirsad Todorovac diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings index dfc27cdc6c05..ed8418e8217a 100644 --- a/tools/testing/selftests/net/settings +++ b/tools/testing/selftests/net/settings @@ -1 +1 @@ -timeout=1500 +timeout=3600 - [snip] # Ping LLA with multiple interfaces TEST: Pre cycle, ping out ns-B - multicast IP [ OK ] TEST: Pre cycle, ping out ns-C - multicast IP [ OK ] TEST: Post cycle ns-A eth1, ping out ns-B - multicast IP [ OK ] TEST: Post cycle ns-A eth1, ping out ns-C - multicast IP [ OK ] TEST: Post cycle ns-A eth2, ping out ns-B - multicast IP [ OK ] TEST: Post cycle ns-A eth2, ping out ns-C - multicast IP [ OK ] # SNAT on VRF TEST: IPv4 TCP connection over VRF with SNAT [ OK ] TEST: IPv6 TCP connection over VRF with SNAT [ OK ] Tests passed: 914 Tests failed: 0 real53m48.460s user0m32.885s sys 2m41.509s root@hostname:/ -- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu System engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb, Republic of Croatia The European Union "I see something approaching fast ... Will it be friends with me?"