Re: [PATCH] nubus: Set default dma mask for nubus_board devices

2018-07-02 Thread Geert Uytterhoeven 
On Mon, Jun 25, 2018 at 1:45 PM Finn Thain  wrote:
> A 32-bit mask is used by default because a NuBus slot has 32
> address/data lines and a NuBus board is free to use all of them.
>
> Cc: Christoph Hellwig 
> Cc: Greg Kroah-Hartman 
> Tested-by: Stan Johnson 
> Signed-off-by: Finn Thain 

Thanks, applied with Christoph's Rb, and queued for v4.19.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] nubus: Set default dma mask for nubus_board devices

2018-06-29 Thread Christoph Hellwig 
On Fri, Jun 29, 2018 at 02:15:21PM +1000, Finn Thain wrote:
> On Thu, 28 Jun 2018, Christoph Hellwig wrote:
> 
> > On Mon, Jun 25, 2018 at 09:46:11PM +1000, Finn Thain wrote:
> > > A 32-bit mask is used by default because a NuBus slot has 32 
> > > address/data lines and a NuBus board is free to use all of them.
> > 
> > Looks good:
> 
> Thanks for looking it over. But did you forget to include an 
> acked-by/reviewed-by tag?

Looks like it.

Reviewed-by: Christoph Hellwig 
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] nubus: Set default dma mask for nubus_board devices

2018-06-28 Thread Finn Thain 
On Thu, 28 Jun 2018, Christoph Hellwig wrote:

> On Mon, Jun 25, 2018 at 09:46:11PM +1000, Finn Thain wrote:
> > A 32-bit mask is used by default because a NuBus slot has 32 
> > address/data lines and a NuBus board is free to use all of them.
> 
> Looks good:

Thanks for looking it over. But did you forget to include an 
acked-by/reviewed-by tag?

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] nubus: Set default dma mask for nubus_board devices

2018-06-28 Thread Christoph Hellwig 
On Mon, Jun 25, 2018 at 09:46:11PM +1000, Finn Thain wrote:
> A 32-bit mask is used by default because a NuBus slot has 32
> address/data lines and a NuBus board is free to use all of them.

Looks good:

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] nubus: Set default dma mask for nubus_board devices

2018-06-25 Thread Finn Thain 
A 32-bit mask is used by default because a NuBus slot has 32
address/data lines and a NuBus board is free to use all of them.

Cc: Christoph Hellwig 
Cc: Greg Kroah-Hartman 
Tested-by: Stan Johnson 
Signed-off-by: Finn Thain 
---
 drivers/nubus/bus.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c
index a59b6c4bb5b8..ad3d17c42e23 100644
--- a/drivers/nubus/bus.c
+++ b/drivers/nubus/bus.c
@@ -5,6 +5,7 @@
 // Copyright (C) 2017 Finn Thain
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -93,6 +94,8 @@ int nubus_device_register(struct nubus_board *board)
board->dev.release = nubus_device_release;
board->dev.bus = _bus_type;
dev_set_name(>dev, "slot.%X", board->slot);
+   board->dev.dma_mask = >dev.coherent_dma_mask;
+   dma_set_mask(>dev, DMA_BIT_MASK(32));
return device_register(>dev);
 }
 
-- 
2.16.4

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html