Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour
Hi Michael, On Tue, Sep 18, 2018 at 02:03:29PM +1200, Michael Schmitz wrote: > Thanks Dmitry! > > I had asked Andreas' signoff for his keymap fixes only - the rewrite of the > Atari keyboard driver to the current input framework (and hence the CapsLock > toggle bug) was entirely mine, no blame attaches to Andreas there. It was not about blame, it was about helping me to check the sanity of the patch given I have no idea about the hardware ;) Thanks. -- Dmitry
Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour
Thanks Dmitry! I had asked Andreas' signoff for his keymap fixes only - the rewrite of the Atari keyboard driver to the current input framework (and hence the CapsLock toggle bug) was entirely mine, no blame attaches to Andreas there. Cheers, Michael On 18/09/18 10:36, Dmitry Torokhov wrote: On Mon, Sep 17, 2018 at 10:29:08PM +0200, Andreas Schwab wrote: On Sep 17 2018, Dmitry Torokhov wrote: On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote: The CapsLock key on Atari keyboards is not a toggle, it does send the normal make and break scancodes. Drop the CapsLock toggle handling code, which did cause the CapsLock key to merely act as a Shift key. Tested-by: Michael Schmitz Signed-off-by: Michael Schmitz Andreas, I have no idea how Atari keyboards work, can you add your signed-off-by (or NAK) to this one as well please? The old atakbd driver never had that special handling. Signed-off-by: Andreas Schwab Applied, thank you.
Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour
On Mon, Sep 17, 2018 at 10:29:08PM +0200, Andreas Schwab wrote: > On Sep 17 2018, Dmitry Torokhov wrote: > > > On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote: > >> The CapsLock key on Atari keyboards is not a toggle, it does send the > >> normal make and break scancodes. > >> > >> Drop the CapsLock toggle handling code, which did cause the CapsLock > >> key to merely act as a Shift key. > >> > >> Tested-by: Michael Schmitz > >> Signed-off-by: Michael Schmitz > > > > Andreas, I have no idea how Atari keyboards work, can you add your > > signed-off-by (or NAK) to this one as well please? > > The old atakbd driver never had that special handling. > > Signed-off-by: Andreas Schwab Applied, thank you. -- Dmitry
Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour
On Sep 17 2018, Dmitry Torokhov wrote: > On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote: >> The CapsLock key on Atari keyboards is not a toggle, it does send the >> normal make and break scancodes. >> >> Drop the CapsLock toggle handling code, which did cause the CapsLock >> key to merely act as a Shift key. >> >> Tested-by: Michael Schmitz >> Signed-off-by: Michael Schmitz > > Andreas, I have no idea how Atari keyboards work, can you add your > signed-off-by (or NAK) to this one as well please? The old atakbd driver never had that special handling. Signed-off-by: Andreas Schwab Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour
On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote:
> The CapsLock key on Atari keyboards is not a toggle, it does send the
> normal make and break scancodes.
>
> Drop the CapsLock toggle handling code, which did cause the CapsLock
> key to merely act as a Shift key.
>
> Tested-by: Michael Schmitz
> Signed-off-by: Michael Schmitz
Andreas, I have no idea how Atari keyboards work, can you add your
signed-off-by (or NAK) to this one as well please?
>
> ---
> drivers/input/keyboard/atakbd.c | 10 ++
> 1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/input/keyboard/atakbd.c b/drivers/input/keyboard/atakbd.c
> index e989574..6caee80 100644
> --- a/drivers/input/keyboard/atakbd.c
> +++ b/drivers/input/keyboard/atakbd.c
> @@ -185,14 +185,8 @@ static void atakbd_interrupt(unsigned char scancode,
> char down)
>
> scancode = atakbd_keycode[scancode];
>
> - if (scancode == KEY_CAPSLOCK) { /* CapsLock is a toggle switch
> key on Amiga */
> - input_report_key(atakbd_dev, scancode, 1);
> - input_report_key(atakbd_dev, scancode, 0);
> - input_sync(atakbd_dev);
> - } else {
> - input_report_key(atakbd_dev, scancode, down);
> - input_sync(atakbd_dev);
> - }
> + input_report_key(atakbd_dev, scancode, down);
> + input_sync(atakbd_dev);
> } else /* scancodes >= 0xf3 are mouse data,
> most likely */
> printk(KERN_INFO "atakbd: unhandled scancode %x\n", scancode);
>
> --
> 1.7.0.4
>
--
Dmitry
[PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour
The CapsLock key on Atari keyboards is not a toggle, it does send the
normal make and break scancodes.
Drop the CapsLock toggle handling code, which did cause the CapsLock
key to merely act as a Shift key.
Tested-by: Michael Schmitz
Signed-off-by: Michael Schmitz
---
drivers/input/keyboard/atakbd.c | 10 ++
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/input/keyboard/atakbd.c b/drivers/input/keyboard/atakbd.c
index e989574..6caee80 100644
--- a/drivers/input/keyboard/atakbd.c
+++ b/drivers/input/keyboard/atakbd.c
@@ -185,14 +185,8 @@ static void atakbd_interrupt(unsigned char scancode, char
down)
scancode = atakbd_keycode[scancode];
- if (scancode == KEY_CAPSLOCK) { /* CapsLock is a toggle switch
key on Amiga */
- input_report_key(atakbd_dev, scancode, 1);
- input_report_key(atakbd_dev, scancode, 0);
- input_sync(atakbd_dev);
- } else {
- input_report_key(atakbd_dev, scancode, down);
- input_sync(atakbd_dev);
- }
+ input_report_key(atakbd_dev, scancode, down);
+ input_sync(atakbd_dev);
} else /* scancodes >= 0xf3 are mouse data,
most likely */
printk(KERN_INFO "atakbd: unhandled scancode %x\n", scancode);
--
1.7.0.4
