date:20101006

Re: [PATCH/RFC v3 01/11] v4l: Move the media/v4l2-mediabus.h header to include/linux

2010-10-06 Thread Laurent Pinchart

Hi Guennadi,

On Tuesday 05 October 2010 17:30:21 Guennadi Liakhovetski wrote:
 On Tue, 5 Oct 2010, Sakari Ailus wrote:
  Laurent Pinchart wrote:
   The header defines the v4l2_mbus_framefmt structure which will be used
   by the V4L2 subdevs userspace API.
   
   Change the type of the v4l2_mbus_framefmt::code field to __u32, as enum
   sizes can differ between different ABIs on the same architectures.
   
   Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

[snip]

   +/**
   + * struct v4l2_mbus_framefmt - frame format on the media bus
   + * @width:   frame width
   + * @height:  frame height
   + * @code:data format code
   + * @field:   used interlacing type
   + * @colorspace:  colorspace of the data
   + */
   +struct v4l2_mbus_framefmt {
   + __u32   width;
   + __u32   height;
   + __u32   code;
   + enum v4l2_field field;
   + enum v4l2_colorspacecolorspace;
   +};
  
  I think this struct would benefit from some reserved fields since it's
  part of the user space interface.
 
 IIUC, this struct is not going to be used in ioctl()s, that's what struct
 v4l2_subdev_mbus_code_enum is for. But in this case - why don't we make
 the code field above of type enum v4l2_mbus_pixelcode?

The v4l2_mbus_framefmt structure isn't used directly as an ioctl argument, but 
it's embedded in the v4l2_subdev_format structure, used as an ioctl argument, 
so its size matters.

The v4l2_subdev_format structure has reserved fields right after the 
v4l2_mbus_framefmt member so there's some room for expansion. As for the 
enums, I've reused the ones already in use in the V4L2 API, but I can replace 
them with __u32.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] V4L: sh_mobile_ceu_camera: use default .get_parm() and .set_parm() operations

2010-10-06 Thread Guennadi Liakhovetski

No need to duplicate default .get_parm() and .set_parm() operations.

Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
 drivers/media/video/sh_mobile_ceu_camera.c |   18 --
 1 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/drivers/media/video/sh_mobile_ceu_camera.c 
b/drivers/media/video/sh_mobile_ceu_camera.c
index 0b029bd..fdaadde 100644
--- a/drivers/media/video/sh_mobile_ceu_camera.c
+++ b/drivers/media/video/sh_mobile_ceu_camera.c
@@ -1789,22 +1789,6 @@ static void sh_mobile_ceu_init_videobuf(struct 
videobuf_queue *q,
   icd);
 }
 
-static int sh_mobile_ceu_get_parm(struct soc_camera_device *icd,
- struct v4l2_streamparm *parm)
-{
-   struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
-
-   return v4l2_subdev_call(sd, video, g_parm, parm);
-}
-
-static int sh_mobile_ceu_set_parm(struct soc_camera_device *icd,
- struct v4l2_streamparm *parm)
-{
-   struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
-
-   return v4l2_subdev_call(sd, video, s_parm, parm);
-}
-
 static int sh_mobile_ceu_get_ctrl(struct soc_camera_device *icd,
  struct v4l2_control *ctrl)
 {
@@ -1866,8 +1850,6 @@ static struct soc_camera_host_ops sh_mobile_ceu_host_ops 
= {
.try_fmt= sh_mobile_ceu_try_fmt,
.set_ctrl   = sh_mobile_ceu_set_ctrl,
.get_ctrl   = sh_mobile_ceu_get_ctrl,
-   .set_parm   = sh_mobile_ceu_set_parm,
-   .get_parm   = sh_mobile_ceu_get_parm,
.reqbufs= sh_mobile_ceu_reqbufs,
.poll   = sh_mobile_ceu_poll,
.querycap   = sh_mobile_ceu_querycap,
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [linux-dvb] Asus MyCinema P7131 Dual support

2010-10-06 Thread Dejan Rodiger

Hi Giorgio,

Dejan,

I have the exact same card:

# sudo lpci -vnn
02:07.0 Multimedia controller [0480]: Philips Semiconductors
SAA7131/SAA7133/SAA7135 Video Broadcast Decoder [1131:7133] (rev d1)
Subsystem: ASUSTeK Computer Inc. Device [1043:4876]
Flags: bus master, medium devsel, latency 64, IRQ 20
Memory at fbfff800 (32-bit, non-prefetchable) [size=2K]
Capabilities: [40] Power Management version 2
Kernel driver in use: saa7134
Kernel modules: saa7134

and I can confirm you that it's autodetected and works very well (both the
analog and the digital part) on 2.6.35.
2.6.32 has a problem with dvb-t reception, but I have reported it and
hopefully
it will be fixed soon upstream:
http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/23604

If you want to test the analog part, install MPlayer and run the following
command:

mplayer tv:// -tv
driver=v4l2:device=/dev/video0:norm=PAL:input=0:chanlist=europe-west

This is working OK. I have also experimented more with tvtime and both
versions work, but I have to do little more fine tuning and then I
have better picture. So I will probably have to manually find exact
stations frequencies and enter them in mythtv. But I first have to
figure how and where to enter them.

and then press 'k' or 'h' to select previous/next channel (after you switch
channel, wait some seconds until the card tunes, for some channels I need
5 seconds here, for others about 1 second). Now, with some patience, explore
all the channels and you should be able to find your local tv stations.
Also, you might need to adjust mplayer options, like norm= or chanlist=
(you could try chanlist=europe-east).

The command line above doesn't grab audio though, so you won't hear a thing.
If you want to hear the audio you need to make sure saa7134-alsa is loaded
and run something like:

mplayer tv:// -tv
driver=v4l2:device=/dev/video0:norm=PAL:input=0:alsa:adevice=hw.1,0:amode=1:immediatemode=0:chanlist=europe-west

saa7134-alsa is loaded automatically, but I am unable to get any sound
from mplayer or tvtime. I see on google, that I am not the only one.
I have also noticed that about 8-10% of the frames are lost.

(make sure you select the right alsa device in adevice=)

The wiki has a good page about MPlayer:

http://www.linuxtv.org/wiki/index.php/MPlayer

and of course the MPlayer man page explain all the options too.

These pages are also useful (but some things might be a bit outdated):

http://www.linuxtv.org/wiki/index.php/ASUS_My_Cinema-P7131_Hybrid
http://www.linuxtv.org/wiki/index.php/Saa7134-alsa

I hope this can help you and others reading this ML.

Regards,
Giorgio Vazzana

Thanks
--
Dejan Rodiger
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

58 matches

Mail list logo