Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
On 12/31/2010 10:48 PM, Finn Thain wrote: On Thu, 30 Dec 2010, Justin P. Mattock wrote: The below patch fixes a typo "diable" to "disable". Please let me know if this is correct or not. Signed-off-by: Justin P. Mattock --- drivers/staging/rtl8187se/r8180_hw.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h index 3fca144..2911d40 100644 --- a/drivers/staging/rtl8187se/r8180_hw.h +++ b/drivers/staging/rtl8187se/r8180_hw.h @@ -554,7 +554,7 @@ /* by amy for power save */ /* by amy for antenna */ #define EEPROM_SW_REVD_OFFSET 0x3f -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable.*/ +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ I think, "other values disable" was what you meant? Finn #define EEPROM_SW_AD_MASK 0x0300 #define EEPROM_SW_AD_ENABLE 0x0100 no! I changed it to disabled to make it proper.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
On Thu, 30 Dec 2010, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if > this > is correct or not. > > Signed-off-by: Justin P. Mattock > > --- > drivers/staging/rtl8187se/r8180_hw.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/rtl8187se/r8180_hw.h > b/drivers/staging/rtl8187se/r8180_hw.h > index 3fca144..2911d40 100644 > --- a/drivers/staging/rtl8187se/r8180_hw.h > +++ b/drivers/staging/rtl8187se/r8180_hw.h > @@ -554,7 +554,7 @@ > /* by amy for power save */ > /* by amy for antenna*/ > #define EEPROM_SW_REVD_OFFSET 0x3f > -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE > means enable, other values are diable. */ > +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE > means enable, other values are disabled. > */ I think, "other values disable" was what you meant? Finn > #define EEPROM_SW_AD_MASK0x0300 > #define EEPROM_SW_AD_ENABLE 0x0100 > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
SAA7136E and AverMedia A188
HI all, Does anyone know if the SAA7136E chipset and/or the AverMEdia A188 PCI-e device are supported yet? $ lspci -v 03:00.0 Multimedia controller: Philips Semiconductors Device 7160 (rev 01) Subsystem: Avermedia Technologies Inc DEvice 1855 Flags: bus master, fast devsel, latency 0, IRQ 7 Memory at fd80 (64-bit, non-prefetachable) [size=1M] Capabilities: Regards Bidski -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864
Mauro, Please revert at least the wm8775.c portion of commit fcb9757333df37cf4a7feccef7ef6f5300643864: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fcb9757333df37cf4a7feccef7ef6f5300643864 It completely trashes baseband line-in audio for PVR-150 cards, and likely does the same for any other ivtv card that has a WM8775 chip. Reported-by: Eric Sharkey http://ivtvdriver.org/pipermail/ivtv-users/2010-December/010104.html Reported-by: Auric http://ivtvdriver.org/pipermail/ivtv-users/2010-December/010102.html Reported by: David Gesswein http://ivtvdriver.org/pipermail/ivtv-devel/2010-December/006619.html I have also verified with my own PVR-150 that this commit is the cause. Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Adaptec AVC-2410 remote codes
Mauro, Here is the lirc config file for the Adaptec AVC-2410: http://lirc.git.sourceforge.net/git/gitweb.cgi?p=lirc/lirc;a=blob;f=remotes/adaptec/lircd.conf.AVC-2410;h=3f6c5f08c8fef187d6015f4c1abe930464aa0d78;hb=HEAD The 16 bit button codes are obviously in a command:command' data payload like standard NEC. For example: Mute 0x13EC The 16 bit prefix data is 0x82F1, which doesn't remind me of anything in particular. Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Hauppauge Nova-T Stick 3 Issues
Apologies for bumping this message, but I am still having this problem. I thought that this Hauppauge receiver should work flawlessly ... Any clue's? On Mon, Dec 27, 2010 at 1:47 PM, Ray Kinsella wrote: > Hi all, > > I recently purchased a Hauppauge Nova-T USB DVB-T receiver and have > been having trouble getting it to work. > I read through the Wiki page > (http://www.linuxtv.org/wiki/index.php/Hauppauge_WinTV-NOVA-T-Stick) > for this device and followed the instructions but still no luck. > > Most of the time the frontend will fail to attach (as show below), on > the rare occasions when the frontend does attach it will hang when I > try to scan for channels. > In both cases the driver complains of I2C read/write failures. > I am using the latest from code from the V4L-DVB backports repository > with a 2.6.35 Kernel (Mythubuntu 10.10) > > Any advice on what to try? > > r...@pvr:~$ uname -a > Linux pvr 2.6.35-22-generic #33-Ubuntu SMP Sun Sep 19 20:34:50 UTC > 2010 i686 GNU/Linux > > r...@pvr:~$ lsusb > Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub > ... > Bus 001 Device 004: ID 2040:7070 Hauppauge Nova-T Stick 3 > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > r...@pvr:~$ dmesg > [ 18.492014] usb 1-4: new high speed USB device using ehci_hcd and address 4 > [ 18.653158] WARNING: You're using an experimental version of the > DVB stack. As the driver > [ 18.653160] is backported to an older kernel, it doesn't > offer enough quality for > [ 18.653161] its usage in production. > [ 18.653161] Use it with care. > [ 18.667402] dib0700: loaded with support for 14 different device-types > [ 18.667425] check for cold 10b8 1e14 > [ 18.667426] check for cold 10b8 1e78 > [ 18.667427] check for cold 2040 7050 > [ 18.667428] check for cold 2040 7060 > [ 18.667430] check for cold 7ca a807 > [ 18.667431] check for cold 7ca b808 > [ 18.667432] check for cold 185b 1e78 > [ 18.667433] check for cold 185b 1e80 > [ 18.667434] check for cold 1584 6003 > [ 18.667436] check for cold 413 6f00 > [ 18.667437] check for cold 413 6f01 > [ 18.667438] check for cold 7ca b568 > [ 18.667439] check for cold 1044 7001 > [ 18.667440] check for cold 2040 9941 > [ 18.667441] check for cold 2040 9950 > [ 18.667443] check for cold 2304 22c > [ 18.667444] check for cold ccd 5a > [ 18.667445] check for cold 2040 9580 > [ 18.667446] check for cold 10b8 1ef0 > [ 18.667447] check for cold 1164 1e8c > [ 18.667448] check for cold b05 171f > [ 18.667450] check for cold 1164 1edc > [ 18.667451] check for cold ccd 62 > [ 18.667452] check for cold 10b8 1ebc > [ 18.667453] check for cold 2304 228 > [ 18.667454] check for cold 5d8 810f > [ 18.667456] check for cold b05 173f > [ 18.667457] check for cold 2040 7070 > [ 18.667565] FW GET_VERSION length: -32 > [ 18.667567] cold: 1 > [ 18.667568] dvb-usb: found a 'Hauppauge Nova-T Stick' in cold > state, will try to load a firmware > [ 18.674300] dvb-usb: downloading firmware from file > 'dvb-usb-dib0700-1.20.fw' > [ 18.875965] dib0700: firmware started successfully. > [ 24.376079] dvb-usb: found a 'Hauppauge Nova-T Stick' in warm state. > [ 24.376086] power control: 1 > [ 24.376129] dvb-usb: will pass the complete MPEG2 transport stream > to the software demuxer. > [ 24.376546] DVB: registering new adapter (Hauppauge Nova-T Stick) > [ 74.424074] ep 0 read error (status = -110) > [ 74.424079] I2C read failed on address 0x40 > [ 84.424148] ep 0 read error (status = -110) > [ 84.424151] I2C read failed on address 0x09 > [ 84.424157] dib0700: stk7070p_frontend_attach: > dib7000p_i2c_enumeration failed. Cannot continue > [ 84.424159] > [ 84.424162] dvb-usb: no frontend was attached by 'Hauppauge Nova-T Stick' > [ 84.424166] power control: 0 > [ 84.424168] dvb-usb: Hauppauge Nova-T Stick successfully > initialized and connected. > [ 89.424093] Firmware version: 0, -1941421839, 0x100, 1348026105 > [ 94.424065] dib0700: ir protocol setup failed > [ 94.424104] usbcore: registered new interface driver dvb_usb_dib0700 > > > r...@pvr:~$ cat /etc/modprobe.d/options.conf > options dvb_usb_dib0700 force_lna_activation=1 debug=1 > options dvb_usb disable_rc_polling=1 debug=1 > options dvb_core debug=1 > > r...@pvr:~$ lsmod > Module Size Used by > dvb_usb_dib0700 56317 0 > dib7000p 16176 1 dvb_usb_dib0700 > dib0090 1 1 dvb_usb_dib0700 > dib7000m 13132 1 dvb_usb_dib0700 > dib0070 7766 1 dvb_usb_dib0700 > dvb_usb 17643 1 dvb_usb_dib0700 > dib8000 25510 1 dvb_usb_dib0700 > dvb_core 86744 3 dib7000p,dvb_usb,dib8000 > dib3000mc 11200 1 dvb_usb_dib0700 > dibx000_common 3112 4 dib7000p,dib7000m,dib8000,dib3000mc > usbhid 36882 0 > hid 67742 1 usbhid > ... > >
Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
On 12/31/2010 01:15 PM, Andy Walls wrote: On Thu, 2010-12-30 at 15:08 -0800, Justin P. Mattock wrote: The below patch fixes a typo "diable" to "disable". Please let me know if this is correct or not. ^^ What, else could it be? The "diablo" chroma spatial filter type? ;) Looks fine. Acked-by: Andy Walls depends on what the search engine gives you.. diablo did show up but figured better throw that in to be safe since some definitions appear to be incorect but are in fact correct.. Signed-off-by: Justin P. Mattock --- drivers/media/video/cx18/cx23418.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h index 2c00980..7e40035 100644 --- a/drivers/media/video/cx18/cx23418.h +++ b/drivers/media/video/cx18/cx23418.h @@ -177,7 +177,7 @@ IN[0] - Task handle. IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical only, 3 = 2D H/V separable, 4 = 2D symmetric non-separable - IN[2] - chroma type: 0 - diable, 1 = 1D horizontal + IN[2] - chroma type: 0 - disable, 1 = 1D horizontal ReturnCode - One of the ERR_CAPTURE_... */ #define CX18_CPU_SET_SPATIAL_FILTER_TYPE (CPU_CMD_MASK_CAPTURE | 0x000C) cheers, Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
On Thu, 2010-12-30 at 15:08 -0800, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if > this > is correct or not. ^^ What, else could it be? The "diablo" chroma spatial filter type? ;) Looks fine. Acked-by: Andy Walls > > Signed-off-by: Justin P. Mattock > > --- > drivers/media/video/cx18/cx23418.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/cx18/cx23418.h > b/drivers/media/video/cx18/cx23418.h > index 2c00980..7e40035 100644 > --- a/drivers/media/video/cx18/cx23418.h > +++ b/drivers/media/video/cx18/cx23418.h > @@ -177,7 +177,7 @@ > IN[0] - Task handle. > IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical > only, > 3 = 2D H/V separable, 4 = 2D symmetric non-separable > - IN[2] - chroma type: 0 - diable, 1 = 1D horizontal > + IN[2] - chroma type: 0 - disable, 1 = 1D horizontal > ReturnCode - One of the ERR_CAPTURE_... */ > #define CX18_CPU_SET_SPATIAL_FILTER_TYPE (CPU_CMD_MASK_CAPTURE | > 0x000C) > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
DVB driver for TerraTec H7 - how do I install them?
Ok, I downloaded drivers for the TerraTec H7 from here: http://linux.terratec.de/ This file to be exact: http://linux.terratec.de/files/TERRATEC_H7_Linux.tar.gz Which supposedly contains drivers for the H7. I am running Xubuntu 10.04: ti...@kg-htpc:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 10.04.1 LTS Release:10.04 Codename: lucid ti...@kg-htpc:~$ uname -a Linux kg-htpc 2.6.32-27-generic #49-Ubuntu SMP Wed Dec 1 23:52:12 UTC 2010 i686 GNU/Linux I followed this guide[1] to get and install a new v4l-dvb, which worked fine. Then I did 'make distclean' and copied the files from the TERRATEC_H7_Linux.tar.gz file to where I thought they should be, and tried recompiling the v4l-dvb tree. That didn't work, the compilation aborted: CC [M] /home/tingo/work/v4l-dvb/v4l/au6610.o CC [M] /home/tingo/work/v4l-dvb/v4l/az6007.o In file included from /home/tingo/work/v4l-dvb/v4l/az6007.c:11: /home/tingo/work/v4l-dvb/v4l/mt2063_cfg.h: In function 'tuner_MT2063_Open': /home/tingo/work/v4l-dvb/v4l/mt2063_cfg.h:62: error: 'DVBFE_TUNER_OPEN' undeclared (first use in this function) /home/tingo/work/v4l-dvb/v4l/mt2063_cfg.h:62: error: (Each undeclared identifier is reported only once /home/tingo/work/v4l-dvb/v4l/mt2063_cfg.h:62: error: for each function it appears in.) /home/tingo/work/v4l-dvb/v4l/mt2063_cfg.h: In function 'tuner_MT2063_SoftwareShutdown': /home/tingo/work/v4l-dvb/v4l/mt2063_cfg.h:83: error: 'DVBFE_TUNER_SOFTWARE_SHUTDOWN' undeclared (first use in this function) /home/tingo/work/v4l-dvb/v4l/mt2063_cfg.h: In function 'tuner_MT2063_ClearPowerMaskBits': /home/tingo/work/v4l-dvb/v4l/mt2063_cfg.h:104: error: 'DVBFE_TUNER_CLEAR_POWER_MASKBITS' undeclared (first use in this function) /home/tingo/work/v4l-dvb/v4l/az6007.c: At top level: /home/tingo/work/v4l-dvb/v4l/az6007.c:157: warning: excess elements in struct initializer /home/tingo/work/v4l-dvb/v4l/az6007.c:157: warning: (near initialization for 'az6007_rc_keys[0]') /home/tingo/work/v4l-dvb/v4l/az6007.c:158: warning: excess elements in struct initializer /home/tingo/work/v4l-dvb/v4l/az6007.c:158: warning: (near initialization for 'az6007_rc_keys[1]') /home/tingo/work/v4l-dvb/v4l/az6007.c:535: error: 'USB_PID_AZUREWAVE_6007' undeclared here (not in a function) /home/tingo/work/v4l-dvb/v4l/az6007.c:536: error: 'USB_PID_TERRATEC_H7' undeclared here (not in a function) make[3]: *** [/home/tingo/work/v4l-dvb/v4l/az6007.o] Error 1 make[2]: *** [_module_/home/tingo/work/v4l-dvb/v4l] Error 2 make[2]: Leaving directory `/usr/src/linux-headers-2.6.32-27-generic' make[1]: *** [default] Error 2 make[1]: Leaving directory `/home/tingo/work/v4l-dvb/v4l' make: *** [all] Error 2 So obviously I'm doing something wrong. How do I install those drivers for the TerraTec H7? Oh, and best wishes for the new year to everyone! References: 1) http://linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers -- Regards, Torfinn Ingolfsen Norway -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATVH] media, dvb, IX2505V: Remember to free allocated memory in failure path (ix2505v_attach()).
On Fri, 2010-12-31 at 15:51 +0100, Jesper Juhl wrote:
> On Fri, 31 Dec 2010, Malcolm Priestley wrote:
>
> > On Fri, 2010-12-31 at 00:11 +0100, Jesper Juhl wrote:
> > > Hi,
> > >
> > > We may leak the storage allocated to 'state' in
> > > drivers/media/dvb/frontends/ix2505v.c::ix2505v_attach() on error.
> > > This patch makes sure we free the allocated memory in the failure case.
> > >
> > >
> > > Signed-off-by: Jesper Juhl
> > > ---
> > > ix2505v.c |1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > Compile tested only.
> > >
> > > diff --git a/drivers/media/dvb/frontends/ix2505v.c
> > > b/drivers/media/dvb/frontends/ix2505v.c
> > > index 55f2eba..fcb173d 100644
> > > --- a/drivers/media/dvb/frontends/ix2505v.c
> > > +++ b/drivers/media/dvb/frontends/ix2505v.c
> > > @@ -293,6 +293,7 @@ struct dvb_frontend *ix2505v_attach(struct
> > > dvb_frontend *fe,
> > > ret = ix2505v_read_status_reg(state);
> > >
> > > if (ret & 0x80) {
> > > + kfree(state);
> > > deb_i2c("%s: No IX2505V found\n", __func__);
> > > goto error;
> > > }
> > >
> > Memory is freed in...
> >
> > error:
> > ix2505v_release(fe);
> > return NULL;
> >
> > via...
> >
> > static int ix2505v_release(struct dvb_frontend *fe)
> > {
> > struct ix2505v_state *state = fe->tuner_priv;
> >
> > fe->tuner_priv = NULL;
> > kfree(state);
> >
> > return 0;
> > }
> >
>
> Except that 'state' has not been assigned to fe->tuner_priv at this
> point, so ix2505v_release() cannot free the memory that was just
> allocated with kzalloc().
>
>
> state is a local variable:
> struct ix2505v_state *state = NULL;
> ...
>
> we allocate memory and assign it to 'state' here:
> state = kzalloc(sizeof(struct ix2505v_state), GFP_KERNEL);
> if (NULL == state)
> return NULL;
>
> state->config = config;
> state->i2c = i2c;
>
> here 'state' is used, but not in a way that saves it anywhere:
> if (state->config->tuner_write_only) {
> if (fe->ops.i2c_gate_ctrl)
> fe->ops.i2c_gate_ctrl(fe, 1);
>
> this function call involves 'state' but it does not save it anywhere
> either:
> ret = ix2505v_read_status_reg(state);
>
> if (ret & 0x80) {
> deb_i2c("%s: No IX2505V found\n", __func__);
> so when we jump to error here 'state' still exists only as the local
> variable, it has not been assigned to anything else.
> goto error;
> }
> ...
> error:
> there is no way this function call can free 'state' on this path since
> it has not been assigned to fe->tuner_priv.
> ix2505v_release(fe);
> The local variable state goes out of scope here and leaks the memory it
> points to:
> return NULL;
> }
>
> Am I missing something?
Oh, Sorry, I see it now.
Now there is two options.
Either;
1) Move fe->tuner_priv = state to below line 287, so it can be released
by ix2505v_release and fe->tuner_priv returned to NULL;
2) or not calling ix2505v_release changing line 314 to kfree(state).
fe->tuner_priv will remain NULL through out.
Currently, tuner_write_only is not implemented in the dvb-usb-lmedm04
driver, as sometimes it returned unpredictable results, and wrongly
failed to attach the tuner. Although, I will test it again.
Regards
Malcolm
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[cron job] v4l-dvb daily build: WARNINGS
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Fri Dec 31 19:00:30 CET 2010 git master: 59365d136d205cc20fe666ca7f89b1c5001b0d5a git media-master: gcc version: i686-linux-gcc (GCC) 4.5.1 host hardware:x86_64 host os: 2.6.32.5 linux-git-armv5: WARNINGS linux-git-armv5-davinci: WARNINGS linux-git-armv5-ixp: WARNINGS linux-git-armv5-omap2: WARNINGS linux-git-i686: WARNINGS linux-git-m32r: WARNINGS linux-git-mips: WARNINGS linux-git-powerpc64: WARNINGS linux-git-x86_64: WARNINGS spec-git: OK sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Friday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Friday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On 12/31/2010 09:41 AM, Dan Carpenter wrote: On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote: Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable regards, dan carpenter alright.. so having the backlash is alright for the subject Well really my point is not so much about backslashes vs colons, it's about getting the *one* correct prefix. This stuff is probably scriptable most of the time, but you may still be required to think a little on the corner cases. Here is a script to get you started. git log --format="%s" drivers/spi/dw_spi.c | \ head -n 20 | \ perl -ne 's/(.*):.*/$1/; print' |\ sort | uniq -c | sort -rn | \ perl -ne 's/^\W+\d+ //; print' | \ head -n 1 regards, dan carpenter thats a nice little script there(just ran it) any way you want to add this into to getmaintainers.pl or something? (this way people get the maintainers address plus a subject line in the mix) Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote: > >Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. > > > >Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable > > > >regards, > >dan carpenter > > > > alright.. so having the backlash is alright for the subject Well really my point is not so much about backslashes vs colons, it's about getting the *one* correct prefix. This stuff is probably scriptable most of the time, but you may still be required to think a little on the corner cases. Here is a script to get you started. git log --format="%s" drivers/spi/dw_spi.c | \ head -n 20 | \ perl -ne 's/(.*):.*/$1/; print' |\ sort | uniq -c | sort -rn | \ perl -ne 's/^\W+\d+ //; print' | \ head -n 1 regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: nasty bug at qv4l2
Em 31-12-2010 13:08, Hans Verkuil escreveu: > On Friday, December 31, 2010 16:02:10 Hans de Goede wrote: >> Hi, >> >> Hans V. I've tested your patch for avoiding the double >> conversion problem, and I can report it fixes the issue seen with >> webcameras which need 90 degrees rotation. >> >> While testing I found a bug in gspca, which gets triggered by >> qv4l2 which makes it impossible to switch between userptr and >> mmap mode. While fixing that I also found some locking issues in >> gspca. As these all touch the gscpa core I'll send a patch set >> to Jean Francois Moine for this. >> >> With the issues in gspca fixed, I found a bug in qv4l2 when using >> read mode in raw mode (not passing the correct src_size to >> libv4lconvert_convert). >> >> I've attached 2 patches to qv4l2, fixing the read issue and a similar >> issue in mmap / userptr mode. These apply on top of your patch. > > Thanks for testing this! I've committed mine and your patches for qv4l2. Ok, I did some tests here too. The applied patches fix the bugs I've reported: the pac7302 driver formats are properly reported (the emulated ones), and it is now possible to change resolution/format with the uvc driver. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.38] Compile warning fixes
This should make the daily build give us some OKs. Regards, Hans The following changes since commit 187134a5875df20356f4dca075db29f294115a47: David Henningsson (1): [media] DVB: IR support for TechnoTrend CT-3650 are available in the git repository at: ssh://linuxtv.org/git/hverkuil/media_tree.git compile-fixes Hans Verkuil (4): ngene: fix compile warning tda18218: fix compile warning zoran: fix compiler warning v4l2-compat-ioctl32: fix compile warning drivers/media/common/tuners/tda18218.c|2 +- drivers/media/dvb/ngene/ngene-core.c |3 ++- drivers/media/video/v4l2-compat-ioctl32.c |4 drivers/media/video/zoran/zoran_driver.c |1 + 4 files changed, 4 insertions(+), 6 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 07/15]drivers:net:wireless:iwlwifi Typo change diable to disable.
On 12/30/2010 05:07 PM, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if > this > is correct or not. > > Signed-off-by: Justin P. Mattock > ACKed-by: Larry Finger > --- > drivers/net/wireless/iwlwifi/iwl-agn-ict.c |2 +- > drivers/net/wireless/iwlwifi/iwl-agn.c |4 ++-- > drivers/net/wireless/iwlwifi/iwl-core.c|2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c > b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c > index a5dbfea..b5cb3be 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c > +++ b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c > @@ -197,7 +197,7 @@ static irqreturn_t iwl_isr(int irq, void *data) > > none: > /* re-enable interrupts here since we don't have anything to service. */ > - /* only Re-enable if diabled by irq and no schedules tasklet. */ > + /* only Re-enable if disabled by irq and no schedules tasklet. */ > if (test_bit(STATUS_INT_ENABLED, &priv->status) && !priv->_agn.inta) > iwl_enable_interrupts(priv); > > diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c > b/drivers/net/wireless/iwlwifi/iwl-agn.c > index c2636a7..9b912c0 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-agn.c > +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c > @@ -1316,7 +1316,7 @@ static void iwl_irq_tasklet_legacy(struct iwl_priv > *priv) > } > > /* Re-enable all interrupts */ > - /* only Re-enable if diabled by irq */ > + /* only Re-enable if disabled by irq */ > if (test_bit(STATUS_INT_ENABLED, &priv->status)) > iwl_enable_interrupts(priv); > > @@ -1530,7 +1530,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv) > } > > /* Re-enable all interrupts */ > - /* only Re-enable if diabled by irq */ > + /* only Re-enable if disabled by irq */ > if (test_bit(STATUS_INT_ENABLED, &priv->status)) > iwl_enable_interrupts(priv); > } > diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c > b/drivers/net/wireless/iwlwifi/iwl-core.c > index 25fb391..8700ab3 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-core.c > +++ b/drivers/net/wireless/iwlwifi/iwl-core.c > @@ -1304,7 +1304,7 @@ irqreturn_t iwl_isr_legacy(int irq, void *data) > > none: > /* re-enable interrupts here since we don't have anything to service. */ > - /* only Re-enable if diabled by irq */ > + /* only Re-enable if disabled by irq */ > if (test_bit(STATUS_INT_ENABLED, &priv->status)) > iwl_enable_interrupts(priv); > spin_unlock_irqrestore(&priv->lock, flags); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
On 12/30/2010 05:07 PM, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if > this > is correct or not. > > Signed-off-by: Justin P. Mattock > > --- ACKed-by: Larry Finger > drivers/staging/rtl8187se/r8180_hw.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/rtl8187se/r8180_hw.h > b/drivers/staging/rtl8187se/r8180_hw.h > index 3fca144..2911d40 100644 > --- a/drivers/staging/rtl8187se/r8180_hw.h > +++ b/drivers/staging/rtl8187se/r8180_hw.h > @@ -554,7 +554,7 @@ > /* by amy for power save */ > /* by amy for antenna*/ > #define EEPROM_SW_REVD_OFFSET 0x3f > -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE > means enable, other values are diable. */ > +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE > means enable, other values are disabled. > */ > #define EEPROM_SW_AD_MASK0x0300 > #define EEPROM_SW_AD_ENABLE 0x0100 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: nasty bug at qv4l2
On Friday, December 31, 2010 16:02:10 Hans de Goede wrote: > Hi, > > Hans V. I've tested your patch for avoiding the double > conversion problem, and I can report it fixes the issue seen with > webcameras which need 90 degrees rotation. > > While testing I found a bug in gspca, which gets triggered by > qv4l2 which makes it impossible to switch between userptr and > mmap mode. While fixing that I also found some locking issues in > gspca. As these all touch the gscpa core I'll send a patch set > to Jean Francois Moine for this. > > With the issues in gspca fixed, I found a bug in qv4l2 when using > read mode in raw mode (not passing the correct src_size to > libv4lconvert_convert). > > I've attached 2 patches to qv4l2, fixing the read issue and a similar > issue in mmap / userptr mode. These apply on top of your patch. Thanks for testing this! I've committed mine and your patches for qv4l2. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On Fri, 2010-12-31 at 06:17 -0800, Justin P. Mattock wrote: > On 12/31/2010 01:11 AM, Dan Carpenter wrote: > > On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote: > >> On 12/30/2010 10:45 PM, Grant Likely wrote: > >>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know > if this > is correct or not. > > Signed-off-by: Justin P. Mattock > >>> > >>> applied, thanks. > >>> > >>> g. > >> > >> ahh.. thanks.. just cleared up the left out diabled that I had > >> thought I forgotten(ended up separating comments and code and > >> forgot) > > > > This is really just defensiveness and random grumbling and grumpiness on > > my part, but one reason I may have missed the first patch is because > > your subject lines are crap. > > > > Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. > > > > Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable > > > > regards, > > dan carpenter > > > > alright.. so having the backlash is alright for the subject > > Thanks for the pointer on this.. There is actually no specific form. Most of us edit this part of the subject line anyway to conform to whatever (nonuniform) conventions we use. I just use : with no scsi or drivers prefix because the git tree is tagged [SCSI]; others are different. James -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/18] Altera FPGA firmware download module.
On Fri, 31 Dec 2010 09:47:41 -0200, Mauro Carvalho Chehab wrote: > > I understand this. However, a complete JTAG state machine in the kernel, > > plus > > an Altera firmware parser, seems to be a lot of code that could live in > > userspace. > > Moving it to userspace would mean a kernel driver that would depend on an > userspace daemon^Wfirmware loader to work. I would NAK such designs. > Why? I agree that JTAG is a lot to place in the kernel and is much better suited to be in user space. What exactly is your objection to depending on a userspace utility? There is no shortage of precedent for loading firmware in userspace (e.g. fx2 usb devices). > > If I understand it correctly the driver assumes the firmware is in an > > Altera > > proprietary format. If we really want JTAG code in the kernel we should at > > least split the file parser and the TAP access code. > > > > Agreed, but I don't think this would be a good reason to block the code merge > for .38. > I agree with the above isn't good reason to block it but if there is still debate about the general architecture of the code (see above), then it seems aren't ready yet. The code looks very nice, but I'm not at all convinced that it needs to be in the kernel. Just my two-tenths of a cent. Cheers, - Ben -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: nasty bug at qv4l2
Hi,
Hans V. I've tested your patch for avoiding the double
conversion problem, and I can report it fixes the issue seen with
webcameras which need 90 degrees rotation.
While testing I found a bug in gspca, which gets triggered by
qv4l2 which makes it impossible to switch between userptr and
mmap mode. While fixing that I also found some locking issues in
gspca. As these all touch the gscpa core I'll send a patch set
to Jean Francois Moine for this.
With the issues in gspca fixed, I found a bug in qv4l2 when using
read mode in raw mode (not passing the correct src_size to
libv4lconvert_convert).
I've attached 2 patches to qv4l2, fixing the read issue and a similar
issue in mmap / userptr mode. These apply on top of your patch.
Regards,
Hans
>From d3393364292441fca894186c406a7e9ee982d243 Mon Sep 17 00:00:00 2001
From: Hans de Goede
Date: Fri, 31 Dec 2010 11:50:28 +0100
Subject: [PATCH 1/2] qv4l2: Check and use result of read()
qv4l2 was calling libv4lconvert_convert with a src size of fmt.pix.sizeimage,
rather then using the actual amount of bytes read. This causes decompressors
which check if they have consumed the entire compressed frame (ie pjpg) to
error out, because they were not being passed the actual frame size.
This patch fixes this, and also adds reporting of libv4lconvert_convert
errors.
Signed-off-by: Hans de Goede
---
utils/qv4l2/qv4l2.cpp | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/utils/qv4l2/qv4l2.cpp b/utils/qv4l2/qv4l2.cpp
index a085f86..1876b3c 100644
--- a/utils/qv4l2/qv4l2.cpp
+++ b/utils/qv4l2/qv4l2.cpp
@@ -178,11 +178,18 @@ void ApplicationWindow::capFrame()
switch (m_capMethod) {
case methodRead:
s = read(m_frameData, m_capSrcFormat.fmt.pix.sizeimage);
+ if (s < 0) {
+ if (errno != EAGAIN) {
+ error("read");
+ m_capStartAct->setChecked(false);
+ }
+ return;
+ }
if (useWrapper())
- memcpy(m_capImage->bits(), m_frameData,
m_capSrcFormat.fmt.pix.sizeimage);
+ memcpy(m_capImage->bits(), m_frameData, s);
else
err = v4lconvert_convert(m_convertData,
&m_capSrcFormat, &m_capDestFormat,
- m_frameData, m_capSrcFormat.fmt.pix.sizeimage,
+ m_frameData, s,
m_capImage->bits(),
m_capDestFormat.fmt.pix.sizeimage);
break;
@@ -227,6 +234,9 @@ void ApplicationWindow::capFrame()
qbuf(buf);
break;
}
+ if (err == -1)
+ error(v4lconvert_get_error_message(m_convertData));
+
m_capture->setImage(*m_capImage);
if (m_capture->frame() == 1)
refresh();
--
1.7.3.2
>From 4a3587e7466274f74d89a6608999887f3c62e66a Mon Sep 17 00:00:00 2001
From: Hans de Goede
Date: Fri, 31 Dec 2010 11:55:44 +0100
Subject: [PATCH 2/2] qv4l2: When in wrapped mode memcpy the actual framesize
Signed-off-by: Hans de Goede
---
utils/qv4l2/qv4l2.cpp |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/utils/qv4l2/qv4l2.cpp b/utils/qv4l2/qv4l2.cpp
index 1876b3c..bd1db3e 100644
--- a/utils/qv4l2/qv4l2.cpp
+++ b/utils/qv4l2/qv4l2.cpp
@@ -202,7 +202,7 @@ void ApplicationWindow::capFrame()
if (useWrapper())
memcpy(m_capImage->bits(), (unsigned char
*)m_buffers[buf.index].start,
- m_capSrcFormat.fmt.pix.sizeimage);
+ buf.bytesused);
else
err = v4lconvert_convert(m_convertData,
&m_capSrcFormat, &m_capDestFormat,
(unsigned char *)m_buffers[buf.index].start,
buf.bytesused,
@@ -225,7 +225,7 @@ void ApplicationWindow::capFrame()
if (useWrapper())
memcpy(m_capImage->bits(), (unsigned char
*)buf.m.userptr,
- m_capSrcFormat.fmt.pix.sizeimage);
+ buf.bytesused);
else
err = v4lconvert_convert(m_convertData,
&m_capSrcFormat, &m_capDestFormat,
(unsigned char *)buf.m.userptr, buf.bytesused,
--
1.7.3.2
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On 12/31/2010 01:11 AM, Dan Carpenter wrote: On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote: On 12/30/2010 10:45 PM, Grant Likely wrote: On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: The below patch fixes a typo "diable" to "disable". Please let me know if this is correct or not. Signed-off-by: Justin P. Mattock applied, thanks. g. ahh.. thanks.. just cleared up the left out diabled that I had thought I forgotten(ended up separating comments and code and forgot) This is really just defensiveness and random grumbling and grumpiness on my part, but one reason I may have missed the first patch is because your subject lines are crap. Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable regards, dan carpenter alright.. so having the backlash is alright for the subject Thanks for the pointer on this.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
On 12/31/2010 02:27 AM, Mauro Carvalho Chehab wrote:
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
Acked-by: Mauro Carvalho Chehab
PS.: Next time, please c/c linux-media ONLY on patches related to media
drivers (/drivers/video and the corresponding include files). Having to
dig into a series of 15 patches to just actually look on 3 patches
is not nice.
alright...
---
include/media/davinci/vpss.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
index c59cc02..b586495 100644
--- a/include/media/davinci/vpss.h
+++ b/include/media/davinci/vpss.h
@@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
short pplen;
};
-/* Used for enable/diable VPSS Clock */
+/* Used for enable/disable VPSS Clock */
enum vpss_clock_sel {
/* DM355/DM365 */
VPSS_CCDC_CLOCK,
Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Summary of the pending patches up to Dec, 31 (26 patches)
On Fri, 31 Dec 2010, Mauro Carvalho Chehab wrote: > == Soc_camera waiting for Guennadi Liakhovetski > review == > > Aug, 3 2010: [04/11] mt9m111: added new bit offset defines > http://patchwork.kernel.org/patch/116721 Michael Grzeschik > Merged into "Oct,25 2010: [v3] mt9m111: rewrite set_pixfmt" below > Aug, 3 2010: [08/11] mt9m111: added reg_mask function > http://patchwork.kernel.org/patch/116722 Michael Grzeschik > ditto > Aug, 3 2010: [v2,11/11] mt9m111: make use of testpattern > http://patchwork.kernel.org/patch/116730 Michael Grzeschik > A .vidioc_s_input() implementation has been proposed, no reply followed > Oct,25 2010: [v3] mt9m111: rewrite set_pixfmt > http://patchwork.kernel.org/patch/266822 Michael Grzeschik > See my reply to this patch. It has been rejected in that form and there has been no update. > Nov,17 2010: v4l: list entries no need to check > http://patchwork.kernel.org/patch/332611 Figo.zhang > It's the first time I see this one. > Dec, 2 2010: [v3] soc_camera: Add the ability to bind regulators to > soc_camedra dev http://patchwork.kernel.org/patch/373691 Alberto Panizzo > In yesterday's pull request > Dec, 2 2010: [v2] V4L2: Add a v4l2-subdev (soc-camera) driver for OmniVision > OV2640 http://patchwork.kernel.org/patch/374771 Alberto Panizzo > ditto > Dec, 5 2010: [1/2] OMAP1: allow reserving memory for camera > http://patchwork.kernel.org/patch/381601 Janusz Krzysztofik > > Dec, 5 2010: [2/2] OMAP1: Amstrad Delta: reserve memory for camera > http://patchwork.kernel.org/patch/381621 Janusz Krzysztofik > These two could only go via the ARM tree, if at all. > Guennadi, > Probably, several of those patches are obsolete and you already pointed > it to me. > but I probably missed your comments, due to my email issues. Wishing you reliable communication in the new year;) Thanks Guennadi > > == waiting for Hendrik Skarpeid tests == > > Oct,23 2010: DM1105: could not attach frontend 195d:1105 > http://patchwork.kernel.org/patch/279091 Igor M. Liplianin > > > == Waiting for Patrick Boettcher review > == > > May,25 2010: Adding support to the Geniatech/MyGica SBTVD Stick S870 remote > control http://patchwork.kernel.org/patch/102314 Hernán Ordiales > > Jul,14 2010: [1/4] drivers/media/dvb: Remove dead Configs > http://patchwork.kernel.org/patch/111972 Christian Dietrich > > Jul,14 2010: [2/4] drivers/media/dvb: Remove undead configs > http://patchwork.kernel.org/patch/111973 Christian Dietrich > > > == waiting for videobuf2 == > > Mar,17 2010: [2/2] V4L/DVB: buf-dma-sg.c: support non-pageable user-allocated > memor http://patchwork.kernel.org/patch/97263 Arnout Vandecappelle > > Jul,27 2010: videobuf_dma_sg: a new implementation for mmap > http://patchwork.kernel.org/patch/114520 Figo.zhang > > Jul,28 2010: [v2] videobuf_dma_sg: a new implementation for mmap > http://patchwork.kernel.org/patch/114760 Figo.zhang > > Jul,30 2010: [v2] Resend:videobuf_dma_sg: a new implementation for mmap > http://patchwork.kernel.org/patch/115348 Figo.zhang > > > The above patches will likely be obsolete after videobuf2 merge. We need to > double-check > if the needed functionality is provided on videobuf2. > > == Waiting for Mauro Carvalho Chehab fixes > on Docbook == > > Oct,23 2010: [RFC, PATCHv3] DocBook: Add rules to auto-generate some media > docbooks http://patchwork.kernel.org/patch/279201 Mauro Carvalho Chehab > > > == Waiting for a Kworld UB430-AF to test and report back to > Mauro Carvalho Chehab == > > Nov, 8 2010: [RFC] cx231xx: Add support for Kworld UB430 AF > http://patchwork.kernel.org/patch/308712 Mauro Carvalho Chehab > > > > Number of pending patches per reviewer: > Guennadi Liakhovetski : 9 > LinuxTV community : 5 > Manu Abraham : 4 > Patrick Boettcher : 3 > Mauro Carvalho Chehab : 2 > Adams Xu : 1 > Hendrik Skarpeid : 1 > Steven Toth : 1 > > Cheers, > Mauro > > --- > > If you discover any patch submitted via email that weren't caught by > kernel.patchwork.org, this means that the patch got mangled by your emailer. > The more likely cause is that the emailer converted tabs into spaces or broke > long lines. > > If you're using Thunder
[GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs
This is a pull request for a subset of the RFC patch series I posted almost three weeks ago. The only change is cx18 where Andy Walls pointed out some bugs. The same bugs were introduced in cx25840 and Andy's fixes for those had to be applied as well in cx18 for the AV core. I dropped tvaudio, tda7432, tda9875 and ov7670 for now since these need more testing. This has been tested with the vivi, cx18, em28xx and vpif_capture/vpif_display drivers. Regards, Hans The following changes since commit 187134a5875df20356f4dca075db29f294115a47: David Henningsson (1): [media] DVB: IR support for TechnoTrend CT-3650 are available in the git repository at: ssh://linuxtv.org/git/hverkuil/media_tree.git subdev-ctrl1 Hans Verkuil (11): cs5345: use the control framework cx18: Use the control framework. adv7343: use control framework bt819: use control framework saa7110: use control framework tlv320aic23b: use control framework tvp514x: use the control framework tvp5150: use the control framework vpx3220: use control framework tvp7002: use control framework vivi: convert to the control framework and add test controls. drivers/media/video/adv7343.c| 167 +++--- drivers/media/video/adv7343_regs.h |8 +- drivers/media/video/bt819.c | 129 +- drivers/media/video/cs5345.c | 87 ++--- drivers/media/video/cx18/cx18-av-audio.c | 92 ++- drivers/media/video/cx18/cx18-av-core.c | 175 --- drivers/media/video/cx18/cx18-av-core.h | 12 +- drivers/media/video/cx18/cx18-controls.c | 285 -- drivers/media/video/cx18/cx18-controls.h |7 +- drivers/media/video/cx18/cx18-driver.c | 30 ++-- drivers/media/video/cx18/cx18-driver.h |2 +- drivers/media/video/cx18/cx18-fileops.c | 32 +--- drivers/media/video/cx18/cx18-ioctl.c| 24 +-- drivers/media/video/cx18/cx18-mailbox.c |5 +- drivers/media/video/cx18/cx18-mailbox.h |5 - drivers/media/video/cx18/cx18-streams.c | 16 +- drivers/media/video/saa7110.c| 115 +--- drivers/media/video/tlv320aic23b.c | 74 +--- drivers/media/video/tvp514x.c| 236 ++--- drivers/media/video/tvp5150.c| 157 + drivers/media/video/tvp7002.c| 117 + drivers/media/video/vivi.c | 228 +++- drivers/media/video/vpx3220.c| 137 ++- 23 files changed, 773 insertions(+), 1367 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] [RFC] Prio handling and v4l2_device release callback
On Friday, December 31, 2010 12:39:09 Mauro Carvalho Chehab wrote: > Em 31-12-2010 09:25, Hans Verkuil escreveu: > > On Friday, December 31, 2010 12:01:17 Mauro Carvalho Chehab wrote: > >> Em 29-12-2010 19:43, Hans Verkuil escreveu: > >>> This patch series adds two new features to the V4L2 framework. > >>> > >>> The first 5 patches add support for VIDIOC_G/S_PRIORITY. All prio handling > >>> will be done in the core for any driver that either uses struct v4l2_fh > >>> (ivtv only at the moment) or has no open and release file operations (true > >>> for many simple (radio) drivers). In all other cases the driver will have > >>> to do the work. > >> > >> It doesn't make sense to implement this at core, and for some this will > >> happen > >> automatically, while, for others, drivers need to do something. > > > > However, it makes it possible to gradually convert all drivers. > > This will likely mean years of conversion. > > > >>> Eventually all drivers should either use v4l2_fh or never set > >>> filp->private_data. > >> > >> I made a series of patches, due to BKL stuff converting the core to always > >> use v4l2_fh on all drivers. This seems to be the right solution for it. > > > > Can you point me to those patches? I remember seeing them, but can't > > remember where. > > They are at devel/bkl branch. The main one is this: > > http://git.linuxtv.org/media_tree.git?a=commitdiff;h=285267378581fbf852f24f3f99d2e937cd200fd5 > > I remember you had some issues on it, but it is just a matter of fixing them. Thanks, I'll take a look. > > I see two potential problems with this approach: > > > > 1) A lot of drivers do not actually need to allocate a v4l2_fh struct, so it > >wastes memory. But on the other hand, it would be nicely consistent. > > A typical driver allocates at least 2 buffers of 640x480x2. How much memory a > v4l2_fh struct would require? I didn't calculate, but probably less than > 0.01%. > I don't think that the extra consumption of memory will have any real impact, > even > on embedded. On the other hand, if you need to add the priority handling via > code, > you'll probably waste more on codespace than the size of the struct. Actually, I was thinking about the radio drivers which do not use buffers. However, I realized that we also want to add an event that is sent whenever a control changes value. It's not yet implemented, but it's easy to do with the control framework. And since almost all drivers have controls, this also means that all drivers need to use v4l2_fh since that is a prerequisite for events. So it is indeed much better to create v4l2_fh structs in the core. Regards, Hans > > > 2) I prefer for core changes to have the least possible impact to existing > > drivers, > >and just convert existing drivers one by one. > > A per-driver implementation means per-driver errors. A per-core > implementation means > that, once it is fixed, all drivers will be OK. > > > But I would have to see your patch series again to see the impact of such a > > change. > > > > > Regards, > > > > Hans > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Summary of the pending patches up to Dec, 31 (26 patches)
Dear Developers, I'm enclosing the current list of patches that I have on my queue. I did an effort to apply a large amount of patches during the past two weeks, in order to be ready for the 2.6.38 merge window, expected to be after the end year's holiday. I lost about one month of emails from the period between Nov-Dec, so I may have lost a pull request, or some patch comments. I had to fully rely on patchwork for the patches sent during that period. Kernel 2.6.38 will be a nice Kernel for us, as it will contain some very interesting things: - The removal of BKL (in fact, .37 will have that also, but we have some BKL cleanups already for .38, and I suspect that we'll have some bug fixes for the changes during the .38 rc period); - The removal of V4L1 API. We're trying to remove it for a very long time. V4L2 API is here since 2002. That means that we took 8 years to remove the legacy API. - The merge between lirc_i2c and ir-kbd-i2c. The LIRC i2c driver is also very old, and there were several IR key parsers implemented on both. The missing things were migrated into ir-kbd-i2c and some board-specific get key parsers into their respective boards. Due to that, we have enough reasons to celebrate the end of this year and the arrival of the next year. Cheers! I wish you all the best for the coming year! P.S.: 1) I explicitly c/c the developers or the ones waiting for an analysis. If you're a developer and were c/c, please comment on the listed patches. 2) I removed the Videobuf2 patches from the list. I expect to be analyzing and testing them during the next week. == Need more tests/acks from DVB users == Aug, 7 2010: Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function http://patchwork.kernel.org/patch/118147 Marko Ristola * I want to see people testing the above patch, as it seems to improve * * DVB performance by avoiding data copy. * == mantis patches - Waiting for Manu Abraham == Jun,20 2010: [2/2] DVB/V4L: mantis: remove unused files http://patchwork.kernel.org/patch/107062 Bjørn Mork Jul,19 2010: Twinhan DTV Ter-CI (3030 mantis) http://patchwork.kernel.org/patch/112708 Niklas Claesson Aug, 7 2010: Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt http://patchwork.kernel.org/patch/118173 Marko Ristola Oct,10 2010: [v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod http://patchwork.kernel.org/patch/244201 Tuxoholic == for Adams.Xu and Manu Abraham review == Jun,11 2010: stb0899: Removed an extra byte sent at init on DiSEqC bus http://patchwork.kernel.org/patch/105621 Florent AUDEBERT == Waiting for Steven Toth review == Nov,24 2010: [media] saa7164: poll mask set incorrectly http://patchwork.kernel.org/patch/351711 Dan Carpenter == Soc_camera waiting for Guennadi Liakhovetski review == Aug, 3 2010: [04/11] mt9m111: added new bit offset defines http://patchwork.kernel.org/patch/116721 Michael Grzeschik Aug, 3 2010: [08/11] mt9m111: added reg_mask function http://patchwork.kernel.org/patch/116722 Michael Grzeschik Aug, 3 2010: [v2,11/11] mt9m111: make use of testpattern http://patchwork.kernel.org/patch/116730 Michael Grzeschik Oct,25 2010: [v3] mt9m111: rewrite set_pixfmt http://patchwork.kernel.org/patch/266822 Michael Grzeschik Nov,17 2010: v4l: list entries no need to check http://patchwork.kernel.org/patch/332611 Figo.zhang Dec, 2 2010: [v3] soc_camera: Add the ability to bind regulators to soc_camedra dev http://patchwork.kernel.org/patch/373691 Alberto Panizzo Dec, 2 2010: [v2] V4L2: Add a v4l2-subdev (soc-camera) driver for OmniVision OV2640 http://patchwork.kernel.org/patch/374771 Alberto Panizzo Dec, 5 2010: [1/2] OMAP1: allow reserving memory for camera http://patchwork.kernel.org/patch/381601 Janusz Krzysztofik Dec, 5 2010: [2/2] OMAP1: Amstrad Delta: reserve memory for camera http://patchwork.kernel.org/patch/381621 Janusz Krzysztofik Guennadi, Probably, several of those patches are obsolete and you already pointed it to me. but I probably missed your comments, due to my email issues. == waiting for Hendrik Skarpeid tests == Oct,23 2010: DM1105: could not attach frontend 195d:1105 http://patchwork.kernel.org/patch/279091 Igor M. Liplianin == Waiting for Patrick Boettcher review
Re: [PATVH] media, dvb, IX2505V: Remember to free allocated memory in failure path (ix2505v_attach()).
On Fri, 2010-12-31 at 08:30 -0200, Mauro Carvalho Chehab wrote:
> Em 30-12-2010 21:11, Jesper Juhl escreveu:
> > Hi,
> >
> > We may leak the storage allocated to 'state' in
> > drivers/media/dvb/frontends/ix2505v.c::ix2505v_attach() on error.
> > This patch makes sure we free the allocated memory in the failure case.
> >
> >
> > Signed-off-by: Jesper Juhl
> > ---
> > ix2505v.c |1 +
> > 1 file changed, 1 insertion(+)
> >
> > Compile tested only.
> >
> > diff --git a/drivers/media/dvb/frontends/ix2505v.c
> > b/drivers/media/dvb/frontends/ix2505v.c
> > index 55f2eba..fcb173d 100644
> > --- a/drivers/media/dvb/frontends/ix2505v.c
> > +++ b/drivers/media/dvb/frontends/ix2505v.c
> > @@ -293,6 +293,7 @@ struct dvb_frontend *ix2505v_attach(struct dvb_frontend
> > *fe,
> > ret = ix2505v_read_status_reg(state);
> >
> > if (ret & 0x80) {
> > + kfree(state);
>
> Instead of doing the free here, please move it to happen at the error: logic.
> Currently, there's just one error condition, but having part of the
> release/kfree
> logic here and there is not a good idea.
>
> > deb_i2c("%s: No IX2505V found\n", __func__);
> > goto error;
> > }
The state is already freed in ix2505v_release on error.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/18] Altera FPGA firmware download module.
Em 31-12-2010 09:30, Laurent Pinchart escreveu: > Hi Mauro, > > On Friday 31 December 2010 12:27:38 Mauro Carvalho Chehab wrote: >> Em 31-12-2010 09:12, Laurent Pinchart escreveu: >>> Hi Igor, >>> >>> On Friday 31 December 2010 06:26:31 Igor M. Liplianin wrote: It uses STAPL files and programs Altera FPGA through JTAG. Interface to JTAG must be provided from main device module, for example through cx23885 GPIO. >>> >>> It might be a bit late for this comment (sorry for not having noticed the >>> patch set earlier), but... >>> >>> Do we really need a complete JTAG implementation in the kernel ? Wouldn't >>> it better to handle this in userspace with a tiny kernel driver to >>> access the JTAG signals ? >> >> Laurent, >> >> Igor already explained it. From what I understood, the device he is >> working has a firmware that needs to be loaded via JTAG/FPGA. > > I understand this. However, a complete JTAG state machine in the kernel, plus > an Altera firmware parser, seems to be a lot of code that could live in > userspace. Moving it to userspace would mean a kernel driver that would depend on an userspace daemon^Wfirmware loader to work. I would NAK such designs. The way it is is fine from my POV. >> Actually, I liked the idea, as the FPGA programming driver could be >> useful if other drivers have similar usecases. > > If I understand it correctly the driver assumes the firmware is in an Altera > proprietary format. If we really want JTAG code in the kernel we should at > least split the file parser and the TAP access code. > Agreed, but I don't think this would be a good reason to block the code merge for .38. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] [RFC] Prio handling and v4l2_device release callback
Em 31-12-2010 09:25, Hans Verkuil escreveu: > On Friday, December 31, 2010 12:01:17 Mauro Carvalho Chehab wrote: >> Em 29-12-2010 19:43, Hans Verkuil escreveu: >>> This patch series adds two new features to the V4L2 framework. >>> >>> The first 5 patches add support for VIDIOC_G/S_PRIORITY. All prio handling >>> will be done in the core for any driver that either uses struct v4l2_fh >>> (ivtv only at the moment) or has no open and release file operations (true >>> for many simple (radio) drivers). In all other cases the driver will have >>> to do the work. >> >> It doesn't make sense to implement this at core, and for some this will >> happen >> automatically, while, for others, drivers need to do something. > > However, it makes it possible to gradually convert all drivers. This will likely mean years of conversion. > >>> Eventually all drivers should either use v4l2_fh or never set >>> filp->private_data. >> >> I made a series of patches, due to BKL stuff converting the core to always >> use v4l2_fh on all drivers. This seems to be the right solution for it. > > Can you point me to those patches? I remember seeing them, but can't remember > where. They are at devel/bkl branch. The main one is this: http://git.linuxtv.org/media_tree.git?a=commitdiff;h=285267378581fbf852f24f3f99d2e937cd200fd5 I remember you had some issues on it, but it is just a matter of fixing them. > I see two potential problems with this approach: > > 1) A lot of drivers do not actually need to allocate a v4l2_fh struct, so it >wastes memory. But on the other hand, it would be nicely consistent. A typical driver allocates at least 2 buffers of 640x480x2. How much memory a v4l2_fh struct would require? I didn't calculate, but probably less than 0.01%. I don't think that the extra consumption of memory will have any real impact, even on embedded. On the other hand, if you need to add the priority handling via code, you'll probably waste more on codespace than the size of the struct. > 2) I prefer for core changes to have the least possible impact to existing > drivers, >and just convert existing drivers one by one. A per-driver implementation means per-driver errors. A per-core implementation means that, once it is fixed, all drivers will be OK. > But I would have to see your patch series again to see the impact of such a > change. > > Regards, > > Hans > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/18] Altera FPGA firmware download module.
Hi Mauro, On Friday 31 December 2010 12:27:38 Mauro Carvalho Chehab wrote: > Em 31-12-2010 09:12, Laurent Pinchart escreveu: > > Hi Igor, > > > > On Friday 31 December 2010 06:26:31 Igor M. Liplianin wrote: > >> It uses STAPL files and programs Altera FPGA through JTAG. > >> Interface to JTAG must be provided from main device module, > >> for example through cx23885 GPIO. > > > > It might be a bit late for this comment (sorry for not having noticed the > > patch set earlier), but... > > > > Do we really need a complete JTAG implementation in the kernel ? Wouldn't > > it better to handle this in userspace with a tiny kernel driver to > > access the JTAG signals ? > > Laurent, > > Igor already explained it. From what I understood, the device he is > working has a firmware that needs to be loaded via JTAG/FPGA. I understand this. However, a complete JTAG state machine in the kernel, plus an Altera firmware parser, seems to be a lot of code that could live in userspace. > Actually, I liked the idea, as the FPGA programming driver could be > useful if other drivers have similar usecases. If I understand it correctly the driver assumes the firmware is in an Altera proprietary format. If we really want JTAG code in the kernel we should at least split the file parser and the TAP access code. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/18] Altera FPGA firmware download module.
Em 31-12-2010 09:12, Laurent Pinchart escreveu: > Hi Igor, > > On Friday 31 December 2010 06:26:31 Igor M. Liplianin wrote: >> It uses STAPL files and programs Altera FPGA through JTAG. >> Interface to JTAG must be provided from main device module, >> for example through cx23885 GPIO. > > It might be a bit late for this comment (sorry for not having noticed the > patch set earlier), but... > > Do we really need a complete JTAG implementation in the kernel ? Wouldn't it > better to handle this in userspace with a tiny kernel driver to access the > JTAG signals ? > Laurent, Igor already explained it. From what I understood, the device he is working has a firmware that needs to be loaded via JTAG/FPGA. Actually, I liked the idea, as the FPGA programming driver could be useful if other drivers have similar usecases. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] [RFC] Prio handling and v4l2_device release callback
On Friday, December 31, 2010 12:01:17 Mauro Carvalho Chehab wrote: > Em 29-12-2010 19:43, Hans Verkuil escreveu: > > This patch series adds two new features to the V4L2 framework. > > > > The first 5 patches add support for VIDIOC_G/S_PRIORITY. All prio handling > > will be done in the core for any driver that either uses struct v4l2_fh > > (ivtv only at the moment) or has no open and release file operations (true > > for many simple (radio) drivers). In all other cases the driver will have > > to do the work. > > It doesn't make sense to implement this at core, and for some this will happen > automatically, while, for others, drivers need to do something. However, it makes it possible to gradually convert all drivers. > > Eventually all drivers should either use v4l2_fh or never set > > filp->private_data. > > I made a series of patches, due to BKL stuff converting the core to always > use v4l2_fh on all drivers. This seems to be the right solution for it. Can you point me to those patches? I remember seeing them, but can't remember where. I see two potential problems with this approach: 1) A lot of drivers do not actually need to allocate a v4l2_fh struct, so it wastes memory. But on the other hand, it would be nicely consistent. 2) I prefer for core changes to have the least possible impact to existing drivers, and just convert existing drivers one by one. But I would have to see your patch series again to see the impact of such a change. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: support for IR remote TerraTec Cinergy T USB XXS
Em 29-12-2010 12:49, Stefan Kriwanek escreveu: > Dear linux-media developers, > > I think I found a bug in the support of the TerraTec Cinergy T USB XXS > remote control, or maybe just a new hardware revision appeared. > > When I recently bought such a USB-stick I found the remote not working, > instead 'dib0700: Unknown remote controller key' lines appearing in > syslog on each keypress. The dvb_usb_dib0700 kernel module got > autoloaded by my Ubuntu 10.10. I am using current hg revision of v4l-dvb > and load the kernel module using the 'dvb_usb_dib0700_ir_proto=0' > option. Simply adding the keycodes to the driver file > (linux/drivers/media/dvb/dvb-usb/dib0700_devices.c, > patch appended) made things work. Don't use a legacy, obsoleted, discontinued tree when writing patches. The mercurial tree is obsolete, and it is there just to preserve the tree history. Instead, you should use the git tree. The media_build tree[1] provides a feature similar to the old hg tree. [1] http://git.linuxtv.org/media_build.git The IR code has changed _a_lot_ since the last update in -hg. Basically, the entire support were rewritten, and now the protocol is (or should) be auto-detected. Douglas, It would be a good idea to write a patch for the legacy mercurial tree warning people about that. > > However, by incident I found those very keycodes are already defined in > the linux/drivers/media/IR/keymaps/rc-nec-terratec-cinergy-xs.c file, so > maybe the issue is just about loading it? > > 'lsusb' lists my device as > Bus 001 Device 006: ID 0ccd:00ab TerraTec Electronic GmbH > despite I do not own the 'HD' version of the device, your wiki > http://linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_XXS > says that ID corresponds to. The output of 'lsusb -v' is appended to > this mail. > > 'cat /proc/bus/input/devices' lists the input device as > I: Bus=0003 Vendor=0ccd Product=00ab Version=0100 > N: Name="IR-receiver inside an USB DVB receiver" > P: Phys=usb-:00:12.2-2/ir0 > S: Sysfs=/devices/pci:00/:00:12.2/usb1/1-2/input/input13 > U: Uniq= > H: Handlers=kbd event8 > B: EV=3 > B: KEY=14afc336 2b4285f 0 480158000 21904801 9e96c0 > 90024010004ffc > > I hope you could add support for my stick; I'd be happy to provide > further information if necessary. > > Best regards > Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/18] Altera FPGA firmware download module.
Hi Igor, On Friday 31 December 2010 06:26:31 Igor M. Liplianin wrote: > It uses STAPL files and programs Altera FPGA through JTAG. > Interface to JTAG must be provided from main device module, > for example through cx23885 GPIO. It might be a bit late for this comment (sorry for not having noticed the patch set earlier), but... Do we really need a complete JTAG implementation in the kernel ? Wouldn't it better to handle this in userspace with a tiny kernel driver to access the JTAG signals ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] [RFC] Prio handling and v4l2_device release callback
Em 29-12-2010 19:43, Hans Verkuil escreveu: > This patch series adds two new features to the V4L2 framework. > > The first 5 patches add support for VIDIOC_G/S_PRIORITY. All prio handling > will be done in the core for any driver that either uses struct v4l2_fh > (ivtv only at the moment) or has no open and release file operations (true > for many simple (radio) drivers). In all other cases the driver will have > to do the work. It doesn't make sense to implement this at core, and for some this will happen automatically, while, for others, drivers need to do something. > Eventually all drivers should either use v4l2_fh or never set > filp->private_data. I made a series of patches, due to BKL stuff converting the core to always use v4l2_fh on all drivers. This seems to be the right solution for it. > All drivers that use the control framework must also use core-prio handling > since control handling is no longer done through v4l2_ioctl_ops, so the driver > doesn't have an easy way of checking the priority before changing a control. > > By default all device nodes use the same priority state in v4l2_device, but > drivers can assign the prio field in video_device to a different priority > state, > allowing e.g. all capture device nodes to use a different priority from all > the display device nodes. > > The v4l2_ioctl.c code will check the ioctls whether or not they are allowed > based on the current priority. The vidioc_default callback has a new argument > that just tells the driver whether the prio is OK or not. The driver can use > this argument to return -EBUSY for those commands that modify state of the > driver. > > The following three patches implement this in ivtv and update the > documentation. > > The last two patches add a release callback in v4l2_device which will be > called > when the last registered device node is removed. This is very useful for > implementing the hotplug disconnect functionality as it provides a single > clean > up callback when the last user of any of the unregistered device nodes has > closed its filehandle. For drivers with just a single device node this is not > very relevant since the video_device release() does the same job, but for > drivers that create multiple device nodes (e.g. usbvision) this is a > must-have. > > An example of how this would be used can be found in the dsbr100 patches in > this branch: > > http://git.linuxtv.org/hverkuil/media_tree.git?a=shortlog;h=refs/heads/usbvision > > Comments? > > Regards, > > Hans > > Hans Verkuil (10): > v4l2_prio: move from v4l2-common to v4l2-dev. > v4l2: add v4l2_prio_state to v4l2_device and video_device > v4l2-fh: implement v4l2_priority support. > v4l2-dev: add and support flag V4L2_FH_USE_PRIO. > v4l2-ioctl: add priority handling support. > ivtv: convert to core priority handling. > ivtv: use core-assisted locking. > v4l2-framework: update documentation for new prio field > v4l2-device: add kref and a release function > v4l2-framework.txt: document new v4l2_device release() callback > > Documentation/video4linux/v4l2-framework.txt | 34 - > drivers/media/radio/radio-si4713.c |3 +- > drivers/media/video/cx18/cx18-ioctl.c|3 +- > drivers/media/video/davinci/vpfe_capture.c |2 +- > drivers/media/video/ivtv/ivtv-driver.h |2 - > drivers/media/video/ivtv/ivtv-fileops.c | 17 + > drivers/media/video/ivtv/ivtv-ioctl.c| 77 +--- > drivers/media/video/ivtv/ivtv-streams.c |1 + > drivers/media/video/meye.c |3 +- > drivers/media/video/mxb.c|3 +- > drivers/media/video/v4l2-common.c| 63 > drivers/media/video/v4l2-dev.c | 101 > +- > drivers/media/video/v4l2-device.c| 16 > drivers/media/video/v4l2-fh.c|4 + > drivers/media/video/v4l2-ioctl.c | 73 +-- > include/media/v4l2-common.h | 15 > include/media/v4l2-dev.h | 24 ++ > include/media/v4l2-device.h | 14 > include/media/v4l2-fh.h |1 + > include/media/v4l2-ioctl.h |2 +- > 20 files changed, 286 insertions(+), 172 deletions(-) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/18] Altera FPGA firmware download module.
Em 31-12-2010 03:26, Igor M. Liplianin escreveu: > It uses STAPL files and programs Altera FPGA through JTAG. > Interface to JTAG must be provided from main device module, > for example through cx23885 GPIO. > > Signed-off-by: Igor M. Liplianin There's something wrong with the way you sent your patches: They were sent with some random dates (most patches are from Aug), so they went out-of-order in patchwork and at the default email display order. Also, patch 4/18 seems missed. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/15]arch:m68k:ifpsp060:src:fpsp.S Typo change diable to disable.
On Fri, Dec 31, 2010 at 00:07, Justin P. Mattock
wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock
Acked-by: Geert Uytterhoeven
> ---
> arch/m68k/ifpsp060/src/fpsp.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/ifpsp060/src/fpsp.S b/arch/m68k/ifpsp060/src/fpsp.S
> index 73613b5..26e85e2 100644
> --- a/arch/m68k/ifpsp060/src/fpsp.S
> +++ b/arch/m68k/ifpsp060/src/fpsp.S
> @@ -3881,7 +3881,7 @@ _fpsp_fline:
> # FP Unimplemented Instruction stack frame and jump to that entry
> # point.
> #
> -# but, if the FPU is disabled, then we need to jump to the FPU diabled
> +# but, if the FPU is disabled, then we need to jump to the FPU disabled
> # entry point.
> movc %pcr,%d0
> btst &0x1,%d0
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATVH] media, dvb, IX2505V: Remember to free allocated memory in failure path (ix2505v_attach()).
Em 30-12-2010 21:11, Jesper Juhl escreveu:
> Hi,
>
> We may leak the storage allocated to 'state' in
> drivers/media/dvb/frontends/ix2505v.c::ix2505v_attach() on error.
> This patch makes sure we free the allocated memory in the failure case.
>
>
> Signed-off-by: Jesper Juhl
> ---
> ix2505v.c |1 +
> 1 file changed, 1 insertion(+)
>
> Compile tested only.
>
> diff --git a/drivers/media/dvb/frontends/ix2505v.c
> b/drivers/media/dvb/frontends/ix2505v.c
> index 55f2eba..fcb173d 100644
> --- a/drivers/media/dvb/frontends/ix2505v.c
> +++ b/drivers/media/dvb/frontends/ix2505v.c
> @@ -293,6 +293,7 @@ struct dvb_frontend *ix2505v_attach(struct dvb_frontend
> *fe,
> ret = ix2505v_read_status_reg(state);
>
> if (ret & 0x80) {
> + kfree(state);
Instead of doing the free here, please move it to happen at the error: logic.
Currently, there's just one error condition, but having part of the
release/kfree
logic here and there is not a good idea.
> deb_i2c("%s: No IX2505V found\n", __func__);
> goto error;
> }
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 12/15]drivers:media:video:tvp7002.c Typo change diable to disable.
Em 30-12-2010 21:08, Justin P. Mattock escreveu: > The below patch fixes a typo "diable" to "disable". Please let me know if > this > is correct or not. > > Signed-off-by: Justin P. Mattock Acked-by: Mauro Carvalho Chehab > > --- > drivers/media/video/tvp7002.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c > index e63b40f..c799e4e 100644 > --- a/drivers/media/video/tvp7002.c > +++ b/drivers/media/video/tvp7002.c > @@ -789,7 +789,7 @@ static int tvp7002_query_dv_preset(struct v4l2_subdev *sd, > * Get the value of a TVP7002 decoder device register. > * Returns zero when successful, -EINVAL if register read fails or > * access to I2C client fails, -EPERM if the call is not allowed > - * by diabled CAP_SYS_ADMIN. > + * by disabled CAP_SYS_ADMIN. > */ > static int tvp7002_g_register(struct v4l2_subdev *sd, > struct v4l2_dbg_register *reg) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
> The below patch fixes a typo "diable" to "disable". Please let me know if
> this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock
Acked-by: Mauro Carvalho Chehab
PS.: Next time, please c/c linux-media ONLY on patches related to media
drivers (/drivers/video and the corresponding include files). Having to
dig into a series of 15 patches to just actually look on 3 patches
is not nice.
>
> ---
> include/media/davinci/vpss.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
> index c59cc02..b586495 100644
> --- a/include/media/davinci/vpss.h
> +++ b/include/media/davinci/vpss.h
> @@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
> short pplen;
> };
>
> -/* Used for enable/diable VPSS Clock */
> +/* Used for enable/disable VPSS Clock */
> enum vpss_clock_sel {
> /* DM355/DM365 */
> VPSS_CCDC_CLOCK,
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 7/9] media: MFC: Add MFC v5.1 V4L2 driver
Hi Hans,
Thanks for the review. I will answer, because some of your comments apply to
my patch.
Sorry for replying so late - I've been ill for the past few days. I also
have a question
about the control framework.
> -Original Message-
> From: Hans Verkuil [mailto:hverk...@xs4all.nl]
> Sent: 22 December 2010 14:01
> To: Jeongtae Park
> Cc: linux-media@vger.kernel.org; linux-samsung-...@vger.kernel.org;
> k.deb...@samsung.com; jaeryul...@samsung.com; kgene@samsung.com;
> ben-li...@fluff.org; jonghun@samsung.com
> Subject: Re: [PATCH 7/9] media: MFC: Add MFC v5.1 V4L2 driver
>
> A quick review:
>
> On Wednesday, December 22, 2010 12:54:43 Jeongtae Park wrote:
> > Multi Format Codec v5.1 is a module available on S5PC110 and S5PC210
> > Samsung SoCs. Hardware is capable of handling a range of video codecs
> > and this driver provides V4L2 interface for video decoding &
> encoding.
> >
> > Reviewed-by: Peter Oh
> > Signed-off-by: Jeongtae Park
> > ---
> > drivers/media/video/Kconfig |8 +
> > drivers/media/video/Makefile |1 +
> > drivers/media/video/s5p-mfc/Makefile |3 +
> > drivers/media/video/s5p-mfc/regs-mfc5.h | 356 +++
> > drivers/media/video/s5p-mfc/s5p_mfc.c| 3237
> ++
>
> Over 3000 lines?! I strongly suggest splitting up this source, it's way
> too
> big.
In my patch it was around 2000 lines. I understand that after adding
encoding
by Jeongtae Park this became even larger.
> > drivers/media/video/s5p-mfc/s5p_mfc_common.h | 333 +++
> > drivers/media/video/s5p-mfc/s5p_mfc_ctrls.h | 622 +
> > drivers/media/video/s5p-mfc/s5p_mfc_debug.h | 55 +
> > drivers/media/video/s5p-mfc/s5p_mfc_intr.c | 94 +
> > drivers/media/video/s5p-mfc/s5p_mfc_intr.h | 26 +
> > drivers/media/video/s5p-mfc/s5p_mfc_memory.h | 42 +
> > drivers/media/video/s5p-mfc/s5p_mfc_opr.c| 1349 +++
> > drivers/media/video/s5p-mfc/s5p_mfc_opr.h| 147 ++
> > 13 files changed, 6273 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/media/video/s5p-mfc/Makefile
> > create mode 100644 drivers/media/video/s5p-mfc/regs-mfc5.h
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc.c
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_common.h
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_ctrls.h
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_debug.h
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_intr.c
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_intr.h
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_memory.h
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_opr.c
> > create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_opr.h
> >
>
>
>
> > diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c
> b/drivers/media/video/s5p-mfc/s5p_mfc.c
> > new file mode 100644
> > index 000..2653864
> > --- /dev/null
> > +++ b/drivers/media/video/s5p-mfc/s5p_mfc.c
> > @@ -0,0 +1,3237 @@
>
>
>
> > +/* Get format */
> > +static int vidioc_g_fmt(struct file *file, void *priv, struct
> v4l2_format *f)
> > +{
> > + struct s5p_mfc_ctx *ctx = priv;
> > +
> > + mfc_debug_enter();
> > + mfc_debug("f->type = %d ctx->state = %d\n", f->type, ctx->state);
> > + if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE &&
> > + ctx->state == MFCINST_GOT_INST) {
> > + /* If the MFC is parsing the header,
> > +* so wait until it is finished */
> > + s5p_mfc_clean_ctx_int_flags(ctx);
> > + s5p_mfc_wait_for_done_ctx(ctx,
> S5P_FIMV_R2H_CMD_SEQ_DONE_RET,
> > + 1);
> > + }
> > + if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE &&
> > + ctx->state >= MFCINST_HEAD_PARSED &&
> > + ctx->state <= MFCINST_ABORT) {
> > + /* This is run on CAPTURE (deocde output) */
> > + /* Width and height are set to the dimensions
> > + of the movie, the buffer is bigger and
> > + further processing stages should crop to this
> > + rectangle. */
> > + f->fmt.pix_mp.width = ctx->buf_width;
>
> Create a temp variable pointing to &f->fmt.pix_mp and use that in this
> and
> the next function. It makes it easier to read.
Good idea, I will do it that way.
> > + f->fmt.pix_mp.height = ctx->buf_height;
> > + f->fmt.pix_mp.field = V4L2_FIELD_NONE;
> > + f->fmt.pix_mp.num_planes = 2;
> > + /* Set pixelformat to the format in which MFC
> > + outputs the decoded frame */
> > + f->fmt.pix_mp.pixelformat = V4L2_PIX_FMT_NV12MT;
> > + f->fmt.pix_mp.plane_fmt[0].bytesperline = ctx->buf_width;
> > + f->fmt.pix_mp.plane_fmt[0].sizeimage = ctx->luma_size;
> > + f->fmt.pix_mp.plane_fmt[1].bytesperline = ctx->buf_width;
> > + f->fmt.pix_mp.plane_fmt[1].sizeimag
Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
Em 30-12-2010 21:08, Justin P. Mattock escreveu: > The below patch fixes a typo "diable" to "disable". Please let me know if > this > is correct or not. > > Signed-off-by: Justin P. Mattock Acked-by: Mauro Carvalho Chehab > > --- > drivers/media/video/cx18/cx23418.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/cx18/cx23418.h > b/drivers/media/video/cx18/cx23418.h > index 2c00980..7e40035 100644 > --- a/drivers/media/video/cx18/cx23418.h > +++ b/drivers/media/video/cx18/cx23418.h > @@ -177,7 +177,7 @@ > IN[0] - Task handle. > IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical > only, > 3 = 2D H/V separable, 4 = 2D symmetric non-separable > - IN[2] - chroma type: 0 - diable, 1 = 1D horizontal > + IN[2] - chroma type: 0 - disable, 1 = 1D horizontal > ReturnCode - One of the ERR_CAPTURE_... */ > #define CX18_CPU_SET_SPATIAL_FILTER_TYPE (CPU_CMD_MASK_CAPTURE | > 0x000C) > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Ci+ CAM support
Hi Which hardware does have a CI+ CAM ? Does Linux support CI+ CAM or will it be implemented in the future ? Thanks Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote: > On 12/30/2010 10:45 PM, Grant Likely wrote: > >On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: > >>The below patch fixes a typo "diable" to "disable". Please let me know if > >>this > >>is correct or not. > >> > >>Signed-off-by: Justin P. Mattock > > > >applied, thanks. > > > >g. > > ahh.. thanks.. just cleared up the left out diabled that I had > thought I forgotten(ended up separating comments and code and > forgot) This is really just defensiveness and random grumbling and grumpiness on my part, but one reason I may have missed the first patch is because your subject lines are crap. Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
