Re: [PATCH] cx23885: Added support for AVerTV Hybrid Express Slim HC81R (only analog)
субота, 03-лис-2012 16:41:10 Andy Walls написано: Oleg Kravchenko o...@kaa.org.ua wrote: Hello! Please review my patch. Supported inputs: Television, S-Video, Component. Modules options: options cx25840 firmware=v4l-cx23418-dig.fw Hi, Please do not use the CX23418 digitizer firmware with the CX2388[578] chips. Use the proper cx23885 digitizer firmware. You need the proper firmware to get the best results in detecting the audio standard in broadcast analog video. Regards, Andy Windows driver use v4l-cx23418-dig.fw 95bc688d3e7599fd5800161e9971cc55 merlinAVC.rom 95bc688d3e7599fd5800161e9971cc55 /lib/firmware/v4l-cx23418-dig.fw So, i think this is a proper firmware :) -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: small regression in mediatree/for_v3.7-3 - media_build
--- On Sat, 3/11/12, VDR User user@gmail.com wrote: On Tue, Aug 14, 2012 at 4:51 PM, Antti Palosaari cr...@iki.fi wrote: There seems to be a small regression on mediatree/for_v3.7-3 - dmesg/klog get flooded with these: [201145.140260] dvb_frontend_poll: 15 callbacks suppressed [201145.586405] usb_urb_complete: 88 callbacks suppressed [201150.587308] usb_urb_complete: 3456 callbacks suppressed [201468.630197] usb_urb_complete: 3315 callbacks suppressed [201473.632978] usb_urb_complete: 3529 callbacks suppressed [201478.635400] usb_urb_complete: 3574 callbacks suppressed It seems to be every 5 seconds, but I think that's just klog skipping repeats and collapsing duplicate entries. This does not happen the last time I tried playing with the TV stick :-). That's because you has dynamic debugs enabled! modprobe dvb_core; echo -n 'module dvb_core +p' /sys/kernel/debug/dynamic_debug/control modprobe dvb_usbv2; echo -n 'module dvb_usbv2 +p' /sys/kernel/debug/dynamic_debug/control If you don't add dvb_core and dvb_usbv2 modules to /sys/kernel/debug/dynamic_debug/control you will not see those. I'm getting massive amounts of dvb_frontend_poll: 20 callbacks suppressed messages in dmesg also and I definitely did not put dvb_core or anything else in /sys/kernel/debug/dynamic_debug/control. For that matter I don't even have a /sys/kernel/debug/dynamic_debug/control file. I have added ratelimited version for those few debugs that are flooded normally. This suppressed is coming from ratelimit - it does not print all those similar debugs. I'm using kernel 3.6.3 with media_build from Oct. 21, 2012. How I can disable those messages? I'd rather not see hundreds, possibly thousands or millions of those messages. :) okay, if you had followed the threads further down, you would probably see that I patched the host side copy of device.h, i.e: /lib/modules/`uname -r `/build/include/linux/device.h to get around this, since media_build does not use a full dev kernel tree, but uses the host-side copy of the kernel headers. So you need to apply the patch (attached) to that. i.e. cd /lib/modules/`uname -r `/build/include/linux/ patch -p3 /tmp/patch Mind you this messes up your kernel-dev headers. In my case, because that file is part of the fedora distro kernel-devel package, and as soon as I get a new kernel the whole thing is thrown away, so I don't care. But if you compile your own kernel (and hence have your own kernel-devel headers which you want to keep in clean state), you might want to take note about this. Hope this helps. patch Description: Binary data
Re: [segfault] running ir-keytable with v4l-utils 0.8.9
Hello, On 10/27/12 1:26 PM, Gregor Jasny wrote: I looked at the crash and it seems that the rc_dev structure is not initialized when a device name is set on the command line. Could you please take a look? I filed this as a Fedora bug report so that it does not get lost: https://bugzilla.redhat.com/show_bug.cgi?id=872927 Thanks, Gregor -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 1/8] video: add display_timing struct and helpers
On Thu, Nov 01, 2012 at 09:08:42PM +0100, Thierry Reding wrote:
On Wed, Oct 31, 2012 at 10:28:01AM +0100, Steffen Trumtrar wrote:
[...]
+void timings_release(struct display_timings *disp)
+{
+ int i;
+
+ for (i = 0; i disp-num_timings; i++)
+ kfree(disp-timings[i]);
+}
+
+void display_timings_release(struct display_timings *disp)
+{
+ timings_release(disp);
+ kfree(disp-timings);
+}
I'm not quite sure I understand how these are supposed to be used. The
only use-case where a struct display_timings is dynamically allocated is
for the OF helpers. In that case, wouldn't it be more useful to have a
function that frees the complete structure, including the struct
display_timings itself? Something like this, which has all of the above
rolled into one:
void display_timings_free(struct display_timings *disp)
{
if (disp-timings) {
unsigned int i;
for (i = 0; i disp-num_timings; i++)
kfree(disp-timings[i]);
}
kfree(disp-timings);
kfree(disp);
}
Well, you are right. They can be rolled into one function.
The extra function call is useless and as it seems confusing.
Regards,
Steffen
___
devicetree-discuss mailing list
devicetree-disc...@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 2/8] of: add helper to parse display timings
On Thu, Nov 01, 2012 at 09:15:10PM +0100, Thierry Reding wrote: On Wed, Oct 31, 2012 at 10:28:02AM +0100, Steffen Trumtrar wrote: [...] diff --git a/Documentation/devicetree/bindings/video/display-timings.txt b/Documentation/devicetree/bindings/video/display-timings.txt [...] @@ -0,0 +1,139 @@ +display-timings bindings +== + +display-timings-node + Maybe extend the underline to the length of the section and subsection titles respectively? +struct display_timing +=== Same here. +config OF_DISPLAY_TIMINGS + def_bool y + depends on DISPLAY_TIMING Maybe this should be called OF_DISPLAY_TIMING to match DISPLAY_TIMING, or rename DISPLAY_TIMING to DISPLAY_TIMINGS for the sake of consistency? Yes, to all three above. +/** + * of_get_display_timing_list - parse all display_timing entries from a device_node + * @np: device_node with the subnodes + **/ +struct display_timings *of_get_display_timing_list(struct device_node *np) Perhaps this would better be named of_get_display_timings() to match the return type? Hm, I'm not really sure about that. I found it to error prone, to have a function of_get_display_timing and of_get_display_timings. That's why I chose of_get_display_timing_list. But you are correct, that it doesn't match the return value. Maybe I should just make the first function static and change the name as you suggested. + disp = kzalloc(sizeof(*disp), GFP_KERNEL); Shouldn't you be checking this for allocation failures? + disp-timings = kzalloc(sizeof(struct display_timing *)*disp-num_timings, + GFP_KERNEL); Same here. Yes, to both. Regards, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 2/8] of: add helper to parse display timings
Hi!
On Fri, Nov 02, 2012 at 10:49:47PM +0530, Leela Krishna Amudala wrote:
Hello Steffen,
On Wed, Oct 31, 2012 at 2:58 PM, Steffen Trumtrar
+static int parse_property(struct device_node *np, char *name,
+ struct timing_entry *result)
+{
+ struct property *prop;
+ int length;
+ int cells;
+ int ret;
+
+ prop = of_find_property(np, name, length);
+ if (!prop) {
+ pr_err(%s: could not find property %s\n, __func__, name);
+ return -EINVAL;
+ }
+
+ cells = length / sizeof(u32);
+ if (cells == 1) {
+ ret = of_property_read_u32_array(np, name, result-typ,
cells);
As you are reading only one vaue, you can use of_property_read_u32 instead.
Yes, thats copypasta, no need for _array here.
+ result-min = result-typ;
+ result-max = result-typ;
+ } else if (cells == 3) {
+ ret = of_property_read_u32_array(np, name, result-min,
cells);
You are considering only min element, what about typ and max elements?
I start at the address of result-min and read three u32-values, therefore all
three (min,typ,max) are filled with values.
+
+/**
+ * of_display_timings_exists - check if a display-timings node is provided
+ * @np: device_node with the timing
+ **/
+int of_display_timings_exists(struct device_node *np)
+{
+ struct device_node *timings_np;
+ struct device_node *default_np;
+
+ if (!np)
+ return -EINVAL;
+
+ timings_np = of_parse_phandle(np, display-timings, 0);
+ if (!timings_np)
+ return -EINVAL;
+
+ return -EINVAL;
Here it should return success instead of -EINVAL.
Yes.
And one query.. are the binding properties names and display-timings
node structure template finalized..?
I sure hope so. There actually is one error in the examples though.
The property clock is called clock-frequency. I included it correctly
at the top of display-timings.txt, but overlooked it in the examples.
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 10/23] V4L: Add auto focus targets to the selections API
Hi Sylwester, Thanks for the update! On Mon, Oct 29, 2012 at 11:43:07PM +0100, Sylwester Nawrocki wrote: Hi Sakari, On 10/29/2012 09:00 PM, Sakari Ailus wrote: On Thu, May 10, 2012 at 12:30:45PM +0200, Sylwester Nawrocki wrote: The camera automatic focus algorithms may require setting up a spot or rectangle coordinates or multiple such parameters. The automatic focus selection targets are introduced in order to allow applications to query and set such coordinates. Those selections are intended to be used together with the automatic focus controls available in the camera control class. Signed-off-by: Sylwester Nawrockis.nawro...@samsung.com Signed-off-by: Kyungmin Parkkyungmin.p...@samsung.com --- Documentation/DocBook/media/v4l/selection-api.xml | 33 +++- .../DocBook/media/v4l/vidioc-g-selection.xml | 11 +++ include/linux/videodev2.h |5 +++ 3 files changed, 48 insertions(+), 1 deletion(-) What's the status of this patch? May I ask if you have plans to continue with it? Thanks for reminding about it. I'd like to make this ready for v3.8, if possible. I've done some minor improvements of the related V4L2_CID_AUTO_FOCUS_AREA control and we use this patch internally. We would like to see how all this can be used for auto focus feature of the s5c73m3 camera. I hope to have these patches posted next week. I'm looking forward to that! Speaking of multiple AF windows --- I originally thought we could just have multiple selection targets for them. I'm not sure which one would be better; multiple selection targets or another field telling the window ID. In case of the former we'd leave a largish gap for additional window IDs. I think I'm leaning towards using one reserved field for the purpose. That also as my preference. I imagine the ID field could be reused for other future or existing selection targets anyway. I recall someone already asked about multiple ROI support for image cropping [1], perhaps the ID field could be used also for that. I wonder how that would make sense with a single stream. Selections could also be used on the event interface: they fit exactly to the union there. One of the applications is passing face tracking information to the user space. Another question I had was that which of the selection rectangles would the AF rectangle be related to? Is it the compose bounds rectangle, or the crop bounds rectangle, for example? I thought it might make sense to use another field to tell that, since I think which one this really is related to is purely hardware specific. It's indeed very hardware specific. I've seen sensors that allow to define bounds for the auto focus rectangle entirely independent from the output format, crop or compose rectangle. It may look strange, but some sensor firmwares just accept rectangle/point coordinates with bounds rectangle corresponding to video display area (so it is easy, e.g. to use coordinates coming directly from a touchscreen) and then perform required calculations to map/scale it onto e.g. sensor crop or output rectangle. I guess your question is related to how to determine in what stage of video pipeline the AF selections would be and what the configuration order should be from the user space side ? How to determine what the coordinates are related to. Only that, and inside a single subdev, actually. The rest is already well visible to the user. The targets defined up to now are well defined in relation to the other targets in the documentation. About the configuration order --- the AF window target could likely be configured after the related target has been configured. Perhaps this information should actually come from VIDIOC_(SUBDEV_,)QUERY_SELECTION. :-) I think this can well be done later on. Kind regards, -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
avermedia, new version of avertv volar green hd
Bonjour,
It's a dvb-t usb dongle
It's the same name than a former device but with new id : 07ca:3835
instead of 07ca:a835 and probably new hardware ; and it doesn't work...
I've tried to enter a new device in the v4l-dvb web list but nothing has
happened ; the source, can be found at
http://www.linuxtv.org/wiki/index.php?title=DVB-T_USB_Devices_ListData/Helperaction=editsection=1
I've made a photo too but don't know how I can upload it.
Anyway, here is the source :
AVerMedia AVerTV Volar Green HD 07ca:3835
{{DeviceDisplayMedium|AVerMedia AVerTV Volar Green HD 07ca:3835}}
/noincludeincludeonly
{renderwith}}}|src=USB_Device_Data|selatt1={{{selatt1|}}}|selval1={{{selval1|}}}|selatt2={{{selatt2|}}}|selval2={{{selval2|}}}|selatt3={{{selatt3|}}}|selval3={{{selval3|}}}|selatt4={{{selatt4|}}}|selval4={{{selval4|}}}
| did=AVerMedia AVerTV Volar Green HD 07ca:3835
| vendor=[[AVerMedia]]
| device=[[AVerMedia AVerTV Volar Green HD | AVerTV Volar Green HD]]
| standard=DVB-T
| supported={{no}}
| pic=
| pic=
| url=
| url=
| hostinterface=USB2.0
| usbid=07ca:3835
| hw=unknown (see pic)
| tuner=
| demodulator=
| usbbridge=
| fw=
| comment= New version with same name ; main chipset (square, 4x12 pins)
named AV3007 SXB1102 ; a little chip with 8 pins named 402R6 K207,
another one with 5 pins 215L1(or I instead of 1) AC1H ; last small
chip with metal on top T120 WtBF.
This device don't work on recent ubuntu kernel (3.2.0-23-lowlatency),
even with the last (04/11/2012) v4l drivers that I've downloaded and
install today.
}}
cordialement,
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] add MAINTAINERS entry
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- MAINTAINERS | 40 1 file changed, 40 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 28eeaec..ac738f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4100,6 +4100,22 @@ S: Maintained F: Documentation/hwmon/it87 F: drivers/hwmon/it87.c +IT913X MEDIA DRIVER +M: Malcolm Priestley tvbox...@gmail.com +L: linux-media@vger.kernel.org +W: http://linuxtv.org/ +Q: http://patchwork.linuxtv.org/project/linux-media/list/ +S: Maintained +F: drivers/media/usb/dvb-usb-v2/it913x* + +IT913X FE MEDIA DRIVER +M: Malcolm Priestley tvbox...@gmail.com +L: linux-media@vger.kernel.org +W: http://linuxtv.org/ +Q: http://patchwork.linuxtv.org/project/linux-media/list/ +S: Maintained +F: drivers/media/dvb-frontends/it913x-fe* + IVTV VIDEO4LINUX DRIVER M: Andy Walls awa...@md.metrocast.net L: ivtv-de...@ivtvdriver.org (moderated for non-subscribers) @@ -4111,6 +4127,14 @@ F: Documentation/video4linux/*.ivtv F: drivers/media/pci/ivtv/ F: include/linux/ivtv* +IX2505V MEDIA DRIVER +M: Malcolm Priestley tvbox...@gmail.com +L: linux-media@vger.kernel.org +W: http://linuxtv.org/ +Q: http://patchwork.linuxtv.org/project/linux-media/list/ +S: Maintained +F: drivers/media/dvb-frontends/ix2505v* + JC42.4 TEMPERATURE SENSOR DRIVER M: Guenter Roeck li...@roeck-us.net L: lm-sens...@lm-sensors.org @@ -4555,6 +4579,14 @@ S: Maintained F: Documentation/hwmon/lm90 F: drivers/hwmon/lm90.c +LME2510 MEDIA DRIVER +M: Malcolm Priestley tvbox...@gmail.com +L: linux-media@vger.kernel.org +W: http://linuxtv.org/ +Q: http://patchwork.linuxtv.org/project/linux-media/list/ +S: Maintained +F: drivers/media/usb/dvb-usb-v2/lmedm04* + LOCKDEP AND LOCKSTAT M: Peter Zijlstra pet...@infradead.org M: Ingo Molnar mi...@redhat.com @@ -4645,6 +4677,14 @@ W: http://www.tazenda.demon.co.uk/phil/linux-hp S: Maintained F: arch/m68k/hp300/ +M88RS2000 MEDIA DRIVER +M: Malcolm Priestley tvbox...@gmail.com +L: linux-media@vger.kernel.org +W: http://linuxtv.org/ +Q: http://patchwork.linuxtv.org/project/linux-media/list/ +S: Maintained +F: drivers/media/dvb-frontends/m88rs2000* + MAC80211 M: Johannes Berg johan...@sipsolutions.net L: linux-wirel...@vger.kernel.org -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] staging/media: Use dev_ printks in go7007/go7007-driver.c
fixed below checkpatch warning.
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then
pr_info(... to printk(KERN_INFO ...
Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com
---
drivers/staging/media/go7007/go7007-driver.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/go7007/go7007-driver.c
b/drivers/staging/media/go7007/go7007-driver.c
index ece2dd1..c9dfc75 100644
--- a/drivers/staging/media/go7007/go7007-driver.c
+++ b/drivers/staging/media/go7007/go7007-driver.c
@@ -201,7 +201,8 @@ static int init_i2c_module(struct i2c_adapter *adapter,
const char *type,
if (v4l2_i2c_new_subdev(v4l2_dev, adapter, type, addr, NULL))
return 0;
- printk(KERN_INFO go7007: probing for module i2c:%s failed\n, type);
+ dev_info(adapter-dev,
+go7007: probing for module i2c:%s failed\n, type);
return -1;
}
@@ -217,7 +218,7 @@ int go7007_register_encoder(struct go7007 *go)
{
int i, ret;
- printk(KERN_INFO go7007: registering new %s\n, go-name);
+ dev_info(go-dev, go7007: registering new %s\n, go-name);
mutex_lock(go-hw_lock);
ret = go7007_init_encoder(go);
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] staging/media: Use dev_ printks in go7007/wis-sony-tuner.c
fixed below checkpatch warning.
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then
pr_info(... to printk(KERN_INFO ...
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
pr_debug(... to printk(KERN_DEBUG ...
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...
to printk(KERN_ERR ...
Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com
---
drivers/staging/media/go7007/wis-sony-tuner.c | 86 -
1 file changed, 42 insertions(+), 44 deletions(-)
diff --git a/drivers/staging/media/go7007/wis-sony-tuner.c
b/drivers/staging/media/go7007/wis-sony-tuner.c
index 8f1b7d4..3e013b9 100644
--- a/drivers/staging/media/go7007/wis-sony-tuner.c
+++ b/drivers/staging/media/go7007/wis-sony-tuner.c
@@ -95,8 +95,8 @@ static int set_freq(struct i2c_client *client, int freq)
band_name = UHF;
band_select = tun-UHF;
}
- printk(KERN_DEBUG wis-sony-tuner: tuning to frequency %d.%04d (%s)\n,
- freq / 16, (freq % 16) * 625, band_name);
+ dev_dbg(client-dev, tuning to frequency %d.%04d (%s)\n,
+ freq / 16, (freq % 16) * 625, band_name);
n = freq + tun-IFPCoff;
buffer[0] = n 8;
@@ -288,16 +288,16 @@ static int mpx_setup(struct i2c_client *client)
u8 buf1[3], buf2[2];
struct i2c_msg msgs[2];
- printk(KERN_DEBUG wis-sony-tuner: MPX registers: %04x %04x
- %04x %04x %04x %04x %04x %04x\n,
- mpx_audio_modes[t-mpxmode].modus,
- source,
- mpx_audio_modes[t-mpxmode].acb,
- mpx_audio_modes[t-mpxmode].fm_prescale,
- mpx_audio_modes[t-mpxmode].nicam_prescale,
- mpx_audio_modes[t-mpxmode].scart_prescale,
- mpx_audio_modes[t-mpxmode].system,
- mpx_audio_modes[t-mpxmode].volume);
+ dev_dbg(client-dev,
+ MPX registers: %04x %04x %04x %04x %04x %04x %04x
%04x\n,
+ mpx_audio_modes[t-mpxmode].modus,
+ source,
+ mpx_audio_modes[t-mpxmode].acb,
+ mpx_audio_modes[t-mpxmode].fm_prescale,
+ mpx_audio_modes[t-mpxmode].nicam_prescale,
+ mpx_audio_modes[t-mpxmode].scart_prescale,
+ mpx_audio_modes[t-mpxmode].system,
+ mpx_audio_modes[t-mpxmode].volume);
buf1[0] = 0x11;
buf1[1] = 0x00;
buf1[2] = 0x7e;
@@ -310,14 +310,14 @@ static int mpx_setup(struct i2c_client *client)
msgs[1].len = 2;
msgs[1].buf = buf2;
i2c_transfer(client-adapter, msgs, 2);
- printk(KERN_DEBUG wis-sony-tuner: MPX system: %02x%02x\n,
- buf2[0], buf2[1]);
+ dev_dbg(client-dev, MPX system: %02x%02x\n,
+ buf2[0], buf2[1]);
buf1[0] = 0x11;
buf1[1] = 0x02;
buf1[2] = 0x00;
i2c_transfer(client-adapter, msgs, 2);
- printk(KERN_DEBUG wis-sony-tuner: MPX status: %02x%02x\n,
- buf2[0], buf2[1]);
+ dev_dbg(client-dev, MPX status: %02x%02x\n,
+ buf2[0], buf2[1]);
}
#endif
return 0;
@@ -375,8 +375,7 @@ static int set_if(struct i2c_client *client)
t-mpxmode = force_mpx_mode;
else
t-mpxmode = default_mpx_mode;
- printk(KERN_DEBUG wis-sony-tuner: setting MPX to mode %d\n,
- t-mpxmode);
+ dev_dbg(client-dev, setting MPX to mode %d\n, t-mpxmode);
mpx_setup(client);
return 0;
@@ -401,8 +400,8 @@ static int tuner_command(struct i2c_client *client,
unsigned int cmd, void *arg)
if (t-type = 0) {
if (t-type != *type)
- printk(KERN_ERR wis-sony-tuner: type already
- set to %d, ignoring request for %d\n,
+ dev_err(client-dev,
+ type already set to %d, ignoring
request for %d\n,
t-type, *type);
break;
}
@@ -414,28 +413,28 @@ static int tuner_command(struct i2c_client *client,
unsigned int cmd, void *arg)
case 'B':
case 'g':
case 'G':
- printk(KERN_INFO wis-sony-tuner: forcing
- tuner to PAL-B/G bands\n);
+ dev_info(client-dev,
+
Re: Please help me with cx88 audio
Gene K dataclue at yahoo.com writes: I can't get the cx88-alsa driver to produce anything but loud noise (white noise or pink noise) from my FusionHDTV 5 Gold card. This problem has been reported on this list and elsewhere, but seemingly with no resolution, despite a LOT of RTFM and Googling. I have tried a variety of tools and settings, but the result is always the same. Video works. Audio in digital mode works. This is for line in inputs on the card. This is on 3.6.1.fc17.x86_64. Disturbingly, dmesg has a lot of this [ 2754.810011] cx88[0]: irq aud [0x1001] dn_risci1* dn_sync* Can anyone help? It is probably something simple, like the audio-mux/GPIO settings, but I just can't find enough information to fix it myself or even experiment! Is there a way to control audio mux or GPIO explicitly from userspace, so I can try to poke around to see if it's that? Thanks again. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
cron job: media_tree daily build: WARNINGS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Nov 4 19:00:26 CET 2012 git hash:8f7e91a31fb95c50880c76505b416630c0326d93 gcc version: i686-linux-gcc (GCC) 4.7.1 host hardware:x86_64 host os: 3.4.07-marune linux-git-arm-eabi-davinci: WARNINGS linux-git-arm-eabi-exynos: WARNINGS linux-git-arm-eabi-omap: WARNINGS linux-git-i686: OK linux-git-m32r: OK linux-git-mips: OK linux-git-powerpc64: OK linux-git-sh: WARNINGS linux-git-x86_64: OK linux-2.6.31.12-i686: WARNINGS linux-2.6.32.6-i686: WARNINGS linux-2.6.33-i686: WARNINGS linux-2.6.34-i686: WARNINGS linux-2.6.35.3-i686: WARNINGS linux-2.6.36-i686: WARNINGS linux-2.6.37-i686: WARNINGS linux-2.6.38.2-i686: WARNINGS linux-2.6.39.1-i686: WARNINGS linux-3.0-i686: WARNINGS linux-3.1-i686: WARNINGS linux-3.2.1-i686: WARNINGS linux-3.3-i686: WARNINGS linux-3.4-i686: WARNINGS linux-3.5-i686: WARNINGS linux-3.6-i686: WARNINGS linux-3.7-rc1-i686: WARNINGS linux-2.6.31.12-x86_64: WARNINGS linux-2.6.32.6-x86_64: WARNINGS linux-2.6.33-x86_64: WARNINGS linux-2.6.34-x86_64: WARNINGS linux-2.6.35.3-x86_64: WARNINGS linux-2.6.36-x86_64: WARNINGS linux-2.6.37-x86_64: WARNINGS linux-2.6.38.2-x86_64: WARNINGS linux-2.6.39.1-x86_64: WARNINGS linux-3.0-x86_64: WARNINGS linux-3.1-x86_64: WARNINGS linux-3.2.1-x86_64: WARNINGS linux-3.3-x86_64: WARNINGS linux-3.4-x86_64: WARNINGS linux-3.5-x86_64: WARNINGS linux-3.6-x86_64: WARNINGS linux-3.7-rc1-x86_64: WARNINGS apps: WARNINGS spec-git: WARNINGS sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL FOR 3.8] Miscellaneous fixes
Hi Mauro, Please pull from my tree for a bunch of miscellaneous fixes for 3.8 . The following changes since commit 8f7e91a31fb95c50880c76505b416630c0326d93: [media] smiapp-pll: Constify limits argument to smiapp_pll_calculate() (2012-10-29 09:51:38 -0200) are available in the git repository at: git://linuxtv.org/hgoede/gspca.git media-for_v3.8 for you to fetch changes up to e103a482eb63e89a749bab5b6cd645e2c7146346: gspca-sonixb: Add USB-id for Genius Eye 310 (2012-11-04 22:33:10 +0100) Frank Schäfer (2): gspca_pac7302: correct register documentation gspca_pac7302: use registers 0x01 and 0x03 for red and blue balance controls Hans de Goede (4): pwc: Fix codec1 cameras no longer working MAINTAINERS: Add entries for the radioShark and radioShark2 drivers MAINTAINERS: Add an entry for the pwc webcam driver gspca-sonixb: Add USB-id for Genius Eye 310 MAINTAINERS | 22 ++ drivers/media/usb/gspca/pac7302.c | 62 --- drivers/media/usb/gspca/sonixb.c | 1 + drivers/media/usb/pwc/pwc-ctrl.c | 2 ++ 4 files changed, 70 insertions(+), 17 deletions(-) Thanks Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cx23885: Added support for AVerTV Hybrid Express Slim HC81R (only analog)
On Sun, 2012-11-04 at 09:59 +0200, Oleg Kravchenko wrote: субота, 03-лис-2012 16:41:10 Andy Walls написано: Oleg Kravchenko o...@kaa.org.ua wrote: Hello! Please review my patch. Supported inputs: Television, S-Video, Component. Modules options: options cx25840 firmware=v4l-cx23418-dig.fw Hi, Please do not use the CX23418 digitizer firmware with the CX2388[578] chips. Use the proper cx23885 digitizer firmware. You need the proper firmware to get the best results in detecting the audio standard in broadcast analog video. Regards, Andy Windows driver use v4l-cx23418-dig.fw 95bc688d3e7599fd5800161e9971cc55 merlinAVC.rom 95bc688d3e7599fd5800161e9971cc55 /lib/firmware/v4l-cx23418-dig.fw So, i think this is a proper firmware :) Maybe it is, but it is not the v4l-cx23418-dig.fw file: $ md5sum /lib/firmware/v4l-cx23418-dig.fw b3704908fd058485f3ef136941b2e513 /lib/firmware/v4l-cx23418-dig.fw Which can be extracted from this (double) gzipped tar archive: http://dl.ivtvdriver.org/ivtv/firmware/cx18-firmware.tar.gz (After downloading the file, rename it to cx18-firmware.tar.gz.gz. Sorry, I don't know how to stop the web server from gzipping things twice. :( ) Mauro or Hans, Linuxtv.org seems to be serving up the wrong firmware for the CX23418's built in CX25843 core: http://www.linuxtv.org/downloads/firmware/v4l-cx23418-dig.fw $ md5sum Downloads/linuxtv.org-v4l-cx23418-dig.fw 95bc688d3e7599fd5800161e9971cc55 Downloads/linuxtv.org-v4l-cx23418-dig.fw Can either of you please put the proper firmware file in place at LinuxTV.org? Thanks. Regards, Andy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cx23885: Added support for AVerTV Hybrid Express Slim HC81R (only analog)
неділя, 04-лис-2012 16:49:00 Andy Walls написано: On Sun, 2012-11-04 at 09:59 +0200, Oleg Kravchenko wrote: субота, 03-лис-2012 16:41:10 Andy Walls написано: Oleg Kravchenko o...@kaa.org.ua wrote: Hello! Please review my patch. Supported inputs: Television, S-Video, Component. Modules options: options cx25840 firmware=v4l-cx23418-dig.fw Hi, Please do not use the CX23418 digitizer firmware with the CX2388[578] chips. Use the proper cx23885 digitizer firmware. You need the proper firmware to get the best results in detecting the audio standard in broadcast analog video. Regards, Andy Windows driver use v4l-cx23418-dig.fw 95bc688d3e7599fd5800161e9971cc55 merlinAVC.rom 95bc688d3e7599fd5800161e9971cc55 /lib/firmware/v4l-cx23418-dig.fw So, i think this is a proper firmware :) Maybe it is, but it is not the v4l-cx23418-dig.fw file: $ md5sum /lib/firmware/v4l-cx23418-dig.fw b3704908fd058485f3ef136941b2e513 /lib/firmware/v4l-cx23418-dig.fw Which can be extracted from this (double) gzipped tar archive: http://dl.ivtvdriver.org/ivtv/firmware/cx18-firmware.tar.gz (After downloading the file, rename it to cx18-firmware.tar.gz.gz. Sorry, I don't know how to stop the web server from gzipping things twice. :( ) Ok, i am change /etc/modprobe.d/avermedia_hc81r.conf to: options cx25840 firmware=merlinAVC.rom -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: S3C244X/S3C64XX SoC camera host interface driver questions
Hi Andrey, Cc: LMML On 11/04/2012 09:43 PM, Andrey Gusakov wrote: Hi all. I'm testing your FIMC driver on S3C6410 hardware with OV9650 (in plans OV2640). I fixed some register definition, gpio init, fixed IRQ handling for S3C6410. So now i can get test frames from internal pattern generator. But when i try to read from external sensor i got blue or green trash. Does it change when external light conditions change ? Or is it completely random ? Yes. When it's dark - almost all picture is green. when I light on sensor, picture become more noisy with more blue pixels. If i comment out ov965x_init_regs write to sensor, I get black and white noise, like on TV when no signal. My opinion is there is some mistmatch in formats between sensor and FIMC. Yes, I also suspect this is the root cause. But documentation on ov9650 is too conflicting and did not cover all registers used in driver. Do you mean the OV9650 datasheet, version 1.3, from September 24, 2004 ? What resolution are you testing with ? 320x240. Are you using media-ctl to configure resolution on the camif and sensor subdev ? I'm using GStreamer: gst-launch -v v4l2src device=/dev/video0 \ ! video/x-raw-yuv, width=320, height=240 \ ! ffmpegcolorspace \ ! fbdevsink AFAIR, in the s3c-camif-v3.5 branch there was a bug that the CAMIF input resolution was not being properly set to what was reported by the sensor driver (default s3c-camif resolution is 640 x 480). The s3c-camif driver is supposed to get format from a sensor subdev and set it on the S3C-CAMIF subdev, upon image sensor subdev registration. Please see function camif_register_sensor() for details. The above issue should be fixed in this branch: [1] http://git.linuxtv.org/snawrocki/media.git/shortlog/refs/heads/s3c-camif Also, it could be verified by setting the formats with media-ctl manually, before running gst-launch, i.e. media-ctl --set-v4l2 'OV9650:0 [fmt: YUYV2X8/320x240]' media-ctl --set-v4l2 'S3C-CAMIF:0 [fmt: YUYV2X8/320x240]' with your current kernel and the s3c-camif driver. media-ctl was integrated in the OSELAS mini2440 BSP and probably is also in the mini6440 version. And what kernel version is it ? 3.6.0-rc3 with some modifications for mini6410 devboard. Have no time to move my stuff to last samsung kernel. OK, it's recent enough. The patches from s3c-camif branch should apply cleanly. Can you measure the frequency of the master clock that CAMIF provides to the sensor ? 16.67 MHz. As i understand this is limitation of divider. Min clock is HCLKx2 (266) / 16 = 16.67 in my case. PCLK is near 4 MHz. Looks fine (16.625). :) I spend two days trying to fix it, and now I'm out of ideas. May be you can help me. I have some questions. Did you have to invert some of camera signals (VSYNC, HREF, PCLK)? Maybe you had to make some hardware modifications? (i use CAM130 module from FriendlyARM). I'm also using CAM130, attached to mini2440 board without any hardware modifications. Tomasz, (added at Cc) tested the driver on mini6410 and it worked with same camera module. VSYNC, PCLK, etc. configuration is specified in the board patch (as in the below branch). Are you using this version of patches: http://git.linuxtv.org/snawrocki/media.git/shortlog/refs/heads/s3c-camif ? I'm using patches from https://github.com/snawrocki/linux/commits/s3c-camif-v3.5 wich was in your mail to samsung maillist. I suggest you to update to the s3c-camif branch as above, it includes some bug fixes. Sorry, I don't have exact patch for your issue handy right now. I've also added at Cc In-Bae Jeong, who had successfully used the driver on s3c6410 based board. However I'm not really sure now which board exactly was it. I'm using mini6410. But i think there is only one way sensor can be connected to FIMC. Some differents may be in Reset and Power-down signals, but not in interface. Yes, right. But since I2C communication works, the GPIOs and the clock should be fine. It looks like there is a mismatch in the sensor and the CAMIF registers configuration. P.S. Try to connect ov2640, but seems it need some modifications in FIMC driver to be connected thrue soc_camera_link. Hmm, this is a general problem in the v4l2 core code. The are two slightly incompatible interfaces that sensor subdevs are using. There were attempts to make soc_camera subdevs usable with non-soc_camera host drivers, but it is not finished yet. I could try to look at that, but I can't promise when that happens. There are pad level ops needed in the ov2640 driver - in addition to or instead of g/s/try_mbus_fmt. Regulator supply names are not supposed to be passed through platform data, those should be defined with fixed names as specified in the sensor datasheet and board code should be providing required regulator supply names or the dummy regulator should be used. IMO passing regulator supply names through platform data is the regulator API misuse. We need to resolve this issue
Re: S3C244X/S3C64XX SoC camera host interface driver questions
Hi Andrey, On Sunday 04 of November 2012 23:14:47 Sylwester Nawrocki wrote: Are you using this version of patches: http://git.linuxtv.org/snawrocki/media.git/shortlog/refs/heads/s3c-cam if ? I'm using patches from https://github.com/snawrocki/linux/commits/s3c-camif-v3.5 wich was in your mail to samsung maillist. I suggest you to update to the s3c-camif branch as above, it includes some bug fixes. Sorry, I don't have exact patch for your issue handy right now. Yes, you should definitely try the branch pointed by Sylwester, because the one you originally tested does not contain my fixes for S3C6410. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] vpif_capture: fix condition logic in vpif_capture.c
Wei, On Tue, Oct 30, 2012 at 7:15 PM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The pattern E == C1 E == C2 is always false. This patch fix this according to the assumption that should be ||. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/platform/davinci/vpif_capture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for the patch, I'll queue it for 3.8. Regards, --Prabhakar Lad diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index fcabc02..2d28a96 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c @@ -1715,7 +1715,7 @@ vpif_enum_dv_timings(struct file *file, void *priv, int ret; ret = v4l2_subdev_call(ch-sd, video, enum_dv_timings, timings); - if (ret == -ENOIOCTLCMD ret == -ENODEV) + if (ret == -ENOIOCTLCMD || ret == -ENODEV) return -EINVAL; return ret; } @@ -1735,7 +1735,7 @@ vpif_query_dv_timings(struct file *file, void *priv, int ret; ret = v4l2_subdev_call(ch-sd, video, query_dv_timings, timings); - if (ret == -ENOIOCTLCMD ret == -ENODEV) + if (ret == -ENOIOCTLCMD || ret == -ENODEV) return -ENODATA; return ret; } -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] vpif_display: fix condition logic in vpif_enum_dv_timings()
Hi Wei, On Tue, Oct 30, 2012 at 7:19 PM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The pattern E == C1 E == C2 is always false. This patch fix this according to the assumption that should be ||. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/platform/davinci/vpif_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the patch, I'll queue it for 3.8. Regards, --Prabhakar Lad diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c index b716fbd..977ee43 100644 --- a/drivers/media/platform/davinci/vpif_display.c +++ b/drivers/media/platform/davinci/vpif_display.c @@ -1380,7 +1380,7 @@ vpif_enum_dv_timings(struct file *file, void *priv, int ret; ret = v4l2_subdev_call(ch-sd, video, enum_dv_timings, timings); - if (ret == -ENOIOCTLCMD ret == -ENODEV) + if (ret == -ENOIOCTLCMD || ret == -ENODEV) return -EINVAL; return ret; } -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
