date:20150920

Re: Terratec H7 Rev. 4 is DVBSky

2015-09-20 Thread Erik Andresen

Hi Roger,

> I'm not able to enable any protocols. Nothing happens when running 
> ir-keytable with "-p rc-5". Nothing shows in the row "Enabled protocols" and 
> nothing happens when testing with "ir-keytable -t". 
try to give it the device, e.g.

ir-keytable -d /dev/input/event14 -t

I was able to get output from it. The device is now running for a week under 
mythbackend.

greetings,
Erik


Am 19.09.2015 um 23:48 schrieb Roger Mårtensson:
> Den 2015-09-19 kl. 23:39, skrev Roger Mårtensson:
>> Den 2015-09-11 kl. 17:04, skrev Erik Andresen:
>>> Hi,
>>>
>>> I recently got a Terratec H7 in Revision 4 and turned out that it is not
>>> just a new revision, but a new product with USB ProductID 0x10a5.
>>> Previous revisions have been AZ6007, but this revision does not work
>>> with this driver [1].
>>>
>>> Output of lsusb (extended output attached):
>>> Bus 001 Device 011: ID 0ccd:10a5 TerraTec Electronic GmbH
>>>
>>> The revision 4 seems to a DVBSky variant, adding its Product ID to
>>> dvbsky.c with the attached patch enabled me to scan for channels and
>>> watch DVB-C and DVB-T.
>>>
>>> greetings,
>>> Erik
>>>
>>> [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg70934.html
>> Do I feel lucky or what..
>> Just got my H7 devices delivered and noticed the lack of supported driver 
>> and some quick searches gave me this e-mail.
>> Maybe should take a trip to the race track. :)
>>
>> I have tried this driver and it works wonderfully. I have noticed a freeze 
>> or two when handling the device (powering off, ripping USB etc) but I'm not 
>> sure it is the driver that is causing this.
>>
>> I do notice something weird. The remote doesn't seem to work.
>> Found /sys/class/rc/rc0/ (/dev/input/event14) with:
>> Driver dvb_usb_dvbsky, table rc-tt-1500
>> Supported protocols: RC-5
>> Enabled protocols:
>> Name: Terratec H7 Rev.4
>> bus: 3, vendor/product: 0ccd:10a5, version: 0x
>> Repeat delay = 500 ms, repeat period = 125 ms
>>
>> I'm not able to enable any protocols. Nothing happens when running 
>> ir-keytable with "-p rc-5". Nothing shows in the row "Enabled protocols" and 
>> nothing happens when testing with "ir-keytable -t".
>>
>> I've tested on a Ubuntu 14.04 (Mythbuntu) with Linux Kernel 4.2 that I have 
>> to compile myself. (Don't know in which kernel dvbsky was released)
>> Tested using both Kaffeine and MythTV and it works like a charm (with the 
>> exception of missing IR).
>> I tested using DVB-C with CI for encrypted channels
> One more this..
> Is there a possibility that Signal strength support could be added to the 
> driver?
> MythTV uses this and I think Kaffeine also uses it (not sure). Currently the 
> logs are filling up with "Operation not supported".




signature.asc
Description: OpenPGP digital signature

Re: [RFC 0/9] Unrestricted media entity ID range support

2015-09-20 Thread Sakari Ailus


Hi Mauro,

Mauro Carvalho Chehab wrote:

Hi Sakari,

On Fri, 11 Sep 2015 13:09:03 +0300
Sakari Ailus  wrote:


Hi all,

This patchset adds an API for managing entity enumerations, i.e.
storing a bit of information per entity. The entity ID is no longer
limited to small integers (e.g. 31 or 63), but
MEDIA_ENTITY_MAX_LOW_ID. The drivers are also converted to use that
instead of a fixed number.

If the number of entities in a real use case grows beyond the
capabilities of the approach, the algorithm may be changed. But most
importantly, the API is used to perform the same operation everywhere
it's done.

I'm sending this for review only, the code itself is untested.

I haven't entirely made up my mind on the fourth patch. It could be
dropped, as it uses the API for a somewhat different purpose.



Sorry for not reviewing this earlier, but I'm traveling this week to
China, and I was having some troubles with the Internet. Btw, I don't
have my notebook here (just a chromebook without the media tree).
So, please consider this as just a preliminary review.

I won't be comment this series patch by patch, because it is really
painful to do it while here with this Internet.

Also, I want to discuss the patch series as a hole.

 From what we've agreed last week, we won't be using a separate ID
range for the entity ID, but this patch series is actually adding
it, and, IMHO, using a confusing nomenclature: instead of calling the
entity ID range as "entity_id" at the media_device struct, you're
now calling it "low_id". That sounds confusing to me. If you think
we should keep a separate range for entities, calling it as
"entity_id" is clearer.


It's *not* the entity ID. It's a number used internally to keep track of 
the entities, and only used for this purpose, nothing else. If you look 
at the patch, the number of places where low_id is used is very limited. 
Individual drivers do not and must not access the low_id field.


The underlying algorithm for keeping track of entities does not change, 
but that could be changed later on without affecting the users of the 
alrogithm. --- See patch 3.


There are two main reasons for this:

1. No need to implement a new algorithm which would be less efficient 
but could cope in cases we do not have yet; this can be done later on, 
as patch 3 adds an API to access the information without making 
assumptions on the implementation.


2. It does solve the problem. The graph object IDs of the entities can 
be large without adversely affecting the functionality of existing drivers.




Also, you said at the low_id comment that if an entity is
unregistered and then re-registered, it would preserve the same


I never claimed that, and the patchset does not implement that either.

If an entity is unregistered and registered again, from the MC point of 
view it is not the same entity. We do not keep track of entities that 
are not registered with MC, do we?



entity ID. That doesn't seem easy to implement, as we would need
to track those previously-used ID. On the other hand, if we just
re-use a previously released ID for some other entity, this can
be a problem, as userspace may not be aware of such changes and
might be asking the Kernel to do the wrong thing.


Let's not do that then. This is why we have graph object IDs.



So, I can't see how non-monotonically incremented numbers would
work here.

Finally, the changes you did still rely on having the ID limited
to a well-defined, hardcoded number (MEDIA_ENTITY_MAX_LOW_ID).

I can see this working only if:

- We keep a separate range ID for entities (so, having a minimum
   of two ranges);

- the entity maximum ID is defined by the driver (as the number
   of entities is actually dependent on the hardware);


The case is that we do not have a driver requiring more entities. Once 
we do, we can implement a new algorithm for the purpose. Memory 
allocation will be required, but that's a separate matter from the graph 
object ID of the entities, which is the problem this patchset was 
intended to solve.




- some other mechanism would be available for drivers that
   would support dynamic entity creation.

So, I don't see how this would solve the problems that we
discussed at the last week IRC chats.

Am I missing something?


This set indeed solves a problem, and that problem was unrestricting the 
graph object ID of the entities. There are other problems remaining 
before entities can be e.g. unregistered one by one, but they are 
separate problems.




Regards,
Mauro

PS.: sparse already complains on two places at the media-entity where
bitmaps are declared at the stack. With max entities equal to 64,
that's not an issue, but if we change to a higher number, those will
need to be dynamically allocated, in order to avoid stack overflows.
I didn't see any patches touching that.


I agree. The aim of the set was not to increase the number of concurrent 
entities. That is a separate problem which can be

drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:18: error: too many arguments to function 'horus3a_attach'

2015-09-20 Thread kbuild test robot

Hi Kozlov,

FYI, the error/warning still remains. You may either fix it or ask me to 
silently ignore in future.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   99bc7215bc60f6cd414cf1b85cd9d52cc596cccb
commit: 52b1eaf4c59a3bbd07afbb4ab4f43418a807d02e [media] netup_unidvb: NetUP 
Universal DVB-S/S2/T/T2/C PCI-E card driver
date:   6 weeks ago
config: i386-randconfig-b0-09201649 (attached as .config)
reproduce:
  git checkout 52b1eaf4c59a3bbd07afbb4ab4f43418a807d02e
  # save the attached .config to linux build tree
  make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from 
drivers/media/pci/netup_unidvb/netup_unidvb_core.c:34:0:
   drivers/media/dvb-frontends/horus3a.h:51:13: warning: 'struct 
cxd2820r_config' declared inside parameter list
 struct i2c_adapter *i2c)
^
   drivers/media/dvb-frontends/horus3a.h:51:13: warning: its scope is only this 
definition or declaration, which is probably not what you want
   In file included from include/media/videobuf2-dvb.h:4:0,
from drivers/media/pci/netup_unidvb/netup_unidvb.h:26,
from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:32:
   drivers/media/pci/netup_unidvb/netup_unidvb_core.c: In function 
'netup_unidvb_dvb_init':
   drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:34: warning: passing 
argument 1 of 'horus3a_attach' from incompatible pointer type 
[-Wincompatible-pointer-types]
 if (!dvb_attach(horus3a_attach, fe0->dvb.frontend,
 ^
   drivers/media/dvb-core/dvbdev.h:170:11: note: in definition of macro 
'dvb_attach'
 FUNCTION(ARGS); \
  ^
   In file included from 
drivers/media/pci/netup_unidvb/netup_unidvb_core.c:34:0:
   drivers/media/dvb-frontends/horus3a.h:49:36: note: expected 'const struct 
cxd2820r_config *' but argument is of type 'struct dvb_frontend *'
static inline struct dvb_frontend *horus3a_attach(
   ^
   In file included from include/media/videobuf2-dvb.h:4:0,
from drivers/media/pci/netup_unidvb/netup_unidvb.h:26,
from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:32:
   drivers/media/pci/netup_unidvb/netup_unidvb_core.c:418:4: warning: passing 
argument 2 of 'horus3a_attach' from incompatible pointer type 
[-Wincompatible-pointer-types]
   _conf, >i2c[num].adap)) {
   ^
   drivers/media/dvb-core/dvbdev.h:170:11: note: in definition of macro 
'dvb_attach'
 FUNCTION(ARGS); \
  ^
   In file included from 
drivers/media/pci/netup_unidvb/netup_unidvb_core.c:34:0:
   drivers/media/dvb-frontends/horus3a.h:49:36: note: expected 'struct 
i2c_adapter *' but argument is of type 'struct horus3a_config *'
static inline struct dvb_frontend *horus3a_attach(
   ^
   In file included from include/media/videobuf2-dvb.h:4:0,
from drivers/media/pci/netup_unidvb/netup_unidvb.h:26,
from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:32:
>> drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:18: error: too many 
>> arguments to function 'horus3a_attach'
 if (!dvb_attach(horus3a_attach, fe0->dvb.frontend,
 ^
   drivers/media/dvb-core/dvbdev.h:170:2: note: in definition of macro 
'dvb_attach'
 FUNCTION(ARGS); \
 ^
   In file included from 
drivers/media/pci/netup_unidvb/netup_unidvb_core.c:34:0:
   drivers/media/dvb-frontends/horus3a.h:49:36: note: declared here
static inline struct dvb_frontend *horus3a_attach(
   ^

vim +/horus3a_attach +417 drivers/media/pci/netup_unidvb/netup_unidvb_core.c

   411  dev_dbg(>pci_dev->dev,
   412  "%s(): unable to attach DVB-S/S2 frontend\n",
   413  __func__);
   414  goto frontend_detach;
   415  }
   416  horus3a_conf.set_tuner_priv = >dma[num];
 > 417  if (!dvb_attach(horus3a_attach, fe0->dvb.frontend,
   418  _conf, >i2c[num].adap)) {
   419  dev_dbg(>pci_dev->dev,
   420  "%s(): unable to attach DVB-S/S2 tuner 
frontend\n",

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/i386 4.2.0-rc2 Kernel Configuration
#
# CONFIG_64BIT is not set
CONFIG_X86_32=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_PERF_EVENTS_INTEL_UNCORE=y
CONFIG_OUTPUT_FORMAT="elf32-i386"
CONFIG_ARCH_DEFCONFIG="arch/x86/configs/i386_defconfig"
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y

drivers/media/i2c/adv7604.c:1853:9: error: implicit declaration of function 'v4l2_subdev_get_try_format'

2015-09-20 Thread kbuild test robot

Hi Hans,

FYI, the error/warning still remains. You may either fix it or ask me to 
silently ignore in future.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   99bc7215bc60f6cd414cf1b85cd9d52cc596cccb
commit: 85756a069c55e0315ac5990806899cfb607b987f [media] cobalt: add new driver
date:   4 months ago
config: x86_64-randconfig-s0-09201514 (attached as .config)
reproduce:
  git checkout 85756a069c55e0315ac5990806899cfb607b987f
  # save the attached .config to linux build tree
  make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/media/i2c/adv7604.c: In function 'adv76xx_get_format':
>> drivers/media/i2c/adv7604.c:1853:9: error: implicit declaration of function 
>> 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
^
   drivers/media/i2c/adv7604.c:1853:7: warning: assignment makes pointer from 
integer without a cast [-Wint-conversion]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
  ^
   drivers/media/i2c/adv7604.c: In function 'adv76xx_set_format':
   drivers/media/i2c/adv7604.c:1882:7: warning: assignment makes pointer from 
integer without a cast [-Wint-conversion]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
  ^
   cc1: some warnings being treated as errors
--
   drivers/media/i2c/adv7842.c: In function 'adv7842_get_format':
>> drivers/media/i2c/adv7842.c:2093:9: error: implicit declaration of function 
>> 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
^
   drivers/media/i2c/adv7842.c:2093:7: warning: assignment makes pointer from 
integer without a cast [-Wint-conversion]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
  ^
   drivers/media/i2c/adv7842.c: In function 'adv7842_set_format':
   drivers/media/i2c/adv7842.c:2125:7: warning: assignment makes pointer from 
integer without a cast [-Wint-conversion]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
  ^
   cc1: some warnings being treated as errors
--
   drivers/media/i2c/adv7511.c: In function 'adv7511_get_fmt':
>> drivers/media/i2c/adv7511.c:859:9: error: implicit declaration of function 
>> 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
^
   drivers/media/i2c/adv7511.c:859:7: warning: assignment makes pointer from 
integer without a cast [-Wint-conversion]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
  ^
   drivers/media/i2c/adv7511.c: In function 'adv7511_set_fmt':
   drivers/media/i2c/adv7511.c:910:7: warning: assignment makes pointer from 
integer without a cast [-Wint-conversion]
  fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
  ^
   cc1: some warnings being treated as errors

vim +/v4l2_subdev_get_try_format +1853 drivers/media/i2c/adv7604.c

539b33b0 Laurent Pinchart 2014-01-26  1837  }
539b33b0 Laurent Pinchart 2014-01-26  1838  
f7234138 Hans Verkuil 2015-03-04  1839  static int 
adv76xx_get_format(struct v4l2_subdev *sd,
f7234138 Hans Verkuil 2015-03-04  1840struct 
v4l2_subdev_pad_config *cfg,
539b33b0 Laurent Pinchart 2014-01-26  1841struct 
v4l2_subdev_format *format)
539b33b0 Laurent Pinchart 2014-01-26  1842  {
b44b2e06 Pablo Anton  2015-02-03  1843  struct adv76xx_state *state = 
to_state(sd);
539b33b0 Laurent Pinchart 2014-01-26  1844  
539b33b0 Laurent Pinchart 2014-01-26  1845  if (format->pad != 
state->source_pad)
539b33b0 Laurent Pinchart 2014-01-26  1846  return -EINVAL;
539b33b0 Laurent Pinchart 2014-01-26  1847  
b44b2e06 Pablo Anton  2015-02-03  1848  adv76xx_fill_format(state, 
>format);
539b33b0 Laurent Pinchart 2014-01-26  1849  
539b33b0 Laurent Pinchart 2014-01-26  1850  if (format->which == 
V4L2_SUBDEV_FORMAT_TRY) {
539b33b0 Laurent Pinchart 2014-01-26  1851  struct 
v4l2_mbus_framefmt *fmt;
539b33b0 Laurent Pinchart 2014-01-26  1852  
f7234138 Hans Verkuil 2015-03-04 @1853  fmt = 
v4l2_subdev_get_try_format(sd, cfg, format->pad);
539b33b0 Laurent Pinchart 2014-01-26  1854  format->format.code = 
fmt->code;
539b33b0 Laurent Pinchart 2014-01-26  1855  } else {
539b33b0 Laurent Pinchart 2014-01-26  1856  format->format.code = 
state->format->code;
539b33b0 Laurent Pinchart 2014-01-26  1857  }
539b33b0 Laurent Pinchart 2014-01-26  1858  
539b33b0 Laurent Pinchart 2014-01-26  1859  return 0;
539b33b0 Laurent Pinchart 2014-01-26  1860  }
539b33b0 Laurent Pinchart 2014-01-26  1861  

:: The code at line 1853 was first introduced by commit
:: f7234138f14c2296c5eb6b8224abe00b507faf3f [media] v4l2-subdev: replace 
v4l2_subdev_fh by v4l2_subdev_pad_config

:: TO: Hans

Re: [Patch] media: v4l2-ctrls: Fix 64bit support in get_ctrl()

2015-09-20 Thread Sakari Ailus

Hi Benoit,

On Wed, Sep 16, 2015 at 05:58:19PM -0500, Benoit Parrot wrote:
> When trying to use v4l2_ctrl_g_ctrl_int64() to retrieve a
> V4L2_CTRL_TYPE_INTEGER64 type value the internal helper function
> get_ctrl() would prematurely exits because for this control type
> the 'is_int' flag is not set. This would result in v4l2_ctrl_g_ctrl_int64
> always returning 0.
> 
> This patch extend the condition check to allow V4L2_CTRL_TYPE_INTEGER64
> type to continue processing instead of exiting.
> 
> Signed-off-by: Benoit Parrot 
> ---
>  drivers/media/v4l2-core/v4l2-ctrls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c 
> b/drivers/media/v4l2-core/v4l2-ctrls.c
> index b6b7dcc1b77d..989919c44c2f 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
> @@ -2884,7 +2884,7 @@ static int get_ctrl(struct v4l2_ctrl *ctrl, struct 
> v4l2_ext_control *c)
>* cur_to_user() calls below would need to be modified not to access
>* userspace memory when called from get_ctrl().
>*/
> - if (!ctrl->is_int)
> + if (!ctrl->is_int && ctrl->type != V4L2_CTRL_TYPE_INTEGER64)
>   return -EINVAL;
>  
>   if (ctrl->flags & V4L2_CTRL_FLAG_WRITE_ONLY)

Well spotted.

However, this does not appear to be the only problem with
v4l2_ctrl_g_ctrl_int64(). It accesses the 32-bit value field instead of
value64. While at it, could you fix that one as well?

I wonder how this could have happened. :-o

-- 
Regards,

Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] atmel-isi: Remove platform data support

2015-09-20 Thread Josh Wu


Hi, Guennadi

On 9/20/2015 11:25 PM, Guennadi Liakhovetski wrote:

Hi Laurent, Josh,

It's ok not to CC me immediately if it's expected, that patches will be
further forwarded (by Josh in this case) to me. And it helps, that Josh
has collected all Atmel ISI patches in a git tree branch - thanks! But,
please make sure, that all patches also appear in my mailbox at least
once, especially if they are (even trivially) modified - like in this
case, where patches 2 and 3 have been merged into 1.

yes, got it. I will make sure of that in future. Thanks for the remind.

Best Regards,
Josh Wu


Thanks
Guennadi

On Sat, 1 Aug 2015, Laurent Pinchart wrote:


Hello,

While reviewing patches for the atmel-isi I noticed a couple of small issues
with the driver. Here's a patch series to fix them, the main change being the
removal of platform data support now that all users have migrated to DT.

The patches have been compile-tested only. Josh, would you be able to test
them on hardware ?

Laurent Pinchart (4):
   v4l: atmel-isi: Simplify error handling during DT parsing
   v4l: atmel-isi: Remove unused variable
   v4l: atmel-isi: Remove support for platform data
   v4l: atmel-isi: Remove unused platform data fields

  drivers/media/platform/soc_camera/atmel-isi.c |  40 ++--
  drivers/media/platform/soc_camera/atmel-isi.h | 126 +
  include/media/atmel-isi.h | 131 --
  3 files changed, 136 insertions(+), 161 deletions(-)
  create mode 100644 drivers/media/platform/soc_camera/atmel-isi.h
  delete mode 100644 include/media/atmel-isi.h

--
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] atmel-isi: Remove platform data support

2015-09-20 Thread Guennadi Liakhovetski

Hi Laurent, Josh,

It's ok not to CC me immediately if it's expected, that patches will be 
further forwarded (by Josh in this case) to me. And it helps, that Josh 
has collected all Atmel ISI patches in a git tree branch - thanks! But, 
please make sure, that all patches also appear in my mailbox at least 
once, especially if they are (even trivially) modified - like in this 
case, where patches 2 and 3 have been merged into 1.

Thanks
Guennadi

On Sat, 1 Aug 2015, Laurent Pinchart wrote:

> Hello,
> 
> While reviewing patches for the atmel-isi I noticed a couple of small issues
> with the driver. Here's a patch series to fix them, the main change being the
> removal of platform data support now that all users have migrated to DT.
> 
> The patches have been compile-tested only. Josh, would you be able to test
> them on hardware ?
> 
> Laurent Pinchart (4):
>   v4l: atmel-isi: Simplify error handling during DT parsing
>   v4l: atmel-isi: Remove unused variable
>   v4l: atmel-isi: Remove support for platform data
>   v4l: atmel-isi: Remove unused platform data fields
> 
>  drivers/media/platform/soc_camera/atmel-isi.c |  40 ++--
>  drivers/media/platform/soc_camera/atmel-isi.h | 126 +
>  include/media/atmel-isi.h | 131 
> --
>  3 files changed, 136 insertions(+), 161 deletions(-)
>  create mode 100644 drivers/media/platform/soc_camera/atmel-isi.h
>  delete mode 100644 include/media/atmel-isi.h
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] [media] c8sectpfe: forward err instead of returning an uninitialized variable

2015-09-20 Thread Nicolas Iooss

When load_c8sectpfe_fw_step1() tests whether the return value of
request_firmware_nowait(), stored in variable err, indicates an error,
it then returns the value hold by uninitialized variable ret, which
seems incorrect.

Fix this by forwarding the error returned by request_firmware_nowait()
to the caller of load_c8sectpfe_fw_step1().

Signed-off-by: Nicolas Iooss 
---
 drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c 
b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index a424339b18bc..c25a1172bcf5 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -1192,7 +1192,6 @@ err:
 
 static int load_c8sectpfe_fw_step1(struct c8sectpfei *fei)
 {
-   int ret;
int err;
 
dev_info(fei->dev, "Loading firmware: %s\n", FIRMWARE_MEMDMA);
@@ -1207,7 +1206,7 @@ static int load_c8sectpfe_fw_step1(struct c8sectpfei *fei)
if (err) {
dev_err(fei->dev, "request_firmware_nowait err: %d.\n", err);
complete_all(>fw_ack);
-   return ret;
+   return err;
}
 
return 0;
-- 
2.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] [media] c8sectpfe: initialize err in load_slim_core_fw

2015-09-20 Thread Nicolas Iooss

load_slim_core_fw() uses a for loop with !err in its condition without
first initializing err.  Fix this by setting err to 0 in its definition.

Signed-off-by: Nicolas Iooss 
---
 drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c 
b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index 486aef50d99b..a424339b18bc 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -1097,7 +1097,7 @@ static int load_slim_core_fw(const struct firmware *fw, 
void *context)
Elf32_Ehdr *ehdr;
Elf32_Phdr *phdr;
u8 __iomem *dst;
-   int err, i;
+   int err = 0, i;
 
if (!fw || !context)
return -EINVAL;
-- 
2.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

cron job: media_tree daily build: OK

2015-09-20 Thread Hans Verkuil

This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.

Results of the daily build of media_tree:

date:   Mon Sep 21 04:00:15 CEST 2015
git branch: test
git hash:   9ddf9071ea17b83954358b2dac42b34e5857a9af
gcc version:i686-linux-gcc (GCC) 5.1.0
sparse version: v0.5.0-51-ga53cea2
smatch version: 0.4.1-3153-g7d56ab3
host hardware:  x86_64
host os:4.0.0-3.slh.1-amd64

linux-git-arm-at91: OK
linux-git-arm-davinci: OK
linux-git-arm-exynos: OK
linux-git-arm-mx: OK
linux-git-arm-omap: OK
linux-git-arm-omap1: OK
linux-git-arm-pxa: OK
linux-git-blackfin-bf561: OK
linux-git-i686: OK
linux-git-m32r: OK
linux-git-mips: OK
linux-git-powerpc64: OK
linux-git-sh: OK
linux-git-x86_64: OK
linux-2.6.32.27-i686: OK
linux-2.6.33.7-i686: OK
linux-2.6.34.7-i686: OK
linux-2.6.35.9-i686: OK
linux-2.6.36.4-i686: OK
linux-2.6.37.6-i686: OK
linux-2.6.38.8-i686: OK
linux-2.6.39.4-i686: OK
linux-3.0.60-i686: OK
linux-3.1.10-i686: OK
linux-3.2.37-i686: OK
linux-3.3.8-i686: OK
linux-3.4.27-i686: OK
linux-3.5.7-i686: OK
linux-3.6.11-i686: OK
linux-3.7.4-i686: OK
linux-3.8-i686: OK
linux-3.9.2-i686: OK
linux-3.10.1-i686: OK
linux-3.11.1-i686: OK
linux-3.12.23-i686: OK
linux-3.13.11-i686: OK
linux-3.14.9-i686: OK
linux-3.15.2-i686: OK
linux-3.16.7-i686: OK
linux-3.17.8-i686: OK
linux-3.18.7-i686: OK
linux-3.19-i686: OK
linux-4.0-i686: OK
linux-4.1.1-i686: OK
linux-4.2-i686: OK
linux-4.3-rc1-i686: OK
linux-2.6.32.27-x86_64: OK
linux-2.6.33.7-x86_64: OK
linux-2.6.34.7-x86_64: OK
linux-2.6.35.9-x86_64: OK
linux-2.6.36.4-x86_64: OK
linux-2.6.37.6-x86_64: OK
linux-2.6.38.8-x86_64: OK
linux-2.6.39.4-x86_64: OK
linux-3.0.60-x86_64: OK
linux-3.1.10-x86_64: OK
linux-3.2.37-x86_64: OK
linux-3.3.8-x86_64: OK
linux-3.4.27-x86_64: OK
linux-3.5.7-x86_64: OK
linux-3.6.11-x86_64: OK
linux-3.7.4-x86_64: OK
linux-3.8-x86_64: OK
linux-3.9.2-x86_64: OK
linux-3.10.1-x86_64: OK
linux-3.11.1-x86_64: OK
linux-3.12.23-x86_64: OK
linux-3.13.11-x86_64: OK
linux-3.14.9-x86_64: OK
linux-3.15.2-x86_64: OK
linux-3.16.7-x86_64: OK
linux-3.17.8-x86_64: OK
linux-3.18.7-x86_64: OK
linux-3.19-x86_64: OK
linux-4.0-x86_64: OK
linux-4.1.1-x86_64: OK
linux-4.2-x86_64: OK
linux-4.3-rc1-x86_64: OK
apps: OK
spec-git: OK
sparse: WARNINGS
smatch: ERRORS

Detailed results are available here:

http://www.xs4all.nl/~hverkuil/logs/Monday.log

Full logs are available here:

http://www.xs4all.nl/~hverkuil/logs/Monday.tar.bz2

The Media Infrastructure API from this daily build is here:

http://www.xs4all.nl/~hverkuil/spec/media.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

ERROR: "vb2_ops_wait_finish" [drivers/input/touchscreen/sur40.ko] undefined!

2015-09-20 Thread kbuild test robot

Hi Florian,

FYI, the error/warning still remains. You may either fix it or ask me to 
silently ignore in future.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   1f93e4a96c9109378204c147b3eec0d0e8100fde
commit: e831cd251fb91d6c25352d322743db0d17ea11dd [media] add raw video stream 
support for Samsung SUR40
date:   6 months ago
config: i386-randconfig-c0-09211007 (attached as .config)
reproduce:
  git checkout e831cd251fb91d6c25352d322743db0d17ea11dd
  # save the attached .config to linux build tree
  make ARCH=i386 

All error/warnings (new ones prefixed by >>):

>> ERROR: "vb2_ops_wait_finish" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_ops_wait_prepare" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_fop_release" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "v4l2_fh_open" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_fop_mmap" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "video_ioctl2" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_fop_poll" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_fop_read" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_ioctl_streamoff" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_ioctl_streamon" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_ioctl_create_bufs" [drivers/input/touchscreen/sur40.ko] 
>> undefined!
>> ERROR: "vb2_ioctl_dqbuf" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_ioctl_expbuf" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_ioctl_qbuf" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_ioctl_querybuf" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_ioctl_reqbufs" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "__video_register_device" [drivers/input/touchscreen/sur40.ko] 
>> undefined!
>> ERROR: "video_device_release_empty" [drivers/input/touchscreen/sur40.ko] 
>> undefined!
>> ERROR: "vb2_dma_sg_init_ctx" [drivers/input/touchscreen/sur40.ko] undefined!
>> ERROR: "vb2_queue_init" [drivers/input/touchscreen/sur40.ko] undefined!

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/i386 4.0.0-rc1 Kernel Configuration
#
# CONFIG_64BIT is not set
CONFIG_X86_32=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_PERF_EVENTS_INTEL_UNCORE=y
CONFIG_OUTPUT_FORMAT="elf32-i386"
CONFIG_ARCH_DEFCONFIG="arch/x86/configs/i386_defconfig"
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
# CONFIG_ZONE_DMA32 is not set
# CONFIG_AUDIT_ARCH is not set
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_X86_32_SMP=y
CONFIG_X86_HT=y
CONFIG_X86_32_LAZY_GS=y
CONFIG_ARCH_HWEIGHT_CFLAGS="-fcall-saved-ecx -fcall-saved-edx"
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y

#
# General setup
#
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=""
# CONFIG_COMPILE_TEST is not set
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
CONFIG_KERNEL_LZO=y
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME="(none)"
# CONFIG_SWAP is not set
# CONFIG_SYSVIPC is not set
CONFIG_POSIX_MQUEUE=y
CONFIG_POSIX_MQUEUE_SYSCTL=y
CONFIG_CROSS_MEMORY_ATTACH=y
CONFIG_FHANDLE=y
# CONFIG_USELIB is not set
# CONFIG_AUDIT is not set
CONFIG_HAVE_ARCH_AUDITSYSCALL=y

#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_IRQ_LEGACY_ALLOC_HWIRQ=y
CONFIG_GENERIC_PENDING_IRQ=y
CONFIG_IRQ_DOMAIN=y
CONFIG_IRQ_DOMAIN_DEBUG=y
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BUILD=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONFIG_GENERIC_CMOS_UPDATE=y

#
# Timers

[GIT PULL] soc-camera: 4.4 batch #1

2015-09-20 Thread Guennadi Liakhovetski

Hi Mauro,

I missed the 4.3 cycle completely, so, this should clean up my backlog. 
There are still PXA patches outstanding, but Robert wanted to work a bit 
more on them.

The following changes since commit 9ddf9071ea17b83954358b2dac42b34e5857a9af:

  Merge tag 'v4.3-rc1' into patchwork (2015-09-13 11:10:12 -0300)

are available in the git repository at:


  git://linuxtv.org/gliakhovetski/v4l-dvb.git for-4.4-1

for you to fetch changes up to 8cf27580b31fd81031e8cd3b54008236dc7193c1:

  atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity 
(2015-09-20 18:30:28 +0200)


Geert Uytterhoeven (2):
  rcar_vin: Remove obsolete r8a779x-vin platform_device_id entries
  atmel-isi: Protect PM-only functions to kill warning

Josh Wu (6):
  soc-camera: increase the length of clk_name on soc_of_bind()
  atmel-isi: increase timeout to disable/enable isi
  atmel-isi: setup the ISI_CFG2 register directly
  atmel-isi: move configure_geometry() to start_streaming()
  atmel-isi: add sanity check for supported formats in try/set_fmt()
  atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

Laurent Pinchart (3):
  v4l: atmel-isi: Simplify error handling during DT parsing
  v4l: atmel-isi: Remove support for platform data
  v4l: atmel-isi: Remove unused platform data fields

Sergei Shtylyov (2):
  rcar_vin: propagate querystd() error upstream
  rcar_vin: call g_std() instead of querystd()

 drivers/media/platform/soc_camera/atmel-isi.c  | 125 +++--
 .../media/platform/soc_camera}/atmel-isi.h |   7 +-
 drivers/media/platform/soc_camera/rcar_vin.c   |  20 ++--
 drivers/media/platform/soc_camera/soc_camera.c |   2 +-
 4 files changed, 79 insertions(+), 75 deletions(-)
 rename {include/media => drivers/media/platform/soc_camera}/atmel-isi.h (95%)

Thanks
Guennadi
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Terratec H7 Rev. 4 is DVBSky

Re: [RFC 0/9] Unrestricted media entity ID range support

drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:18: error: too many arguments to function 'horus3a_attach'

drivers/media/i2c/adv7604.c:1853:9: error: implicit declaration of function 'v4l2_subdev_get_try_format'

Re: [Patch] media: v4l2-ctrls: Fix 64bit support in get_ctrl()

Re: [PATCH 0/4] atmel-isi: Remove platform data support

Re: [PATCH 0/4] atmel-isi: Remove platform data support

[PATCH 2/2] [media] c8sectpfe: forward err instead of returning an uninitialized variable

[PATCH 1/2] [media] c8sectpfe: initialize err in load_slim_core_fw

cron job: media_tree daily build: OK

ERROR: "vb2_ops_wait_finish" [drivers/input/touchscreen/sur40.ko] undefined!

[GIT PULL] soc-camera: 4.4 batch #1

12 matches

Site Navigation

Mail list logo

Footer information