Re: [PULL] http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci_init-fix
Hi Mauro,
On Fri, 2010-05-21 at 11:45 -0300, Mauro Carvalho Chehab wrote:
The fix seems ok, but it is at the wrong place: if DVB bus fails, it makes
no sense on keep running any post-register initialization, like
calling netup_get_card_info() and copying the mac address.
The better is to return the fail.
So, I moved the return to the proper place. See bellow.
ok, accepted.
thanks
Cheers,
Mauro
---
commit 94096e78ed500d424153da0ecbc69273753f2ee3
Author: Abylay Ospan aos...@netup.ru
Date: Wed May 12 04:24:09 2010 -0300
V4L/DVB: cx23885: Check register errors
Fix kernel Oops when number of NetUP Dual DVB-S2-CI cards more than
DVB_MAX_ADAPTERS limit.
[mche...@redhat.com: move the return to the proper place]
Signed-off-by: Abylay Ospan aos...@netup.ru
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c
b/drivers/media/video/cx23885/cx23885-dvb.c
index 939079d..1ed058f 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -991,6 +991,8 @@ static int dvb_register(struct cx23885_tsport *port)
ret = videobuf_dvb_register_bus(port-frontends, THIS_MODULE, port,
dev-pci-dev, adapter_nr, 0,
cx23885_dvb_fe_ioctl_override);
+ if (!ret)
+ return ret;
/* init CI MAC */
switch (dev-board) {
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci_init-fix
Mauro, Please pull follwing fix: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci_init-fix Fix kernel Oops when number of NetUP Dual DVB-S2-CI cards more than DVB_MAX_ADAPTERS limit Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: stv090x vs stv0900
Hello, On Thu, 2010-05-06 at 10:46 +0200, Pascal Terjan wrote: Also, are they both maintained ? I wrote a patch to add get_frontend to stv090x but stv0900 also does not have it and I don't know which one should get new code. I have added get_frontend to stv0900 two months ago - http://linuxtv.org/hg/v4l-dvb/rev/a3e28fbefdc3 I'm trying to describe my point of view about two drivers for stv6110 +stv0900. History: I have anounced our card on November 2008 - http://www.linuxtv.org/pipermail/linux-dvb/2008-November/030439.html As you can see I have mentioned that we developing code and will be publish it under GPL. All people in ML received this message. This should be prevent of duplicate work. Also we have obtained permission (signed letter) from STM to publish resulting code under GPL. We have send pull request at Feb 2009 - http://www.mail-archive.com/linux-media@vger.kernel.org/msg02180.html (stv090x commit requested later - in May 2009 - http://www.mail-archive.com/linux-media@vger.kernel.org/msg04978.html ). Solution: Ideally two drivers should be combined into one. stv0900 driver can be used as starting point. We (NetUP Inc.) can initiaite this job. But we need approval from Manu and all community who using stv090x. Manu what do you think about this ? This is not trivial because some features may be broken when combining this two code. -- Abylai Ospan aos...@netup.ru NetUP Inc. P.S. From our side we have strong experience in STV6110+STV0900 IC's. Our engeneers designed NetUP Dual DVB-S2 CI card from scratch. We know many nuances about this IC's. For example, we have tested 16APSK/32APSK - http://linuxtv.org/wiki/index.php/STMicroelectronics_STV0900A_16APSK_32APSK Also we developing new version of our NetUP Dual DVB-S2 CI based on FPGA (like our Dual DVB-T/C CI card - http://linuxtv.org/wiki/index.php/NetUP_Dual_DVB_T_C_CI_RF ). This new version of card can proceed high bitrates from STV0900 (120Mbps and higher ). Also this card can receive raw frames from STV0900 ( not only TS ) for extra functionality ( GSE ). -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-tscheck
Hello Mauro, On Wed, 2010-02-24 at 02:33 -0300, Mauro Carvalho Chehab wrote: Please pull change: http://udev.netup.ru/hg/v4l-dvb-aospan-tscheck/rev/0fdeb662c7f6 Allow to enable TS continuity and TEI check on loaded module. Current dvb_demux_tscheck processing doesn't allow to enable check on loaded module. dvb_demux_tscheck can be enabled only when loading module ( dvb_dmx_init should be called to enable dvb_demux_tscheck ). This patch fix this issue. NACK. It is not safe to use vmalloc at dvb_dmx_swfilter_packet(), as this function can be called during interrupt time, and vmalloc can sleep. ok, you are right. I have modified this patch. Please check it again: http://udev.netup.ru/hg/v4l-dvb-aospan-tscheck/rev/3d42e560c88d in this patch cnt_storage always allocated and used only when dvb_demux_tscheck assigned. Is this acceptable ? Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-get_frontend
Mauro, Please pull change: http://udev.netup.ru/hg/v4l-dvb-aospan-get_frontend 1. configurable IRQ from CAM. IRQ from CAM disabled by default. In some environment enabled IRQ can cause of machine freeze. 2. get_frontend for STV0900 realized. Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. signature.asc Description: This is a digitally signed message part
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-tscheck
Mauro, Please pull change: http://udev.netup.ru/hg/v4l-dvb-aospan-tscheck/rev/0fdeb662c7f6 Allow to enable TS continuity and TEI check on loaded module. Current dvb_demux_tscheck processing doesn't allow to enable check on loaded module. dvb_demux_tscheck can be enabled only when loading module ( dvb_dmx_init should be called to enable dvb_demux_tscheck ). This patch fix this issue. Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. signature.asc Description: This is a digitally signed message part
16APSK/32APSK
Hello, We have tested 16APSK/32APSK on STV0900A. Small experimental change set created. 16APSK 2/3 (TS bit rate is 70Mbps) works fine: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-stv0900aac Description added to linuxtv wiki: http://linuxtv.org/wiki/index.php/STMicroelectronics_STV0900A_16APSK_32APSK -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-cut3.0
Mauro, Please pull change: http://udev.netup.ru/hg/v4l-dvb-aospan-cut3.0/rev/19d25fe524a5 STV0900 Cut 3.0 AGC2 fix for NetUP Dual DVB-S2-CI card. Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. signature.asc Description: This is a digitally signed message part
Re: CAM appears to introduce packet loss
Hello, Try to check raw speed coming from demod: echo 1 /sys/module/dvb_core/parameters/dvb_demux_speedcheck and then: tail -f /var/log/messages | grep -i speed or dmesg | grep -i speed what values do you see ? this TS going through CAM. CAM has a bitrate limitation which they can pass (this depends on CAM model). On Sun, 2010-01-31 at 13:12 +0100, Marc Schmitt wrote: Hi all, For quite some time now, I'm fighting with my DVB-C setup and I think I've eliminated any hardware issues that could be the origin of the issue I'm seeing. Here is my setup: Hardware: * KNC1 TV-Station DVB-C with KNC1 CineView CI (I also tried the SATELCO EasyWatch PCI (DVB-C) with SATELCO EasyWatch CI which is exactly the same hardware, just different brand) * Conax 4.00e CAM (tested in a DVB-C capable TV, works fine) * Smartcard from the DVB provider (http://www.sasag.ch, tested and properly accessible through `gnutv -cammenu`) * Dell PE700, P4 2.80GHz, 4GB RAM Software: * Mythbuntu 9.10 (karmic) * kernel 2.6.31-17-generic #54-Ubuntu SMP Thu Dec 10 16:20:31 UTC 2009 i686 GNU/Linux My DVB provider uses the free-to-view system for all channels except the local TV channel which is transmitted unencrypted. When the CAM is not inserted in the CI, I'm getting a perfect video stream ([PS/PES: ITU-T Rec. H.262 | ISO/IEC 13818-2 or ISO/IEC 11172-2 video stream]) for that unencrypted channel. dvbsnoop tells me that the stream is coming in at a fairly constant bandwidth of 4852 kbit/s. The moment I insert the CAM into the CI, the bandwidth drops to an average of 4070 kbit/s. I did analyze both streams with Peter Daniel's MPEG-2 Transport Stream packet analyser. As expected, the former stream has no continuity issues whereas the latter does. I see the continuity counter jump from 12 to 15 for example. The resulting video stream is visually distorted, I've uploaded an example at https://sites.google.com/site/msslinux/linuxmce/SFInfo.mpeg?attredirects=0d=1 to give you an idea. I get exactly the same result for any free-to-view channel which makes me suspect that the CAM/Smartcard does properly decrypt the stream. However, something appears not to be able to keep up. My DVB provider used QAM_256 which makes the bandwidth susceptible to the signal to noise ratio. The S/N ratio is at f5f5 without the CAM inserted and drops to f4f4 with the CAM inserted. I don't think that's the issue. I saw a few postings on the net about performance issues of budget cards with QAM_256 when using CI/CAM. Is that really the problem? How can I find out, i.e. further narrow down the problem? Any pointers will be appreciated. Thanks, Marc -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CAM appears to introduce packet loss
On Sun, 2010-01-31 at 16:23 +0100, Marc Schmitt wrote: Looks like I need to build the DVB subsystem from the latest sources to get this option as it was recently added only (http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan/rev/1d956b581b02). On it. yes. this option should show raw bitrate coming from demod and which passed to CI. In user level you may be measuring bitrate after software PID filtering ( may be not ). -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CAM appears to introduce packet loss
On Sun, 2010-01-31 at 17:25 +0100, Marc Schmitt wrote: Compiling from source made me stumble across http://www.mail-archive.com/ubuntu-devel-disc...@lists.ubuntu.com/msg09422.html I just left out the firedtv driver as recommended. I'm getting the following kernel output after enabling dvb_demux_speedcheck: [ 330.366115] TS speed 40350 Kbits/sec [ 332.197693] TS speed 40085 Kbits/sec [ 334.011856] TS speed 40528 Kbits/sec [ 335.843466] TS speed 40107 Kbits/sec [ 337.665411] TS speed 40261 Kbits/sec [ 339.496959] TS speed 40107 Kbits/sec [ 341.318289] TS speed 40350 Kbits/sec Do you think the CI/CAM can not handle that? 40 Mbit/sec is high bitrate for some CAM's. You can: 1. Try to contact with CAM vendor and check maximum bitrate which can be passed throught this CAM 2. Try to find reception card with hardware PID filtering and pass only interesting PID's throught CAM. Bitrate should be equal to bitrate of one channel - aprox. 4-5 mbit/sec ( not 40 mbit/sec). 3.may be some fixes can be made on TS output from demod. Demod's usually has tunable TS output timings/forms. You should check TS clock by oscilloscope and then try to change TS timings/forms in demod. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CAM appears to introduce packet loss
You can: 1. Try to contact with CAM vendor and check maximum bitrate which can be passed throught this CAM I tried that CAM in a TV with DVB-C support. The image was perfect so I suspect that the CAM itself can handle it unless the TV did HW PID filtering before sending the stream to the CAM, as you point out below... Is that to be expected? Depends on TV vendor. But it's not impossible. 2. Try to find reception card with hardware PID filtering and pass only interesting PID's throught CAM. Bitrate should be equal to bitrate of one channel - aprox. 4-5 mbit/sec ( not 40 mbit/sec). Do you have a recommendation for such a card? try to search on linuxtv wiki. Would it be possible to do the filtering in software somehow? usually TS going from demod to CI directly without any programmable IC between. in this case you can't do PID filtering nor SW nor HW. 3.may be some fixes can be made on TS output from demod. Demod's usually has tunable TS output timings/forms. You should check TS clock by oscilloscope and then try to change TS timings/forms in demod. Unfortunately, I don't have the necessary equipment/knowledge to do this. :( I'd assume the DVB provider could give me the TS clock? But then I'm at bit at a loss with change TS timings/forms in demod. What exactly are you referring to by demod. demod is IC doing demodulation of signal and producing Transport Stream. In your card seems Philips TDA10021 is used as DVB-C demodulator. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hello, On Fri, 2010-01-22 at 15:34 -0200, Mauro Carvalho Chehab wrote: You forgot to sign it. You can simply reply to this email with your SOB, as I'll need to add Olvier's ack on it also. fixed. http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/058d68daed91 -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
On Fri, 2010-01-22 at 17:31 -0200, Mauro Carvalho Chehab wrote: Abylai Ospan wrote: Hello, On Fri, 2010-01-22 at 15:34 -0200, Mauro Carvalho Chehab wrote: You forgot to sign it. You can simply reply to this email with your SOB, as I'll need to add Olvier's ack on it also. fixed. http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/058d68daed91 Applied on -git, thanks. PS.: Douglas should update -hg tree when he have time. ok, thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
On Sat, 2010-01-16 at 11:18 -0200, Mauro Carvalho Chehab wrote: Abylai Ospan wrote: Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/fc3e44f30da3 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. 22kHz logic controlled by demod. This patch modified after discussion with Oliver. This version is acceptable for both side ... Thanks. Your site seems to be down: abort: error: No route to host Please send me a pull request when the site returns. Please try again. Should work. Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hello Oliver, There is no reason why we have to use the set_tone routine of the stv0900. You can combine - set_tone of LNBH24 with - stv090x_send_diseqc_msg of stv0900 without losing anything. Before a DiSEqC message will be sent, the tone will be disabled. Then the stv090x_send_diseqc_msg of the stv0900 can control the 22kHz tone generator of the LNBH24 using EXTM or DSQIN. yes, you right. I think lnbp21_set_tone will be used if set_tone is not defined previously (set_tone == NULL). Is this correct ? No, sorry. set_tone had to be added, because the stv0900 can also operate in DiSEqC envelope mode (connected to DSQIN of the LNBH24). In this mode set_tone of the LNBH24 has to be used. ok, you right. But seems like fe-ops.set_tone = lnbp21_set_tone; override .set_tone = stv090x_set_tone, and stv090x_set_tone never used. Is this right ? Also please check our logic. We set override_clear=LNBH24_TEN in cx23885-dvb.c i.e. we disabling 22kHz logic in LNBH24 and all 22kHz logic driven from one place ( stv0900 ). This more clear for debugging (hardware and software ). This problem is reported by one of our customer. Your changeset 13673:75331e740f61 is broke 22khz tone functionality on our cards. We need to find compromise. Reverting the patch is not a problem ( in this case we need to remove override_clear=LNBH24_TEN). -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/fc3e44f30da3 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. 22kHz logic controlled by demod. This patch modified after discussion with Oliver. This version is acceptable for both side ... Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. signature.asc Description: This is a digitally signed message part
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hello, On Thu, 2010-01-14 at 14:44 +0100, Oliver Endriss wrote: This more clear for debugging (hardware and software ). This problem is reported by one of our customer. Your changeset 13673:75331e740f61 is broke 22khz tone functionality on our cards. Ok, I did not expect that someone would set LNBH24_TEN in override_clear. ;-) yes, this not trivial to trace all override definitions :) We need to find compromise. Reverting the patch is not a problem ( in this case we need to remove override_clear=LNBH24_TEN). No problem. Both solutions above are ok for me. Maybe b) is more robust, because it allows override_clear=LNBH24_TEN to be used. I leaveit to you: Choose the one you like. ok. second is choosen - it's no broke yours and our logic. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Mauro, Please pulll change: http://udev.netup.ru/hg/v4l-dvb-aospan-22fix/ 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. Description: 22-kHz tone can be driven in two ways: 1. LNBH24 can produce 22kHz continuous tone when TEN=1 ( 22 KHz tone output is always activated ). 2. LNBH24 can reproduce 22kHz tone timings from DSQIN or EXTM pin's when TEN=0. From LNBH24 datasheet: In order to improve design flexibility an external tone input pin is available (EXTM). The EXTM is a Logic input pin which activates the 22 kHz tone output, on the VoTX pin, by using the LNBH24 integrated tone generator (similar to the DSQIN pin function). In fact, the output tone waveform characteristics will always be internally controlled by the LNBH24 tone generator and the EXTM signal will be used as a timing control for DiSEqC tone data encoding on the VoTX output. In NetUP Dual DVB-S2-CI card 22kHz tone timings on EXTM pin produced by STV0900 demod: .set_tone = stv0900_set_tone redefine to set_tone = lnbp21_set_tone is not correct for NetUP Dual DVB-S2-CI card. -- Abylai Ospan aos...@netup.ru NetUP Inc. P.S. Also I think diseqc doesn't work when TEN bit enabled in LNBH24 (22kHz tone can't be modulated by demod), but need to check ... signature.asc Description: This is a digitally signed message part
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-ci-irq/
Mauro, Please pull change: http://udev.netup.ru/hg/v4l-dvb-aospan-ci-irq/ configurable IRQ mode on NetUP Dual DVB-S2 CI; IRQ from CAM processing (CI interface works faster). with this patch CI works 7x times faster in our benchmarks. Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. signature.asc Description: This is a digitally signed message part
Re: [PULL] http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci
On Sat, 2009-12-12 at 14:21 -0200, Mauro Carvalho Chehab wrote: Hmm.. It would be better if you read the registers only if debug. right. fixed - http://udev.netup.ru/hg/v4l-dvb-aospan-ci-new/rev/ac82edbd88fc is this ok ? Btw, it could be interesting to add the bit rate measure at the stats API, after we merge it (I'm still waiting for some comments at the RFC, before being able to take a decision between a rigid struct-based ioctl, or a flexible S2API based one). I'm not sure if the struct-based ioctl has a messure for the transfer bit-rate, but, with S2API, it can be easily added. ok, no problem. We can point our bit rate measure function to API when it will be ready. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci
Hello Mauro, Please review your patch against checkpatch.pl before posting. It found a number of errors. Also, the patches on your tree doesn't match your description. Please have a separate tree for your pull requests, since I generally pull everything new there instead of cherry-picking patches. Ok, understand. I didn't knew about this. Here is a clean tree with only this patch: http://udev.netup.ru/hg/v4l-dvb-aospan-ci-new please pull it. checkpatch.pl shows total: 0 errors, 0 warnings, 23 lines checked -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci
Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci/rev/3b217910057c Print bitrate measured by stv0900 demod in stv0900_read_status. this feature very useful for debugging. -- Abylai Ospan aos...@netup.ru NetUP Inc. signature.asc Description: This is a digitally signed message part
Re: [PULL] http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci
On Thu, 2009-12-10 at 17:26 +0300, Abylai Ospan wrote: Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci/rev/3b217910057c Print bitrate measured by stv0900 demod in stv0900_read_status. this feature very useful for debugging. sorry, here is a correct version of this patch: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci/rev/cf16baf33f0d -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RESEND PULL] http://udev.netup.ru/hg/v4l-dvb-aospan
Mauro, Please pulll changes from: http://udev.netup.ru/hg/v4l-dvb-aospan/rev/711d9630876f Show speed of transport stream in Kbit/sec: for example, data obtained from DVB-S2 transponder from Eutelsat W4: Jun 27 12:06:01 udev TS speed 58608 Kbits/sec Jun 27 12:06:03 udev TS speed 58422 Kbits/sec Jun 27 12:06:04 udev TS speed 58608 Kbits/sec for DVB-S1 transponder from the same satellite: Jun 27 12:07:00 udev TS speed 37108 Kbits/sec Jun 27 12:07:02 udev TS speed 37089 Kbits/sec Jun 27 12:07:04 udev TS speed 37202 Kbits/sec this feature can be enabled using following command: echo 1 /sys/module/dvb_core/parameters/dvb_demux_speedcheck and disabled by following command: echo 0 /sys/module/dvb_core/parameters/dvb_demux_speedcheck -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
NetUP Dual DVB-T/C-CI RF PCI-E x1
Hello, We have designed NetUP Dual NetUP Dual DVB-T/C-CI RF PCI-E x1 card. A short description is available in wiki - http://linuxtv.org/wiki/index.php/NetUP_Dual_DVB_T_C_CI_RF Features: * PCI-e x1 * Supports two DVB-T/DVB-C transponders simultaneously * Supports two analog audio/video channels simultaneously * Independent descrambling of two transponders * Hardware PID filtering Now we have started the work on the driver for Linux. The following components used in this card already have their code for Linux published: * Conexant CX23885, CX25840 * Xceive XC5000 silicon TV tuner We are working on the code for the following components: * STM STV0367 low-power and ultra-compact combo DVB-T/C single-chip receiver * Altera FPGA for Common Interafce. We have developed FPGA firmware for CI (according to PCMCIA/en50221). Also we are doing hardware PID filtering. It's fast and very flexible. JTAG is used for firmware uploading into FPGA - this part contains JAM player from Altera for processing JAM STAPL Byte-Code (.jbc files). The resulting code will be published under GPL after receiving permissions from IC vendors. -- Abylai Ospan aos...@netup.ru NetUP Inc. P.S. We will show this card at the upcoming IBC exhibition ( stand IP402 ). -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan
Mauro, Please pulll changes: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan/rev/8b0c92aec325 vmalloc to kmalloc changed. vmalloc don't work (kernel oops hapens) when dvb_dmx_swfilter_packets called from IRQ handler ( for example in budget-core ). -- Abylai Ospan aos...@netup.ru NetUP Inc. smime.p7s Description: S/MIME cryptographic signature
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan
Mauro, Please pulll changes: 1. correct init values in cnt_storage for TS continuity check: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan/rev/f753dd0f27c9 2. Show speed of transport stream in Kbit/sec: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan/rev/91923e3471ac for example, data obtained from DVB-S2 transponder from Eutelsat W4: Jun 27 12:06:01 udev TS speed 58608 Kbits/sec Jun 27 12:06:03 udev TS speed 58422 Kbits/sec Jun 27 12:06:04 udev TS speed 58608 Kbits/sec for DVB-S1 transponder from the same satellite: Jun 27 12:07:00 udev TS speed 37108 Kbits/sec Jun 27 12:07:02 udev TS speed 37089 Kbits/sec Jun 27 12:07:04 udev TS speed 37202 Kbits/sec this feature can be enabled using following command: echo 1 /sys/module/dvb_core/parameters/dvb_demux_speedcheck and disabled by following command: echo 0 /sys/module/dvb_core/parameters/dvb_demux_speedcheck -- Abylai Ospan aos...@netup.ru NetUP Inc. smime.p7s Description: S/MIME cryptographic signature
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan
Mauro,
Please pull new changes -
http://udev.netup.ru/hg/v4l-dvb-aospan/rev/db2114ac07ed
+#define dprintk_tscheck(x...) do { \
+ if (dvb_demux_tscheck printk_ratelimit()) printk(x); } while (0)
checkpatch.pl is not perfect. The better is to break the macro as I've shown
on
my previous email, breaking one statement per line:
done.
No need for an empty line here. Please remove to keep all vars together.
done.
+ int cnt_pid;
unsigned cnt_pid;
changed to pid var. Thanks for Andreas Oberritter.
+
+ if (dvb_demux_tscheck) {
+
No need for an empty line here.
done.
Please add a define for 0x1fff and use the define, instead of using a magic
value at vmalloc, like:
#define MAX_PID 0x1ffe
done.
You need to add a check to see if the vmalloc really worked.
Also, if you don't have memory for the first packet, it doesn't make sense to
keep insisting on allocating memory. Better just to disable the check. So, I
would code it like:
done.
+ /* check pkt counter */
+ cnt_pid = ((buf[1] 0x1f)8) | buf[2];
+
+ if (cnt_pid != 0x1fff) {
if (cnt_pid = MAX_PID) {
changed for if (cnt_pid MAX_PID) because PID=0x1FFF should be
ignored ( padding NULL packets - described in
http://en.wikipedia.org/wiki/MPEG_transport_stream ).
+ if ((buf[3] 0xf) != demux-cnt_storage[cnt_pid])
+ dprintk_tscheck(TS packet counter mismatch.
PID=0x%x expected 0x%x got 0x%x\n,\
+ cnt_pid,
demux-cnt_storage[cnt_pid], buf[3] 0xf);
Please, don't add the backslash. Also, in order to have it 80-line compliant,
you could break the strings as:
done.
In order to work with the lack of memory, you'll need a label here:
no_dvb_demux_tscheck
done.
--
Abylai Ospan aos...@netup.ru
NetUP Inc.
smime.p7s
Description: S/MIME cryptographic signature
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan
Mauro, В Пнд, 01/06/2009 в 04:52 -0300, Mauro Carvalho Chehab пишет: + * uncomment this define for transport stream packets continuity counter check + * #define DVB_DEMUX_SECTION_TS_COUNTER_CHECK + */ It wouldn't be better to add it as a Kconfig or as a module option, in order to be easy for people to enable it? module option seems more flexible. Also, it may make sense to change it to use printk_ratelimit, to avoid it to produce too much printk errors. yes, this right. Please pulll new changes - http://udev.netup.ru/hg/v4l-dvb-aospan/rev/4acf883807a8 1. Module option dvb_demux_tscheck added. Can be changed on fly ( by echo 1 /sys/module/dvb_core/parameters/dvb_demux_tscheck). Check disabled by default. 2. printk_ratelimit used. 3. DVB_DEMUX_SECTION_TS_COUNTER_CHECK define removed -- Abylai Ospan aos...@netup.ru NetUP Inc. smime.p7s Description: S/MIME cryptographic signature
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan
В Пнд, 01/06/2009 в 06:38 -0300, Mauro Carvalho Chehab пишет: Please check your patch against kernel codingstyle with checkpatch.pl. There are some CodingStyle violations here and on the code bellow. Please pull new changes - http://udev.netup.ru/hg/v4l-dvb-aospan/rev/0d3e6c0695cc 1. checkpatch.pl don't show warnings/errors ( except printk line length ). 2. cnt_storage array dinamically allocated before doing checks. We can't allocate it in dvb_dmx_init routine because module option dvb_demux_tscheck can be enabled on running system ( not in module startup only ). -- Abylai Ospan aos...@netup.ru NetUP Inc. smime.p7s Description: S/MIME cryptographic signature
