[PATCH] [media] fix tua6034 pll bandwich configuration [3rd and last attempt]

[Arne Fitzenreiter]

i have already send this patch twice and the mailing list but get no 
response. (Three weeks delay between the mails).

Why mail mails are ignored?

The tua6034 pll is corrupted by commit [media] dvb-pll: use DVBv5 
parameters on set_params()

http://git.linuxtv.org/media_tree.git/commit/80d8d4985f280dca3c395286d13b49f910a029e7

[SNIP]
/* Infineon TUA6034
* used in LG TDTP E102P
*/
-static void tua6034_bw(struct dvb_frontend *fe, u8 *buf,
-  const struct dvb_frontend_parameters *params)
+static void tua6034_bw(struct dvb_frontend *fe, u8 *buf)
{
-   if (BANDWIDTH_7_MHZ != params-u.ofdm.bandwidth)
+   u32 bw = fe-dtv_property_cache.bandwidth_hz;
+   if (bw == 700)
  buf[3] |= 0x08;
}
[/SNIP]

so here is a patch to fix this typo to get the Skymaster DTMU100 
(HANFTEK UMT010 OEM BOX)

working again.

Arne

Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=51011

diff -Naur linux-3.7-rc7-org/drivers/media/dvb-frontends/dvb-pll.c 
linux-3.7-rc7/drivers/media/dvb-frontends/dvb-pll.c
--- linux-3.7-rc7-org/drivers/media/dvb-frontends/dvb-pll.c	2012-11-26 
02:59:19.0 +0100
+++ linux-3.7-rc7/drivers/media/dvb-frontends/dvb-pll.c	2012-11-27 
09:45:16.736775252 +0100

@@ -247,7 +247,7 @@
static void tua6034_bw(struct dvb_frontend *fe, u8 *buf)
{
u32 bw = fe-dtv_property_cache.bandwidth_hz;
-   if (bw == 700)
+   if (bw != 700)
buf[3] |= 0x08;
}

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] [media] fix tua6034 pll bandwich configuration [resend]

[Arne Fitzenreiter]

Hi Mauro,

i have already send this patch to you and the mailing list around 3 
weeks ago but get no response.
The tua6034 pll is corrupted by your commit [media] dvb-pll: use DVBv5 
parameters on set_params()

http://git.linuxtv.org/media_tree.git/commit/80d8d4985f280dca3c395286d13b49f910a029e7

[SNIP]
/* Infineon TUA6034
 * used in LG TDTP E102P
 */
-static void tua6034_bw(struct dvb_frontend *fe, u8 *buf,
-  const struct dvb_frontend_parameters *params)
+static void tua6034_bw(struct dvb_frontend *fe, u8 *buf)
{
-   if (BANDWIDTH_7_MHZ != params-u.ofdm.bandwidth)
+   u32 bw = fe-dtv_property_cache.bandwidth_hz;
+   if (bw == 700)
   buf[3] |= 0x08;
}
[SNIP]

so here is a patch to fix this typo to get the Skymaster DTMU100 
(HANFTEK UMT010 OEM BOX)

working again.

Arne

Signed-off-by: Arne Fitzenreiter arne.fitzenrei...@ipfire.org

---

diff -Naur a/drivers/media/dvb-frontends/dvb-pll.c 
b/drivers/media/dvb-frontends/dvb-pll.c
--- a/drivers/media/dvb-frontends/dvb-pll.c	2012-08-14 
05:45:22.0 +0200
+++ b/drivers/media/dvb-frontends/dvb-pll.c	2012-10-25 
14:06:42.123360189 +0200

@@ -247,7 +247,7 @@
static void tua6034_bw(struct dvb_frontend *fe, u8 *buf)
{
u32 bw = fe-dtv_property_cache.bandwidth_hz;
-   if (bw == 700)
+   if (bw != 700)
buf[3] |= 0x08;
}

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] [media] fix tua6034 pll bandwich configuration

[Arne Fitzenreiter]

commit 80d8d4985f280dca3c395286d13b49f910a029e7 introduce a bug
that set the wrong bandwich bit on the tua6034 pll.

Signed-off-by: Arne Fitzenreiter arne.fitzenrei...@ipfire.org

diff -Naur a/drivers/media/dvb-frontends/dvb-pll.c 
b/drivers/media/dvb-frontends/dvb-pll.c
--- a/drivers/media/dvb-frontends/dvb-pll.c	2012-08-14 
05:45:22.0 +0200
+++ b/drivers/media/dvb-frontends/dvb-pll.c	2012-10-25 
14:06:42.123360189 +0200

@@ -247,7 +247,7 @@
static void tua6034_bw(struct dvb_frontend *fe, u8 *buf)
{
u32 bw = fe-dtv_property_cache.bandwidth_hz;
-   if (bw == 700)
+   if (bw != 700)
buf[3] |= 0x08;
}

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html