[PATCH] gspca_sn9c20x: device 0c45:62b3: fix status LED

2011-07-01 Thread Frank Schaefer
Tested with webcam "SilverCrest WC2130".

Signed-off-by: Frank Schaefer 

Cc: sta...@kernel.org
---
 drivers/media/video/gspca/sn9c20x.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/gspca/sn9c20x.c 
b/drivers/media/video/gspca/sn9c20x.c
index c431900..af9cd50 100644
--- a/drivers/media/video/gspca/sn9c20x.c
+++ b/drivers/media/video/gspca/sn9c20x.c
@@ -2513,7 +2513,7 @@ static const struct usb_device_id device_table[] = {
{USB_DEVICE(0x0c45, 0x628f), SN9C20X(OV9650, 0x30, 0)},
{USB_DEVICE(0x0c45, 0x62a0), SN9C20X(OV7670, 0x21, 0)},
{USB_DEVICE(0x0c45, 0x62b0), SN9C20X(MT9VPRB, 0x00, 0)},
-   {USB_DEVICE(0x0c45, 0x62b3), SN9C20X(OV9655, 0x30, 0)},
+   {USB_DEVICE(0x0c45, 0x62b3), SN9C20X(OV9655, 0x30, LED_REVERSE)},
{USB_DEVICE(0x0c45, 0x62bb), SN9C20X(OV7660, 0x21, LED_REVERSE)},
{USB_DEVICE(0x0c45, 0x62bc), SN9C20X(HV7131R, 0x11, 0)},
{USB_DEVICE(0x045e, 0x00f4), SN9C20X(OV9650, 0x30, 0)},
-- 
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Question about BTTV-video controls "whitecrush upper/lower"

2010-07-10 Thread Frank Schaefer
Andy Walls schrieb:
> On Tue, 2010-07-06 at 13:27 +0200, Frank Schaefer wrote:
>   
>> Hi,
>>
>> there are two video controls in the Bttv-driver called "whitecrush
>> upper" and "whitecrush lower".
>> But what does "whitecrush" mean ? Is it the same as "white noise" ?
>> The german KDE translators are currently trying to translate these
>> strings...
>> 
>
> "White Crush" is Conexant's term for adapting to nonstandard or varying
> Sync to White level voltage differences of the incoming video signal.
> It's basically an adaptive AGC to prevent "blooming" of the video signal
> due to very high Luminance levels.
>
> The public BT878A datasheet has terse descriptions of what the registers
> settings do: they are basically upper and lower thresholds to determine
> when to adapt the automatic gain control.
>
> The public CX25840 datasheet gives a better written description of white
> crush in section 3.4.9:
>
>  http://dl.ivtvdriver.org/datasheets/video/cx25840.pdf
>
> I'm actually surprised the bttv driver has those presented as user
> controls at all.
>
> Regards,
> Andy
>   

Thank you Andy, that really helps a lot !

Regards,
Frank
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Question about BTTV-video controls "whitecrush upper/lower"

2010-07-06 Thread Frank Schaefer
Hi,

there are two video controls in the Bttv-driver called "whitecrush
upper" and "whitecrush lower".
But what does "whitecrush" mean ? Is it the same as "white noise" ?
The german KDE translators are currently trying to translate these
strings...

Thanks,
Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: gspca-sonixj: ioctl VIDIOC_DQBUF blocks for 3s and retuns EIO

2010-05-14 Thread Frank Schaefer
Hans de Goede schrieb:
> Hi,
>
> On 05/14/2010 08:00 AM, Jean-Francois Moine wrote:
>> On Thu, 13 May 2010 17:58:49 +0200
>> Frank Schaefer  wrote:
>>
>>> I'm not sure if I'm hitting a bug or this is the expected driver
>>> behavior: With a Microsoft LifeCam VX-3000 (045e:00f5) and
>>> gspca-sonixj, ioctl VIDIOC_DQBUF intermittently blocks for exactly 3
>>> seconds and then returns EIO.
>>> I noticed that it strongly depends on the captured scenery: when it's
>>> changing much, everything is fine.
>>> But when for example capturing the wall under constant (lower) light
>>> conditions, I'm getting this error nearly permanently.
>>>
>>> It's a JPEG-device, so I guess the device stops sending data if the
>>> picture doesn't change and that's how it should be.
>>> But is the long blocking + EIO the way drivers should handle this
>>> situtation ?
>>
>> Hello Frank,
>>
>> You are right, this is a bug. I did not know that a webcam could suspend
>> streaming when the image did not change. I will remove the timeout.
>>
>
> The way jpeg works mandates that for each block some data still needs to
> be generated even if it is a solid color, moreover as these cams do jpeg
> not mpeg, there is no delta towards the previous frame. So the cam should
> not stop streaming if it doe timing out and returning -EIO is
> appropriate.
>
> Thus we should not remove the DQBUF timeout IMHO.
Urgh, sorry, of course jpeg is not mpeg !
So the device *should* not stop sending frames, which means that I will
have to find out what's exactly going on in the kernel...
Will need some time, I don't have permanent access to this device.

Thanks so far,
Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


gspca-sonixj: ioctl VIDIOC_DQBUF blocks for 3s and retuns EIO

2010-05-13 Thread Frank Schaefer
Hi,

I'm not sure if I'm hitting a bug or this is the expected driver behavior:
With a Microsoft LifeCam VX-3000 (045e:00f5) and gspca-sonixj, ioctl
VIDIOC_DQBUF intermittently blocks for exactly 3 seconds and then
returns EIO.
I noticed that it strongly depends on the captured scenery: when it's
changing much, everything is fine.
But when for example capturing the wall under constant (lower) light
conditions, I'm getting this error nearly permanently.

It's a JPEG-device, so I guess the device stops sending data if the
picture doesn't change and that's how it should be.
But is the long blocking + EIO the way drivers should handle this
situtation ?

Regards,
Frank Schaefer

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 1/2] v4l: Add V4L2_CID_IRIS_ABSOLUTE and V4L2_CID_IRIS_RELATIVE controls

2010-03-19 Thread Frank Schaefer
Laurent Pinchart schrieb:
> Those control, as their names imply, control the camera aperture
> settings.
>
> Signed-off-by: Laurent Pinchart 
> ---
>  Documentation/DocBook/v4l/compat.xml  |   11 +++
>  Documentation/DocBook/v4l/controls.xml|   19 +++
>  Documentation/DocBook/v4l/videodev2.h.xml |3 +++
>  include/linux/videodev2.h |3 +++
>  4 files changed, 36 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/DocBook/v4l/compat.xml 
> b/Documentation/DocBook/v4l/compat.xml
> index b9dbdf9..854235b 100644
> --- a/Documentation/DocBook/v4l/compat.xml
> +++ b/Documentation/DocBook/v4l/compat.xml
> @@ -2332,6 +2332,17 @@ more information.
>   
>
>  
> +
> +  V4L2 in Linux 2.6.34
> +  
> + 
> +   Added
> +V4L2_CID_IRIS_ABSOLUTE and
> +V4L2_CID_IRIS_RELATIVE controls to the
> + Camera controls class.
> +   
> + 
> +  
> 
>  
> 
> diff --git a/Documentation/DocBook/v4l/controls.xml 
> b/Documentation/DocBook/v4l/controls.xml
> index f464506..e47999d 100644
> --- a/Documentation/DocBook/v4l/controls.xml
> +++ b/Documentation/DocBook/v4l/controls.xml
> @@ -1825,6 +1825,25 @@ wide-angle direction. The zoom speed unit is 
> driver-specific.
> 
>  
> 
> +  spanname="id">V4L2_CID_IRIS_ABSOLUTE 
> + integer
> +   This control sets the
> +camera's aperture to the specified value. The unit is undefined.
> +Larger values open the iris wider, smaller values close it.
> +   
> +   
> +
> +   
> +  spanname="id">V4L2_CID_IRIS_RELATIVE 
> + integer
> +   This control modifies the
> +camera's aperture by the specified amount. The unit is undefined.
> +Positive values open the iris one step further, negative values close
> +it one step further. This is a write-only control.
> +   
> +   
> +
> +   
>spanname="id">V4L2_CID_PRIVACY 
>   boolean
> Prevent video from being acquired
> diff --git a/Documentation/DocBook/v4l/videodev2.h.xml 
> b/Documentation/DocBook/v4l/videodev2.h.xml
> index 0683259..c18dfeb 100644
> --- a/Documentation/DocBook/v4l/videodev2.h.xml
> +++ b/Documentation/DocBook/v4l/videodev2.h.xml
> @@ -1271,6 +1271,9 @@ enum   linkend="v4l2-exposure-auto-type">v4l2_exposure_auto_type {
>  
>  #define V4L2_CID_PRIVACY
> (V4L2_CID_CAMERA_CLASS_BASE+16)
>  
> +#define V4L2_CID_IRIS_ABSOLUTE  
> (V4L2_CID_CAMERA_CLASS_BASE+17)
> +#define V4L2_CID_IRIS_RELATIVE  
> (V4L2_CID_CAMERA_CLASS_BASE+18)
> +
>  /* FM Modulator class control IDs */
>  #define V4L2_CID_FM_TX_CLASS_BASE   (V4L2_CTRL_CLASS_FM_TX | 
> 0x900)
>  #define V4L2_CID_FM_TX_CLASS(V4L2_CTRL_CLASS_FM_TX | 1)
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index 3c26560..c9d2120 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -1277,6 +1277,9 @@ enum  v4l2_exposure_auto_type {
>  
>  #define V4L2_CID_PRIVACY (V4L2_CID_CAMERA_CLASS_BASE+16)
>  
> +#define V4L2_CID_IRIS_ABSOLUTE   
> (V4L2_CID_CAMERA_CLASS_BASE+17)
> +#define V4L2_CID_IRIS_RELATIVE   
> (V4L2_CID_CAMERA_CLASS_BASE+18)
> +
>  /* FM Modulator class control IDs */
>  #define V4L2_CID_FM_TX_CLASS_BASE(V4L2_CTRL_CLASS_FM_TX | 0x900)
>  #define V4L2_CID_FM_TX_CLASS (V4L2_CTRL_CLASS_FM_TX | 1)
>   
Please also add proper titles to v4l2_ctrl_get_name() in v4l2-common.c.

Thanks,
Frank
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] v4l2_ctrl_get_name(): add missing control names, and make title for V4L2_CID_BG_COLOR consistent

2010-03-14 Thread Frank Schaefer
v4l2_ctrl_get_name(): add missing control names, and make title for
V4L2_CID_BG_COLOR consistent

V4L2_CID_AUTOBRIGHTNESS   was introduced with kernel 2.6.31
V4L2_CID_BAND_STOP_FILTER was introduced with kernel 2.6.32

Signed-off-by: Frank Schaefer 

diff --git a/drivers/media/video/v4l2-common.c
b/drivers/media/video/v4l2-common.c
index 36b5cb8..e679834 100644
--- a/drivers/media/video/v4l2-common.c
+++ b/drivers/media/video/v4l2-common.c
@@ -431,8 +431,10 @@ const char *v4l2_ctrl_get_name(u32 id)
 case V4L2_CID_CHROMA_AGC:return "Chroma AGC";
 case V4L2_CID_COLOR_KILLER:return "Color Killer";
 case V4L2_CID_COLORFX:return "Color Effects";
+case V4L2_CID_AUTOBRIGHTNESS:return "Brightness, Automatic";
+case V4L2_CID_BAND_STOP_FILTER:return "Band-Stop Filter";
 case V4L2_CID_ROTATE:return "Rotate";
-case V4L2_CID_BG_COLOR:return "Background color";
+case V4L2_CID_BG_COLOR:return "Background Color";
 
 /* MPEG controls */
 case V4L2_CID_MPEG_CLASS: return "MPEG Encoder Controls";
-- 
1.6.0.2
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html