Re: [PATCH v6 1/3] iommu: Implement common IOMMU ops for DMA mapping

2015-10-30 Thread Joerg Roedel
On Fri, Oct 30, 2015 at 09:17:52AM +0800, Daniel Kurtz wrote:
> Hmm, I thought the DMA API maps a (possibly) non-contiguous set of
> memory pages into a contiguous block in device memory address space.
> This would allow passing a dma mapped buffer to device dma using just
> a device address and length.

If you are speaking of the dma_map_sg interface, than there is absolutly
no guarantee from the API side that the buffers you pass in will end up
mapped contiguously.
IOMMU drivers handle this differently, and when there is no IOMMU at all
there is also no way to map these buffers together.

> So, is the videobuf2-dma-contig.c based on an incorrect assumption
> about how the DMA API is supposed to work?

If it makes the above assumption, then yes.



Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [GIT PULL FOR v3.16] Migrate the OMAP3 ISP driver to videobuf2

2014-06-05 Thread Joerg Roedel
Hi Mauro,

On Wed, Jun 04, 2014 at 08:53:10PM -0300, Mauro Carvalho Chehab wrote:
 Hi Joerg,
 
 I have one topic branch here that depends on your branch:
   git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git arm/omap
 
 Did you send already a pull request for Linus? If not, when are you planning
 to do?
 
 My intention is to send my pull request after yours ;)

Just sent my pull-request. In the future you can also let me know
earlier and I can give you a topic-branch then from my tree to just pull
into yours to avoid those dependencies :-)


Joerg


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] arm: omap: Fix build error in ispccdc.c

2011-09-06 Thread Joerg Roedel
The following build error occurs with 3.1-rc5:

  CC  drivers/media/video/omap3isp/ispccdc.o
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In 
function 'ccdc_lsc_config':
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:2: 
error: implicit declaration of function 'kzalloc' 
[-Werror=implicit-function-declaration]
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:6: 
warning: assignment makes pointer from integer without a cast [enabled by 
default]

This patch adds the missing 'linux/slab.h' include to fix the problem.

Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: linux-media@vger.kernel.org
Cc: linux-o...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Joerg Roedel joerg.roe...@amd.com
---
 drivers/media/video/omap3isp/ispccdc.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/omap3isp/ispccdc.c 
b/drivers/media/video/omap3isp/ispccdc.c
index 9d3459d..80796eb 100644
--- a/drivers/media/video/omap3isp/ispccdc.c
+++ b/drivers/media/video/omap3isp/ispccdc.c
@@ -31,6 +31,7 @@
 #include linux/dma-mapping.h
 #include linux/mm.h
 #include linux/sched.h
+#include linux/slab.h
 #include media/v4l2-event.h
 
 #include isp.h
-- 
1.7.4.1


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html