Re: [Ksummit-discuss] Including images on Sphinx documents
> > > You had pointed me to this plugin before > > > https://pythonhosted.org/sphinxcontrib-aafig/ > > > > > > but I don't think it can actually represent any of the pictures. > > > > No, but there are some ascii art images inside some txt/rst files > > and inside some kernel-doc comments. We could either use the above > > extension for them or to convert into some image. The ascii art > > images I saw seem to be diagrams, so Graphviz would allow replacing > > most of them, if not all. > > Please don't replace ASCII art that effectively conveys conceptual > diagrams. If you do, we'll wind up in situations where someone > hasn't built the docs and doesn't possess the tools to see a diagram > that was previously shown by every text editor (or can't be bothered > to dig out the now separate file). In the name of creating > "prettier" diagrams (and final doc), we'll have damaged capacity to > understand stuff by just reading the source if this diagram is in > kernel doc comments. I think this is a good application of "if it > ain't broke, don't fix it". Right, I agree completely! That's the selling point of aafig though, it translates to pretty diagrams, but looks fine when viewed in a normal text editor (with fixed-width font) I had a hack elsewhere that would embed the fixed-width text if the plugin isn't present, which seemed like a decent compromise, but nobody is willing to let plugins be used in general to start with, it seems :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Ksummit-discuss] Including images on Sphinx documents
> So, the problem that remains is for those images whose source > is a bitmap. If we want to stick with the Sphinx supported formats, > we have only two options for bitmaps: jpg or png. We could eventually > use uuencode or base64 to make sure that the patches won't use > git binary diff extension, or, as Arnd proposed, use a portable > bitmap format, in ascii, converting via Makefile, but losing > the alpha channel with makes the background transparent. > Or just "rewrite" them in svg? None of the gif files I can see actually look like they'd have been drawn in gif format anyway. The original source may be lost, but it doesn't seem all that hard to recreate them in svg. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/22] Add and use pci_zalloc_consistent
On Tue, 2014-06-24 at 09:27 +1000, Julian Calaby wrote: - x = (T)pci_alloc_consistent(E1,E2,E3); + x = pci_zalloc_consistent(E1,E2,E3); if ((x==NULL) || ...) S - memset((T2)x,0,E2); I don't know much about SmPL, but wouldn't having that if statement there reduce your matches? Code that matched without the if statement would be buggy, since it wouldn't be checking the pci_zalloc_consistent return value properly.l johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: non-working UVC device 058f:5608
Hi Laurent, Thanks for the quick reply! and then the kernel message repeats forever, while I can't even exit uvccapture unless I kill it hard, at which point I get xhci_hcd :00:14.0: Signal while waiting for configure endpoint command usb 1-3.4.4.3: Not enough bandwidth for altsetting 0 from the kernel. This looks like low-level USB issues, CC'ing the linux-usb mailing list. Ok. Any thoughts? Just to rule out hardware defects I connected it to my windows 7 work machine and it works fine without even installing a driver. Could you try connecting it to an EHCI controller instead of XHCI on a Linux machine ? Indeed, that works! Interestingly, it works neither on a USB3 port directly, nor on a USB2 hub behind the USB3 port. Thanks, johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: non-working UVC device 058f:5608
On Mon, 2014-06-09 at 11:25 +0200, Laurent Pinchart wrote: Indeed, that works! Interestingly, it works neither on a USB3 port directly, nor on a USB2 hub behind the USB3 port. I would thus be tempted to classify this as an XHCI controller issue. linux- usb should be the right list to get help. I've CC'ed Mathias Nyman, the XHCI maintainer. Yeah, I tend to agree. Johannes, could you enable USB debugging in the linus/master kernel and provide a kernel log ? Sure. Note that linus/next is having even more issues with this device, to the point where I couldn't even get the lsusb I pasted into the first email. I used 3.13 (because I had it installed on the system in question) to get that. It was also throwing an autosuspend warning: http://mid.gmane.org/1402177014.8442.1.ca...@jlt4.sipsolutions.net I'll try to get some logs (wasn't there tracing added to xhci too? will check) johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: non-working UVC device 058f:5608
On Mon, 2014-06-09 at 11:59 +0200, Johannes Berg wrote: Johannes, could you enable USB debugging in the linus/master kernel and provide a kernel log ? I'll try to get some logs (wasn't there tracing added to xhci too? will check) Here we go - log + tracing: log: http://p.sipsolutions.net/d5926c43d531e3af.txt trace: http://johannes.sipsolutions.net/files/xhci.trace.dat.xz I plugged in the device, waited a bit, tried to run a camera application (didn't work) and then ran lsusb -t and lsusb -v. johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: non-working UVC device 058f:5608
On Mon, 2014-06-09 at 12:27 +0200, Johannes Berg wrote:
Here we go - log + tracing:
log: http://p.sipsolutions.net/d5926c43d531e3af.txt
trace: http://johannes.sipsolutions.net/files/xhci.trace.dat.xz
Oh, and this was the kernel diff to commit
963649d735c8b6eb0f97e82c54f02426ff3f1f45:
diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
index eb009a4..00621cb 100644
--- a/drivers/usb/host/xhci-dbg.c
+++ b/drivers/usb/host/xhci-dbg.c
@@ -20,6 +20,8 @@
* Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#define DEBUG
+
#include xhci.h
#define XHCI_INIT_VALUE 0x0
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 6231ce6..70b09cd 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -20,6 +20,8 @@
* Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#define DEBUG
+
#include linux/slab.h
#include asm/unaligned.h
@@ -287,7 +289,7 @@ static int xhci_stop_device(struct xhci_hcd *xhci, int
slot_id, int suspend)
if (virt_dev-eps[i].ring virt_dev-eps[i].ring-dequeue) {
struct xhci_command *command;
command = xhci_alloc_command(xhci, false, false,
-GFP_NOIO);
+GFP_ATOMIC);
if (!command) {
spin_unlock_irqrestore(xhci-lock, flags);
xhci_free_command(xhci, cmd);
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 8056d90..2ceed51 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -20,6 +20,8 @@
* Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#define DEBUG
+
#include linux/usb.h
#include linux/pci.h
#include linux/slab.h
diff --git a/drivers/usb/host/xhci-mvebu.c b/drivers/usb/host/xhci-mvebu.c
index 1eefc98..4b289d6 100644
--- a/drivers/usb/host/xhci-mvebu.c
+++ b/drivers/usb/host/xhci-mvebu.c
@@ -7,6 +7,8 @@
* version 2 as published by the Free Software Foundation.
*/
+#define DEBUG
+
#include linux/io.h
#include linux/mbus.h
#include linux/of.h
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index e20520f..aae5dc9 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -20,6 +20,8 @@
* Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#define DEBUG
+
#include linux/pci.h
#include linux/slab.h
#include linux/module.h
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 29d8adb..2149b0c 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -11,6 +11,8 @@
* version 2 as published by the Free Software Foundation.
*/
+#define DEBUG
+
#include linux/clk.h
#include linux/dma-mapping.h
#include linux/module.h
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index d67ff71..a7eda28 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -64,6 +64,8 @@
* endpoint rings; it generates events on the event ring for these.
*/
+#define DEBUG
+
#include linux/scatterlist.h
#include linux/slab.h
#include xhci.h
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 2b8d9a2..fd350b7 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -20,6 +20,8 @@
* Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#define DEBUG
+
#include linux/pci.h
#include linux/irq.h
#include linux/log2.h
johannes
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
non-working UVC device 058f:5608
I just obtained a new (special-purpose) webcam, and it doesn't seem to work at all. On kernel torvals/linux.git next branch, it doesn't even really connect, on 3.13 (which I'm running on my laptop) I get errors like this: xhci_hcd :00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD when running uvccapture. When running e.g. cheese or the like, the screen stays blank. uvccapture also reports: ioctl querycontrol error 22 and then the kernel message repeats forever, while I can't even exit uvccapture unless I kill it hard, at which point I get xhci_hcd :00:14.0: Signal while waiting for configure endpoint command usb 1-3.4.4.3: Not enough bandwidth for altsetting 0 from the kernel. The device really is detected as UVC, of course: [ 3423.299311] usb 1-3.4.4.3: new high-speed USB device number 12 using xhci_hcd [ 3423.426280] usb 1-3.4.4.3: New USB device found, idVendor=058f, idProduct=5608 [ 3423.426286] usb 1-3.4.4.3: New USB device strings: Mfr=3, Product=1, SerialNumber=0 [ 3423.426290] usb 1-3.4.4.3: Product: USB 2.0 PC Camera [ 3423.426293] usb 1-3.4.4.3: Manufacturer: Alcor Micro, Corp. [ 3423.432137] uvcvideo: Found UVC 1.00 device USB 2.0 PC Camera (058f:5608) [ 3423.435383] input: USB 2.0 PC Camera as /devices/pci:00/:00:14.0/usb1/1-3/1-3.4/1-3.4.4/1-3.4.4.3/1-3.4.4.3:1.0/input/input36 (see also full lsusb below) I see a device from the same manufacturer has a kernel driver as a vendor device but actually being UVC, but this one reports being UVC and doesn't really work. Any thoughts? Just to rule out hardware defects I connected it to my windows 7 work machine and it works fine without even installing a driver. I can arrange remote access to the device (maybe as a VM to be able to experiment with the kernel more easily?) if anyone wants it. johannes lsusb: Bus 001 Device 012: ID 058f:5608 Alcor Micro Corp. Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 ? bDeviceProtocol 1 Interface Association bMaxPacketSize064 idVendor 0x058f Alcor Micro Corp. idProduct 0x5608 bcdDevice0.03 iManufacturer 3 Alcor Micro, Corp. iProduct1 USB 2.0 PC Camera iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 407 bNumInterfaces 2 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powered) MaxPower 200mA Interface Association: bLength 8 bDescriptorType11 bFirstInterface 0 bInterfaceCount 2 bFunctionClass 14 Video bFunctionSubClass 3 Video Interface Collection bFunctionProtocol 0 iFunction 1 USB 2.0 PC Camera Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber0 bAlternateSetting 0 bNumEndpoints 1 bInterfaceClass14 Video bInterfaceSubClass 1 Video Control bInterfaceProtocol 0 iInterface 1 USB 2.0 PC Camera VideoControl Interface Descriptor: bLength13 bDescriptorType36 bDescriptorSubtype 1 (HEADER) bcdUVC 1.00 wTotalLength 85 dwClockFrequency 30.00MHz bInCollection 1 baInterfaceNr( 0) 1 VideoControl Interface Descriptor: bLength18 bDescriptorType36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 1 wTerminalType 0x0201 Camera Sensor bAssocTerminal 0 iTerminal 0 wObjectiveFocalLengthMin 0 wObjectiveFocalLengthMax 0 wOcularFocalLength0 bControlSize 3 bmControls 0x VideoControl Interface Descriptor: bLength 9 bDescriptorType36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 3 wTerminalType 0x0101 USB Streaming bAssocTerminal 0 bSourceID 6 iTerminal 0 VideoControl Interface Descriptor: bLength 7 bDescriptorType36 bDescriptorSubtype 4 (SELECTOR_UNIT) bUnitID 4 bNrInPins 1 baSource( 0)1 iSelector 0 VideoControl Interface Descriptor: bLength11 bDescriptorType36
Re: [PATCH 6/7] backports: add media subsystem drivers
On Sat, 2013-04-13 at 07:13 -0700, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@do-not-panic.com This adds backport support for all media subsystem drivers. This is enabled only for = 3.2. Some media drivers rely on the new probe deferrral mechanism (-EPROBE_DEFER see commit d1c3414c), those are only enabled for kernels = 3.4. Some media drivers only depend on the regulatory but since we only support backporting the regulatory on kernels = 3.4 we only enable those media drivers for = 3.4. This backports 433 media drivers. Heh. Applied. Good thing I can kill the pr_fmt patches again soon. johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: macbook webcam no longer works on .35-rc
On Mon, 2010-07-05 at 10:23 +0200, Laurent Pinchart wrote:
Could you please test the following patch when you will have time ?
That fixes it, thank you.
johannes
diff --git a/drivers/media/video/uvc/uvc_ctrl.c
b/drivers/media/video/uvc/uvc_ctrl.c
index 9af4d47..a350fad 100644
--- a/drivers/media/video/uvc/uvc_ctrl.c
+++ b/drivers/media/video/uvc/uvc_ctrl.c
@@ -122,8 +122,8 @@ static struct uvc_control_info uvc_ctrls[] = {
.selector = UVC_PU_POWER_LINE_FREQUENCY_CONTROL,
.index = 10,
.size = 1,
- .flags = UVC_CONTROL_SET_CUR | UVC_CONTROL_GET_RANGE
- | UVC_CONTROL_RESTORE,
+ .flags = UVC_CONTROL_SET_CUR | UVC_CONTROL_GET_CUR
+ | UVC_CONTROL_GET_DEF | UVC_CONTROL_RESTORE,
},
{
.entity = UVC_GUID_UVC_PROCESSING,
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: macbook webcam no longer works on .35-rc
On Mon, 2010-07-05 at 09:28 +0200, Laurent Pinchart wrote: Hi Johannes, On Friday 02 July 2010 09:26:15 Johannes Berg wrote: On Wed, 2010-06-30 at 23:11 +0200, Johannes Berg wrote: I'm pretty sure this was a regression in .34, but haven't checked right now, can bisect when I find time but wanted to inquire first if somebody had ideas. All I get is: [57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3) : -32 (exp. 1). Does it prevent your camera from working, or does it just print annoying messages to the kernel log ? It prevents it from working, and it's the only error message since the tool/driver/libv4l/whatever just gives up after getting -EIO. lsusb -v is: Bus 001 Device 002: ID 05ac:8507 Apple, Inc. Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 ? bDeviceProtocol 1 Interface Association bMaxPacketSize064 idVendor 0x05ac Apple, Inc. idProduct 0x8507 bcdDevice4.18 iManufacturer 1 Apple Inc. iProduct2 Built-in iSight iSerial 3 8J8B41B6T40U3A00 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 642 bNumInterfaces 3 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powered) MaxPower 500mA Interface Association: bLength 8 bDescriptorType11 bFirstInterface 0 bInterfaceCount 2 bFunctionClass 14 Video bFunctionSubClass 3 Video Interface Collection bFunctionProtocol 0 iFunction 2 Built-in iSight Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber0 bAlternateSetting 0 bNumEndpoints 1 bInterfaceClass14 Video bInterfaceSubClass 1 Video Control bInterfaceProtocol 0 iInterface 2 Built-in iSight VideoControl Interface Descriptor: bLength13 bDescriptorType36 bDescriptorSubtype 1 (HEADER) bcdUVC 1.00 wTotalLength 51 dwClockFrequency4.00MHz bInCollection 1 baInterfaceNr( 0) 1 VideoControl Interface Descriptor: bLength18 bDescriptorType36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 1 wTerminalType 0x0201 Camera Sensor bAssocTerminal 0 iTerminal 0 wObjectiveFocalLengthMin 0 wObjectiveFocalLengthMax 0 wOcularFocalLength0 bControlSize 3 bmControls 0x000a Auto-Exposure Mode Exposure Time (Absolute) VideoControl Interface Descriptor: bLength 9 bDescriptorType36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 2 wTerminalType 0x0101 USB Streaming bAssocTerminal 0 bSourceID 3 iTerminal 0 VideoControl Interface Descriptor: bLength11 bDescriptorType36 bDescriptorSubtype 5 (PROCESSING_UNIT) Warning: Descriptor too short bUnitID 3 bSourceID 1 wMaxMultiplier 0 bControlSize2 bmControls 0x157f Brightness Contrast Hue Saturation Sharpness Gamma White Balance Temperature Backlight Compensation Power Line Frequency White Balance Temperature, Auto iProcessing 0 bmVideoStandards 0x 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes3 Transfer TypeInterrupt Synch Type None Usage Type Data wMaxPacketSize 0x0008 1x 8 bytes bInterval 6 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 VideoStreaming Interface Descriptor: bLength14
Re: macbook webcam no longer works on .35-rc
On Wed, 2010-06-30 at 23:11 +0200, Johannes Berg wrote: I'm pretty sure this was a regression in .34, but haven't checked right now, can bisect when I find time but wanted to inquire first if somebody had ideas. All I get is: [57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3) : -32 (exp. 1). Didn't have to bisect it. The problem is caused by commit 59529081e092506edb81a42d914e2d0522f65ca7 Author: Laurent Pinchart laurent.pinch...@ideasonboard.com Date: Sat Jan 23 06:30:20 2010 -0300 V4L/DVB: uvcvideo: Cache control min, max, res and def query results which reverts cleanly, but then the driver doesn't compile and one also needs to revert commit cf7a50eeb6f462a0b7d1619fcb27a727a2981769 Author: Laurent Pinchart laurent.pinch...@ideasonboard.com Date: Sun Apr 25 16:27:14 2010 -0300 V4L/DVB: uvcvideo: Prevent division by 0 when control step value is 0 and commit e54532e591cd5b9ce77dbc8d9786ae9f600f101a Author: Laurent Pinchart laurent.pinch...@ideasonboard.com Date: Sat Jan 23 07:07:53 2010 -0300 V4L/DVB: uvcvideo: Clamp control values to the minimum and maximum values in that order. These are commits introduced in the .34/.35 cycles. Please fix. Can we revert things that are regressions pre-dating the current kernel version? johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
macbook webcam no longer works on .35-rc
I'm pretty sure this was a regression in .34, but haven't checked right now, can bisect when I find time but wanted to inquire first if somebody had ideas. All I get is: [57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3) : -32 (exp. 1). johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
