Re: [BUG] - Why anyone fix this problem?

2015-02-02 Thread Roberto Alcântara 
Mauro,

Francesco has reported problem with DVB-T on Siano sms2270. Basically
him reach a lock with tzap but seems not have stream data.

I tried to help him to debug but I can't reproduce their problem once
I have isdb-t only here. He is using some dvb firmware with device
that seems works fine on Windows.

Cheers,
 - Roberto


 - Roberto


On Mon, Feb 2, 2015 at 10:10 AM, Francesco Other
francesco.ot...@gmail.com wrote:
 Is it possible that the problem I explained here isn't interesting for anyone?

 The device is supported by kernel but obviously there is a bug with DVB-T.

 I have the working firmware (on Windows) for DVB-T if you need it.

 http://www.spinics.net/lists/linux-media/msg85505.html

 http://www.spinics.net/lists/linux-media/msg85478.html

 http://www.spinics.net/lists/linux-media/msg85432.html

 Regards

 Francesco
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Driver/module in kernel fault. Anyone expert to help me? Siano ID 187f:0600

2015-01-14 Thread Roberto Alcântara 
Francesco,

Seems very strange not work once you have lock (1f) and ber 0. not a
real problem signal report.

After tzap -r open another console and:

dd if=/dev/dvb/adapter0/dvr0 of=test.ts

Wait 10 seconds and stop it. Please check file size (try to open on
vlc too if big enough...).

Cheers,
 - Roberto

On Tue, Jan 13, 2015 at 6:56 PM, Francesco Other
francesco.ot...@gmail.com wrote:


 So, this is the output for tzap with the NOT-working-device:

 $ tzap -r -c ~/.tzap/channels.conf Italia1
 using '/dev/dvb/adapter0/frontend0' and '/dev/dvb/adapter0/demux0'
 reading channels from file '/home/ionic/.tzap/channels.conf'
 Version: 5.10   FE_CAN { DVB-T }
 tuning to 69800 Hz
 video pid 0x0654, audio pid 0x0655
 status 00 | signal  | snr  | ber  | unc  |
 status 1f | signal  | snr 0104 | ber  | unc  | FE_HAS_LOCK
 status 1f | signal  | snr 0104 | ber  | unc  | FE_HAS_LOCK
 status 1f | signal  | snr 0104 | ber  | unc  | FE_HAS_LOCK
 status 1f | signal  | snr 0104 | ber  | unc  | FE_HAS_LOCK
 status 1f | signal  | snr 0104 | ber  | unc  | FE_HAS_LOCK
 status 1f | signal  | snr 010e | ber  | unc  | FE_HAS_LOCK
 status 1f | signal  | snr 0104 | ber  | unc  | FE_HAS_LOCK
 status 1f | signal  | snr 010e | ber  | unc  | FE_HAS_LOCK
 status 1f | signal  | snr 0104 | ber  | unc  | FE_HAS_LOCK




 - Roberto
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Driver/module in kernel fault. Anyone expert to help me? Siano ID 187f:0600

2015-01-13 Thread Roberto Alcântara 
Hi Francesco,

You are using Siano SMS2270, am I right?

My guess you're using ISDB-T firmware to program your ic, but are you
in ISDB-T region? I use same firmware name here and works fine
(Brazil) and it seems loaded ok on your log.

I never saw an DVB firmware available to sms2270. Your tuner is
working fine under Windows with provided software ?

Cheers,
  - Roberto



On Tue, Jan 13, 2015 at 11:50 AM, Francesco Other
francesco.ot...@gmail.com wrote:
 Is there a gentleman that can help me with my problem? On linuxtv.org
 they said that someone here sure will help me.

 I submitted the problem here:
 http://www.spinics.net/lists/linux-media/msg85432.html

 Regards

 Francesco
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Driver/module in kernel fault. Anyone expert to help me? Siano ID 187f:0600

2015-01-13 Thread Roberto Alcântara 
Good to know about DVB on this chip. This is sms2270 id :-)

I think you can get more  information from module debug messages.

Try
options smsusb debug=3
on /etc/modprobe.d.

Then reload it and try to tzap one of channels found by scan to look
for some lock.  You will have more debug messages now.

Cheers,
 - Roberto




 - Roberto


On Tue, Jan 13, 2015 at 12:35 PM, Francesco Other
francesco.ot...@gmail.com wrote:
 Hi Roberto, thanks for your fast reply.

 I'm from Italy, a DVB-T region. With Windows the device works fine, it
 receives all the channels from multiplexes.
 I don't know if my device has the SMS2270 chip, I know the ID,
 187f:0600, and the link on the Terratec site:
 http://www.terratec.net/details.php?artnr=145258#.VLU5Z2SG9LY

 In that site there are the software and the Windows driver, if you
 install those driver you can obtain the dvb_rio.inp driver from
 system32 folder.
 I forced the DVB-T mode because without it in dmesg output I see that
 system ask for isdbt_rio.inp, but with DVB-T forced mode the system
 ask for dvb_rio.inp.

 I can't understand why I can't receive any channels from multiplexes,
 the signal is ok, I can see this from many software (Kaffeine, w_scan,
 scan, TvHeadend).

 Can you help me please?

 Best Regards

 Francesco


 2015-01-13 16:21 GMT+01:00 Roberto Alcântara robe...@eletronica.org:
 Hi Francesco,

 You are using Siano SMS2270, am I right?

 My guess you're using ISDB-T firmware to program your ic, but are you in
 ISDB-T region? I use same firmware name here and works fine (Brazil) and it
 seems loaded ok on your log.

 I never saw an DVB firmware available to sms2270. Your tuner is working fine
 under Windows with provided software ?

 Cheers,
   - Roberto






  - Roberto

 On Tue, Jan 13, 2015 at 11:50 AM, Francesco Other
 francesco.ot...@gmail.com wrote:

 Is there a gentleman that can help me with my problem? On linuxtv.org
 they said that someone here sure will help me.

 I submitted the problem here:
 http://www.spinics.net/lists/linux-media/msg85432.html

 Regards

 Francesco
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

1080i input interface support

2013-09-18 Thread Roberto Alcântara 
Guys,

I have seeing a few devices as GoogleTv and Sony usb dongle with HDMI input.

Do you know what chipset this devices are using? We have any hdmi
input device supported for now?

best regards,

 - Roberto
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Siano - Device presence handler

2013-09-14 Thread Roberto Alcântara 
Guys,

Looking Siano driver files I can find lot of container_of macro as in
smdvb.main smsdvb_read_signal_strength :

client = container_of(fe, struct smsdvb_client_t, frontend);

But I can't find any error checking before client use.

Something like

if (!client) {
  return NODEV;
}

before client access should not be useful to avoid error condition ?

Thank you,

 - Roberto
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] smscoreapi: memory leak fix

2013-05-21 Thread Roberto Alcântara 
Ensure release_firmware is called if kmalloc fails.

Signed-off-by:Roberto Alcantara robe...@eletronica.org
diff --git a/linux/drivers/media/common/siano/smscoreapi.c
b/linux/drivers/media/common/siano/smscoreapi.c
index dbe9b4d..f65b4e3 100644
--- a/linux/drivers/media/common/siano/smscoreapi.c
+++ b/linux/drivers/media/common/siano/smscoreapi.c
@@ -1173,16 +1173,16 @@ static int
smscore_load_firmware_from_file(struct smscore_device_t *coredev,
  GFP_KERNEL | GFP_DMA);
 if (!fw_buf) {
 sms_err(failed to allocate firmware buffer);
-return -ENOMEM;
-}
-memcpy(fw_buf, fw-data, fw-size);
-fw_buf_size = fw-size;
-
-rc = (coredev-device_flags  SMS_DEVICE_FAMILY2) ?
-smscore_load_firmware_family2(coredev, fw_buf, fw_buf_size)
-: loadfirmware_handler(coredev-context, fw_buf,
-fw_buf_size);
+rc = -ENOMEM;
+} else {
+memcpy(fw_buf, fw-data, fw-size);
+fw_buf_size = fw-size;

+rc = (coredev-device_flags  SMS_DEVICE_FAMILY2) ?
+smscore_load_firmware_family2(coredev, fw_buf, fw_buf_size)
+: loadfirmware_handler(coredev-context, fw_buf,
+fw_buf_size);
+}
 kfree(fw_buf);
 release_firmware(fw);
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] smscoreapi: Make Siano firmware load more verbose

2013-05-12 Thread Roberto Alcântara 
Hi Sakari,

Ok I will review code looking for memory leaks.

Thank you for the tip.

 - Roberto


On Sun, May 12, 2013 at 4:17 AM, Sakari Ailus sakari.ai...@iki.fi wrote:
 Hi Roberto,

 On Sat, May 11, 2013 at 12:53:29PM -0300, Roberto Alcântara wrote:
 Signed-off-by: Roberto Alcantara robe...@eletronica.org

 diff --git a/drivers/media/common/siano/smscoreapi.c
 b/drivers/media/common/siano/smscoreapi.c
 index 45ac9ee..dbe9b4d 100644
 --- a/drivers/media/common/siano/smscoreapi.c
 +++ b/drivers/media/common/siano/smscoreapi.c
 @@ -1154,7 +1154,7 @@ static int
 smscore_load_firmware_from_file(struct smscore_device_t *coredev,

  char *fw_filename = smscore_get_fw_filename(coredev, mode);
  if (!fw_filename) {
 -sms_info(mode %d not supported on this device, mode);
 +sms_err(mode %d not supported on this device, mode);
  return -ENOENT;
  }
  sms_debug(Firmware name: %s, fw_filename);
 @@ -1165,14 +1165,14 @@ static int
 smscore_load_firmware_from_file(struct smscore_device_t *coredev,

  rc = request_firmware(fw, fw_filename, coredev-device);
  if (rc  0) {
 -sms_info(failed to open \%s\, fw_filename);
 +sms_err(failed to open firmware file \%s\, fw_filename);
  return rc;
  }
  sms_info(read fw %s, buffer size=0x%zx, fw_filename, fw-size);
  fw_buf = kmalloc(ALIGN(fw-size, SMS_ALLOC_ALIGNMENT),
   GFP_KERNEL | GFP_DMA);
  if (!fw_buf) {
 -sms_info(failed to allocate firmware buffer);
 +sms_err(failed to allocate firmware buffer);

 It's not really related to this patch, but I think there's a memory leak
 here: release_firmware() isn't called if kmalloc() above fails. I'd just add
 a goto and a label to the end of the function where that's being done (and
 set rc, too).

 While you're at it, could you send a patch for that, please?

  return -ENOMEM;
  }
  memcpy(fw_buf, fw-data, fw-size);

 --
 Kind regards,

 Sakari Ailus
 e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] smscoreapi: fixing memory leak

2013-05-12 Thread Roberto Alcântara 
 - Roberto


mem.patch
Description: Binary data

[PATCH] smscoreapi: Make Siano firmware load more verbose

2013-05-11 Thread Roberto Alcântara 
Signed-off-by: Roberto Alcantara robe...@eletronica.org

diff --git a/drivers/media/common/siano/smscoreapi.c
b/drivers/media/common/siano/smscoreapi.c
index 45ac9ee..dbe9b4d 100644
--- a/drivers/media/common/siano/smscoreapi.c
+++ b/drivers/media/common/siano/smscoreapi.c
@@ -1154,7 +1154,7 @@ static int
smscore_load_firmware_from_file(struct smscore_device_t *coredev,

 char *fw_filename = smscore_get_fw_filename(coredev, mode);
 if (!fw_filename) {
-sms_info(mode %d not supported on this device, mode);
+sms_err(mode %d not supported on this device, mode);
 return -ENOENT;
 }
 sms_debug(Firmware name: %s, fw_filename);
@@ -1165,14 +1165,14 @@ static int
smscore_load_firmware_from_file(struct smscore_device_t *coredev,

 rc = request_firmware(fw, fw_filename, coredev-device);
 if (rc  0) {
-sms_info(failed to open \%s\, fw_filename);
+sms_err(failed to open firmware file \%s\, fw_filename);
 return rc;
 }
 sms_info(read fw %s, buffer size=0x%zx, fw_filename, fw-size);
 fw_buf = kmalloc(ALIGN(fw-size, SMS_ALLOC_ALIGNMENT),
  GFP_KERNEL | GFP_DMA);
 if (!fw_buf) {
-sms_info(failed to allocate firmware buffer);
+sms_err(failed to allocate firmware buffer);
 return -ENOMEM;
 }
 memcpy(fw_buf, fw-data, fw-size);
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html