Re: Re: [PATCHv4 05/11] omap3isp: Use *_dec_not_zero instead of *_add_unless

[Sven Eckelmann]

On Sunday 31 July 2011 17:00:43 Laurent Pinchart wrote:
> Hi Sven,
> 
> Thanks for the patch.
> 
> On Wednesday 27 July 2011 11:47:44 Sven Eckelmann wrote:
> > atomic_dec_not_zero is defined for each architecture through
> >  to provide the functionality of
> > atomic_add_unless(x, -1, 0).
> > 
> > Signed-off-by: Sven Eckelmann 
> > Cc: Laurent Pinchart 
> 
> Acked-by: Laurent Pinchart 
> 
> I'll queue this to my tree for v3.2. Please let me know if you would rather
> push the patch through another tree.

The problem is that until now no one from linux-arch has applied the patch 
01/11 in his tree (which is needed before this patch can be applied) and you 
tree have to be based on the "yet to be chosen linux-arch tree". Otherwise 
your tree will just break and not be acceptable for a pull request. 

Maybe it is easier when one person applies 01-11 after 02-11 was Acked-by the 
responsible maintainers.

02 is more or less automatically Acked-by us :)
04, 09 and 10 are also Acked.
... and the rest is waiting for actions.

Kind regards,
Sven

signature.asc
Description: This is a digitally signed message part.

[PATCHv4 05/11] omap3isp: Use *_dec_not_zero instead of *_add_unless

[Sven Eckelmann]

atomic_dec_not_zero is defined for each architecture through
 to provide the functionality of
atomic_add_unless(x, -1, 0).

Signed-off-by: Sven Eckelmann 
Cc: Laurent Pinchart 
Cc: linux-media@vger.kernel.org
---
 drivers/media/video/omap3isp/ispstat.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/omap3isp/ispstat.c 
b/drivers/media/video/omap3isp/ispstat.c
index b44cb68..81b1ec9 100644
--- a/drivers/media/video/omap3isp/ispstat.c
+++ b/drivers/media/video/omap3isp/ispstat.c
@@ -652,7 +652,7 @@ static int isp_stat_buf_process(struct ispstat *stat, int 
buf_state)
 {
int ret = STAT_NO_BUF;
 
-   if (!atomic_add_unless(&stat->buf_err, -1, 0) &&
+   if (!atomic_dec_not_zero(&stat->buf_err) &&
buf_state == STAT_BUF_DONE && stat->state == ISPSTAT_ENABLED) {
ret = isp_stat_buf_queue(stat);
isp_stat_buf_next(stat);
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html