Re: [PATCH] [media] media: am437x-vpfe: ensure ret is initialized

[Lad, Prabhakar]

Hi Colin,

On Mon, Mar 21, 2016 at 11:32 PM, Colin King  wrote:
> From: Colin Ian King 
>
> ret should be initialized to 0; for example if pfe->fmt.fmt.pix.field
> is V4L2_FIELD_NONE then ret will contain garbage from the
> uninitialized state causing garbage to be returned if it is non-zero.
>
Thanks for the patch, patch [1] fixing this issue is already posted in ML.

[1] http://www.mail-archive.com/linux-media@vger.kernel.org/msg95562.html

Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] [media] media: am437x-vpfe: ensure ret is initialized

[Colin King]

From: Colin Ian King 

ret should be initialized to 0; for example if pfe->fmt.fmt.pix.field
is V4L2_FIELD_NONE then ret will contain garbage from the
uninitialized state causing garbage to be returned if it is non-zero.

Signed-off-by: Colin Ian King 
---
 drivers/media/platform/am437x/am437x-vpfe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/am437x/am437x-vpfe.c 
b/drivers/media/platform/am437x/am437x-vpfe.c
index de32e3a..7d14732 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.c
+++ b/drivers/media/platform/am437x/am437x-vpfe.c
@@ -1047,7 +1047,7 @@ static int vpfe_get_ccdc_image_format(struct vpfe_device 
*vpfe,
 static int vpfe_config_ccdc_image_format(struct vpfe_device *vpfe)
 {
enum ccdc_frmfmt frm_fmt = CCDC_FRMFMT_INTERLACED;
-   int ret;
+   int ret = 0;
 
vpfe_dbg(2, vpfe, "vpfe_config_ccdc_image_format\n");
 
-- 
2.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html