Re: [PATCH] [media] v4l: vb2: fix error return code in __vb2_init_fileio()

2013-05-14 Thread Marek Szyprowski 

Hello,

On 2013-05-13 07:48, Wei Yongjun wrote:

From: Wei Yongjun yongjun_...@trendmicro.com.cn

Fix to return -EINVAL in the get kernel address error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn


Acked-by: Marek Szyprowski m.szyprow...@samsung.com


---
  drivers/media/v4l2-core/videobuf2-core.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/videobuf2-core.c 
b/drivers/media/v4l2-core/videobuf2-core.c
index 7d833ee..7bd3ee6 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -2193,8 +2193,10 @@ static int __vb2_init_fileio(struct vb2_queue *q, int 
read)
 */
for (i = 0; i  q-num_buffers; i++) {
fileio-bufs[i].vaddr = vb2_plane_vaddr(q-bufs[i], 0);
-   if (fileio-bufs[i].vaddr == NULL)
+   if (fileio-bufs[i].vaddr == NULL) {
+   ret = -EINVAL;
goto err_reqbufs;
+   }
fileio-bufs[i].size = vb2_plane_size(q-bufs[i], 0);
}
  





Best regards
--
Marek Szyprowski
Samsung Poland RD Center


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] v4l: vb2: fix error return code in __vb2_init_fileio()

2013-05-13 Thread Sakari Ailus 
Hi Wei,

On Mon, May 13, 2013 at 01:48:45PM +0800, Wei Yongjun wrote:
 From: Wei Yongjun yongjun_...@trendmicro.com.cn
 
 Fix to return -EINVAL in the get kernel address error handling
 case instead of 0, as done elsewhere in this function.
 
 Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
 ---
  drivers/media/v4l2-core/videobuf2-core.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
 
 diff --git a/drivers/media/v4l2-core/videobuf2-core.c 
 b/drivers/media/v4l2-core/videobuf2-core.c
 index 7d833ee..7bd3ee6 100644
 --- a/drivers/media/v4l2-core/videobuf2-core.c
 +++ b/drivers/media/v4l2-core/videobuf2-core.c
 @@ -2193,8 +2193,10 @@ static int __vb2_init_fileio(struct vb2_queue *q, int 
 read)
*/
   for (i = 0; i  q-num_buffers; i++) {
   fileio-bufs[i].vaddr = vb2_plane_vaddr(q-bufs[i], 0);
 - if (fileio-bufs[i].vaddr == NULL)
 + if (fileio-bufs[i].vaddr == NULL) {
 + ret = -EINVAL;
   goto err_reqbufs;
 + }
   fileio-bufs[i].size = vb2_plane_size(q-bufs[i], 0);
   }
  
 

Nice patch!

Reviewed-by: Sakari Ailus sakari.ai...@iki.fi

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] [media] v4l: vb2: fix error return code in __vb2_init_fileio()

2013-05-12 Thread Wei Yongjun 
From: Wei Yongjun yongjun_...@trendmicro.com.cn

Fix to return -EINVAL in the get kernel address error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
 drivers/media/v4l2-core/videobuf2-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/videobuf2-core.c 
b/drivers/media/v4l2-core/videobuf2-core.c
index 7d833ee..7bd3ee6 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -2193,8 +2193,10 @@ static int __vb2_init_fileio(struct vb2_queue *q, int 
read)
 */
for (i = 0; i  q-num_buffers; i++) {
fileio-bufs[i].vaddr = vb2_plane_vaddr(q-bufs[i], 0);
-   if (fileio-bufs[i].vaddr == NULL)
+   if (fileio-bufs[i].vaddr == NULL) {
+   ret = -EINVAL;
goto err_reqbufs;
+   }
fileio-bufs[i].size = vb2_plane_size(q-bufs[i], 0);
}
 

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html