Re: [PATCH] CONFIG_VIDEO_DEV needs to be enabled by MEDIA_DIGITAL_TV_SUPPORT also

2015-04-08 Thread Mauro Carvalho Chehab
Em Sun, 15 Feb 2015 22:13:13 +
David Howells dhowe...@redhat.com escreveu:

 CONFIG_VIDEO_DEV needs to be enabled by MEDIA_DIGITAL_TV_SUPPORT so that DVB
 TV receiver drivers can be enabled.

Actually, no. VIDEO_DEV enables the V4L2 core, with is not needed by pure
DVB devices.

Ok, some drivers are hybrid, and there's no way to enable just the DVB part
of the driver. So, for those specific drivers, both analog and digital
support should be enabled. 

This is actually a driver issue, as the driver was written originally for
analog, and then extended to support digital, without making the analog
part optional. I fixed this on a few drivers (like em28xx). It is not that
hard to split the driver, but it requires some care and careful tests to
avoiding breaking the driver, as sometimes the register init for the
device mixes analog and digital init at the same part of the driver.

Regards,
Mauro

 
 Signed-off-by: David Howells dhowe...@redhat.com
 ---
 
  drivers/media/Kconfig |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
 index 49cd308..52d4a20 100644
 --- a/drivers/media/Kconfig
 +++ b/drivers/media/Kconfig
 @@ -102,7 +102,7 @@ config MEDIA_CONTROLLER
  config VIDEO_DEV
   tristate
   depends on MEDIA_SUPPORT
 - depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || 
 MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
 + depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || 
 MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
   default y
  
  config VIDEO_V4L2_SUBDEV_API
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] CONFIG_VIDEO_DEV needs to be enabled by MEDIA_DIGITAL_TV_SUPPORT also

2015-02-15 Thread David Howells
CONFIG_VIDEO_DEV needs to be enabled by MEDIA_DIGITAL_TV_SUPPORT so that DVB
TV receiver drivers can be enabled.

Signed-off-by: David Howells dhowe...@redhat.com
---

 drivers/media/Kconfig |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 49cd308..52d4a20 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -102,7 +102,7 @@ config MEDIA_CONTROLLER
 config VIDEO_DEV
tristate
depends on MEDIA_SUPPORT
-   depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || 
MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
+   depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || 
MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
default y
 
 config VIDEO_V4L2_SUBDEV_API

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html