Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making code match

2018-03-07 Thread Antti Palosaari

On 03/07/2018 06:39 PM, Ron Economos wrote:
I'm almost 100% sure that the patch I submitted (and was committed in 
Linux 4.16-rc1) for the si2168 fixes Nigel's issue. I would suggest that 
Nigel's patch be retired.


https://github.com/torvalds/linux/blob/master/drivers/media/dvb-frontends/si2168.c

media: [RESEND] media: dvb-frontends: Add delay to Si2168 restart

On faster CPUs a delay is required after the resume command and the 
restart command. Without the delay, the restart command often returns 
-EREMOTEIO and the Si2168 does not restart. Note that this patch fixes 
the same issue as https://patchwork.linuxtv.org/patch/44304/, but I 
believe my udelay() fix addresses the actual problem.


Signed-off-by: Ron Economos 
Signed-off-by: Mauro Carvalho Chehab 

Ron



Yes, you are likely correct!

Patch is already applied, but however I think it should be something 
like usleep_range(100, ~0) in order to allow scheduler optimize 
resources as upper limit of delay is not critical at all. See 
Documentation/timers/timers-howto.txt



regards
Antti


--
http://palosaari.fi/


Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making code match

2018-03-07 Thread Ron Economos
I'm almost 100% sure that the patch I submitted (and was committed in 
Linux 4.16-rc1) for the si2168 fixes Nigel's issue. I would suggest that 
Nigel's patch be retired.


https://github.com/torvalds/linux/blob/master/drivers/media/dvb-frontends/si2168.c

media: [RESEND] media: dvb-frontends: Add delay to Si2168 restart

On faster CPUs a delay is required after the resume command and the 
restart command. Without the delay, the restart command often returns 
-EREMOTEIO and the Si2168 does not restart. Note that this patch fixes 
the same issue as https://patchwork.linuxtv.org/patch/44304/, but I 
believe my udelay() fix addresses the actual problem.


Signed-off-by: Ron Economos 
Signed-off-by: Mauro Carvalho Chehab 

Ron