Re: [PATCH] cxd2820r_c: Fix if_ctl calculation
CrazyCat, Could you fix your mailer? Or tell me the command I can import that patch to my local git tree for testing? git send-email is at least know to break patches. I will manually applying that patch and testing, but.. $ wget --no-check-certificate -O - https://patchwork.linuxtv.org/patch/20560/mbox/ | git am -s --2013-11-03 19:15:11-- https://patchwork.linuxtv.org/patch/20560/mbox/ Resolving patchwork.linuxtv.org (patchwork.linuxtv.org)... 130.149.80.248 Connecting to patchwork.linuxtv.org (patchwork.linuxtv.org)|130.149.80.248|:443... connected. WARNING: cannot verify patchwork.linuxtv.org's certificate, issued by ‘/C=XX/ST=There is no such thing outside US/L=Everywhere/O=OCOSA/OU=Office for Complication of Otherwise Simple Affairs/CN=www.linuxtv.org/emailAddress=r...@www.linuxtv.org’: Self-signed certificate encountered. WARNING: certificate common name ‘www.linuxtv.org’ doesn't match requested host name ‘patchwork.linuxtv.org’. HTTP request sent, awaiting response... 200 OK Length: unspecified [text/plain] Saving to: ‘STDOUT’ [ = ] 1 199 --.-K/s in 0s 2013-11-03 19:15:11 (9,34 MB/s) - written to stdout [1199] Applying: cxd2820r_c: Fix if_ctl calculation error: patch failed: drivers/media/dvb-frontends/cxd2820r_c.c:78 error: drivers/media/dvb-frontends/cxd2820r_c.c: patch does not apply Patch failed at 0001 cxd2820r_c: Fix if_ctl calculation The copy of the patch that failed is found in: /home/crope/linuxtv/code/linux/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. regards Antti On 02.11.2013 23:04, CrazyCat wrote: Fix tune for DVB-C. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c b/drivers/media/dvb-frontends/cxd2820r_c.c index 125a440..5c6ab49 100644 --- a/drivers/media/dvb-frontends/cxd2820r_c.c +++ b/drivers/media/dvb-frontends/cxd2820r_c.c @@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe) num = if_freq / 1000; /* Hz = kHz */ num *= 0x4000; -if_ctl = cxd2820r_div_u64_round_closest(num, 41000); +if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000); buf[0] = (if_ctl 8) 0x3f; buf[1] = (if_ctl 0) 0xff; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cxd2820r_c: Fix if_ctl calculation
On 03.11.2013 19:18, Antti Palosaari wrote: CrazyCat, Could you fix your mailer? Or tell me the command I can import that patch to my local git tree for testing? git send-email is at least know to break patches. *not* to break patches! I will manually applying that patch and testing, but.. error: drivers/media/dvb-frontends/cxd2820r_c.c: patch does not apply I tested it, by manually copy pasting that single line. I didn't noticed any change to existing behavior, but I have no reason to suspect patch is wrong. I am not going to apply that via my tree as patch fails. It is up to subsystem maintainers to pick it up. Acked-by: Antti Palosaari cr...@iki.fi Reviewed-by: Antti Palosaari cr...@iki.fi Tested-by: Antti Palosaari cr...@iki.fi regards Antti On 02.11.2013 23:04, CrazyCat wrote: Fix tune for DVB-C. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c b/drivers/media/dvb-frontends/cxd2820r_c.c index 125a440..5c6ab49 100644 --- a/drivers/media/dvb-frontends/cxd2820r_c.c +++ b/drivers/media/dvb-frontends/cxd2820r_c.c @@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe) num = if_freq / 1000; /* Hz = kHz */ num *= 0x4000; -if_ctl = cxd2820r_div_u64_round_closest(num, 41000); +if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000); buf[0] = (if_ctl 8) 0x3f; buf[1] = (if_ctl 0) 0xff; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cxd2820r_c: Fix if_ctl calculation
Fix tune for DVB-C. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c b/drivers/media/dvb-frontends/cxd2820r_c.c index 125a440..5c6ab49 100644 --- a/drivers/media/dvb-frontends/cxd2820r_c.c +++ b/drivers/media/dvb-frontends/cxd2820r_c.c @@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe) num = if_freq / 1000; /* Hz = kHz */ num *= 0x4000; - if_ctl = cxd2820r_div_u64_round_closest(num, 41000); + if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000); buf[0] = (if_ctl 8) 0x3f; buf[1] = (if_ctl 0) 0xff; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cxd2820r_c: Fix if_ctl calculation
Fix tune for DVB-C. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net mailto:evgenyple...@ukr.net diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c b/drivers/media/dvb-frontends/cxd2820r_c.c index 125a440..5c6ab49 100644 --- a/drivers/media/dvb-frontends/cxd2820r_c.c +++ b/drivers/media/dvb-frontends/cxd2820r_c.c @@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe) num = if_freq / 1000; /* Hz = kHz */ num *= 0x4000; -if_ctl = cxd2820r_div_u64_round_closest(num, 41000); +if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000); buf[0] = (if_ctl 8) 0x3f; buf[1] = (if_ctl 0) 0xff; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cxd2820r_c: Fix if_ctl calculation
Hello Patch itself looks quite correct, but I would like to test it still and also that tuner patch. But the problem is that your patches are broken. Could you fix your settings and resend? $ wget --no-check-certificate -O - https://patchwork.linuxtv.org/patch/20513/mbox/ | git am -s --2013-11-01 22:00:18-- https://patchwork.linuxtv.org/patch/20513/mbox/ Resolving patchwork.linuxtv.org (patchwork.linuxtv.org)... 130.149.80.248 Connecting to patchwork.linuxtv.org (patchwork.linuxtv.org)|130.149.80.248|:443... connected. WARNING: cannot verify patchwork.linuxtv.org's certificate, issued by ‘/C=XX/ST=There is no such thing outside US/L=Everywhere/O=OCOSA/OU=Office for Complication of Otherwise Simple Affairs/CN=www.linuxtv.org/emailAddress=r...@www.linuxtv.org’: Self-signed certificate encountered. WARNING: certificate common name ‘www.linuxtv.org’ doesn't match requested host name ‘patchwork.linuxtv.org’. HTTP request sent, awaiting response... 200 OK Length: unspecified [text/plain] Saving to: ‘STDOUT’ [ = ] 1 213 --.-K/s in 0s 2013-11-01 22:00:18 (9,00 MB/s) - written to stdout [1213] Applying: cxd2820r_c: Fix if_ctl calculation fatal: corrupt patch at line 8 Patch failed at 0001 cxd2820r_c: Fix if_ctl calculation The copy of the patch that failed is found in: /home/crope/linuxtv/code/linux/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. [crope@localhost linux]$ regards Antti On 01.11.2013 21:27, CrazyCat wrote: Fix tune for DVB-C. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net mailto:evgenyple...@ukr.net diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c b/drivers/media/dvb-frontends/cxd2820r_c.c index 125a440..5c6ab49 100644 --- a/drivers/media/dvb-frontends/cxd2820r_c.c +++ b/drivers/media/dvb-frontends/cxd2820r_c.c @@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe) num = if_freq / 1000; /* Hz = kHz */ num *= 0x4000; -if_ctl = cxd2820r_div_u64_round_closest(num, 41000); +if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000); buf[0] = (if_ctl 8) 0x3f; buf[1] = (if_ctl 0) 0xff; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cxd2820r_c: Fix if_ctl calculation
Fix tune for DVB-C. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c b/drivers/media/dvb-frontends/cxd2820r_c.c index 125a440..5c6ab49 100644 --- a/drivers/media/dvb-frontends/cxd2820r_c.c +++ b/drivers/media/dvb-frontends/cxd2820r_c.c @@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe) num = if_freq / 1000; /* Hz = kHz */ num *= 0x4000; -if_ctl = cxd2820r_div_u64_round_closest(num, 41000); +if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000); buf[0] = (if_ctl 8) 0x3f; buf[1] = (if_ctl 0) 0xff; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cxd2820r_c: Fix if_ctl calculation
$ wget --no-check-certificate -O - https://patchwork.linuxtv.org/patch/20516/mbox/ | git am -s --2013-11-01 22:10:30-- https://patchwork.linuxtv.org/patch/20516/mbox/ Resolving patchwork.linuxtv.org (patchwork.linuxtv.org)... 130.149.80.248 Connecting to patchwork.linuxtv.org (patchwork.linuxtv.org)|130.149.80.248|:443... connected. WARNING: cannot verify patchwork.linuxtv.org's certificate, issued by ‘/C=XX/ST=There is no such thing outside US/L=Everywhere/O=OCOSA/OU=Office for Complication of Otherwise Simple Affairs/CN=www.linuxtv.org/emailAddress=r...@www.linuxtv.org’: Self-signed certificate encountered. WARNING: certificate common name ‘www.linuxtv.org’ doesn't match requested host name ‘patchwork.linuxtv.org’. HTTP request sent, awaiting response... 200 OK Length: unspecified [text/plain] Saving to: ‘STDOUT’ [ = ] 1 218 --.-K/s in 0s 2013-11-01 22:10:30 (8,89 MB/s) - written to stdout [1218] Applying: cxd2820r_c: Fix if_ctl calculation error: patch failed: drivers/media/dvb-frontends/cxd2820r_c.c:78 error: drivers/media/dvb-frontends/cxd2820r_c.c: patch does not apply Patch failed at 0001 cxd2820r_c: Fix if_ctl calculation The copy of the patch that failed is found in: /home/crope/linuxtv/code/linux/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. On 01.11.2013 22:06, CrazyCat wrote: Fix tune for DVB-C. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c b/drivers/media/dvb-frontends/cxd2820r_c.c index 125a440..5c6ab49 100644 --- a/drivers/media/dvb-frontends/cxd2820r_c.c +++ b/drivers/media/dvb-frontends/cxd2820r_c.c @@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe) num = if_freq / 1000; /* Hz = kHz */ num *= 0x4000; -if_ctl = cxd2820r_div_u64_round_closest(num, 41000); +if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000); buf[0] = (if_ctl 8) 0x3f; buf[1] = (if_ctl 0) 0xff; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
