[PATCH] lg2160: fix off-by-one error in lg216x_write_regs

[Michael Krufky]

Fix an off-by-one error in lg216x_write_regs, causing the last element
of the lg216x init block to be ignored.  Spotted by Dan Carpenteter.

Thanks-to: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Michael Krufky mkru...@linuxtv.org
---
 drivers/media/dvb/frontends/lg2160.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb/frontends/lg2160.c 
b/drivers/media/dvb/frontends/lg2160.c
index a3ab1a5..cc11260 100644
--- a/drivers/media/dvb/frontends/lg2160.c
+++ b/drivers/media/dvb/frontends/lg2160.c
@@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state,
 
lg_reg(writing %d registers...\n, len);
 
-   for (i = 0; i  len - 1; i++) {
+   for (i = 0; i  len; i++) {
ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
if (lg_fail(ret))
return ret;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] lg2160: fix off-by-one error in lg216x_write_regs

[Michael Krufky]

eeek!  spelling error in dan's name!  my apologies.  I will correct
this in my tree before I ask Mauro to merge it.

-Mike

On Mon, May 21, 2012 at 11:34 AM, Michael Krufky mkru...@kernellabs.com wrote:
 Fix an off-by-one error in lg216x_write_regs, causing the last element
 of the lg216x init block to be ignored.  Spotted by Dan Carpenteter.

 Thanks-to: Dan Carpenter dan.carpen...@oracle.com
 Signed-off-by: Michael Krufky mkru...@linuxtv.org
 ---
  drivers/media/dvb/frontends/lg2160.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/drivers/media/dvb/frontends/lg2160.c 
 b/drivers/media/dvb/frontends/lg2160.c
 index a3ab1a5..cc11260 100644
 --- a/drivers/media/dvb/frontends/lg2160.c
 +++ b/drivers/media/dvb/frontends/lg2160.c
 @@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state,

        lg_reg(writing %d registers...\n, len);

 -       for (i = 0; i  len - 1; i++) {
 +       for (i = 0; i  len; i++) {
                ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
                if (lg_fail(ret))
                        return ret;
 --
 1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] lg2160: fix off-by-one error in lg216x_write_regs

[Dan Carpenter]

On Mon, May 21, 2012 at 11:58:06AM -0400, Michael Krufky wrote:
 eeek!  spelling error in dan's name!  my apologies.  I will correct
 this in my tree before I ask Mauro to merge it.
 

Hehe.  Also since you're redoing it, could you change the Thanks-to:
to Reported-by:?

regards,
dan carpenter

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] lg2160: fix off-by-one error in lg216x_write_regs

[Michael Krufky]

Fix an off-by-one error in lg216x_write_regs, causing the last element
of the lg216x init block to be ignored.  Spotted by Dan Carpenter.

Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Michael Krufky mkru...@linuxtv.org
---
 drivers/media/dvb/frontends/lg2160.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb/frontends/lg2160.c 
b/drivers/media/dvb/frontends/lg2160.c
index a3ab1a5..cc11260 100644
--- a/drivers/media/dvb/frontends/lg2160.c
+++ b/drivers/media/dvb/frontends/lg2160.c
@@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state,
 
lg_reg(writing %d registers...\n, len);
 
-   for (i = 0; i  len - 1; i++) {
+   for (i = 0; i  len; i++) {
ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
if (lg_fail(ret))
return ret;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html