Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions

2018-10-13 Thread Sakari Ailus 
On Fri, Oct 12, 2018 at 07:00:44PM +, Mani, Rajmohan wrote:
> Hi Bingbu, Kieren,
> 
> > Subject: Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
> > 
> > 
> > 
> > On 10/11/2018 05:33 PM, Kieran Bingham wrote:
> > > Hi Rajmohan
> > >
> > > Thank you for the patch,
> > >
> > > On 10/10/18 00:42, Rajmohan Mani wrote:
> > >> Removed redundant CIO2_IMAGE_MAX_* definitions
> > >>
> > >> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2
> > >> driver")
> > >>
> > >> Signed-off-by: Rajmohan Mani 
> > > Reviewed-by: Kieran Bingham
> > 
> > >
> > > Looks like this {sh,c}ould be bundled in with  "[PATCH 0/2] Trivial
> > > CIO2 patches" from Sakari at integration.
> > Raj and Sakari, I think this change could be bundled into the Trivial patch 
> > sets,
> > what do you think?
> > >
> 
> Sounds good to me.
> I will leave this up to Sakari.

Yes, these are all in my branch for 4.21.

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi

RE: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions

2018-10-12 Thread Mani, Rajmohan 
Hi Bingbu, Kieren,

> Subject: Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
> 
> 
> 
> On 10/11/2018 05:33 PM, Kieran Bingham wrote:
> > Hi Rajmohan
> >
> > Thank you for the patch,
> >
> > On 10/10/18 00:42, Rajmohan Mani wrote:
> >> Removed redundant CIO2_IMAGE_MAX_* definitions
> >>
> >> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2
> >> driver")
> >>
> >> Signed-off-by: Rajmohan Mani 
> > Reviewed-by: Kieran Bingham
> 
> >
> > Looks like this {sh,c}ould be bundled in with  "[PATCH 0/2] Trivial
> > CIO2 patches" from Sakari at integration.
> Raj and Sakari, I think this change could be bundled into the Trivial patch 
> sets,
> what do you think?
> >

Sounds good to me.
I will leave this up to Sakari.

Thanks
Raj

Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions

2018-10-11 Thread Bing Bu Cao 



On 10/11/2018 05:33 PM, Kieran Bingham wrote:
> Hi Rajmohan
>
> Thank you for the patch,
>
> On 10/10/18 00:42, Rajmohan Mani wrote:
>> Removed redundant CIO2_IMAGE_MAX_* definitions
>>
>> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
>>
>> Signed-off-by: Rajmohan Mani 
> Reviewed-by: Kieran Bingham 
>
> Looks like this {sh,c}ould be bundled in with
>  "[PATCH 0/2] Trivial CIO2 patches" from Sakari at integration.
Raj and Sakari, I think this change could be bundled into the Trivial
patch sets, what do you think?
>
> --
> Regards
>
> Kieran Bingham
>
>> ---
>>  drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h 
>> b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> index 240635be7a31..7caab9b8c2b9 100644
>> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> @@ -10,8 +10,6 @@
>>  #define CIO2_PCI_ID 0x9d32
>>  #define CIO2_PCI_BAR0
>>  #define CIO2_DMA_MASK   DMA_BIT_MASK(39)
>> -#define CIO2_IMAGE_MAX_WIDTH4224
>> -#define CIO2_IMAGE_MAX_LENGTH   3136
>>  
>>  #define CIO2_IMAGE_MAX_WIDTH4224
>>  #define CIO2_IMAGE_MAX_LENGTH   3136
>>
>

Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions

2018-10-11 Thread Kieran Bingham 
Hi Rajmohan

Thank you for the patch,

On 10/10/18 00:42, Rajmohan Mani wrote:
> Removed redundant CIO2_IMAGE_MAX_* definitions
> 
> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
> 
> Signed-off-by: Rajmohan Mani 

Reviewed-by: Kieran Bingham 

Looks like this {sh,c}ould be bundled in with
 "[PATCH 0/2] Trivial CIO2 patches" from Sakari at integration.

--
Regards

Kieran Bingham

> ---
>  drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h 
> b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> index 240635be7a31..7caab9b8c2b9 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> @@ -10,8 +10,6 @@
>  #define CIO2_PCI_ID  0x9d32
>  #define CIO2_PCI_BAR 0
>  #define CIO2_DMA_MASKDMA_BIT_MASK(39)
> -#define CIO2_IMAGE_MAX_WIDTH 4224
> -#define CIO2_IMAGE_MAX_LENGTH3136
>  
>  #define CIO2_IMAGE_MAX_WIDTH 4224
>  #define CIO2_IMAGE_MAX_LENGTH3136
>

[PATCH] media: intel-ipu3: cio2: Remove redundant definitions

2018-10-09 Thread Rajmohan Mani 
Removed redundant CIO2_IMAGE_MAX_* definitions

Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")

Signed-off-by: Rajmohan Mani 
---
 drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h 
b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
index 240635be7a31..7caab9b8c2b9 100644
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
@@ -10,8 +10,6 @@
 #define CIO2_PCI_ID0x9d32
 #define CIO2_PCI_BAR   0
 #define CIO2_DMA_MASK  DMA_BIT_MASK(39)
-#define CIO2_IMAGE_MAX_WIDTH   4224
-#define CIO2_IMAGE_MAX_LENGTH  3136
 
 #define CIO2_IMAGE_MAX_WIDTH   4224
 #define CIO2_IMAGE_MAX_LENGTH  3136
-- 
2.19.1