Re: [PATCH] media: omap3isp: fix format string warning

2011-05-30 Thread Laurent Pinchart 
Hi Ohad,

On Sunday 29 May 2011 09:04:51 Ohad Ben-Cohen wrote:
 Trivially fix this:
 
 drivers/media/video/omap3isp/isp.c: In function 'isp_isr_dbg':
 drivers/media/video/omap3isp/isp.c:394: warning: zero-length gnu_printf
 format string

Thanks for the patch, but I've already applied something similar to my tree. 
Sorry :-)

 Signed-off-by: Ohad Ben-Cohen o...@wizery.com
 ---
  drivers/media/video/omap3isp/isp.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/media/video/omap3isp/isp.c
 b/drivers/media/video/omap3isp/isp.c index 472a693..a0d5e69 100644
 --- a/drivers/media/video/omap3isp/isp.c
 +++ b/drivers/media/video/omap3isp/isp.c
 @@ -391,7 +391,7 @@ static inline void isp_isr_dbg(struct isp_device *isp,
 u32 irqstatus) };
   int i;
 
 - dev_dbg(isp-dev, );
 + dev_dbg(isp-dev, %s\n, __func__);
 
   for (i = 0; i  ARRAY_SIZE(name); i++) {
   if ((1  i)  irqstatus)

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] media: omap3isp: fix format string warning

2011-05-30 Thread Ohad Ben-Cohen 
On Mon, May 30, 2011 at 5:57 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
 Thanks for the patch, but I've already applied something similar to my tree.
 Sorry :-)

np, thanks. I'm just playing with omap3isp a bit and wanted to get rid
of that hey what did I do wrong this time feeling every time I
recompiled it :)
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] media: omap3isp: fix format string warning

2011-05-29 Thread Ohad Ben-Cohen 
Trivially fix this:

drivers/media/video/omap3isp/isp.c: In function 'isp_isr_dbg':
drivers/media/video/omap3isp/isp.c:394: warning: zero-length gnu_printf format 
string

Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
 drivers/media/video/omap3isp/isp.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/omap3isp/isp.c 
b/drivers/media/video/omap3isp/isp.c
index 472a693..a0d5e69 100644
--- a/drivers/media/video/omap3isp/isp.c
+++ b/drivers/media/video/omap3isp/isp.c
@@ -391,7 +391,7 @@ static inline void isp_isr_dbg(struct isp_device *isp, u32 
irqstatus)
};
int i;
 
-   dev_dbg(isp-dev, );
+   dev_dbg(isp-dev, %s\n, __func__);
 
for (i = 0; i  ARRAY_SIZE(name); i++) {
if ((1  i)  irqstatus)
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html