Re: [PATCH] media: staging: atomisp: sh_css_calloc shall return a pointer to the allocated space

2017-08-08 Thread Sakari Ailus 
On Wed, Aug 02, 2017 at 01:11:06AM -0700, Joe Perches wrote:
> On Wed, 2017-08-02 at 18:00 +1000, Sergei A. Trusov wrote:
> > The calloc function returns either a null pointer or a pointer to the
> > allocated space. Add the second case that is missed.
> 
> gads.
> 
> Bug added by commit da22013f7df4 ("atomisp: remove indirection from
> sh_css_malloc")
> 
> These wrappers should really be deleted.

Applied, with the appropriate Fixes: header.

Thanks!

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

[PATCH] media: staging: atomisp: sh_css_calloc shall return a pointer to the allocated space

2017-08-02 Thread Sergei A. Trusov 
The calloc function returns either a null pointer or a pointer to the
allocated space. Add the second case that is missed.

Signed-off-by: Sergei A. Trusov 
---
 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c 
b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
index 471f2be974e2..e882b5596813 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
@@ -1939,6 +1939,7 @@ void *sh_css_calloc(size_t N, size_t size)
p = sh_css_malloc(N*size);
if (p)
memset(p, 0, size);
+   return p;
}
return NULL;
 }

Re: [PATCH] media: staging: atomisp: sh_css_calloc shall return a pointer to the allocated space

2017-08-02 Thread Joe Perches 
On Wed, 2017-08-02 at 18:00 +1000, Sergei A. Trusov wrote:
> The calloc function returns either a null pointer or a pointer to the
> allocated space. Add the second case that is missed.

gads.

Bug added by commit da22013f7df4 ("atomisp: remove indirection from
sh_css_malloc")

These wrappers should really be deleted.