Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
On Wed, Mar 01, 2017 at 10:58:59PM +0100, Daniel Glöckner wrote: On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote: drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu May I ask which repository this patch is based on? The email is replying to this one, which shows Greg's staging tree. Date: Wed, 1 Mar 2017 18:30:16 +0800 From: kbuild test robot To: Alan Cox Cc: de...@driverdev.osuosl.org, Greg Kroah-Hartman , kbuild-...@01.org Subject: [kbuild-all] [staging:staging-testing 209/209] drivers/staging/media/atomisp/i2c/gc2235.c:37:41: fatal error: linux/atomisp_gmin_platform.h: No such file or directory tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 628b2b91d50c74e2475a11a0db5978d9a36d2026 commit: 628b2b91d50c74e2475a11a0db5978d9a36d2026 [209/209] staging/atomisp: Add support for the Intel IPU v2 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 628b2b91d50c74e2475a11a0db5978d9a36d2026 # save the attached .config to linux build tree make ARCH=i386 Does Intel finally attempt to upstream the atomisp driver? It looks so. Thanks, Fengguang
Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
On Wed, 2017-03-01 at 22:58 +0100, Daniel Glöckner wrote: > On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote: > > > > drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to > > set .owner here. The core will do it. > > > > Remove .owner field if calls are used which set it automatically > > > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > > > CC: Alan Cox> > Signed-off-by: Fengguang Wu > > > May I ask which repository this patch is based on? It's a major clean up from internal code. For various reasons the previous history of the code can't be exposed (the internal repository we have contains code that can't go out of Intel for example). > Does Intel finally attempt to upstream the atomisp driver? That's the goal for the ISP 2 driver (Baytrail/T and later Cherrytrail). I can't speak for longer term plans with ISP 3 and later devices which currently don't have upstream drivers. There are some bits of support in ISP2 for some of the odder phone platforms as well but I don't have a way to test them or think anyone cares so plan to drop those. Alan
Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote: > drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner > here. The core will do it. > > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > CC: Alan Cox> Signed-off-by: Fengguang Wu May I ask which repository this patch is based on? Does Intel finally attempt to upstream the atomisp driver? Best regards, Daniel
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/gc0310.c:1470:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- gc0310.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/gc0310.c +++ b/drivers/staging/media/atomisp/i2c/gc0310.c @@ -1467,7 +1467,6 @@ MODULE_DEVICE_TABLE(acpi, gc0310_acpi_ma MODULE_DEVICE_TABLE(i2c, gc0310_id); static struct i2c_driver gc0310_driver = { .driver = { - .owner = THIS_MODULE, .name = GC0310_NAME, .acpi_match_table = ACPI_PTR(gc0310_acpi_match), },
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/imx/../ov8858.c:2199:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- ov8858.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/imx/../ov8858.c +++ b/drivers/staging/media/atomisp/i2c/imx/../ov8858.c @@ -2196,7 +2196,6 @@ static struct acpi_device_id ov8858_acpi static struct i2c_driver ov8858_driver = { .driver = { - .owner = THIS_MODULE, .name = OV8858_NAME, .acpi_match_table = ACPI_PTR(ov8858_acpi_match), },
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c:248:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- vlv2_plat_clock.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c +++ b/drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c @@ -245,7 +245,6 @@ static struct platform_driver vlv2_plat_ .driver = { .name = "vlv2_plat_clk", .pm = _pm_ops, - .owner = THIS_MODULE, }, };
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/ov2680.c:1535:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- ov2680.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/ov2680.c +++ b/drivers/staging/media/atomisp/i2c/ov2680.c @@ -1532,7 +1532,6 @@ MODULE_DEVICE_TABLE(acpi, ov2680_acpi_ma MODULE_DEVICE_TABLE(i2c, ov2680_id); static struct i2c_driver ov2680_driver = { .driver = { - .owner = THIS_MODULE, .name = OV2680_NAME, .acpi_match_table = ACPI_PTR(ov2680_acpi_match),
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/gc2235.c:1208:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- gc2235.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/gc2235.c +++ b/drivers/staging/media/atomisp/i2c/gc2235.c @@ -1205,7 +1205,6 @@ MODULE_DEVICE_TABLE(acpi, gc2235_acpi_ma MODULE_DEVICE_TABLE(i2c, gc2235_id); static struct i2c_driver gc2235_driver = { .driver = { - .owner = THIS_MODULE, .name = GC2235_NAME, .acpi_match_table = ACPI_PTR(gc2235_acpi_match), },
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/ov2722.c:1352:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- ov2722.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/ov2722.c +++ b/drivers/staging/media/atomisp/i2c/ov2722.c @@ -1349,7 +1349,6 @@ MODULE_DEVICE_TABLE(acpi, ov2722_acpi_ma static struct i2c_driver ov2722_driver = { .driver = { - .owner = THIS_MODULE, .name = OV2722_NAME, .acpi_match_table = ACPI_PTR(ov2722_acpi_match), },
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/mt9m114.c:1946:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- mt9m114.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/mt9m114.c @@ -1943,7 +1943,6 @@ MODULE_DEVICE_TABLE(acpi, mt9m114_acpi_m static struct i2c_driver mt9m114_driver = { .driver = { - .owner = THIS_MODULE, .name = "mt9m114", .acpi_match_table = ACPI_PTR(mt9m114_acpi_match), },
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/lm3554.c:986:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- lm3554.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/lm3554.c +++ b/drivers/staging/media/atomisp/i2c/lm3554.c @@ -983,7 +983,6 @@ MODULE_DEVICE_TABLE(acpi, lm3554_acpi_ma static struct i2c_driver lm3554_driver = { .driver = { - .owner = THIS_MODULE, .name = LM3554_NAME, .pm = _pm_ops, .acpi_match_table = ACPI_PTR(lm3554_acpi_match),
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/ap1302.c:1250:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- ap1302.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/ap1302.c +++ b/drivers/staging/media/atomisp/i2c/ap1302.c @@ -1247,7 +1247,6 @@ MODULE_DEVICE_TABLE(i2c, ap1302_id); static struct i2c_driver ap1302_driver = { .driver = { - .owner = THIS_MODULE, .name = AP1302_NAME, }, .probe = ap1302_probe,
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/ov5693/ov5693.c:2066:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- ov5693.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c +++ b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c @@ -2063,7 +2063,6 @@ MODULE_DEVICE_TABLE(acpi, ov5693_acpi_ma static struct i2c_driver ov5693_driver = { .driver = { - .owner = THIS_MODULE, .name = OV5693_NAME, .acpi_match_table = ACPI_PTR(ov5693_acpi_match), },
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings
drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan CoxSigned-off-by: Fengguang Wu --- imx.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/atomisp/i2c/imx/imx.c +++ b/drivers/staging/media/atomisp/i2c/imx/imx.c @@ -2483,7 +2483,6 @@ MODULE_DEVICE_TABLE(i2c, imx_ids); static struct i2c_driver imx_driver = { .driver = { - .owner = THIS_MODULE, .name = IMX_DRIVER, }, .probe = imx_probe,