Re: [PATCH 0/2] staging: atomisp: activate ATOMISP2401 support

2017-09-11 Thread Alan Cox 
On Mon, 11 Sep 2017 20:49:27 +0200
Vincent Hervieux  wrote:

> Currently atomisp module supports Intel's Baytrail SoC and contains
> some compilation switches to support Intel's Cherrytrail SoC instead.
> The patchset aims to :
> - 1/2: activate ATOMISP2400 or ATOMISP2401 from the menu.
> - 2/2: fix compilation errors for ATOMISP2401.
> I'm not so confident with patch 2/2, as it is only working around the non 
> declared functions by using the 2400 path. As I couln't find any 
> declaration/definition for the ISP2401 missing functions...So any help would 
> be appreciated.
> Also patch 2/2 doesn't correct any cosmetic changes reported by checkpatch.pl 
> as explained in TODO step 6.

Please don't. Right now we know what work is to be done and tested.

Alan

[PATCH 0/2] staging: atomisp: activate ATOMISP2401 support

2017-09-11 Thread Vincent Hervieux 
Currently atomisp module supports Intel's Baytrail SoC and contains
some compilation switches to support Intel's Cherrytrail SoC instead.
The patchset aims to :
- 1/2: activate ATOMISP2400 or ATOMISP2401 from the menu.
- 2/2: fix compilation errors for ATOMISP2401.
I'm not so confident with patch 2/2, as it is only working around the non 
declared functions by using the 2400 path. As I couln't find any 
declaration/definition for the ISP2401 missing functions...So any help would be 
appreciated.
Also patch 2/2 doesn't correct any cosmetic changes reported by checkpatch.pl 
as explained in TODO step 6.

Vincent Hervieux (2):
  staging: atomisp: add menu entries to choose between ATOMISP_2400 and
ATOMISP_2401.
  staging: atomisp: fix compilation errors in case of ISP2401.

 drivers/staging/media/atomisp/pci/Kconfig  | 23 +
 .../staging/media/atomisp/pci/atomisp2/Makefile| 10 -
 .../media/atomisp/pci/atomisp2/atomisp_cmd.c   |  5 ++---
 .../media/atomisp/pci/atomisp2/atomisp_v4l2.c  |  6 +-
 .../pci/atomisp2/css2400/ia_css_acc_types.h|  1 +
 .../css2400/runtime/debug/src/ia_css_debug.c   |  3 ---
 .../media/atomisp/pci/atomisp2/css2400/sh_css.c| 24 ++
 .../atomisp/pci/atomisp2/css2400/sh_css_params.c   |  8 +---
 8 files changed, 52 insertions(+), 28 deletions(-)

-- 
2.11.0