Re: [PATCH 0/3] Remaining patches in my queue for IR
On Wed, 2010-10-20 at 14:40 -0400, Jarod Wilson wrote: On Sun, Oct 17, 2010 at 12:56:27AM +0200, Maxim Levitsky wrote: Hi, This series is rebased on top of media_tree/staging/v2.6.37 only. Really this time, sorry for cheating, last time :-) The first patch like we agreed extends the raw packets. It touches all drivers (except imon as it isn't a raw IR driver). Code is compile tested with all drivers, and run tested with ENE and all receiver protocols (except the streamzap rc5 flavour) Since it also moves timeouts to lirc bridge, at least streazap driver should have its timeout gap support removed. I am afraid to break the code if I do so. I've tested both mceusb and streamzap with this patchset included, don't see any ill side-effects. Only issue I really saw was that the raw event init call was added somewhat superfluously to a number of drivers -- the rawir struct its initializing was already kzalloc'd, so we're just needlessly re-zero'ing it out again. Its not bad for clarity's sake, but does add some unnecessary inefficiency. Yes, I somewhat agree. On the other hand, I had an idea to add a magic field to ir_raw_event to guard against uninitialized uses. (something like the struct scatterlist). Don't know it that is worth it. Or that I sound like a typical supporter of OOP style of abstracting everything because sometime at the future there will be need to change it.. Anyway, as Andy pointed, note that few drivers became broken due to that patch because these don't initialize the ir_raw_event. I will send a patch tomorrow (I was very busy this week). Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Remaining patches in my queue for IR
On Sun, Oct 17, 2010 at 12:56:27AM +0200, Maxim Levitsky wrote: Hi, This series is rebased on top of media_tree/staging/v2.6.37 only. Really this time, sorry for cheating, last time :-) The first patch like we agreed extends the raw packets. It touches all drivers (except imon as it isn't a raw IR driver). Code is compile tested with all drivers, and run tested with ENE and all receiver protocols (except the streamzap rc5 flavour) Since it also moves timeouts to lirc bridge, at least streazap driver should have its timeout gap support removed. I am afraid to break the code if I do so. I've tested both mceusb and streamzap with this patchset included, don't see any ill side-effects. Only issue I really saw was that the raw event init call was added somewhat superfluously to a number of drivers -- the rawir struct its initializing was already kzalloc'd, so we're just needlessly re-zero'ing it out again. Its not bad for clarity's sake, but does add some unnecessary inefficiency. -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Remaining patches in my queue for IR
On Sun, Oct 17, 2010 at 12:56:27AM +0200, Maxim Levitsky wrote: This series is rebased on top of media_tree/staging/v2.6.37 only. Really this time, sorry for cheating, last time :-) On a related note, Mauro - is the plan still that I should wait for the large scancodes support for the input subsystem to land (somewhere around 2.6.37-rc1 supposedly) and then resend my patchset based on the media_tree/staging/v2.6.37 tree at that point? -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] Remaining patches in my queue for IR
Hi, This series is rebased on top of media_tree/staging/v2.6.37 only. Really this time, sorry for cheating, last time :-) The first patch like we agreed extends the raw packets. It touches all drivers (except imon as it isn't a raw IR driver). Code is compile tested with all drivers, and run tested with ENE and all receiver protocols (except the streamzap rc5 flavour) Since it also moves timeouts to lirc bridge, at least streazap driver should have its timeout gap support removed. I am afraid to break the code if I do so. Other 2 patches are ENE specific, and don't touch anything else. Please test other drivers. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Remaining patches in my queue for IR
On Sun, 2010-10-17 at 00:56 +0200, Maxim Levitsky wrote: Hi, This series is rebased on top of media_tree/staging/v2.6.37 only. Really this time, sorry for cheating, last time :-) The first patch like we agreed extends the raw packets. It touches all drivers (except imon as it isn't a raw IR driver). Will IR for the CX23885 and CX23888 still work given the changes? Here's the relevant files that use struct ir_raw_event: http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23885-input.c;h=bb61870b8d6ed39d25c11aa676b55bd0a94dc235;hb=staging/v2.6.37 http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx25840/cx25840-ir.c;h=c2b4c14dc9ab533ff524b3e301235d6bdc92e2b9;hb=staging/v2.6.37 http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23888-ir.c;h=2502a0a6709783b8c01d5de639d759d097f0f1cd;hb=staging/v2.6.37 If needed, cx23885-input.c is where a fix can be made to ensure structure fields are properly zeroed until I have time to fix he lower level stuff. Regards, Andy Code is compile tested with all drivers, and run tested with ENE and all receiver protocols (except the streamzap rc5 flavour) Since it also moves timeouts to lirc bridge, at least streazap driver should have its timeout gap support removed. I am afraid to break the code if I do so. Other 2 patches are ENE specific, and don't touch anything else. Please test other drivers. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Remaining patches in my queue for IR
On Sat, 2010-10-16 at 20:36 -0400, Andy Walls wrote: On Sun, 2010-10-17 at 00:56 +0200, Maxim Levitsky wrote: Hi, This series is rebased on top of media_tree/staging/v2.6.37 only. Really this time, sorry for cheating, last time :-) The first patch like we agreed extends the raw packets. It touches all drivers (except imon as it isn't a raw IR driver). Will IR for the CX23885 and CX23888 still work given the changes? Here's the relevant files that use struct ir_raw_event: http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23885-input.c;h=bb61870b8d6ed39d25c11aa676b55bd0a94dc235;hb=staging/v2.6.37 http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx25840/cx25840-ir.c;h=c2b4c14dc9ab533ff524b3e301235d6bdc92e2b9;hb=staging/v2.6.37 http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23888-ir.c;h=2502a0a6709783b8c01d5de639d759d097f0f1cd;hb=staging/v2.6.37 If needed, cx23885-input.c is where a fix can be made to ensure structure fields are properly zeroed until I have time to fix he lower level stuff. Regards, Andy Wasn't aware of this as I only looked at IR directory. Will grep the sources for more drivers. Anyway the changes I propose are straightforward, I shouldn't break the driver with it. But of course if driver isn't updated it probably won't work. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
