Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)
On Mon, 30 Apr 2012 15:51:01 +0200 Antonio Ospite osp...@studenti.unina.it wrote: On Mon, 23 Apr 2012 14:16:25 -0600 Jonathan Corbet cor...@lwn.net wrote: On Mon, 23 Apr 2012 15:21:04 +0200 Antonio Ospite osp...@studenti.unina.it wrote: Jonathan, maybe fixp_sin() and fixp_cos() can be used in drivers/media/video/ov7670.c too where currently ov7670_sine() and ov7670_cosine() are defined, but I didn't want to send a patch I could not test. Seems like a good idea. No reason to have multiple such hacks in the kernel; I'll look at dumping the ov7670 version when I get a chance. That may not be all that soon, though; life is a bit challenging at the moment. One concern is that if we're going to add users to fixp-arith.h, some of it should maybe go to a C file. Otherwise we'll create duplicated copies of the cos_table array for each user. I'm not sure the functions need to be inline either; nobody expects cos() to be blindingly fast. Jonathan, does lib/fixp-arith.c sound OK to you? I'll put that on my TODO, unless Johann wans to do some more rework; in any case I think we can still merge this patchset like it is right now. Jean-Francois will you take care of that? Or wait :) I'll send a v2, I think I should merge the current COLORS control used for SENSOR_OV767x and the SATURATION one I added for SENSOR_OV772x as they both are V4L2_CID_SATURATION. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? pgp7OH4SEvDn8.pgp Description: PGP signature
Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)
On Mon, 23 Apr 2012 14:16:25 -0600 Jonathan Corbet cor...@lwn.net wrote: On Mon, 23 Apr 2012 15:21:04 +0200 Antonio Ospite osp...@studenti.unina.it wrote: Jonathan, maybe fixp_sin() and fixp_cos() can be used in drivers/media/video/ov7670.c too where currently ov7670_sine() and ov7670_cosine() are defined, but I didn't want to send a patch I could not test. Seems like a good idea. No reason to have multiple such hacks in the kernel; I'll look at dumping the ov7670 version when I get a chance. That may not be all that soon, though; life is a bit challenging at the moment. One concern is that if we're going to add users to fixp-arith.h, some of it should maybe go to a C file. Otherwise we'll create duplicated copies of the cos_table array for each user. I'm not sure the functions need to be inline either; nobody expects cos() to be blindingly fast. Jonathan, does lib/fixp-arith.c sound OK to you? I'll put that on my TODO, unless Johann wans to do some more rework; in any case I think we can still merge this patchset like it is right now. Jean-Francois will you take care of that? Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? pgpsTmBTy6qfs.pgp Description: PGP signature
Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)
If you reply to all please fix Johann Deneux's address, I mis-wrote it, sorry. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? pgpr7B7n5pQIk.pgp Description: PGP signature
Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)
On Mon, Apr 23, 2012 at 03:21:04PM +0200, Antonio Ospite wrote: Hi, here are a couple more of controls for the gspca ov534 subdriver. In order to control the HUE value the sensor expects sin(HUE) and cos(HUE) to be set so I decided to reuse the fixed point implementation of sine and cosine from drivers/input/fixp-arith.h, see patches 2 and 3. Dmitry, can the movement of fixp-arith.h in patch 2 go via the media tree? That should ease up the integration of patch 3 in this series I think. Yep, this is fine with me. Jonathan, maybe fixp_sin() and fixp_cos() can be used in drivers/media/video/ov7670.c too where currently ov7670_sine() and ov7670_cosine() are defined, but I didn't want to send a patch I could not test. BTW What is the usual way to communicate these cross-subsystem stuff? I CC-ed everybody only on the cover letter and on patches 2 and 3 which are the ones concerning somehow both input and media. Thanks, Antonio Antonio Ospite (3): [media] gspca - ov534: Add Saturation control Input: move drivers/input/fixp-arith.h to include/linux [media] gspca - ov534: Add Hue control drivers/input/ff-memless.c|3 +- drivers/input/fixp-arith.h| 87 drivers/media/video/gspca/ov534.c | 89 - include/linux/fixp-arith.h| 87 4 files changed, 176 insertions(+), 90 deletions(-) delete mode 100644 drivers/input/fixp-arith.h create mode 100644 include/linux/fixp-arith.h -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)
On Mon, 23 Apr 2012 15:21:04 +0200 Antonio Ospite osp...@studenti.unina.it wrote: Jonathan, maybe fixp_sin() and fixp_cos() can be used in drivers/media/video/ov7670.c too where currently ov7670_sine() and ov7670_cosine() are defined, but I didn't want to send a patch I could not test. Seems like a good idea. No reason to have multiple such hacks in the kernel; I'll look at dumping the ov7670 version when I get a chance. That may not be all that soon, though; life is a bit challenging at the moment. One concern is that if we're going to add users to fixp-arith.h, some of it should maybe go to a C file. Otherwise we'll create duplicated copies of the cos_table array for each user. I'm not sure the functions need to be inline either; nobody expects cos() to be blindingly fast. Thanks, jon -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
