Re: [PATCH 01/28] venus: hfi_msgs: correct pointer increment

[Tomasz Figa]

On Fri, May 18, 2018 at 5:52 PM Stanimir Varbanov <
stanimir.varba...@linaro.org> wrote:

> Hi Tomasz,

> Thanks for the review!

> On 05/18/2018 11:33 AM, Tomasz Figa wrote:
> > Hi Stanimir,
> >
> > Thanks for the series. I'll be gradually reviewing subsequent patches.
Stay
> > tuned. :)
> >

> Please consider that there is a v2 of this patchset. :)

Thanks for heads up. Looks like I missed it originally. Will move to v2
with my review.

Best regards,
Tomasz

Re: [PATCH 01/28] venus: hfi_msgs: correct pointer increment

[Stanimir Varbanov]

Hi Tomasz,

Thanks for the review!

On 05/18/2018 11:33 AM, Tomasz Figa wrote:
> Hi Stanimir,
> 
> Thanks for the series. I'll be gradually reviewing subsequent patches. Stay
> tuned. :)
> 

Please consider that there is a v2 of this patchset. :)

> 
> Reviewed-by: Tomasz Figa 
> 

Thanks!

-- 
regards,
Stan

Re: [PATCH 01/28] venus: hfi_msgs: correct pointer increment

[Tomasz Figa]

Hi Stanimir,

Thanks for the series. I'll be gradually reviewing subsequent patches. Stay
tuned. :)

On Tue, Apr 24, 2018 at 9:56 PM Stanimir Varbanov <
stanimir.varba...@linaro.org> wrote:

> Data pointer should be incremented by size of the structure not
> the size of a pointer, correct the mistake.

> Signed-off-by: Stanimir Varbanov 
> ---
>   drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c
b/drivers/media/platform/qcom/venus/hfi_msgs.c
> index 90c93d9603dc..589e1a6b36a9 100644
> --- a/drivers/media/platform/qcom/venus/hfi_msgs.c
> +++ b/drivers/media/platform/qcom/venus/hfi_msgs.c
> @@ -60,14 +60,14 @@ static void event_seq_changed(struct venus_core
*core, struct venus_inst *inst,
>  frame_sz = (struct hfi_framesize *)data_ptr;
>  event.width = frame_sz->width;
>  event.height = frame_sz->height;
> -   data_ptr += sizeof(frame_sz);
> +   data_ptr += sizeof(*frame_sz);
>  break;
>  case HFI_PROPERTY_PARAM_PROFILE_LEVEL_CURRENT:
>  data_ptr += sizeof(u32);
>  profile_level = (struct hfi_profile_level
*)data_ptr;
>  event.profile = profile_level->profile;
>  event.level = profile_level->level;
> -   data_ptr += sizeof(profile_level);
> +   data_ptr += sizeof(*profile_level);
>  break;
>  default:
>  break;

Reviewed-by: Tomasz Figa 

Best regards,
Tomasz

[PATCH 01/28] venus: hfi_msgs: correct pointer increment

[Stanimir Varbanov]

Data pointer should be incremented by size of the structure not
the size of a pointer, correct the mistake.

Signed-off-by: Stanimir Varbanov 
---
 drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c 
b/drivers/media/platform/qcom/venus/hfi_msgs.c
index 90c93d9603dc..589e1a6b36a9 100644
--- a/drivers/media/platform/qcom/venus/hfi_msgs.c
+++ b/drivers/media/platform/qcom/venus/hfi_msgs.c
@@ -60,14 +60,14 @@ static void event_seq_changed(struct venus_core *core, 
struct venus_inst *inst,
frame_sz = (struct hfi_framesize *)data_ptr;
event.width = frame_sz->width;
event.height = frame_sz->height;
-   data_ptr += sizeof(frame_sz);
+   data_ptr += sizeof(*frame_sz);
break;
case HFI_PROPERTY_PARAM_PROFILE_LEVEL_CURRENT:
data_ptr += sizeof(u32);
profile_level = (struct hfi_profile_level *)data_ptr;
event.profile = profile_level->profile;
event.level = profile_level->level;
-   data_ptr += sizeof(profile_level);
+   data_ptr += sizeof(*profile_level);
break;
default:
break;
-- 
2.14.1