Re: [PATCH 07/19] media: Use the new media_entity_graph_walk_start()

[Sakari Ailus]

Hi Mauro,

On Wed, Oct 28, 2015 at 09:43:43AM +0900, Mauro Carvalho Chehab wrote:
> Em Tue, 27 Oct 2015 01:01:38 +0200
> Sakari Ailus  escreveu:
> 
> > Signed-off-by: Sakari Ailus 
> 
> Please add some documentation at the body for all patches.
> 
> Btw, IMHO, it would be best to fold this patch and the following ones
> that are related to media_entity_graph_walk_init() altogether, as it
> makes easier to review if all places were covered.

I think patches such as the 8th are easier to review as they are.

For the coverage,

$ git grep -l -E '^ *media_entity_graph_walk_start' 
Documentation/media-framework.txt
drivers/media/media-entity.c
drivers/media/platform/exynos4-is/media-dev.c
drivers/media/platform/omap3isp/isp.c
drivers/media/platform/omap3isp/ispvideo.c
drivers/media/platform/vsp1/vsp1_video.c
drivers/media/platform/xilinx/xilinx-dma.c
drivers/staging/media/davinci_vpfe/vpfe_video.c
drivers/staging/media/omap4iss/iss.c
drivers/staging/media/omap4iss/iss_video.c

Which suggests that I'm probably missing a few patches, indeed. I'll take
that into account in the next submission.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/19] media: Use the new media_entity_graph_walk_start()

[Mauro Carvalho Chehab]

Em Tue, 27 Oct 2015 01:01:38 +0200
Sakari Ailus  escreveu:

> Signed-off-by: Sakari Ailus 

Please add some documentation at the body for all patches.

Btw, IMHO, it would be best to fold this patch and the following ones
that are related to media_entity_graph_walk_init() altogether, as it
makes easier to review if all places were covered.

> ---
>  drivers/media/media-entity.c | 12 +++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
> index bf3c31f..4161dc7 100644
> --- a/drivers/media/media-entity.c
> +++ b/drivers/media/media-entity.c
> @@ -492,7 +492,13 @@ __must_check int media_entity_pipeline_start(struct 
> media_entity *entity,
>  
>   mutex_lock(&mdev->graph_mutex);
>  
> - media_entity_graph_walk_start(graph, entity);
> + ret = media_entity_graph_walk_init(&pipe->graph, mdev);
> + if (ret) {
> + mutex_unlock(&mdev->graph_mutex);
> + return ret;
> + }
> +
> + media_entity_graph_walk_start(&pipe->graph, entity);
>  
>   while ((entity = media_entity_graph_walk_next(graph))) {
>   DECLARE_BITMAP(active, MEDIA_ENTITY_MAX_PADS);
> @@ -590,6 +596,8 @@ error:
>   break;
>   }
>  
> + media_entity_graph_walk_cleanup(graph);
> +
>   mutex_unlock(&mdev->graph_mutex);
>  
>   return ret;
> @@ -623,6 +631,8 @@ void media_entity_pipeline_stop(struct media_entity 
> *entity)
>   entity->pipe = NULL;
>   }
>  
> + media_entity_graph_walk_cleanup(graph);
> +
>   mutex_unlock(&mdev->graph_mutex);
>  }
>  EXPORT_SYMBOL_GPL(media_entity_pipeline_stop);


-- 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 07/19] media: Use the new media_entity_graph_walk_start()

[Sakari Ailus]

Signed-off-by: Sakari Ailus 
---
 drivers/media/media-entity.c | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index bf3c31f..4161dc7 100644
--- a/drivers/media/media-entity.c
+++ b/drivers/media/media-entity.c
@@ -492,7 +492,13 @@ __must_check int media_entity_pipeline_start(struct 
media_entity *entity,
 
mutex_lock(&mdev->graph_mutex);
 
-   media_entity_graph_walk_start(graph, entity);
+   ret = media_entity_graph_walk_init(&pipe->graph, mdev);
+   if (ret) {
+   mutex_unlock(&mdev->graph_mutex);
+   return ret;
+   }
+
+   media_entity_graph_walk_start(&pipe->graph, entity);
 
while ((entity = media_entity_graph_walk_next(graph))) {
DECLARE_BITMAP(active, MEDIA_ENTITY_MAX_PADS);
@@ -590,6 +596,8 @@ error:
break;
}
 
+   media_entity_graph_walk_cleanup(graph);
+
mutex_unlock(&mdev->graph_mutex);
 
return ret;
@@ -623,6 +631,8 @@ void media_entity_pipeline_stop(struct media_entity *entity)
entity->pipe = NULL;
}
 
+   media_entity_graph_walk_cleanup(graph);
+
mutex_unlock(&mdev->graph_mutex);
 }
 EXPORT_SYMBOL_GPL(media_entity_pipeline_stop);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html