Re: [PATCH 1/3] v4l: Extend V4L2_CID_COLORFX control with AQUA effect
Hi Laurent, On 09/21/2011 12:23 AM, Laurent Pinchart wrote: > On Monday 19 September 2011 13:26:39 Sylwester Nawrocki wrote: >> On 09/19/2011 08:08 AM, Subash Patel wrote: >>> Hi Laurent, >>> >>> I am not representing Sylwester :), But with a similar sensor I use, Aqua >>> means cool tone which is Cb/Cr manipulations. >>> >>> On 09/19/2011 04:38 AM, Laurent Pinchart wrote: On Friday 16 September 2011 19:05:28 Sylwester Nawrocki wrote: > Add V4L2_COLORFX_AQUA image effect in the V4L2_CID_COLORFX menu. What's the aqua effect ? >> >> Aqua means cool tone, as Subash explained. It's somehow opposite to Sepia >> which is warm tone. I'll improve the commit description in the next patch >> version. >> I tried to make a table with short description of each color effect in the >> DocBook but it was taking me too long so I dropped it for a moment. >> >> I have attached an image presenting the color effects. Maybe it's worth >> to add something like this to the DocBook, or perhaps just the >> descriptions. > > Thanks for the information. I think it would indeed be useful to add > descriptions to the documentation. Sure, I'll try to find some time to complete this. And I wonder, what BLUE_SKY effect is ? I suspect it's very much same as the Aqua effect which is present in our sensor ISP. Does anyone know exactly ? Perhaps I could just use it instead of adding new menu entry. Regards, -- Sylwester Nawrocki Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] v4l: Extend V4L2_CID_COLORFX control with AQUA effect
Hi Sylwester,
On Monday 19 September 2011 13:26:39 Sylwester Nawrocki wrote:
> On 09/19/2011 08:08 AM, Subash Patel wrote:
> > Hi Laurent,
> >
> > I am not representing Sylwester :), But with a similar sensor I use, Aqua
> > means cool tone which is Cb/Cr manipulations.
> >
> > On 09/19/2011 04:38 AM, Laurent Pinchart wrote:
> >> On Friday 16 September 2011 19:05:28 Sylwester Nawrocki wrote:
> >>> Add V4L2_COLORFX_AQUA image effect in the V4L2_CID_COLORFX menu.
> >>
> >> What's the aqua effect ?
>
> Aqua means cool tone, as Subash explained. It's somehow opposite to Sepia
> which is warm tone. I'll improve the commit description in the next patch
> version.
> I tried to make a table with short description of each color effect in the
> DocBook but it was taking me too long so I dropped it for a moment.
>
> I have attached an image presenting the color effects. Maybe it's worth
> to add something like this to the DocBook, or perhaps just the
> descriptions.
Thanks for the information. I think it would indeed be useful to add
descriptions to the documentation.
> >>> Signed-off-by: Sylwester Nawrocki
> >>> Signed-off-by: Kyungmin Park
> >>> ---
> >>>
> >>> Documentation/DocBook/media/v4l/controls.xml |5 +++--
> >>> include/linux/videodev2.h|1 +
> >>> 2 files changed, 4 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/Documentation/DocBook/media/v4l/controls.xml
> >>> b/Documentation/DocBook/media/v4l/controls.xml index 8516401..f3c6457
> >>> 100644
> >>> --- a/Documentation/DocBook/media/v4l/controls.xml
> >>> +++ b/Documentation/DocBook/media/v4l/controls.xml
> >>> @@ -294,8 +294,9 @@ minimum value disables backlight
> >>> compensation.
> >>>
> >>> V4L2_COLORFX_SKETCH (5),
> >>> V4L2_COLORFX_SKY_BLUE (6),
> >>> V4L2_COLORFX_GRASS_GREEN (7),
> >>>
> >>> -V4L2_COLORFX_SKIN_WHITEN (8) and
> >>> -V4L2_COLORFX_VIVID (9).
> >>> +V4L2_COLORFX_SKIN_WHITEN (8),
> >>> +V4L2_COLORFX_VIVID (9) and
> >>> +V4L2_COLORFX_AQUA (10).
> >>>
> >>>
> >>>
> >>> V4L2_CID_ROTATE
> >>>
> >>> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> >>> index fca24cc..5032226 100644
> >>> --- a/include/linux/videodev2.h
> >>> +++ b/include/linux/videodev2.h
> >>> @@ -1144,6 +1144,7 @@ enum v4l2_colorfx {
> >>>
> >>> V4L2_COLORFX_GRASS_GREEN = 7,
> >>> V4L2_COLORFX_SKIN_WHITEN = 8,
> >>> V4L2_COLORFX_VIVID = 9,
> >>>
> >>> +V4L2_COLORFX_AQUA = 10,
> >>>
> >>> };
> >>> #define V4L2_CID_AUTOBRIGHTNESS(V4L2_CID_BASE+32)
> >>> #define V4L2_CID_BAND_STOP_FILTER(V4L2_CID_BASE+33)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] v4l: Extend V4L2_CID_COLORFX control with AQUA effect
Hi Laurent,
I am not representing Sylwester :), But with a similar sensor I use,
Aqua means cool tone which is Cb/Cr manipulations.
Regards,
Subash
On 09/19/2011 04:38 AM, Laurent Pinchart wrote:
Hi Sylwester,
Thanks for the patch.
On Friday 16 September 2011 19:05:28 Sylwester Nawrocki wrote:
Add V4L2_COLORFX_AQUA image effect in the V4L2_CID_COLORFX menu.
What's the aqua effect ?
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
Documentation/DocBook/media/v4l/controls.xml |5 +++--
include/linux/videodev2.h|1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/DocBook/media/v4l/controls.xml
b/Documentation/DocBook/media/v4l/controls.xml index 8516401..f3c6457
100644
--- a/Documentation/DocBook/media/v4l/controls.xml
+++ b/Documentation/DocBook/media/v4l/controls.xml
@@ -294,8 +294,9 @@ minimum value disables backlight compensation.
V4L2_COLORFX_SKETCH (5),
V4L2_COLORFX_SKY_BLUE (6),
V4L2_COLORFX_GRASS_GREEN (7),
-V4L2_COLORFX_SKIN_WHITEN (8) and
-V4L2_COLORFX_VIVID (9).
+V4L2_COLORFX_SKIN_WHITEN (8),
+V4L2_COLORFX_VIVID (9) and
+V4L2_COLORFX_AQUA (10).
V4L2_CID_ROTATE
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index fca24cc..5032226 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -1144,6 +1144,7 @@ enum v4l2_colorfx {
V4L2_COLORFX_GRASS_GREEN = 7,
V4L2_COLORFX_SKIN_WHITEN = 8,
V4L2_COLORFX_VIVID = 9,
+ V4L2_COLORFX_AQUA = 10,
};
#define V4L2_CID_AUTOBRIGHTNESS (V4L2_CID_BASE+32)
#define V4L2_CID_BAND_STOP_FILTER (V4L2_CID_BASE+33)
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] v4l: Extend V4L2_CID_COLORFX control with AQUA effect
Hi Sylwester,
Thanks for the patch.
On Friday 16 September 2011 19:05:28 Sylwester Nawrocki wrote:
> Add V4L2_COLORFX_AQUA image effect in the V4L2_CID_COLORFX menu.
What's the aqua effect ?
> Signed-off-by: Sylwester Nawrocki
> Signed-off-by: Kyungmin Park
> ---
> Documentation/DocBook/media/v4l/controls.xml |5 +++--
> include/linux/videodev2.h|1 +
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/controls.xml
> b/Documentation/DocBook/media/v4l/controls.xml index 8516401..f3c6457
> 100644
> --- a/Documentation/DocBook/media/v4l/controls.xml
> +++ b/Documentation/DocBook/media/v4l/controls.xml
> @@ -294,8 +294,9 @@ minimum value disables backlight compensation.
> V4L2_COLORFX_SKETCH (5),
> V4L2_COLORFX_SKY_BLUE (6),
> V4L2_COLORFX_GRASS_GREEN (7),
> -V4L2_COLORFX_SKIN_WHITEN (8) and
> -V4L2_COLORFX_VIVID (9).
> +V4L2_COLORFX_SKIN_WHITEN (8),
> +V4L2_COLORFX_VIVID (9) and
> +V4L2_COLORFX_AQUA (10).
>
>
> V4L2_CID_ROTATE
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index fca24cc..5032226 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -1144,6 +1144,7 @@ enum v4l2_colorfx {
> V4L2_COLORFX_GRASS_GREEN = 7,
> V4L2_COLORFX_SKIN_WHITEN = 8,
> V4L2_COLORFX_VIVID = 9,
> + V4L2_COLORFX_AQUA = 10,
> };
> #define V4L2_CID_AUTOBRIGHTNESS (V4L2_CID_BASE+32)
> #define V4L2_CID_BAND_STOP_FILTER(V4L2_CID_BASE+33)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/3] v4l: Extend V4L2_CID_COLORFX control with AQUA effect
Add V4L2_COLORFX_AQUA image effect in the V4L2_CID_COLORFX menu.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
Documentation/DocBook/media/v4l/controls.xml |5 +++--
include/linux/videodev2.h|1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/DocBook/media/v4l/controls.xml
b/Documentation/DocBook/media/v4l/controls.xml
index 8516401..f3c6457 100644
--- a/Documentation/DocBook/media/v4l/controls.xml
+++ b/Documentation/DocBook/media/v4l/controls.xml
@@ -294,8 +294,9 @@ minimum value disables backlight compensation.
V4L2_COLORFX_SKETCH (5),
V4L2_COLORFX_SKY_BLUE (6),
V4L2_COLORFX_GRASS_GREEN (7),
-V4L2_COLORFX_SKIN_WHITEN (8) and
-V4L2_COLORFX_VIVID (9).
+V4L2_COLORFX_SKIN_WHITEN (8),
+V4L2_COLORFX_VIVID (9) and
+V4L2_COLORFX_AQUA (10).
V4L2_CID_ROTATE
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index fca24cc..5032226 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -1144,6 +1144,7 @@ enum v4l2_colorfx {
V4L2_COLORFX_GRASS_GREEN = 7,
V4L2_COLORFX_SKIN_WHITEN = 8,
V4L2_COLORFX_VIVID = 9,
+ V4L2_COLORFX_AQUA = 10,
};
#define V4L2_CID_AUTOBRIGHTNESS(V4L2_CID_BASE+32)
#define V4L2_CID_BAND_STOP_FILTER (V4L2_CID_BASE+33)
--
1.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
