Re: [PATCH 1/6] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats

2016-06-20 Thread Sakari Ailus 
Hi Hans,

Hans Verkuil wrote:
> On 05/27/2016 02:44 PM, Sakari Ailus wrote:
>> The 10-bit packed raw bayer format documented that the data of the first
>> pixel of a four-pixel group was found in the first byte and the two
>> highest bits of the fifth byte. This was not entirely correct. The two
>> bits in the fifth byte are the two lowest bits. The second pixel occupies
>> the second byte and third and fourth least significant bits and so on.
> 
> This is used by the uvc driver. Has this been verified against a UVC webcam
> that supports this format? Laurent, do you have such a device?

I bet Laurent hasn't got one. Guennadi, could you comment on this?

-- 
Regards,

Sakari Ailus
sakari.ai...@linux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats

2016-06-20 Thread Hans Verkuil 
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> The 10-bit packed raw bayer format documented that the data of the first
> pixel of a four-pixel group was found in the first byte and the two
> highest bits of the fifth byte. This was not entirely correct. The two
> bits in the fifth byte are the two lowest bits. The second pixel occupies
> the second byte and third and fourth least significant bits and so on.

This is used by the uvc driver. Has this been verified against a UVC webcam
that supports this format? Laurent, do you have such a device?

Just in case UVC actually supports this as it is documented today.

Regards,

Hans

> 
> Signed-off-by: Sakari Ailus 
> ---
>  .../DocBook/media/v4l/pixfmt-srggb10p.xml  | 32 
> +++---
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml 
> b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> index a8cc102..747822b 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> @@ -47,10 +47,10 @@
> G01high
> B02high
> G03high
> -   B00low(bits 7--6)
> -  G01low(bits 5--4)
> -  B02low(bits 3--2)
> -  G03low(bits 1--0)
> +   G03low(bits 7--6)
> +  B02low(bits 5--4)
> +  G01low(bits 3--2)
> +  B00low(bits 1--0)
> 
>   
>   
> @@ -59,10 +59,10 @@
> R11high
> G12high
> R13high
> -   G10low(bits 7--6)
> -  R11low(bits 5--4)
> -  G12low(bits 3--2)
> -  R13low(bits 1--0)
> +   R13low(bits 7--6)
> +  G12low(bits 5--4)
> +  R11low(bits 3--2)
> +  G10low(bits 1--0)
> 
>   
>   
> @@ -71,10 +71,10 @@
> G21high
> B22high
> G23high
> -   B20low(bits 7--6)
> -  G21low(bits 5--4)
> -  B22low(bits 3--2)
> -  G23low(bits 1--0)
> +   G23low(bits 7--6)
> +  B22low(bits 5--4)
> +  G21low(bits 3--2)
> +  B20low(bits 1--0)
> 
>   
>   
> @@ -83,10 +83,10 @@
> R31high
> G32high
> R33high
> -   G30low(bits 7--6)
> -  R31low(bits 5--4)
> -  G32low(bits 3--2)
> -  R33low(bits 1--0)
> +   R33low(bits 7--6)
> +  G32low(bits 5--4)
> +  R31low(bits 3--2)
> +  G30low(bits 1--0)
> 
>   
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/6] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats

2016-05-27 Thread Sakari Ailus 
The 10-bit packed raw bayer format documented that the data of the first
pixel of a four-pixel group was found in the first byte and the two
highest bits of the fifth byte. This was not entirely correct. The two
bits in the fifth byte are the two lowest bits. The second pixel occupies
the second byte and third and fourth least significant bits and so on.

Signed-off-by: Sakari Ailus 
---
 .../DocBook/media/v4l/pixfmt-srggb10p.xml  | 32 +++---
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml 
b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
index a8cc102..747822b 100644
--- a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
+++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
@@ -47,10 +47,10 @@
  G01high
  B02high
  G03high
- B00low(bits 7--6)
-G01low(bits 5--4)
-B02low(bits 3--2)
-G03low(bits 1--0)
+ G03low(bits 7--6)
+B02low(bits 5--4)
+G01low(bits 3--2)
+B00low(bits 1--0)
  


@@ -59,10 +59,10 @@
  R11high
  G12high
  R13high
- G10low(bits 7--6)
-R11low(bits 5--4)
-G12low(bits 3--2)
-R13low(bits 1--0)
+ R13low(bits 7--6)
+G12low(bits 5--4)
+R11low(bits 3--2)
+G10low(bits 1--0)
  


@@ -71,10 +71,10 @@
  G21high
  B22high
  G23high
- B20low(bits 7--6)
-G21low(bits 5--4)
-B22low(bits 3--2)
-G23low(bits 1--0)
+ G23low(bits 7--6)
+B22low(bits 5--4)
+G21low(bits 3--2)
+B20low(bits 1--0)
  


@@ -83,10 +83,10 @@
  R31high
  G32high
  R33high
- G30low(bits 7--6)
-R31low(bits 5--4)
-G32low(bits 3--2)
-R33low(bits 1--0)
+ R33low(bits 7--6)
+G32low(bits 5--4)
+R31low(bits 3--2)
+G30low(bits 1--0)
  

  
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html