Re: [PATCH 19/22] media: drivers: remove "/**" from non-kernel-doc comments

2017-11-30 Thread Kieran Bingham
Hi Mauro,

Thanks for the patch.

On 29/11/17 19:08, Mauro Carvalho Chehab wrote:
> Several comments are wrongly tagged as kernel-doc, causing
> those warnings:
> 
>   drivers/media/rc/st_rc.c:98: warning: No description found for parameter 
> 'irq'
>   drivers/media/rc/st_rc.c:98: warning: No description found for parameter 
> 'data'
>   drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description 
> found for parameter 'solo_dev'
>   drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description 
> found for parameter 'ch'
>   drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description 
> found for parameter 'qp'
>   drivers/media/usb/pwc/pwc-dec23.c:652: warning: Cannot understand  *
>on line 652 - I thought it was a doc line
>   drivers/media/usb/dvb-usb/cinergyT2-fe.c:40: warning: No description found 
> for parameter 'op'
>   drivers/media/usb/dvb-usb/friio-fe.c:301: warning: Cannot understand  * 
> (reg, val) commad list to initialize this module.
>on line 301 - I thought it was a doc line
>   drivers/media/rc/streamzap.c:201: warning: No description found for 
> parameter 'urb'
>   drivers/media/rc/streamzap.c:333: warning: No description found for 
> parameter 'intf'
>   drivers/media/rc/streamzap.c:333: warning: No description found for 
> parameter 'id'
>   drivers/media/rc/streamzap.c:464: warning: No description found for 
> parameter 'interface'
>   drivers/media/i2c/ov5647.c:432: warning: Cannot understand  * @short Subdev 
> core operations registration
>on line 432 - I thought it was a doc line
>   drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
> parameter 'd'
>   drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
> parameter 'addr'
>   drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
> parameter 'wbuf'
>   drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
> parameter 'wlen'
>   drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
> parameter 'rbuf'
>   drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
> parameter 'rlen'
>   drivers/media/platform/vim2m.c:350: warning: No description found for 
> parameter 'priv'
>   drivers/media/dvb-frontends/tua6100.c:34: warning: cannot understand 
> function prototype: 'struct tua6100_priv '
>   drivers/media/platform/sti/hva/hva-h264.c:140: warning: cannot understand 
> function prototype: 'struct hva_h264_stereo_video_sei '
>   drivers/media/platform/sti/hva/hva-h264.c:150: warning: Cannot understand  
> * @frame_width: width in pixels of the buffer containing the input frame
>on line 150 - I thought it was a doc line
>   drivers/media/platform/sti/hva/hva-h264.c:356: warning: Cannot understand  
> * @ slice_size: slice size
>on line 356 - I thought it was a doc line
>   drivers/media/platform/sti/hva/hva-h264.c:369: warning: Cannot understand  
> * @ bitstream_size: bitstream size
>on line 369 - I thought it was a doc line
>   drivers/media/platform/sti/hva/hva-h264.c:395: warning: Cannot understand  
> * @seq_info:  sequence information buffer
>on line 395 - I thought it was a doc line
>   drivers/media/dvb-frontends/sp887x.c:137: warning: No description found for 
> parameter 'fe'
>   drivers/media/dvb-frontends/sp887x.c:137: warning: No description found for 
> parameter 'fw'
>   drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for 
> parameter 'n'
>   drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for 
> parameter 'd'
>   drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for 
> parameter 'quotient_i'
>   drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for 
> parameter 'quotient_f'
>   drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c:83: warning: cannot 
> understand function prototype: 'struct ttusb '
>   drivers/media/platform/sh_veu.c:277: warning: No description found for 
> parameter 'priv'
>   drivers/media/dvb-frontends/zl10036.c:33: warning: cannot understand 
> function prototype: 'int zl10036_debug; '
>   drivers/media/dvb-frontends/zl10036.c:179: warning: No description found 
> for parameter 'state'
>   drivers/media/dvb-frontends/zl10036.c:179: warning: No description found 
> for parameter 'frequency'
>   drivers/media/platform/rcar_fdp1.c:1139: warning: No description found for 
> parameter 'priv'
>   drivers/media/platform/ti-vpe/vpe.c:933: warning: No description found for 
> parameter 'priv'
>   drivers/media/usb/gspca/ov519.c:36: warning: No description found for 
> parameter 'fmt'
>   drivers/media/usb/dvb-usb/dib0700_devices.c:3367: warning: No description 
> found for parameter 'adap'
> 
> Signed-off-by: Mauro Carvalho Chehab 

Acked-by: Kieran Bingham 

For FDP1 at least :)

> ---
>  drivers/media/dvb-frontends/sp887x.c  |  6 +++---
>  drivers/media/dvb-frontends/tua6100.c |  2 +-
>  drivers/media/dvb-frontends/zl1

[PATCH 19/22] media: drivers: remove "/**" from non-kernel-doc comments

2017-11-29 Thread Mauro Carvalho Chehab
Several comments are wrongly tagged as kernel-doc, causing
those warnings:

  drivers/media/rc/st_rc.c:98: warning: No description found for parameter 'irq'
  drivers/media/rc/st_rc.c:98: warning: No description found for parameter 
'data'
  drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found 
for parameter 'solo_dev'
  drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found 
for parameter 'ch'
  drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found 
for parameter 'qp'
  drivers/media/usb/pwc/pwc-dec23.c:652: warning: Cannot understand  *
   on line 652 - I thought it was a doc line
  drivers/media/usb/dvb-usb/cinergyT2-fe.c:40: warning: No description found 
for parameter 'op'
  drivers/media/usb/dvb-usb/friio-fe.c:301: warning: Cannot understand  * (reg, 
val) commad list to initialize this module.
   on line 301 - I thought it was a doc line
  drivers/media/rc/streamzap.c:201: warning: No description found for parameter 
'urb'
  drivers/media/rc/streamzap.c:333: warning: No description found for parameter 
'intf'
  drivers/media/rc/streamzap.c:333: warning: No description found for parameter 
'id'
  drivers/media/rc/streamzap.c:464: warning: No description found for parameter 
'interface'
  drivers/media/i2c/ov5647.c:432: warning: Cannot understand  * @short Subdev 
core operations registration
   on line 432 - I thought it was a doc line
  drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
parameter 'd'
  drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
parameter 'addr'
  drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
parameter 'wbuf'
  drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
parameter 'wlen'
  drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
parameter 'rbuf'
  drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for 
parameter 'rlen'
  drivers/media/platform/vim2m.c:350: warning: No description found for 
parameter 'priv'
  drivers/media/dvb-frontends/tua6100.c:34: warning: cannot understand function 
prototype: 'struct tua6100_priv '
  drivers/media/platform/sti/hva/hva-h264.c:140: warning: cannot understand 
function prototype: 'struct hva_h264_stereo_video_sei '
  drivers/media/platform/sti/hva/hva-h264.c:150: warning: Cannot understand  * 
@frame_width: width in pixels of the buffer containing the input frame
   on line 150 - I thought it was a doc line
  drivers/media/platform/sti/hva/hva-h264.c:356: warning: Cannot understand  * 
@ slice_size: slice size
   on line 356 - I thought it was a doc line
  drivers/media/platform/sti/hva/hva-h264.c:369: warning: Cannot understand  * 
@ bitstream_size: bitstream size
   on line 369 - I thought it was a doc line
  drivers/media/platform/sti/hva/hva-h264.c:395: warning: Cannot understand  * 
@seq_info:  sequence information buffer
   on line 395 - I thought it was a doc line
  drivers/media/dvb-frontends/sp887x.c:137: warning: No description found for 
parameter 'fe'
  drivers/media/dvb-frontends/sp887x.c:137: warning: No description found for 
parameter 'fw'
  drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for 
parameter 'n'
  drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for 
parameter 'd'
  drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for 
parameter 'quotient_i'
  drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for 
parameter 'quotient_f'
  drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c:83: warning: cannot 
understand function prototype: 'struct ttusb '
  drivers/media/platform/sh_veu.c:277: warning: No description found for 
parameter 'priv'
  drivers/media/dvb-frontends/zl10036.c:33: warning: cannot understand function 
prototype: 'int zl10036_debug; '
  drivers/media/dvb-frontends/zl10036.c:179: warning: No description found for 
parameter 'state'
  drivers/media/dvb-frontends/zl10036.c:179: warning: No description found for 
parameter 'frequency'
  drivers/media/platform/rcar_fdp1.c:1139: warning: No description found for 
parameter 'priv'
  drivers/media/platform/ti-vpe/vpe.c:933: warning: No description found for 
parameter 'priv'
  drivers/media/usb/gspca/ov519.c:36: warning: No description found for 
parameter 'fmt'
  drivers/media/usb/dvb-usb/dib0700_devices.c:3367: warning: No description 
found for parameter 'adap'

Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/dvb-frontends/sp887x.c  |  6 +++---
 drivers/media/dvb-frontends/tua6100.c |  2 +-
 drivers/media/dvb-frontends/zl10036.c |  8 
 drivers/media/i2c/ov5647.c|  4 ++--
 drivers/media/pci/solo6x10/solo6x10-enc.c |  2 +-
 drivers/media/platform/rcar_fdp1.c|  2 +-
 drivers/media/platform/sh_veu.c   |  2 +-
 drivers/media/platform/sti/hva/hva-h264.c | 18