Re: [PATCH 2/2] media: sun6i-csi: manually fix other coding style issues

2018-11-26 Thread Maxime Ripard
On Fri, Nov 23, 2018 at 05:13:23AM -0500, Mauro Carvalho Chehab wrote:
> There are a few other coding style issues reported by checkpatch
> while in --strict mode. Fix the ones that make sense.
> 
> Signed-off-by: Mauro Carvalho Chehab 

For both patches,

Acked-by: Maxime Ripard 

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


[PATCH 2/2] media: sun6i-csi: manually fix other coding style issues

2018-11-23 Thread Mauro Carvalho Chehab
There are a few other coding style issues reported by checkpatch
while in --strict mode. Fix the ones that make sense.

Signed-off-by: Mauro Carvalho Chehab 
---
 .../platform/sunxi/sun6i-csi/sun6i_csi.c  |  9 +++
 .../platform/sunxi/sun6i-csi/sun6i_csi_reg.h  | 24 +--
 .../platform/sunxi/sun6i-csi/sun6i_video.c|  3 ++-
 3 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c 
b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
index 89fe2c1e21a8..9c8a98d78c97 100644
--- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
+++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
@@ -57,7 +57,7 @@ bool sun6i_csi_is_format_supported(struct sun6i_csi *csi,
 * Identify the media bus format from device tree.
 */
if ((sdev->csi.v4l2_ep.bus_type == V4L2_MBUS_PARALLEL
- || sdev->csi.v4l2_ep.bus_type == V4L2_MBUS_BT656)
+|| sdev->csi.v4l2_ep.bus_type == V4L2_MBUS_BT656)
 && sdev->csi.v4l2_ep.bus.parallel.bus_width == 16) {
switch (pixformat) {
case V4L2_PIX_FMT_HM12:
@@ -726,9 +726,10 @@ static int sun6i_csi_v4l2_init(struct sun6i_csi *csi)
if (ret)
goto unreg_v4l2;
 
-   ret = v4l2_async_notifier_parse_fwnode_endpoints(
-   csi->dev, >notifier, sizeof(struct v4l2_async_subdev),
-   sun6i_csi_fwnode_parse);
+   ret = v4l2_async_notifier_parse_fwnode_endpoints(csi->dev,
+>notifier,
+sizeof(struct 
v4l2_async_subdev),
+
sun6i_csi_fwnode_parse);
if (ret)
goto clean_video;
 
diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_reg.h 
b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_reg.h
index d9b6d89f1927..703fa14bb313 100644
--- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_reg.h
+++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_reg.h
@@ -46,7 +46,7 @@
 
 #define CSI_CAP_REG0x8
 #define CSI_CAP_CH0_CAP_MASK_MASK  GENMASK(5, 2)
-#define CSI_CAP_CH0_CAP_MASK(count)((count << 2) & 
CSI_CAP_CH0_CAP_MASK_MASK)
+#define CSI_CAP_CH0_CAP_MASK(count)(((count) << 2) & 
CSI_CAP_CH0_CAP_MASK_MASK)
 #define CSI_CAP_CH0_VCAP_ONBIT(1)
 #define CSI_CAP_CH0_SCAP_ONBIT(0)
 
@@ -59,9 +59,9 @@
 
 #define CSI_CH_CFG_REG 0x44
 #define CSI_CH_CFG_INPUT_FMT_MASK  GENMASK(23, 20)
-#define CSI_CH_CFG_INPUT_FMT(fmt)  ((fmt << 20) & 
CSI_CH_CFG_INPUT_FMT_MASK)
+#define CSI_CH_CFG_INPUT_FMT(fmt)  (((fmt) << 20) & 
CSI_CH_CFG_INPUT_FMT_MASK)
 #define CSI_CH_CFG_OUTPUT_FMT_MASK GENMASK(19, 16)
-#define CSI_CH_CFG_OUTPUT_FMT(fmt) ((fmt << 16) & 
CSI_CH_CFG_OUTPUT_FMT_MASK)
+#define CSI_CH_CFG_OUTPUT_FMT(fmt) (((fmt) << 16) & 
CSI_CH_CFG_OUTPUT_FMT_MASK)
 #define CSI_CH_CFG_VFLIP_ENBIT(13)
 #define CSI_CH_CFG_HFLIP_ENBIT(12)
 #define CSI_CH_CFG_FIELD_SEL_MASK  GENMASK(11, 10)
@@ -69,7 +69,7 @@
 #define CSI_CH_CFG_FIELD_SEL_FIELD1((1 << 10) & 
CSI_CH_CFG_FIELD_SEL_MASK)
 #define CSI_CH_CFG_FIELD_SEL_BOTH  ((2 << 10) & 
CSI_CH_CFG_FIELD_SEL_MASK)
 #define CSI_CH_CFG_INPUT_SEQ_MASK  GENMASK(9, 8)
-#define CSI_CH_CFG_INPUT_SEQ(seq)  ((seq << 8) & 
CSI_CH_CFG_INPUT_SEQ_MASK)
+#define CSI_CH_CFG_INPUT_SEQ(seq)  (((seq) << 8) & 
CSI_CH_CFG_INPUT_SEQ_MASK)
 
 #define CSI_CH_SCALE_REG   0x4c
 #define CSI_CH_SCALE_QUART_EN  BIT(0)
@@ -111,27 +111,27 @@
 
 #define CSI_CH_HSIZE_REG   0x80
 #define CSI_CH_HSIZE_HOR_LEN_MASK  GENMASK(28, 16)
-#define CSI_CH_HSIZE_HOR_LEN(len)  ((len << 16) & 
CSI_CH_HSIZE_HOR_LEN_MASK)
+#define CSI_CH_HSIZE_HOR_LEN(len)  (((len) << 16) & 
CSI_CH_HSIZE_HOR_LEN_MASK)
 #define CSI_CH_HSIZE_HOR_START_MASKGENMASK(12, 0)
-#define CSI_CH_HSIZE_HOR_START(start)  ((start << 0) & 
CSI_CH_HSIZE_HOR_START_MASK)
+#define CSI_CH_HSIZE_HOR_START(start)  (((start) << 0) & 
CSI_CH_HSIZE_HOR_START_MASK)
 
 #define CSI_CH_VSIZE_REG   0x84
 #define CSI_CH_VSIZE_VER_LEN_MASK  GENMASK(28, 16)
-#define CSI_CH_VSIZE_VER_LEN(len)  ((len << 16) & 
CSI_CH_VSIZE_VER_LEN_MASK)
+#define CSI_CH_VSIZE_VER_LEN(len)  (((len) << 16) & 
CSI_CH_VSIZE_VER_LEN_MASK)
 #define CSI_CH_VSIZE_VER_START_MASKGENMASK(12, 0)
-#define CSI_CH_VSIZE_VER_START(start)  ((start << 0) & 
CSI_CH_VSIZE_VER_START_MASK)
+#define CSI_CH_VSIZE_VER_START(start)  (((start) << 0) & 
CSI_CH_VSIZE_VER_START_MASK)
 
 #define CSI_CH_BUF_LEN_REG 0x88
 #define