Re: [PATCH 2/3] [media] DaVinci-VPBE-Display: Improve a size determination in two functions

[Lad, Prabhakar]

On Fri, Sep 8, 2017 at 1:32 PM, SF Markus Elfring
 wrote:
> From: Markus Elfring 
> Date: Fri, 8 Sep 2017 10:50:32 +0200
>
> Replace the specification of data structures by pointer dereferences
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> Signed-off-by: Markus Elfring 

Acked-by: Lad, Prabhakar 

Cheers,
--Prabhakar Lad

[PATCH 2/3] [media] DaVinci-VPBE-Display: Improve a size determination in two functions

[SF Markus Elfring]

From: Markus Elfring 
Date: Fri, 8 Sep 2017 10:50:32 +0200

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring 
---
 drivers/media/platform/davinci/vpbe_display.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/media/platform/davinci/vpbe_display.c 
b/drivers/media/platform/davinci/vpbe_display.c
index 5b6fc550736b..afe31900f5de 100644
--- a/drivers/media/platform/davinci/vpbe_display.c
+++ b/drivers/media/platform/davinci/vpbe_display.c
@@ -1305,9 +1305,5 @@ static int init_vpbe_layer(int i, struct vpbe_display 
*disp_dev,
struct video_device *vbd = NULL;
 
/* Allocate memory for four plane display objects */
-
-   disp_dev->dev[i] =
-   kzalloc(sizeof(struct vpbe_layer), GFP_KERNEL);
-
-   /* If memory allocation fails, return error */
+   disp_dev->dev[i] = kzalloc(sizeof(*disp_dev->dev[i]), GFP_KERNEL);
if (!disp_dev->dev[i])
@@ -1396,6 +1392,5 @@ static int vpbe_display_probe(struct platform_device 
*pdev)
 
printk(KERN_DEBUG "vpbe_display_probe\n");
/* Allocate memory for vpbe_display */
-   disp_dev = devm_kzalloc(>dev, sizeof(struct vpbe_display),
-   GFP_KERNEL);
+   disp_dev = devm_kzalloc(>dev, sizeof(*disp_dev), GFP_KERNEL);
if (!disp_dev)
-- 
2.14.1