Re: [PATCH 2/3] media: adv7604: implement cropcap

[Laurent Pinchart]

Hi Ulrich,

Thank you for the patch.

On Friday 11 December 2015 17:04:52 Ulrich Hecht wrote:
> Used by the rcar_vin driver.
> 
> Signed-off-by: Ulrich Hecht 
> ---
>  drivers/media/i2c/adv7604.c | 17 +
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index d30e7cc..1bfa9f3 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -1896,6 +1896,22 @@ static int adv76xx_g_crop(struct v4l2_subdev *sd,
> struct v4l2_crop *a) return 0;
>  }
> 
> +static int adv76xx_cropcap(struct v4l2_subdev *sd, struct v4l2_cropcap *a)
> +{
> + struct adv76xx_state *state = to_state(sd);
> +
> + a->bounds.left   = 0;
> + a->bounds.top= 0;
> + a->bounds.width  = state->timings.bt.width;
> + a->bounds.height = state->timings.bt.height;
> + a->defrect   = a->bounds;
> + a->type  = V4L2_BUF_TYPE_VIDEO_CAPTURE;

As for patch 1/3 the type field is an input parameter.

> + a->pixelaspect.numerator   = 1;
> + a->pixelaspect.denominator = 1;

I'm curious, is this always true with HDMI ?

> +
> + return 0;
> +}
> +
>  static int adv76xx_set_format(struct v4l2_subdev *sd,
> struct v4l2_subdev_pad_config *cfg,
> struct v4l2_subdev_format *format)
> @@ -2419,6 +2435,7 @@ static const struct v4l2_subdev_core_ops
> adv76xx_core_ops = { static const struct v4l2_subdev_video_ops
> adv76xx_video_ops = {
>   .s_routing = adv76xx_s_routing,
>   .g_crop = adv76xx_g_crop,
> + .cropcap = adv76xx_cropcap,
>   .g_input_status = adv76xx_g_input_status,
>   .s_dv_timings = adv76xx_s_dv_timings,
>   .g_dv_timings = adv76xx_g_dv_timings,

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] media: adv7604: implement cropcap

[Ulrich Hecht]

Used by the rcar_vin driver.

Signed-off-by: Ulrich Hecht 
---
 drivers/media/i2c/adv7604.c | 17 +
 1 file changed, 17 insertions(+)

diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index d30e7cc..1bfa9f3 100644
--- a/drivers/media/i2c/adv7604.c
+++ b/drivers/media/i2c/adv7604.c
@@ -1896,6 +1896,22 @@ static int adv76xx_g_crop(struct v4l2_subdev *sd, struct 
v4l2_crop *a)
return 0;
 }
 
+static int adv76xx_cropcap(struct v4l2_subdev *sd, struct v4l2_cropcap *a)
+{
+   struct adv76xx_state *state = to_state(sd);
+
+   a->bounds.left   = 0;
+   a->bounds.top= 0;
+   a->bounds.width  = state->timings.bt.width;
+   a->bounds.height = state->timings.bt.height;
+   a->defrect   = a->bounds;
+   a->type  = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+   a->pixelaspect.numerator   = 1;
+   a->pixelaspect.denominator = 1;
+
+   return 0;
+}
+
 static int adv76xx_set_format(struct v4l2_subdev *sd,
  struct v4l2_subdev_pad_config *cfg,
  struct v4l2_subdev_format *format)
@@ -2419,6 +2435,7 @@ static const struct v4l2_subdev_core_ops adv76xx_core_ops 
= {
 static const struct v4l2_subdev_video_ops adv76xx_video_ops = {
.s_routing = adv76xx_s_routing,
.g_crop = adv76xx_g_crop,
+   .cropcap = adv76xx_cropcap,
.g_input_status = adv76xx_g_input_status,
.s_dv_timings = adv76xx_s_dv_timings,
.g_dv_timings = adv76xx_g_dv_timings,
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html