Re: [PATCH 2/4] dw2102: remove unnecessary newline from log printouts
Em Tue, 5 May 2015 19:33:53 +0300
Olli Salonen escreveu:
> The info and warn functions already add a newline to the end of the
> log printouts, so remove the extra newline from the printouts.
Hi Olli,
The best here would be to convert this driver to use dvb-usb2, and replace
the usage of warn()/info()/dprintk() by the standard driver printk macros:
dev_info()/dev_warn()/...
Regards,
Mauro
>
> Signed-off-by: Olli Salonen
> ---
> drivers/media/usb/dvb-usb/dw2102.c | 60
> +++---
> 1 file changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb/dw2102.c
> b/drivers/media/usb/dvb-usb/dw2102.c
> index 4ad6bb2..b1f8a3f 100644
> --- a/drivers/media/usb/dvb-usb/dw2102.c
> +++ b/drivers/media/usb/dvb-usb/dw2102.c
> @@ -307,7 +307,7 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter
> *adap, struct i2c_msg ms
> u8 ibuf[MAX_XFER_SIZE], obuf[3];
>
> if (2 + msg[1].len > sizeof(ibuf)) {
> - warn("i2c rd: len=%d is too big!\n",
> + warn("i2c rd: len=%d is too big!",
>msg[1].len);
> ret = -EOPNOTSUPP;
> goto unlock;
> @@ -332,7 +332,7 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter
> *adap, struct i2c_msg ms
> u8 obuf[MAX_XFER_SIZE];
>
> if (2 + msg[0].len > sizeof(obuf)) {
> - warn("i2c wr: len=%d is too big!\n",
> + warn("i2c wr: len=%d is too big!",
>msg[1].len);
> ret = -EOPNOTSUPP;
> goto unlock;
> @@ -350,7 +350,7 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter
> *adap, struct i2c_msg ms
> u8 obuf[MAX_XFER_SIZE];
>
> if (2 + msg[0].len > sizeof(obuf)) {
> - warn("i2c wr: len=%d is too big!\n",
> + warn("i2c wr: len=%d is too big!",
>msg[1].len);
> ret = -EOPNOTSUPP;
> goto unlock;
> @@ -426,7 +426,7 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap,
> struct i2c_msg msg[], i
> u8 ibuf[MAX_XFER_SIZE];
>
> if (2 + msg[j].len > sizeof(ibuf)) {
> - warn("i2c rd: len=%d is too big!\n",
> + warn("i2c rd: len=%d is too big!",
>msg[j].len);
> ret = -EOPNOTSUPP;
> goto unlock;
> @@ -463,7 +463,7 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap,
> struct i2c_msg msg[], i
> u8 obuf[MAX_XFER_SIZE];
>
> if (2 + msg[j].len > sizeof(obuf)) {
> - warn("i2c wr: len=%d is too big!\n",
> + warn("i2c wr: len=%d is too big!",
>msg[j].len);
> ret = -EOPNOTSUPP;
> goto unlock;
> @@ -507,7 +507,7 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap,
> struct i2c_msg msg[],
> u8 ibuf[MAX_XFER_SIZE], obuf[3];
>
> if (2 + msg[1].len > sizeof(ibuf)) {
> - warn("i2c rd: len=%d is too big!\n",
> + warn("i2c rd: len=%d is too big!",
>msg[1].len);
> ret = -EOPNOTSUPP;
> goto unlock;
> @@ -532,7 +532,7 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap,
> struct i2c_msg msg[],
> u8 obuf[MAX_XFER_SIZE];
>
> if (2 + msg[0].len > sizeof(obuf)) {
> - warn("i2c wr: len=%d is too big!\n",
> + warn("i2c wr: len=%d is too big!",
>msg[0].len);
> ret = -EOPNOTSUPP;
> goto unlock;
> @@ -623,7 +623,7 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap,
> struct i2c_msg msg[],
> u8 ibuf[MAX_XFER_SIZE];
>
> if (msg[j].len > sizeof(ibuf)) {
> - warn("i2c rd: len=%d is too big!\n",
> + warn("i2c rd: len=%d is too big!",
>msg[j].len);
> ret = -EOPNOTSUPP;
> goto unlock;
> @@ -658,7 +658,7 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap,
> struct i2c_msg msg[],
> u8 obu
[PATCH 2/4] dw2102: remove unnecessary newline from log printouts
The info and warn functions already add a newline to the end of the
log printouts, so remove the extra newline from the printouts.
Signed-off-by: Olli Salonen
---
drivers/media/usb/dvb-usb/dw2102.c | 60 +++---
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/media/usb/dvb-usb/dw2102.c
b/drivers/media/usb/dvb-usb/dw2102.c
index 4ad6bb2..b1f8a3f 100644
--- a/drivers/media/usb/dvb-usb/dw2102.c
+++ b/drivers/media/usb/dvb-usb/dw2102.c
@@ -307,7 +307,7 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter
*adap, struct i2c_msg ms
u8 ibuf[MAX_XFER_SIZE], obuf[3];
if (2 + msg[1].len > sizeof(ibuf)) {
- warn("i2c rd: len=%d is too big!\n",
+ warn("i2c rd: len=%d is too big!",
msg[1].len);
ret = -EOPNOTSUPP;
goto unlock;
@@ -332,7 +332,7 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter
*adap, struct i2c_msg ms
u8 obuf[MAX_XFER_SIZE];
if (2 + msg[0].len > sizeof(obuf)) {
- warn("i2c wr: len=%d is too big!\n",
+ warn("i2c wr: len=%d is too big!",
msg[1].len);
ret = -EOPNOTSUPP;
goto unlock;
@@ -350,7 +350,7 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter
*adap, struct i2c_msg ms
u8 obuf[MAX_XFER_SIZE];
if (2 + msg[0].len > sizeof(obuf)) {
- warn("i2c wr: len=%d is too big!\n",
+ warn("i2c wr: len=%d is too big!",
msg[1].len);
ret = -EOPNOTSUPP;
goto unlock;
@@ -426,7 +426,7 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap,
struct i2c_msg msg[], i
u8 ibuf[MAX_XFER_SIZE];
if (2 + msg[j].len > sizeof(ibuf)) {
- warn("i2c rd: len=%d is too big!\n",
+ warn("i2c rd: len=%d is too big!",
msg[j].len);
ret = -EOPNOTSUPP;
goto unlock;
@@ -463,7 +463,7 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap,
struct i2c_msg msg[], i
u8 obuf[MAX_XFER_SIZE];
if (2 + msg[j].len > sizeof(obuf)) {
- warn("i2c wr: len=%d is too big!\n",
+ warn("i2c wr: len=%d is too big!",
msg[j].len);
ret = -EOPNOTSUPP;
goto unlock;
@@ -507,7 +507,7 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap,
struct i2c_msg msg[],
u8 ibuf[MAX_XFER_SIZE], obuf[3];
if (2 + msg[1].len > sizeof(ibuf)) {
- warn("i2c rd: len=%d is too big!\n",
+ warn("i2c rd: len=%d is too big!",
msg[1].len);
ret = -EOPNOTSUPP;
goto unlock;
@@ -532,7 +532,7 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap,
struct i2c_msg msg[],
u8 obuf[MAX_XFER_SIZE];
if (2 + msg[0].len > sizeof(obuf)) {
- warn("i2c wr: len=%d is too big!\n",
+ warn("i2c wr: len=%d is too big!",
msg[0].len);
ret = -EOPNOTSUPP;
goto unlock;
@@ -623,7 +623,7 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap,
struct i2c_msg msg[],
u8 ibuf[MAX_XFER_SIZE];
if (msg[j].len > sizeof(ibuf)) {
- warn("i2c rd: len=%d is too big!\n",
+ warn("i2c rd: len=%d is too big!",
msg[j].len);
ret = -EOPNOTSUPP;
goto unlock;
@@ -658,7 +658,7 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap,
struct i2c_msg msg[],
u8 obuf[MAX_XFER_SIZE];
if (2 + msg[j].len > sizeof(obuf)) {
- warn("i2c wr: len=%d is too big!\n",
+ warn("i2c wr: len=%d is too big!",
msg[j].len);
ret =
